Re: Ant support for users who use JUnit5
On 2018-02-15, Jaikiran Pai wrote: > I'm now done with the initial goals that I had in mind for this > task. I've opened a PR[1] for review. I've included a manual for this > task and it can be currently found here[2]. I would suggest reading > the manual first, before reviewing the PR, since the manual will give > an overall idea of what's being attempted with this task. It may be a while until I manage to look at it - in particular since I need to "read the manual first" :-) The review of the Java8 refactoring patch is going to take a bit longer still, but I expect to finish it this weekend (am already at src/main/org/apache/tools/ant/types/mappers). Whether we want to include the new task with an upcoming release depends on how comfortable you feel with it from my point of view. It probably won't see much use unless we include it in a release. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/62 These changes might improve performance, but do you have a testsuite with validates that? Most of the changes are done on places which are rarely invoked in a build (without having tested that ;-) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user reudismam commented on the issue: https://github.com/apache/ant/pull/62 Actually, I do not have a documentation, but there are discussions in programming community about the benefits of this change, such as this: [https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x](https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x) This edit is known to have improved performance on other projects such as Guava Project where they improve performance from 10-25%. [https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x](https://github.com/google/guava/commit/8f48177132547cee2943c93837d76b898154d722) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/62 Hi @reudismam, Is there some reference documentation which states that this construct performs better? My brief check of the JLS just showed a note which states that some implementations _might_ perform better with this construct, but other than that I haven't found anything, so just curious. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/62 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/37/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/62 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/43/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/62 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/62 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/62 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #62: Use char notation to represent a character to improve ...
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/62 Use char notation to represent a character to improve performance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant character Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 4df60d6b21f4c85df039037531aa1627fc40b68d Author: reudismam Date: 2018-02-16T12:49:15Z Use char notation to represent a character to improve performance. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
