Re: [dba-dev] improved SQL view

2008-11-06 Thread Maximilian Odendahl

Hi Frank,


[X] I think it's finished, and I just don't dare to say ;-)


ouch, now I remember again the last remaining issue. According to 
[EMAIL PROTECTED], bracket matching does not work on Mac, no idea why.


Would you have access to one and could debug there? Otherwise, I get 
mine in 1 - 3 weeks and could debug it then, but then we might miss 
feature freeze, which would be really unfortunate.


(silent thinking: or maybe get it QA'ed anyway and we fix it afterwards, 
I guess there is still lots of time after feature freeze)


> However, you should rebase your CWS to m35, since m34 saw some big
> changes in dbaccess. I am not sure they would conflict, but we should
> be sure

Yup, will do right after Peking.


Best regards
Max

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dba-dev] improved SQL view

2008-11-06 Thread Frank Schönheit - Sun Microsystems Germany
Hi Maximilian,

> [X] I think it's finished, and I just don't dare to say ;-)
> 
> So yes, finding a QA person and getting it in for 3.1 would be great.

Okay.

However, you should rebase your CWS to m35, since m34 saw some big
changes in dbaccess. I am not sure they would conflict, but we should be
sure.

I took the liberty to merge trunk's changes to solenv/bin/cws.pl,
solenv/bin/modules/Cws.pm, and solenv/bin/modules/CwsConfig.pm. This
way, you should have a working "cws rebase" command in the CWS. (At
least I hope I remembered the needed files correctly ...)

Note that it seems that you already merged in some of the changes, at
least in cws.pl. However, it seems you did not use "svn merge" for this,
but just applied a patch file - which will confuse subsequent "svn
merge" operations. So I reverted your change before doing the actual
merge, hope you don't mind.

> PS: Bettia and I will have a look at the standard colors tomorrow in Bejing

That's good :)

Ciao
Frank

-- 
- Frank Schönheit, Software Engineer [EMAIL PROTECTED] -
- Sun Microsystems  http://www.sun.com/staroffice -
- OpenOffice.org Base   http://dba.openoffice.org -
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dba-dev] improved SQL view

2008-11-06 Thread Maximilian Odendahl

Hi Frank,


where "pretty much finished" means


[X] I think it's finished, and I just don't dare to say.
[ ] There are still some minor open issues, which I'm not sure I should
fix in this CWS.
[ ] other:



I darkly remember having seen the Basic IDE code years ago, do I
remember correctly that highlighting is done on a per-line basis, so the
problem here is that we always generate one-line SQL statements? 


Not really, I think. Once you edit a line in the IDE, a broadcast 
including the current line happens and notifyChange is called, which 
calculates the new portions and should return a range of changed line, 
which are then reformatted based on the tokenizer.


But I now saw that this does not actually seem to work, but you get a 
manual notification for every changed line in the editor, this one is 
then syntax highlighted. In the SQL editor, we just reformat the whole 
thing. I leave it as it is now, as noone seems to be disturbed. If this 
should be an issue, we should do some current cursor magic to reformat a 
smaller range.


> where "pretty much finished" means

[X] I think it's finished, and I just don't dare to say ;-)

So yes, finding a QA person and getting it in for 3.1 would be great.


Best regards
Max

PS: Bettia and I will have a look at the standard colors tomorrow in Bejing

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]