Re: [dba-dev] operator delete mismatch in ODatabaseMetaDataResultSet

[Ocke Janssen]

Hi Terrence,

Great, so you would become a OOo Base developer :-)

I applied your patch in the cws dba33f. Could please add the patch 
directly to the issue and marked as a patch, next time. That would make 
things more easier for me to find the issues. I'm always interested in 
applying patches fast in the source cde.


Best regards,

Ocke

Terrence Enger wrote:

Greetings,

And here is another one, the same except that the source file is
connectivity/source/drivers/odbcbase/OResultSet.cxx, the line number
of new[] is 119, and the line number of scalar delete is 165.

So, how many issues should there be for "operator delete mismatch"?
An awful lot of these come up in my (non-production) build when I work
in Base; I just dug into this one for a change while I wait for advice
on issue 94543.  I have already opened issue 110236
 for the same
assertion arising from a different place.

I invite your guidance.

Cheers,
Terry.


On Mon, 2010-03-22 at 08:28 -0400, Terrence Enger wrote:

  

summary : operator delete mismatch in ODatabaseMetaDataResultSet



  

And then the patch ...

--- ODatabaseMetaDataResultSet.cxx_m752010-03-21 23:37:01.0 
-0400
+++ ODatabaseMetaDataResultSet.cxx_tje2010-03-21 23:38:03.0 
-0400
@@ -97,7 +97,7 @@
  osl_incrementInterlockedCount( &m_refCount );
  dispose();
  }
- delete m_pRowStatusArray;
+ delete [] m_pRowStatusArray;
 }
 // 
-
 void ODatabaseMetaDataResultSet::disposing(void)






-
To unsubscribe, e-mail: dev-unsubscr...@dba.openoffice.org
For additional commands, e-mail: dev-h...@dba.openoffice.org

  



--
Ocke Janssen  Tel: +49 40 23646 661, x1
Dipl. Inf(FH) Fax: +49 40 23646 550
Sun Microsystems Inc.
Nagelsweg 55  mailto:ocke.jans...@sun.com
D-20097 Hamburg   http://www.sun.com/staroffice

Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder


-
To unsubscribe, e-mail: dev-unsubscr...@dba.openoffice.org
For additional commands, e-mail: dev-h...@dba.openoffice.org

Re: [dba-dev] operator delete mismatch in ODatabaseMetaDataResultSet

[Terrence Enger]

Greetings,

And here is another one, the same except that the source file is
connectivity/source/drivers/odbcbase/OResultSet.cxx, the line number
of new[] is 119, and the line number of scalar delete is 165.

So, how many issues should there be for "operator delete mismatch"?
An awful lot of these come up in my (non-production) build when I work
in Base; I just dug into this one for a change while I wait for advice
on issue 94543.  I have already opened issue 110236
 for the same
assertion arising from a different place.

I invite your guidance.

Cheers,
Terry.


On Mon, 2010-03-22 at 08:28 -0400, Terrence Enger wrote:

> summary : operator delete mismatch in ODatabaseMetaDataResultSet

> And then the patch ...
> 
> --- ODatabaseMetaDataResultSet.cxx_m752010-03-21 23:37:01.0 
> -0400
> +++ ODatabaseMetaDataResultSet.cxx_tje2010-03-21 23:38:03.0 
> -0400
> @@ -97,7 +97,7 @@
>   osl_incrementInterlockedCount( &m_refCount );
>   dispose();
>   }
> - delete m_pRowStatusArray;
> + delete [] m_pRowStatusArray;
>  }
>  // 
> -
>  void ODatabaseMetaDataResultSet::disposing(void)




-
To unsubscribe, e-mail: dev-unsubscr...@dba.openoffice.org
For additional commands, e-mail: dev-h...@dba.openoffice.org

[dba-dev] operator delete mismatch in ODatabaseMetaDataResultSet

[Terrence Enger]

Greetings,

I think I have my very first patch to submit.  "Contributing Patches"

suggests that I take it to d...@openoffice.org first, but I am bringing
it here instead.  Here, with some rationales and questions, is what I
contemplate ...

component   : Database access
subcomponent: none
  ( because ODBC is not offered )
found in version: DEV300_m75
platform: other 
os  : Linux
priority: P5
  ( unless some platform is less forgiving than mine, perhaps? )
issue type  : patch
initial state   : new
assigned to : oj
  ( because that is what
  
  does when you click "connectivity" )
summary : operator delete mismatch in ODatabaseMetaDataResultSet
description ...
In file
connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx,
line 86 assigns m_pRowStatusArray from array new but line 100
does a scalar delete.  In a non-production build, this causes
numerous assertion failures at
sal/cpprt/operators_new_delete.cxx line 95 when, for example,
you open a query to an ODBC database.

And then the patch ...

--- ODatabaseMetaDataResultSet.cxx_m75  2010-03-21 23:37:01.0 
-0400
+++ ODatabaseMetaDataResultSet.cxx_tje  2010-03-21 23:38:03.0 
-0400
@@ -97,7 +97,7 @@
osl_incrementInterlockedCount( &m_refCount );
dispose();
}
-   delete m_pRowStatusArray;
+   delete [] m_pRowStatusArray;
 }
 // 
-
 void ODatabaseMetaDataResultSet::disposing(void)

I have tested this only to the extent of observing fewer assertions
raised as I open my favourite query against an ODBC database.

Should I say more?  Less?  Something else?  I welcome your comments.

Cheers,
Terry.



-
To unsubscribe, e-mail: dev-unsubscr...@dba.openoffice.org
For additional commands, e-mail: dev-h...@dba.openoffice.org