Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Moin Max, Frank Schönheit - Sun Microsystems Germany wrote: Hi Max, I'll take it back after I had another look myself, could you have a look? It seems I can't find the issue here. Probably has to wait until after my vacation (starting tomorrow). Btw, I tried to install the Report Designer Extension to verify that the colors of the extension can still be changed correctly, but they did not show up, as nExtCount is still 0. ExtendedColorConfig aExtConfig; sal_Int32 nExtCount = aExtConfig.GetComponentCount(); I don't think I changed anything in this regard, any idea? The color configuration was moved from the main installation to the extension, not sure at the moment when this happened (Ocke could tell more), Yes, now the module reportdesign has a folder named registry which is packed into the oxt file as well. You have to use the extension from your build to get the correct one and you have to adjust the description.xml in that way that you remove the max version. The current dev build is still believing that he is a 3.0 and not a 3.1 ;-) Best regards, Ocke but it implies that you cannot use every extension build with every OOo build (e.g. an extension version not containing the config data cannot run on an OOo not containing the config data). Also, some fixes in this area were made in dba31c, IIRC (again, Ocke can confirm or deny). Ciao Frank -- Ocke Janssen Tel: +49 40 23646 661, x1 Dipl. Inf(FH) Fax: +49 40 23646 550 Sun Microsystems Inc. Nagelsweg 55 mailto:[EMAIL PROTECTED] D-20097 Hamburg http://www.sun.com/staroffice Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Max, >> - optcolor.src:448: Should be SQLIDENTIFIER instead of BASICIDENTIFIER >> (copy'n'paste error) > > seems like you missed the latest svn update, found that one last night :-) Indee, the SVN version of the CWS is just building, I still used the CVS version this afternoon. > Thanks a lot, this indeed fixed the issue. I actually thought about sth. > like that myself, so I made sure to have this code in the right order: > > aSQLBackWN(this), > SQLFT(this, ResId(FT_SQL_COMMAND, *rResId.GetResMgr())), > > Why does the declaration order matter, isn't initialization actually be > done at this place? It is, but a common misperception is that initialization is done in the order you write it in the implementation - it isn't. Declaration order is what controls initialization order, nothing else. So no matter how you re-arrange them in the constructor, your members are always initialized in the order in which you declared them. However, I suppose only a few enlightened people :) knew this two years ago - we all learned it the hard way when we switched on warnings-as-errors, together with -wall, since the GCC we use warns if you write your member initialization in a order different from the one in declaration. > Glad everything works fine now, have a great holiday Thanks. Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Frank, two problems here: - optcolor.src:448: Should be SQLIDENTIFIER instead of BASICIDENTIFIER (copy'n'paste error) seems like you missed the latest svn update, found that one last night :-) - optcolor.cxx: aSQLFT should be declared after aSQLBackWN, not before it. Member declaration order controls member initialization order, which in turn controls Z-ordering Thanks a lot, this indeed fixed the issue. I actually thought about sth. like that myself, so I made sure to have this code in the right order: aSQLBackWN(this), SQLFT(this, ResId(FT_SQL_COMMAND, *rResId.GetResMgr())), Why does the declaration order matter, isn't initialization actually be done at this place? Glad everything works fine now, have a great holiday Regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Max, > I'll take it back after I had another look myself, could you have a > look? It seems I can't find the issue here. two problems here: - optcolor.src:448: Should be SQLIDENTIFIER instead of BASICIDENTIFIER (copy'n'paste error) - optcolor.cxx: aSQLFT should be declared after aSQLBackWN, not before it. Member declaration order controls member initialization order, which in turn controls Z-ordering (i.e. which control is painted "on the top" of which other control(s)). At the moment, the fixed text is covered by the BackWindow, thus you don't see the heading. I have to admit that the optcolor code looks ... ehm, to say it in a way lawyers can't sue me for: It's difficult to maintain. So, I am not really surprised that extending it is difficult, too ... Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Max, > I'll take it back after I had another look myself, could you have a > look? It seems I can't find the issue here. Probably has to wait until after my vacation (starting tomorrow). > Btw, I tried to install the Report Designer Extension to verify that the > colors of the extension can still be changed correctly, but they did > not show up, as nExtCount is still 0. > > ExtendedColorConfig aExtConfig; > sal_Int32 nExtCount = aExtConfig.GetComponentCount(); > > I don't think I changed anything in this regard, any idea? The color configuration was moved from the main installation to the extension, not sure at the moment when this happened (Ocke could tell more), but it implies that you cannot use every extension build with every OOo build (e.g. an extension version not containing the config data cannot run on an OOo not containing the config data). Also, some fixes in this area were made in dba31c, IIRC (again, Ocke can confirm or deny). Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Frank, Thanks, after I fixed another thing, it is now working perfectly fine except the group caption is not showing up, but I'm sure I'll find that one as well soon. Okay, so I won't investigate here ... I'll take it back after I had another look myself, could you have a look? It seems I can't find the issue here. So the CWS is now SVN-based? m33? yes, m32 Btw, I tried to install the Report Designer Extension to verify that the colors of the extension can still be changed correctly, but they did not show up, as nExtCount is still 0. ExtendedColorConfig aExtConfig; sal_Int32 nExtCount = aExtConfig.GetComponentCount(); I don't think I changed anything in this regard, any idea? Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Max, > Thanks, after I fixed another thing, it is now working perfectly fine > except the group caption is not showing up, but I'm sure I'll find that > one as well soon. Okay, so I won't investigate here ... > Thanks for mentioning this possibility again. Although I could swear I > did this a million times, it fixed the issue. Fine. > I used the opportunity to > switch to svn directly as well. So the CWS is now SVN-based? m33? Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Frank, >>(uhm, I did it again, I called you with your full name in my last mail >>... sorry :-\ ) no worries, it is not that important ;-) *trying to get the value does also not seem to work, I always get the default one, although it is saved upon closing and restarting the application. Can reproduce it :), did not investigate. Though, as Ocke already suggested, you forgot adding a new entry to the configuration schema. See the changes I committed to officecfg. Thanks, after I fixed another thing, it is now working perfectly fine except the group caption is not showing up, but I'm sure I'll find that one as well soon. MultiLineEditSyntaxHighlight, it crashes, to verify, just open and close the SQL view. Cannot reproduce. I suppose you have an incompatibility here, i.e. some file which has not been built though it would need to. Try touching the header file of the class, and rebuilding the module. Thanks for mentioning this possibility again. Although I could swear I did this a million times, it fixed the issue. I used the opportunity to switch to svn directly as well. I'll soon provide a new installation set for people to try out. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Max, (uhm, I did it again, I called you with your full name in my last mail ... sorry :-\ ) just had a quick look, so only a short comment: > *trying to get the value does also not seem to work, I always > get > the default one, although it is saved upon closing and > restarting the > application. Can reproduce it :), did not investigate. Though, as Ocke already suggested, you forgot adding a new entry to the configuration schema. See the changes I committed to officecfg. > - by simply adding svtools::ColorConfig m_aColorConfig to my new control > MultiLineEditSyntaxHighlight, it crashes, to verify, just open and > close the SQL view. Cannot reproduce. I suppose you have an incompatibility here, i.e. some file which has not been built though it would need to. Try touching the header file of the class, and rebuilding the module. Alternatively, try rebuilding the complete module. (that's effectively what I did, and I did not get the crash. And the place you mentioned sounds indeed like there is a mismatch between the actual class size, and the size which is just being deleted/freed - a typical incompatibility when you don't rebuild all affected files after changing a classes size.) Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Maximilian, > back from vacation and exams, I have some issue in cws > sqlsyntaxhighlighting, would be great if you could help out once you > find some time: need to get a copy of the CWS here to have a deeper look, this will take a while. > - I tried adding a new group in the appearance dialog and one new > entry.* The group appears, but the caption is not shown > * the colorbox and window appear just fine, but I get an > assertion > that ressource 174 and 175 (the one from the colorbox and > window) can > not be found in the resource file, what ammissing? Which reminds me of an open issue in the current versions - everytime you open the stylist, you get a similar assertion about a missing resource, because this resource is looked up in the wrong .res file. Perhaps the effect you see is something similar, and not really related to your CWS. But that's just wild guessing for the moment. > *trying to get the value does also not seem to work, I always > get > the default one, although it is saved upon closing and > restarting the > application. > > I guess you did all that already once for the Base Extension and know > the pitfalls ;-) Ocke did - since he didn't mention pitfalls, there are none :-) > - by simply adding svtools::ColorConfig m_aColorConfig to my new control > MultiLineEditSyntaxHighlight, it crashes, to verify, just open and > close the SQL view. The crash seems to come from > ColorConfig::~ColorConfig() when calling EndListening( *m_pImpl), no > idea what's going on there. If I use ColorConfig as a local variable in > my highlighting routine, it does not crash, but I guess just creating it > once makes more sense. ColorConfig has, as all the FooConfig classes in svtools, a ref-counted impl class. So, as long as there's one instance already, creating new ones is cheap. However, since it's not known which other components hold a ColorConfig instance (I thought there was a time when the Application did so, but I did not find such code right now ...), that's in fact nothing to rely upon. I need to have a look into the crash to get an idea of it ... see above. Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Ocke, I don't look at the code but I missed sometimes is to copy the res files into the OOo/program/resource folder. :-) yeah, did that ;-) Which is weired that I get the error, but the listbox and label just displays fine. And do you add the SQL color to the module officecfg/registry/schema/org/openoffice/Office/UI.xcs ? I don't see that this module is added to your cws. will look, thanks Best rgeards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Max, Maximilian Odendahl wrote: Hi Frank, back from vacation and exams, I have some issue in cws sqlsyntaxhighlighting, would be great if you could help out once you find some time: - I tried adding a new group in the appearance dialog and one new entry. * The group appears, but the caption is not shown * the colorbox and window appear just fine, but I get an assertion that ressource 174 and 175 (the one from the colorbox and window) can not be found in the resource file, what am missing? I don't look at the code but I missed sometimes is to copy the res files into the OOo/program/resource folder. :-) And do you add the SQL color to the module officecfg/registry/schema/org/openoffice/Office/UI.xcs ? I don't see that this module is added to your cws. - oj *trying to get the value does also not seem to work, I always get the default one, although it is saved upon closing and restarting the application. I guess you did all that already once for the Base Extension and know the pitfalls ;-) - by simply adding svtools::ColorConfig m_aColorConfig to my new control MultiLineEditSyntaxHighlight, it crashes, to verify, just open and close the SQL view. The crash seems to come from ColorConfig::~ColorConfig() when calling EndListening( *m_pImpl), no idea what's going on there. If I use ColorConfig as a local variable in my highlighting routine, it does not crash, but I guess just creating it once makes more sense. Some help and pointers would be great, everything should be available in the cws. Feel free to submit any changes ;-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ocke Janssen Tel: +49 40 23646 661, x1 Dipl. Inf(FH) Fax: +49 40 23646 550 Sun Microsystems Inc. Nagelsweg 55 mailto:[EMAIL PROTECTED] D-20097 Hamburg http://www.sun.com/staroffice Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Frank, back from vacation and exams, I have some issue in cws sqlsyntaxhighlighting, would be great if you could help out once you find some time: - I tried adding a new group in the appearance dialog and one new entry. * The group appears, but the caption is not shown * the colorbox and window appear just fine, but I get an assertion that ressource 174 and 175 (the one from the colorbox and window) can not be found in the resource file, what am missing? *trying to get the value does also not seem to work, I always get the default one, although it is saved upon closing and restarting the application. I guess you did all that already once for the Base Extension and know the pitfalls ;-) - by simply adding svtools::ColorConfig m_aColorConfig to my new control MultiLineEditSyntaxHighlight, it crashes, to verify, just open and close the SQL view. The crash seems to come from ColorConfig::~ColorConfig() when calling EndListening( *m_pImpl), no idea what's going on there. If I use ColorConfig as a local variable in my highlighting routine, it does not crash, but I guess just creating it once makes more sense. Some help and pointers would be great, everything should be available in the cws. Feel free to submit any changes ;-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
