[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959693#comment-13959693 ] Uwe Schindler commented on SOLR-5950: - Thanks Steve! > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Fix For: 4.8, 5.0, 4.7.2 > > Attachments: SOLR-5950.branch_4x.patch, SOLR-5950.patch, > SOLR-5950.trunk.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959477#comment-13959477 ] ASF subversion and git services commented on SOLR-5950: --- Commit 1584480 from sar...@apache.org in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1584480 ] SOLR-5950: Maven config: make the org.slf4j:slf4j-api dependency transitive (i.e., not optional) in all modules in which it's a dependency, including solrj, except for the WAR, where it will remain optional. (merged branch_4x r1584474) > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.branch_4x.patch, SOLR-5950.patch, > SOLR-5950.trunk.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959447#comment-13959447 ] ASF subversion and git services commented on SOLR-5950: --- Commit 1584474 from sar...@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1584474 ] SOLR-5950: Maven config: make the org.slf4j:slf4j-api dependency transitive (i.e., not optional) in all modules in which it's a dependency, including solrj, except for the WAR, where it will remain optional. (merged trunk r1584473) > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.branch_4x.patch, SOLR-5950.patch, > SOLR-5950.trunk.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959438#comment-13959438 ] ASF subversion and git services commented on SOLR-5950: --- Commit 1584473 from sar...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1584473 ] SOLR-5950: Maven config: make the org.slf4j:slf4j-api dependency transitive (i.e., not optional) in all modules in which it's a dependency, including solrj, except for the WAR, where it will remain optional. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.branch_4x.patch, SOLR-5950.patch, > SOLR-5950.trunk.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958910#comment-13958910 ] Uwe Schindler commented on SOLR-5950: - bq. In my opinion, all of solr should depend on slf4j-api (because its used as a hard dependency, it is not optional!). Only the WAR file should exclude it by making it optional. This is, by the way, how it looked like in Solr 4.6. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958903#comment-13958903 ] Steve Rowe commented on SOLR-5950: -- bq. In my opinion, all of solr should depend on slf4j-api (because its used as a hard dependency, it is not optional!). Only the WAR file should exclude it by making it optional. I agree. I'll fix. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958893#comment-13958893 ] Uwe Schindler commented on SOLR-5950: - Hi Steve, I applied the patch to 4.7 and fixed the diamonds. After that I ran it and checked the POM output. It looks fine to me, solrj has the required dependency. But I think the whole magic is not needed at all. Because solrj is required by almost all projects (contrib, solr-core,..) the declaration of "optional" there is not really needed? I think only the WAR file should have it optional, all others get it required, because they depend on solrj (so when you compile or use solr-core, it should also fetch solrj, if I understand it correctly? Please correct me if this is not true. In my opinion, all of solr should depend on slf4j-api (because its used as a hard dependency, it is not optional!). Only the WAR file should exclude it by making it optional. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958870#comment-13958870 ] Uwe Schindler commented on SOLR-5950: - bq. For building the war using the Maven build, no Maven Magic required - I applied the patch to branch_4x and built the war, and the SLF4J jars are not included. The war's POM lists all SLF4J dependencies as optional. And the Solrj POM does not list org.slf4j:slf4j-api as optional. I will check this in a minute! > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958869#comment-13958869 ] Uwe Schindler commented on SOLR-5950: - bq. I thought maybe that's what he meant, but I wanted to make a definitive statement to make sure there are no misunderstandings. I was referring to trunk. There we no longer create and store the WAR in Maven. But the whole issue here is not really related to the WAR file: This is about making slf4j-log API non-optional for the solrj-Module. For using solrj with your project, you definitely need slf4j-api, otherwise you will get ClassNotFoundExceptions when starting the code or run tests (because solrj hardly depends on the log API). > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958812#comment-13958812 ] Steve Rowe commented on SOLR-5950: -- bq. He was just talking about 5x Got pulled out of context a bit. I thought maybe that's what he meant, but I wanted to make a definitive statement to make sure there are no misunderstandings. bq. When building the WAR file in 4.x we should exclude it somehow via Maven Magic(tm). The war deployed to Maven Central is built using Ant, and the Ant build already excludes all the SLF4J jars - the patch doesn't change this. For building the war using the Maven build, no Maven Magic required - I applied the patch to branch_4x and built the war, and the SLF4J jars are not included. The war's POM lists all SLF4J dependencies as optional. And the Solrj POM does not list org.slf4j:slf4j-api as optional. I'll commit to trunk and backport to branch_4x and the lucene_solr_4_7 branch. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958788#comment-13958788 ] Mark Miller commented on SOLR-5950: --- He was just talking about 5x :) Got pulled out of context a bit. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958779#comment-13958779 ] Steve Rowe commented on SOLR-5950: -- bq. The WAR file is no longer deployed to Maven. Uwe, the WAR file is still deployed to Maven, and will be for all 4.X releases, e.g. 4.7.1: http://central.maven.org/maven2/org/apache/solr/solr/4.7.1/solr-4.7.1.war > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958758#comment-13958758 ] Uwe Schindler commented on SOLR-5950: - The WAR file is no longer deployed to Maven. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5950) In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain solrj users
[ https://issues.apache.org/jira/browse/SOLR-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958741#comment-13958741 ] Mark Miller commented on SOLR-5950: --- bq. In trunk we no longer have a WAR file The problem there is that we *do* still have a WAR file and we do still want logging jars to be easily swapped in trunk. > In SolrJ's Maven Dependency Graph, slf4j-api is optional, which breaks plain > solrj users > > > Key: SOLR-5950 > URL: https://issues.apache.org/jira/browse/SOLR-5950 > Project: Solr > Issue Type: Bug > Components: clients - java >Affects Versions: 4.7, 4.7.1 >Reporter: Uwe Schindler >Assignee: Steve Rowe > Attachments: SOLR-5950.patch > > > To run as a Solr Client, you need slf4j actually configured in your > classpath, because HttpSolrServer hardly depends on it, also the used libs > like Commons Httpclient (and others) > In SOLR-3706 *all* of the slf4j JARs were made optional, but because we did > not exclude the dependencies of httpclient and others explicitely, the > dependency was still included by maven automatically for a user that used > SolrJ - so effectively the "optional" was never working. > In 4.7, [~steve_rowe] now explicitely excluded all dependencies of all deps > included via IVY. By that the implicit dependency by httpclient was killed. > When I updated a project from SolrJ 4.6 to SolrJ 4.7, it suddenly failed to > run, because it failed with a classnotfound ex directly after starting. Not > even the default logging to console was enabled (which is provided by slf4j). > This is bad for users of SolrJ, because they have to explicitely add a > dependency for something that really required to use SolrJ. > The reason for excluding slf4j-api was that we don't want to have it in the > WAR file, so it was made optional. But that is wrong: > - In trunk we no longer have a WAR file > - The primary user of SolrJ via Maven is not somebody who wants to install > Solr in his appserver, its the user needing the client. > So we should restore the state from Solr 4.6, where the dep was implicitely > included, by making it non-optional in Maven. > When building the WAR file in 4.x we should exclude it somehow via Maven > Magic(tm). -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
