[jira] [Updated] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10
[
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Palumbo updated MAHOUT-1993:
---
Priority: Blocker (was: Major)
> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work started] (MAHOUT-1994) Remove ViennCL jars upon mvn clean.
[
https://issues.apache.org/jira/browse/MAHOUT-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on MAHOUT-1994 started by Andrew Palumbo.
--
> Remove ViennCL jars upon mvn clean.
> ---
>
> Key: MAHOUT-1994
> URL: https://issues.apache.org/jira/browse/MAHOUT-1994
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> currently, after running `mvn clean` from $MAHOUT_HOME, VinenaCL jars are not
> removed from the base level directory.
> add in something similar to:
> {code}
>
> maven-clean-plugin
> 3.0.0
>
>
>
> ../
>
> mahout-spark*.jar
>
> false
>
>
>
>
>
>
> {code}
> in both {{vienncl}} and {{viennacl-omp}} module pom.xmls
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work started] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10
[
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on MAHOUT-1993 started by Andrew Palumbo.
--
> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11
[
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062164#comment-16062164
]
ASF GitHub Bot commented on MAHOUT-1988:
Github user andrewpalumbo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/326#discussion_r123887027
--- Diff:
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends
MatrixBase {
- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}
- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new
Context(Context.MAIN_MEMORY)) {
--- End diff --
@rawkintrevo lgtm - ship it! we swill still need to do some testing against
other spark versions though. As well, there are some other issues that I've
noticed, but can be addressed in other PRs on top of this anyways, eg. #327.
> ViennaCL and OMP not building for Scala 2.11
>
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11:
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11
> -Phadoop2 -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking
> the 0.13.1 release.
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10
[
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062163#comment-16062163
]
ASF GitHub Bot commented on MAHOUT-1993:
GitHub user andrewpalumbo opened a pull request:
https://github.com/apache/mahout/pull/327
MAHOUT-1993: fix hardcoding of scala version in spark dependency-reduced.xml
### Purpose of PR:
Please give a short description of what this PR is for.
### Important ToDos
Please mark each with an "x"
- [ ] A JIRA ticket exists (if not, please create this
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [ ] Title of PR is "MAHOUT- Brief Description of Changes" where
is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [ ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests
pass locally.
If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"
Does this change break earlier versions?
Is this the beginning of a larger project for which a feature branch should
be made?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewpalumbo/mahout MAHOUT-1993
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mahout/pull/327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #327
commit fad2b573b4234c1cc67a29d6302786d26d9ed49c
Author: Andrew Palumbo
Date: 2017-06-24T22:43:29Z
fix hardcoding of scala version
> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10
[
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Palumbo updated MAHOUT-1993:
---
Affects Version/s: 0.13.0
Fix Version/s: 0.13.1
> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10
[
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Palumbo reassigned MAHOUT-1993:
--
Assignee: Andrew Palumbo
> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
> Issue Type: Bug
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (MAHOUT-1994) Remove ViennCL jars upon mvn clean.
Andrew Palumbo created MAHOUT-1994:
--
Summary: Remove ViennCL jars upon mvn clean.
Key: MAHOUT-1994
URL: https://issues.apache.org/jira/browse/MAHOUT-1994
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.1
currently, after running `mvn clean` from $MAHOUT_HOME, VinenaCL jars are not
removed from the base level directory.
add in something similar to:
{code}
maven-clean-plugin
3.0.0
../
mahout-spark*.jar
false
{code}
in both {{vienncl}} and {{viennacl-omp}} module pom.xmls
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10
Andrew Palumbo created MAHOUT-1993:
--
Summary: ViennaCL dependency-reduced.xml assembly scala versions
are hardcoded to scala 2.10
Key: MAHOUT-1993
URL: https://issues.apache.org/jira/browse/MAHOUT-1993
Project: Mahout
Issue Type: Bug
Reporter: Andrew Palumbo
in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped
are hard-coded to scala-2.10.:
{code}
org.apache.mahout:mahout-native-viennacl_2.10
org.apache.mahout:mahout-native-viennacl-omp_2.10
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (MAHOUT-1992) Mahout PMC + Chair Can't Create Scrum Boards
[ https://issues.apache.org/jira/browse/MAHOUT-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Palumbo resolved MAHOUT-1992. Resolution: Invalid 2nd d'oh of the day > Mahout PMC + Chair Can't Create Scrum Boards > - > > Key: MAHOUT-1992 > URL: https://issues.apache.org/jira/browse/MAHOUT-1992 > Project: Mahout > Issue Type: Bug >Reporter: Andrew Palumbo > Attachments: scrum-board.png > > > Hi all, > I've been having a problem getting the JIRA Permissions/ownership changed > over to myself since being made Mahout Chair. I'm unable to create a scrum > board, and get the attached dialog when I try. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MAHOUT-1992) Mahout PMC + Chair Can't Create Scrum Boards
[ https://issues.apache.org/jira/browse/MAHOUT-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062148#comment-16062148 ] Andrew Palumbo commented on MAHOUT-1992: I am not sure of the "ownership" of the board.. the previous PMC Chair was Suneel Marthi, and I know that he has been able to create boards in the past. *"ownership of the mahout Jira"? Could someone Please assist in an Access level change to the Board that I May not have access to? If I'm correct and it is an access change that needs to be made, could the following PMC members be granted access: apalumbo (myself) rawkintrevo (Trevor Grant) akm(Andrew Musselman) pferrel(Pat Ferrel) > Mahout PMC + Chair Can't Create Scrum Boards > - > > Key: MAHOUT-1992 > URL: https://issues.apache.org/jira/browse/MAHOUT-1992 > Project: Mahout > Issue Type: Bug >Reporter: Andrew Palumbo > Attachments: scrum-board.png > > > Hi all, > I've been having a problem getting the JIRA Permissions/ownership changed > over to myself since being made Mahout Chair. I'm unable to create a scrum > board, and get the attached dialog when I try. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (MAHOUT-1992) Mahout PMC + Chair Can't Create Scrum Boards
[ https://issues.apache.org/jira/browse/MAHOUT-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062148#comment-16062148 ] Andrew Palumbo edited comment on MAHOUT-1992 at 6/24/17 9:42 PM: - I am not sure of the "ownership" of the board.. the previous PMC Chair was Suneel Marthi, and I know that he has been able to create boards in the past. *"ownership of the mahout Jira"? Could someone Please assist in an Access level change to the Board/Jira that I May not have access to? If I'm correct and it is an access change that needs to be made, could the following PMC members be granted access: apalumbo (myself) rawkintrevo (Trevor Grant) akm(Andrew Musselman) pferrel(Pat Ferrel) Thanks very much, Andy was (Author: andrew_palumbo): I am not sure of the "ownership" of the board.. the previous PMC Chair was Suneel Marthi, and I know that he has been able to create boards in the past. *"ownership of the mahout Jira"? Could someone Please assist in an Access level change to the Board that I May not have access to? If I'm correct and it is an access change that needs to be made, could the following PMC members be granted access: apalumbo (myself) rawkintrevo (Trevor Grant) akm(Andrew Musselman) pferrel(Pat Ferrel) Thanks very much, Andy > Mahout PMC + Chair Can't Create Scrum Boards > - > > Key: MAHOUT-1992 > URL: https://issues.apache.org/jira/browse/MAHOUT-1992 > Project: Mahout > Issue Type: Bug >Reporter: Andrew Palumbo > Attachments: scrum-board.png > > > Hi all, > I've been having a problem getting the JIRA Permissions/ownership changed > over to myself since being made Mahout Chair. I'm unable to create a scrum > board, and get the attached dialog when I try. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (MAHOUT-1992) Mahout PMC + Chair Can't Create Scrum Boards
[ https://issues.apache.org/jira/browse/MAHOUT-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062148#comment-16062148 ] Andrew Palumbo edited comment on MAHOUT-1992 at 6/24/17 9:41 PM: - I am not sure of the "ownership" of the board.. the previous PMC Chair was Suneel Marthi, and I know that he has been able to create boards in the past. *"ownership of the mahout Jira"? Could someone Please assist in an Access level change to the Board that I May not have access to? If I'm correct and it is an access change that needs to be made, could the following PMC members be granted access: apalumbo (myself) rawkintrevo (Trevor Grant) akm(Andrew Musselman) pferrel(Pat Ferrel) Thanks very much, Andy was (Author: andrew_palumbo): I am not sure of the "ownership" of the board.. the previous PMC Chair was Suneel Marthi, and I know that he has been able to create boards in the past. *"ownership of the mahout Jira"? Could someone Please assist in an Access level change to the Board that I May not have access to? If I'm correct and it is an access change that needs to be made, could the following PMC members be granted access: apalumbo (myself) rawkintrevo (Trevor Grant) akm(Andrew Musselman) pferrel(Pat Ferrel) > Mahout PMC + Chair Can't Create Scrum Boards > - > > Key: MAHOUT-1992 > URL: https://issues.apache.org/jira/browse/MAHOUT-1992 > Project: Mahout > Issue Type: Bug >Reporter: Andrew Palumbo > Attachments: scrum-board.png > > > Hi all, > I've been having a problem getting the JIRA Permissions/ownership changed > over to myself since being made Mahout Chair. I'm unable to create a scrum > board, and get the attached dialog when I try. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MAHOUT-1992) Mahout PMC + Chair Can't Create Scrum Boards
Andrew Palumbo created MAHOUT-1992: -- Summary: Mahout PMC + Chair Can't Create Scrum Boards Key: MAHOUT-1992 URL: https://issues.apache.org/jira/browse/MAHOUT-1992 Project: Mahout Issue Type: Bug Reporter: Andrew Palumbo Hi all, I've been having a problem getting the JIRA Permissions/ownership changed over to myself since being made Mahout Chair. I'm unable to create a scrum board, and get the attached dialog when I try. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MAHOUT-1992) Mahout PMC + Chair Can't Create Scrum Boards
[ https://issues.apache.org/jira/browse/MAHOUT-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Palumbo updated MAHOUT-1992: --- Attachment: scrum-board.png > Mahout PMC + Chair Can't Create Scrum Boards > - > > Key: MAHOUT-1992 > URL: https://issues.apache.org/jira/browse/MAHOUT-1992 > Project: Mahout > Issue Type: Bug >Reporter: Andrew Palumbo > Attachments: scrum-board.png > > > Hi all, > I've been having a problem getting the JIRA Permissions/ownership changed > over to myself since being made Mahout Chair. I'm unable to create a scrum > board, and get the attached dialog when I try. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11
[
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062128#comment-16062128
]
ASF GitHub Bot commented on MAHOUT-1988:
Github user andrewpalumbo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/326#discussion_r123885295
--- Diff:
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends
MatrixBase {
- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}
- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new
Context(Context.MAIN_MEMORY)) {
--- End diff --
If you'd like to merge this first i'd be +1 on that. Then testing on
pseudo cluster could be a separate issue. The `spark/dependency reduced.xml`
needs to be updated.
> ViennaCL and OMP not building for Scala 2.11
>
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11:
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11
> -Phadoop2 -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking
> the 0.13.1 release.
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11
[
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062126#comment-16062126
]
ASF GitHub Bot commented on MAHOUT-1988:
Github user andrewpalumbo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/326#discussion_r123885270
--- Diff:
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends
MatrixBase {
- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}
- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new
Context(Context.MAIN_MEMORY)) {
--- End diff --
@rawkintrevo:
```
$MAHOUT_HOME/viennacl$ mvn test -Dscala.version=2.11.2
-Dscala.compat.version=2.11 -Pviennacl
```
(I'd tried built with 2.11.2)
tests pass:
```
All tests passed.
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 01:36 min
[INFO] Finished at: 2017-06-24T13:49:59-07:00
[INFO] Final Memory: 20M/296M
[INFO]
```
Sweet- I'd like to try this in Pseudo cluster mode as well, this afternoon.
> ViennaCL and OMP not building for Scala 2.11
>
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11:
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11
> -Phadoop2 -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking
> the 0.13.1 release.
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11
[
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062121#comment-16062121
]
ASF GitHub Bot commented on MAHOUT-1988:
Github user andrewpalumbo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/326#discussion_r123885153
--- Diff:
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends
MatrixBase {
- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}
- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new
Context(Context.MAIN_MEMORY)) {
--- End diff --
rebuilding abd testing now with the correct scala flags.. noticed this in
spark/dependency-reduced-pom.xmlpom.xml: [INFO] Reading assembly descriptor:
src/main/assembly/dependency-reduced.xml
```
[WARNING] The following patterns were never triggered in this artifact
inclusion filter:
o 'org.apache.mahout:mahout-native-viennacl_2.10'
o 'org.apache.mahout:mahout-native-viennacl-omp_2.10'
[INFO] Building jar:
/home/andy/sandbox/mahout_cuda/spark/target/mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
```
*easyhack*: add
to `spark/dependency reduced.xml`:
```
'org.apache.mahout:mahout-native-viennacl_2.11'
'org.apache.mahout:mahout-native-viennacl-omp_2.11'
```
though that pom should honor the `{scala.compat.version}`
> ViennaCL and OMP not building for Scala 2.11
>
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
> Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11:
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11
> -Phadoop2 -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking
> the 0.13.1 release.
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[DISCUSS] New mailing list for JIRA
Can we create a new mailing list like j...@mahout.apache.org for all this jira stuff? Any reason it needs to go to dev?
