[GitHub] incubator-metron pull request #304: METRON-496: Field transformations are ap...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] incubator-metron pull request #304: METRON-496: Field transformations are ap...
I am not aware of any discussions that have happened around that. I think it would be very useful to have that capability though. Good thought, Carolyn. On Tue, Oct 11, 2016 at 2:38 PM, Carolyn Duby wrote: > Have we considered having precondition validation and postcondition > validation. Preconditions could check that the fields are in good > condition to be transformed. Postconditions could find errors in events > after field transformations. > > Thanks > Carolyn > > > > On 10/11/16, 1:52 PM, "cestella" wrote: > > >GitHub user cestella opened a pull request: > > > >https://github.com/apache/incubator-metron/pull/304 > > > >METRON-496: Field transformations are applied after parser validation > > > >Field transformations are applied after validation, which means that > the validation cannot be affected by the transformations. Consider a > situation where you get a timestamp field in as a string and the parser > validation expects a long. Conversion could be done as part of a field > transformation, whereas now it would fail validation. > > > >You can merge this pull request into a Git repository by running: > > > >$ git pull https://github.com/cestella/incubator-metron METRON-496 > > > >Alternatively you can review and apply these changes as the patch at: > > > >https://github.com/apache/incubator-metron/pull/304.patch > > > >To close this pull request, make a commit to your master/trunk branch > >with (at least) the following in the commit message: > > > >This closes #304 > > > > > >commit fa40a3b496a251d55d7fe301b5a839435a4ade7d > >Author: cstella > >Date: 2016-10-11T17:47:24Z > > > >METRON-496: Field transformations are applied after parser validation > > > >commit 329a13d2d676701f4284cf216f9d444de5a56986 > >Author: cstella > >Date: 2016-10-11T17:51:10Z > > > >Merge branch 'master' into METRON-496 > > > > > > > > > >--- > >If your project is set up for it, you can reply to this email and have > your > >reply appear on GitHub as well. If your project does not have this feature > >enabled and wishes so, or if the feature is enabled but not working, > please > >contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > >with INFRA. > >--- > > > -- Nick Allen
Re: [GitHub] incubator-metron pull request #304: METRON-496: Field transformations are ap...
Have we considered having precondition validation and postcondition validation. Preconditions could check that the fields are in good condition to be transformed. Postconditions could find errors in events after field transformations. Thanks Carolyn On 10/11/16, 1:52 PM, "cestella" wrote: >GitHub user cestella opened a pull request: > >https://github.com/apache/incubator-metron/pull/304 > >METRON-496: Field transformations are applied after parser validation > >Field transformations are applied after validation, which means that the > validation cannot be affected by the transformations. Consider a situation > where you get a timestamp field in as a string and the parser validation > expects a long. Conversion could be done as part of a field transformation, > whereas now it would fail validation. > >You can merge this pull request into a Git repository by running: > >$ git pull https://github.com/cestella/incubator-metron METRON-496 > >Alternatively you can review and apply these changes as the patch at: > >https://github.com/apache/incubator-metron/pull/304.patch > >To close this pull request, make a commit to your master/trunk branch >with (at least) the following in the commit message: > >This closes #304 > > >commit fa40a3b496a251d55d7fe301b5a839435a4ade7d >Author: cstella >Date: 2016-10-11T17:47:24Z > >METRON-496: Field transformations are applied after parser validation > >commit 329a13d2d676701f4284cf216f9d444de5a56986 >Author: cstella >Date: 2016-10-11T17:51:10Z > >Merge branch 'master' into METRON-496 > > > > >--- >If your project is set up for it, you can reply to this email and have your >reply appear on GitHub as well. If your project does not have this feature >enabled and wishes so, or if the feature is enabled but not working, please >contact infrastructure at infrastruct...@apache.org or file a JIRA ticket >with INFRA. >--- >
[GitHub] incubator-metron pull request #304: METRON-496: Field transformations are ap...
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/304 METRON-496: Field transformations are applied after parser validation Field transformations are applied after validation, which means that the validation cannot be affected by the transformations. Consider a situation where you get a timestamp field in as a string and the parser validation expects a long. Conversion could be done as part of a field transformation, whereas now it would fail validation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron METRON-496 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #304 commit fa40a3b496a251d55d7fe301b5a839435a4ade7d Author: cstella Date: 2016-10-11T17:47:24Z METRON-496: Field transformations are applied after parser validation commit 329a13d2d676701f4284cf216f9d444de5a56986 Author: cstella Date: 2016-10-11T17:51:10Z Merge branch 'master' into METRON-496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
