[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen

2016-06-28 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352838#comment-15352838
 ] 

Nicolas Malin commented on OFBIZ-7655:
--

Agree with this !


> Use 'conditionFields' instead of 'andCondition' in Lookup screen
> 
>
> Key: OFBIZ-7655
> URL: https://issues.apache.org/jira/browse/OFBIZ-7655
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: andCondition, autocompletion, conditionFields, lookup
>
> In order to improve a little the readibility, we can replace the use of 
> direct call of groovy in Lookup screen for the autocompletion parameters. 
> Instead, we can use the field 'conditionFields', which is a map key/value, to 
> declare those parameters.
> This is a main task and a sub task will be created for each lookup involved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen

2016-06-28 Thread Montalbano Florian (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352837#comment-15352837
 ] 

Montalbano Florian commented on OFBIZ-7655:
---

I'll do that for the next times. Thanks for your answers :)

> Use 'conditionFields' instead of 'andCondition' in Lookup screen
> 
>
> Key: OFBIZ-7655
> URL: https://issues.apache.org/jira/browse/OFBIZ-7655
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: andCondition, autocompletion, conditionFields, lookup
>
> In order to improve a little the readibility, we can replace the use of 
> direct call of groovy in Lookup screen for the autocompletion parameters. 
> Instead, we can use the field 'conditionFields', which is a map key/value, to 
> declare those parameters.
> This is a main task and a sub task will be created for each lookup involved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen

2016-06-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352829#comment-15352829
 ] 

Jacques Le Roux commented on OFBIZ-7655:


Only one patch for all the screens is enough

> Use 'conditionFields' instead of 'andCondition' in Lookup screen
> 
>
> Key: OFBIZ-7655
> URL: https://issues.apache.org/jira/browse/OFBIZ-7655
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: andCondition, autocompletion, conditionFields, lookup
>
> In order to improve a little the readibility, we can replace the use of 
> direct call of groovy in Lookup screen for the autocompletion parameters. 
> Instead, we can use the field 'conditionFields', which is a map key/value, to 
> declare those parameters.
> This is a main task and a sub task will be created for each lookup involved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen

2016-06-28 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352746#comment-15352746
 ] 

Deepak Dixit commented on OFBIZ-7655:
-

I think one would be good. :)

> Use 'conditionFields' instead of 'andCondition' in Lookup screen
> 
>
> Key: OFBIZ-7655
> URL: https://issues.apache.org/jira/browse/OFBIZ-7655
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: andCondition, autocompletion, conditionFields, lookup
>
> In order to improve a little the readibility, we can replace the use of 
> direct call of groovy in Lookup screen for the autocompletion parameters. 
> Instead, we can use the field 'conditionFields', which is a map key/value, to 
> declare those parameters.
> This is a main task and a sub task will be created for each lookup involved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen

2016-06-28 Thread Montalbano Florian (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352731#comment-15352731
 ] 

Montalbano Florian commented on OFBIZ-7655:
---

Ok, I'm taking note for the next time :)
Should I create 1 issue by screen or 1 only patch for all the screen ?

> Use 'conditionFields' instead of 'andCondition' in Lookup screen
> 
>
> Key: OFBIZ-7655
> URL: https://issues.apache.org/jira/browse/OFBIZ-7655
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: andCondition, autocompletion, conditionFields, lookup
>
> In order to improve a little the readibility, we can replace the use of 
> direct call of groovy in Lookup screen for the autocompletion parameters. 
> Instead, we can use the field 'conditionFields', which is a map key/value, to 
> declare those parameters.
> This is a main task and a sub task will be created for each lookup involved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen

2016-06-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352725#comment-15352725
 ] 

Jacques Le Roux commented on OFBIZ-7655:


Florian, in simple cases like that you don't need to create subtasks, a simple 
patch would do it ;)

> Use 'conditionFields' instead of 'andCondition' in Lookup screen
> 
>
> Key: OFBIZ-7655
> URL: https://issues.apache.org/jira/browse/OFBIZ-7655
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: andCondition, autocompletion, conditionFields, lookup
>
> In order to improve a little the readibility, we can replace the use of 
> direct call of groovy in Lookup screen for the autocompletion parameters. 
> Instead, we can use the field 'conditionFields', which is a map key/value, to 
> declare those parameters.
> This is a main task and a sub task will be created for each lookup involved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)