[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473439#comment-16473439 ] Yonatan Gottesman commented on OMID-44: --- +1 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462153#comment-16462153 ] Ohad Shacham commented on OMID-44: -- [~jmclean], could you please review? Thx! > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457941#comment-16457941 ] Ohad Shacham commented on OMID-44: -- [~jamestaylor], the latest version of the NOTICE file is at: [https://github.com/ohadshacham/incubator-omid/blob/OMID-44/NOTICE] > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457935#comment-16457935 ] ASF GitHub Bot commented on OMID-44: GitHub user ohadshacham reopened a pull request: https://github.com/apache/incubator-omid/pull/29 [OMID-44] Since YCSB files are includes in OMID a reference in Yahoo … …is needed in the NOTICE file. Subject raised at: https://lists.apache.org/thread.html/10fd534d9ea4b0a4574637ab49e5d823a47a864ec27f317f90b14196@%3Cgeneral.incubator.apache.org%3E You can merge this pull request into a Git repository by running: $ git pull https://github.com/ohadshacham/incubator-omid OMID-44 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-omid/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit af7acfaa60fc67c1523069be3e6acd4d7c018daf Author: Ohad Shacham Date: 2018-03-26T08:31:37Z [OMID-44] Since YCSB files are includes in OMID a reference in Yahoo is needed in the NOTICE file. Subject raised at: https://lists.apache.org/thread.html/10fd534d9ea4b0a4574637ab49e5d823a47a864ec27f317f90b14196@%3Cgeneral.incubator.apache.org%3E > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457123#comment-16457123 ] James Taylor commented on OMID-44: -- [~ohads] - is the the current, latest version of the NOTICE file: https://github.com/francisco-perez-sorrosal/incubator-omid/blob/1add26da97a4a571089bf7029768f6763c1c9b73/NOTICE? > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453757#comment-16453757 ] Ohad Shacham commented on OMID-44: -- [~jmclean], could you please review? I updated the year and made it as simple as possible. Thx. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424626#comment-16424626 ] Justin Mclean commented on OMID-44: --- Sorry I obviously need more coffee, what you done is correct and what I suggest you do - my mistake you can ignore the comments above. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424623#comment-16424623 ] Justin Mclean commented on OMID-44: --- " and the links I've previously provided." I mean. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424621#comment-16424621 ] Justin Mclean commented on OMID-44: --- Why has Yahoo been added to the NOTICE file? This is not the correct way to deal with this. Please see my comments above and the list I've previously provided. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > Fix For: 0.9.0.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423600#comment-16423600 ] Ohad Shacham commented on OMID-44: -- Thx! > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423599#comment-16423599 ] ASF GitHub Bot commented on OMID-44: Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/29 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422556#comment-16422556 ] James Taylor commented on OMID-44: -- +1 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422236#comment-16422236 ] Ohad Shacham commented on OMID-44: -- Can anyone please review? > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413568#comment-16413568 ] Ohad Shacham commented on OMID-44: -- [~jmclean], Could you please review? Thx! > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413566#comment-16413566 ] ASF GitHub Bot commented on OMID-44: GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/29 [OMID-44] Since YCSB files are includes in OMID a reference in Yahoo … …is needed in the NOTICE file. Subject raised at: https://lists.apache.org/thread.html/10fd534d9ea4b0a4574637ab49e5d823a47a864ec27f317f90b14196@%3Cgeneral.incubator.apache.org%3E You can merge this pull request into a Git repository by running: $ git pull https://github.com/ohadshacham/incubator-omid OMID-44 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-omid/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit af7acfaa60fc67c1523069be3e6acd4d7c018daf Author: Ohad Shacham Date: 2018-03-26T08:31:37Z [OMID-44] Since YCSB files are includes in OMID a reference in Yahoo is needed in the NOTICE file. Subject raised at: https://lists.apache.org/thread.html/10fd534d9ea4b0a4574637ab49e5d823a47a864ec27f317f90b14196@%3Cgeneral.incubator.apache.org%3E > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.9.0.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Ohad Shacham >Priority: Major > Labels: license, notice > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417671#comment-15417671 ] ASF GitHub Bot commented on OMID-44: GitHub user francisco-perez-sorrosal opened a pull request: https://github.com/apache/incubator-omid/pull/6 [OMID-44] Add reference to Yahoo code in NOTICE file Add again the reference to Yahoo code in the NOTICE file after the discussion in JIRA. Change-Id: Iecd6d9cf30d3b0cbbe72603f844f9204266a77b5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/francisco-perez-sorrosal/incubator-omid fix-notice Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-omid/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit d4d5783589dd65ed226d5f198277d615d41e8640 Author: Francisco Perez-Sorrosal Date: 2016-06-06T20:55:18Z [OMID-44] Add reference to Yahoo code in NOTICE file Change-Id: Iecd6d9cf30d3b0cbbe72603f844f9204266a77b5 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.3.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352615#comment-15352615 ] Flavio Junqueira commented on OMID-44: -- Next release sounds fine with me. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.3.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351381#comment-15351381 ] Francisco Perez-Sorrosal commented on OMID-44: -- No objections here. These classes are not core classes and are just used in the load generation for one of the benchmarks. I can try to get rid of them in the next release to avoid this kind of problems with the release. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.3.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350290#comment-15350290 ] Daniel Dai commented on OMID-44: As this is not a blocking issue for 0.8.2.0 releaes, I'd like to resolve it in the next release by adding right content to NOTICE. Any objection? > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.3.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350019#comment-15350019 ] Daniel Dai commented on OMID-44: Compared the files with YCSB2, here is where these files coming from: benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java <- YCSB2/core/src/main/java/com/yahoo/ycsb/generator/Generator.java (differ only in package, header and formatting) benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java <- YCSB2/core/src/main/java/com/yahoo/ycsb/generator/IntegerGenerator.java (differ only in package, header and formatting) benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java <- YCSB2/core/src/main/java/com/yahoo/ycsb/generator/ScrambledZipfianGenerator.java (besides in package, header and formatting, also contain some code from YCSB2/core/src/main/java/com/yahoo/ycsb/Utils.java) benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java <- YCSB2/core/src/main/java/com/yahoo/ycsb/generator/ZipfianGenerator.java (differ only in package, header and formatting) All referenced files in YCSB2 has headers and attribute copyright to Yahoo with Apache license. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349522#comment-15349522
]
Flavio Junqueira commented on OMID-44:
--
Thanks for bringing this up [~jmclean]. There are two references for YCSB, in
one notice file, there is a mention to a google dependency, while the second
doesn't. As I understand, we aren't including such a reference, so we can omit
it.
For the YCSB2 reference you pointed, the notice file says:
{noformat}
=
NOTICE file for use with, and corresponding to Section 4 of,
the Apache License, Version 2.0,
in this case for the YCSB project.
=
This product includes software developed by
Yahoo! Inc. (www.yahoo.com)
Copyright (c) 2010 Yahoo! Inc. All rights reserved.
{noformat}
Two clarification questions:
# Should we include the original NOTICE.txt file along with the copied YCSB
files (in the same folder)?
# Should we have a path in the notice indicating where the files are in the
source code?
> Add reference to Yahoo code in NOTICE file
> --
>
> Key: OMID-44
> URL: https://issues.apache.org/jira/browse/OMID-44
> Project: Apache Omid
> Issue Type: Task
>Affects Versions: 0.8.2.0
>Reporter: Francisco Perez-Sorrosal
>Assignee: Francisco Perez-Sorrosal
> Labels: license, notice
> Fix For: 0.8.2.0
>
>
> Some files were taken from ycsb so we need to say that in NOTICE file:
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349518#comment-15349518 ] Justin Mclean commented on OMID-44: --- BTW the text should be what in the original NOTICE file. I find it a little odd it has "All rights reserved." when it is Apache licensed. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349516#comment-15349516 ] Justin Mclean commented on OMID-44: --- Up to you. IMO it's fine to fix in the next release or a later one as long as it's before graduation. And you already have enough +1 IPMC votes to make a release. I had't realised you had looked at this issue when I voted +0 on the incubator list. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349508#comment-15349508 ] Daniel Dai commented on OMID-44: [~jmclean] How about adding the following into NOTICE? "This product includes code from YCSB (https://github.com/LatencyUtils/YCSB2) copyrighted by Yahoo Inc and licensed under the Apache License, Version 2.0." Do you think we need to redo the rc? > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348992#comment-15348992 ] Justin Mclean commented on OMID-44: --- IMO (with my incubator hat on) it looks to me that this has been resolved incorrectly. Up to the PPMC to decide what action to take. The project the files were taken from looks to have a NOTICE file ([1] or [2]?) and information in that file needs to be bubble up into your NOTICE file. See [2], in particular: "If the dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file." Also see [4] 1. https://github.com/LatencyUtils/YCSB2 2. https://github.com/brianfrankcooper/YCSB/blob/master/NOTICE.txt 3. http://www.apache.org/dev/licensing-howto.html#alv2-dep 4. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340531#comment-15340531 ] Daniel Dai commented on OMID-44: +1 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340525#comment-15340525 ] Francisco Pérez-Sorrosal commented on OMID-44: -- I guess you can +1 and commit -- Francisco Pérez-Sorrosal > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340518#comment-15340518 ] Daniel Dai commented on OMID-44: Are we waiting for [~alangates]'s review on the revert? > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336997#comment-15336997 ] Francisco Perez-Sorrosal commented on OMID-44: -- The pull request for the revert is in here: https://github.com/yahoo/omid/pull/122 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336885#comment-15336885 ] Francisco Perez-Sorrosal commented on OMID-44: -- I submitted a branch reverting the changes of the NOTICE file in here: https://github.com/yahoo/omid/compare/master...omid-44 When you +1, I'll merge the changes into master and I'll push them into the Apache repo. Then, Daniel can cherry pick that change for the release branch. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336773#comment-15336773 ] Alan Gates commented on OMID-44: Relevant documents I found on this: http://incubator.apache.org/guides/releasemanagement.html#note-license-and-notice http://incubator.apache.org/guides/releasemanagement.html#best-practice-license http://www.apache.org/legal/src-headers.html It appears Yahoo's lawyers were viewing those files as not theirs to give away or something they didn't want to give away, maybe because it came from a non-Omid project. Anyway if we treat them as third party work as covered in http://www.apache.org/legal/src-headers.html then we shouldn't remove the copyrights in the header and we don't need to put them in the NOTICE file. So I think Flavio is right. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336565#comment-15336565 ] Flavio Junqueira commented on OMID-44: -- Ok, so maybe [~alangates] missed that it had the Apache License or I'm misinterpreting the requirements. Perhaps [~alangates] can clarify? > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336434#comment-15336434 ] Francisco Perez-Sorrosal commented on OMID-44: -- When [~alangates] voted -1 on Jun 6 at 11:55 AM on the topic "re[VOTE] Omid release branch 0.8.2.0 RC3(6)" he mentioned this: "-1 All incubator releases must have a disclaimer. See http://incubator.apache.org/guides/releasemanagement.html#notes-disclaimer I found for files that still have Yahoo copyright headers: ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java If we need to keep these with the Yahoo header than I think we need to put in the NOTICE file that this code includes code developed at Yahoo. If we just missed these then we should put the standard Apache header on them. See http://incubator.apache.org/guides/releasemanagement.html#best-practice-license for details. I haven’t finished this but sending now as I see Igor is closing the vote and moving it to the incubator list. Alan. " Someone at some point added those classes into Omid from the YCSB project (https://github.com/brianfrankcooper/YCSB/) and they have the follwoing header were Yahoo is referenced: /** * Copyright (c) 2010 Yahoo! Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); you * may not use this file except in compliance with the License. You * may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or * implied. See the License for the specific language governing * permissions and limitations under the License. See accompanying * LICENSE file. */ When we first open-sourced Omid in Github, the legal department told me to maintain those headers, so when I read Alan's response I though that I should add the reference to Yahoo in the NOTICE file. But maybe I misunderstood him. > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336097#comment-15336097
]
Flavio Junqueira commented on OMID-44:
--
I'm confused about this issue. The files you're mentioning above are under
ALv2. In this page:
http://www.apache.org/dev/licensing-howto.html#alv2-dep
we the following:
{noformat}
Bundling an Apache-2.0-licensed Dependency
Assuming once again that that the bundled dependency itself contains no bundled
subcomponents under other licenses and thus the ALv2 applies uniformly to all
files,
there is no need to modify LICENSE.
If the dependency supplies a NOTICE file, its contents must be analyzed and the
relevant portions bubbled up into the top-level NOTICE file.
{noformat}
I'm not sure what led you to the conclusion that we need to add a reference to
Yahoo! in the notice file.
> Add reference to Yahoo code in NOTICE file
> --
>
> Key: OMID-44
> URL: https://issues.apache.org/jira/browse/OMID-44
> Project: Apache Omid
> Issue Type: Task
>Affects Versions: 0.8.2.0
>Reporter: Francisco Perez-Sorrosal
>Assignee: Francisco Perez-Sorrosal
> Labels: license, notice
> Fix For: 0.8.2.0
>
>
> Some files were taken from ycsb so we need to say that in NOTICE file:
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java
> ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323404#comment-15323404 ] Igor Katkov commented on OMID-44: - +1 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OMID-44) Add reference to Yahoo code in NOTICE file
[ https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317227#comment-15317227 ] Francisco Perez-Sorrosal commented on OMID-44: -- PR submitted to https://github.com/yahoo/omid/pull/119 > Add reference to Yahoo code in NOTICE file > -- > > Key: OMID-44 > URL: https://issues.apache.org/jira/browse/OMID-44 > Project: Apache Omid > Issue Type: Task >Affects Versions: 0.8.2.0 >Reporter: Francisco Perez-Sorrosal >Assignee: Francisco Perez-Sorrosal > Labels: license, notice > Fix For: 0.8.2.0 > > > Some files were taken from ycsb so we need to say that in NOTICE file: > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/IntegerGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ScrambledZipfianGenerator.java > ./benchmarks/src/main/java/org/apache/omid/benchmarks/utils/ZipfianGenerator.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
