Re: CDI context propagation for threads spawned asynchronously using servlet 3.0 and javax.resource.spi.work.WorkManager APIs

2012-06-22 Thread Rohit Kelapure
Servlet 3.0 - Section 2.3.3.3.

" When asyncSupported is set to true the application can start
asynchronous processing in a separate thread by calling startAsync ,
passing it a reference to the request and response objects, and then exit
from the container on the original thread. This means that the response
will traverse (in reverse order) the same filters (or filter chain) that
were traversed on the way in. The response isn't committed till complete is
called on the AsyncContext.

*The application is responsible to handle concurrent access to the request
and response objects if the async task is executing before the
container-initiated dispatch that called startAsync has returned to the
container.* "

This mean parent and async task/s may be executing concurrently.

cheers,
--Rohit


On Fri, Jun 22, 2012 at 5:21 PM, Mark Struberg  wrote:

>
>
> My understanding of this is that there is still only 1 concurrent Thread.
> The 'request' will will just get moved over to a new worker, but still max
> 1 at a time, isn't?
>
> But have only read over the spec quickly, will need to dig much deeper...
>
> LieGrue,
> strub
>
>
>
>
> >
> > From: Rohit Kelapure 
> >To: dev@openwebbeans.apache.org; Mark Struberg 
> >Sent: Friday, June 22, 2012 11:12 PM
> >Subject: Re: CDI context propagation for threads spawned asynchronously
> using servlet 3.0 and javax.resource.spi.work.WorkManager APIs
> >
> >
> >
> >Team,
> >
> >
> >Does it make sense to propagate the RequestContext ?  given that there
> may be multiple threads that will inherit and share the same RequestContext
> >
> >
> >We will need to manage the destruction of the RequestContext such that
> only the last one (Parent + child async threads) ends the context.
> >
> >
> >This could get messy with locking and keeping track of when each runnable
> exits.  For servlet 3.0 this may not be a problem since the AsyncListener
> will abstract all this for us. Unfortunately there is no good place to add
> the per request listener asynclistener.
> >
> >
> >The basic issue here is that sharing of the RequestContext leads to
> complexity in ending the context.
> >
> >
> >-cheers,
> >Rohit
> >
> >
> >On Fri, Jun 22, 2012 at 12:36 PM, Mark Struberg 
> wrote:
> >
> >
> >>
> >>Hi folks!
> >>
> >>We are aware that OWB currently doesn't provide this. But all the
> information is already centrally collected and maintained in the
> ContextsService.
> >>For WAS this will most probably be the WebContextsService. So all you
> need to know is centrally available there.
> >>
> >>Also the TheadLocal caches in the proxies will need to get cleared (if
> being used).
> >>
> >>In practice this doesn't make any problems atm, as asynchronous requests
> must only get performed if ALL involved Servlets, Filters, etc must have
> >>
> >>true
> >>
> >>
> >>Of course, at the end of the day we should support it!
> >>
> >>Will take a look once I'm back from the conference next week.
> >>
> >>
> >>LieGrue,
> >>strub
> >>
> >>
> >>- Original Message -
> >>> From: Romain Manni-Bucau 
> >>> To: dev@openwebbeans.apache.org
> >>> Cc:
> >>> Sent: Friday, June 22, 2012 6:24 PM
> >>> Subject: Re: CDI context propagation for threads spawned
> asynchronously using servlet 3.0 and javax.resource.spi.work.WorkManager
> APIs
> >>>
> >>> Hi,
> >>>
> >>> i don't know any standard way but what i often saw was to create a
> kind of
> >>> "invocation context" to avoid to need anything in the async call.
> >>>
> >>> - Romain
> >>>
> >>>
> >>> 2012/6/22 Rohit Kelapure 
> >>>
> >>>>  Team,
> >>>>
> >>>>  Do we have a standard way of propagating CDI contexts (request,
> session,
> >>>>  application, singleton, conversation) and other threadlocal state
> from a
> >>>>  parent thread say servicing a servlet request to its dispatched child
> >>>>  runnable using the servlet 3.0 AsyncContext.startAsync or the
> WorkManager
> >>>>  APIs.
> >>>>
> >>>>  I understand that the solution may be specific to individual
> containers
> >>>>  like Tomcat, WebLogic, WAS etc ...
> >>>>  Has anyone already solved this problem for their container ?
> >>>>  Thought I would ask before fixing it in WAS.
> >>>>
> >>>>  -cheers,
> >>>>  Rohit Kelapure
> >>>>
> >>>
> >>
> >
> >
> >
>


Re: CDI context propagation for threads spawned asynchronously using servlet 3.0 and javax.resource.spi.work.WorkManager APIs

2012-06-22 Thread Rohit Kelapure
Team,

Does it make sense to propagate the RequestContext ?  given that there may
be multiple threads that will inherit and share the same RequestContext

We will need to manage the destruction of the RequestContext such that only
the last one (Parent + child async threads) ends the context.

This could get messy with locking and keeping track of when each runnable
exits.  For servlet 3.0 this may not be a problem since the AsyncListener
will abstract all this for us. Unfortunately there is no good place to add
the per request listener asynclistener.

The basic issue here is that sharing of the RequestContext leads to
complexity in ending the context.

-cheers,
Rohit

On Fri, Jun 22, 2012 at 12:36 PM, Mark Struberg  wrote:

>
>
> Hi folks!
>
> We are aware that OWB currently doesn't provide this. But all the
> information is already centrally collected and maintained in the
> ContextsService.
> For WAS this will most probably be the WebContextsService. So all you need
> to know is centrally available there.
>
> Also the TheadLocal caches in the proxies will need to get cleared (if
> being used).
>
> In practice this doesn't make any problems atm, as asynchronous requests
> must only get performed if ALL involved Servlets, Filters, etc must have
>
> true
>
>
> Of course, at the end of the day we should support it!
>
> Will take a look once I'm back from the conference next week.
>
>
> LieGrue,
> strub
>
> - Original Message -
> > From: Romain Manni-Bucau 
> > To: dev@openwebbeans.apache.org
> > Cc:
> > Sent: Friday, June 22, 2012 6:24 PM
> > Subject: Re: CDI context propagation for threads spawned asynchronously
> using servlet 3.0 and javax.resource.spi.work.WorkManager APIs
> >
> > Hi,
> >
> > i don't know any standard way but what i often saw was to create a kind
> of
> > "invocation context" to avoid to need anything in the async call.
> >
> > - Romain
> >
> >
> > 2012/6/22 Rohit Kelapure 
> >
> >>  Team,
> >>
> >>  Do we have a standard way of propagating CDI contexts (request,
> session,
> >>  application, singleton, conversation) and other threadlocal state from
> a
> >>  parent thread say servicing a servlet request to its dispatched child
> >>  runnable using the servlet 3.0 AsyncContext.startAsync or the
> WorkManager
> >>  APIs.
> >>
> >>  I understand that the solution may be specific to individual containers
> >>  like Tomcat, WebLogic, WAS etc ...
> >>  Has anyone already solved this problem for their container ?
> >>  Thought I would ask before fixing it in WAS.
> >>
> >>  -cheers,
> >>  Rohit Kelapure
> >>
> >
>


Re: CDI context propagation for threads spawned asynchronously using servlet 3.0 and javax.resource.spi.work.WorkManager APIs

2012-06-22 Thread Rohit Kelapure
Correct. Some code in the container peeks, pushes and pops  this JavaEE
context before and after the work has been dispatched.

On Fri, Jun 22, 2012 at 12:24 PM, Romain Manni-Bucau
wrote:

> Hi,
>
> i don't know any standard way but what i often saw was to create a kind of
> "invocation context" to avoid to need anything in the async call.
>
> - Romain
>
>
> 2012/6/22 Rohit Kelapure 
>
> > Team,
> >
> > Do we have a standard way of propagating CDI contexts (request, session,
> > application, singleton, conversation) and other threadlocal state from a
> > parent thread say servicing a servlet request to its dispatched child
> > runnable using the servlet 3.0 AsyncContext.startAsync or the WorkManager
> > APIs.
> >
> > I understand that the solution may be specific to individual containers
> > like Tomcat, WebLogic, WAS etc ...
> > Has anyone already solved this problem for their container ?
> > Thought I would ask before fixing it in WAS.
> >
> > -cheers,
> > Rohit Kelapure
> >
>


CDI context propagation for threads spawned asynchronously using servlet 3.0 and javax.resource.spi.work.WorkManager APIs

2012-06-22 Thread Rohit Kelapure
Team,

Do we have a standard way of propagating CDI contexts (request, session,
application, singleton, conversation) and other threadlocal state from a
parent thread say servicing a servlet request to its dispatched child
runnable using the servlet 3.0 AsyncContext.startAsync or the WorkManager
APIs.

I understand that the solution may be specific to individual containers
like Tomcat, WebLogic, WAS etc ...
Has anyone already solved this problem for their container ?
Thought I would ask before fixing it in WAS.

-cheers,
Rohit Kelapure


Re: Recent presentations on CDI

2012-05-24 Thread Rohit Kelapure
yeah I was pushing CODI :-)  and also DeltaSpike to some extent.
Unfortunately the audience was not as technical as I would have liked.
So I got mostly basic questions on the CDI specification and its various
aspects.

-cheers,
Rohit



On Wed, May 23, 2012 at 11:23 AM, Mark Struberg  wrote:

> Great, thanks!
>
> How was the feedback? It seems you made a fair share of CODI and
> DeltaSpike advertisement? ;)
>
> LieGrue,
> strub
>
>
>
> - Original Message -
> > From: Rohit Kelapure 
> > To: dev@openwebbeans.apache.org
> > Cc:
> > Sent: Wednesday, May 23, 2012 3:53 PM
> > Subject: Re: Recent presentations on CDI
> >
> >T eam,
> >
> > Thank you for all your presentations. I uploaded the most recent one on
> CDI
> > best practices I gave at an IBM Conference  here -
> >
> http://www.slideshare.net/kelapure/2012-0409v2tdp1167cdibestpracticesfinal
> >
> > -cheers,
> > Rohit
> >
> > On Fri, Mar 23, 2012 at 10:29 PM, Rohit Kelapure 
> > wrote:
> >
> >>  Thank you all. I really appreciate it !
> >>
> >>  On Thu, Mar 22, 2012 at 8:21 PM, Gerhard Petracek <
> >>  gerhard.petra...@gmail.com> wrote:
> >>
> >>>  hi rohit,
> >>>
> >>>  you can find my public slides at [1].
> >>>  and you can have a look at [2].
> >>>
> >>>  regards,
> >>>  gerhard
> >>>
> >>>  [1] http://www.slideshare.net/os890/
> >>>  [2] https://cwiki.apache.org/confluence/display/EXTCDI/External
> >>>
> >>>  http://www.irian.at
> >>>
> >>>  Your JSF/JavaEE powerhouse -
> >>>  JavaEE Consulting, Development and
> >>>  Courses in English and German
> >>>
> >>>  Professional Support for Apache MyFaces
> >>>
> >>>
> >>>
> >>>  2012/3/22 Arne Limburg 
> >>>
> >>>  > Hi Rohit,
> >>>  >
> >>>  > http://www.openknowledge.de/?id=62#139
> >>>  >
> >>>  > unfortunately in german, but you should be able to read most of
> > the
> >>>  stuff
> >>>  > ;-)
> >>>  >
> >>>  > Cheers,
> >>>  > Arne
> >>>  >
> >>>  > -Ursprüngliche Nachricht-
> >>>  > Von: Rohit Kelapure [mailto:kelap...@gmail.com]
> >>>  > Gesendet: Donnerstag, 22. März 2012 19:49
> >>>  > An: dev@openwebbeans.apache.org
> >>>  > Betreff: Recent presentations on CDI
> >>>  >
> >>>  > Team,
> >>>  >
> >>>  > Have you recently come across or given advanced level
> > presentations on
> >>>  > topics like CDI best practices, Extensions, CDI 1.1, CODI, Seam 3,
> >>>  > DeltaSpike, JSF 2.2-CDI integration. If so I would be obliged if
> > you
> >>>  could
> >>>  > please bring them to my notice.
> >>>  >
> >>>  > --Thanks,
> >>>  > Rohit Kelapure
> >>>  >
> >>>
> >>
> >>
> >
>


Re: Recent presentations on CDI

2012-05-23 Thread Rohit Kelapure
Team,

Thank you for all your presentations. I uploaded the most recent one on CDI
best practices I gave at an IBM Conference  here -
http://www.slideshare.net/kelapure/2012-0409v2tdp1167cdibestpracticesfinal

-cheers,
Rohit

On Fri, Mar 23, 2012 at 10:29 PM, Rohit Kelapure  wrote:

> Thank you all. I really appreciate it !
>
> On Thu, Mar 22, 2012 at 8:21 PM, Gerhard Petracek <
> gerhard.petra...@gmail.com> wrote:
>
>> hi rohit,
>>
>> you can find my public slides at [1].
>> and you can have a look at [2].
>>
>> regards,
>> gerhard
>>
>> [1] http://www.slideshare.net/os890/
>> [2] https://cwiki.apache.org/confluence/display/EXTCDI/External
>>
>> http://www.irian.at
>>
>> Your JSF/JavaEE powerhouse -
>> JavaEE Consulting, Development and
>> Courses in English and German
>>
>> Professional Support for Apache MyFaces
>>
>>
>>
>> 2012/3/22 Arne Limburg 
>>
>> > Hi Rohit,
>> >
>> > http://www.openknowledge.de/?id=62#139
>> >
>> > unfortunately in german, but you should be able to read most of the
>> stuff
>> > ;-)
>> >
>> > Cheers,
>> > Arne
>> >
>> > -Ursprüngliche Nachricht-
>> > Von: Rohit Kelapure [mailto:kelap...@gmail.com]
>> > Gesendet: Donnerstag, 22. März 2012 19:49
>> > An: dev@openwebbeans.apache.org
>> > Betreff: Recent presentations on CDI
>> >
>> > Team,
>> >
>> > Have you recently come across or given advanced level presentations on
>> > topics like CDI best practices, Extensions, CDI 1.1, CODI, Seam 3,
>> > DeltaSpike, JSF 2.2-CDI integration. If so I would be obliged if you
>> could
>> > please bring them to my notice.
>> >
>> > --Thanks,
>> > Rohit Kelapure
>> >
>>
>
>


Re: Recent presentations on CDI

2012-03-23 Thread Rohit Kelapure
Thank you all. I really appreciate it !

On Thu, Mar 22, 2012 at 8:21 PM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:

> hi rohit,
>
> you can find my public slides at [1].
> and you can have a look at [2].
>
> regards,
> gerhard
>
> [1] http://www.slideshare.net/os890/
> [2] https://cwiki.apache.org/confluence/display/EXTCDI/External
>
> http://www.irian.at
>
> Your JSF/JavaEE powerhouse -
> JavaEE Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
>
> 2012/3/22 Arne Limburg 
>
> > Hi Rohit,
> >
> > http://www.openknowledge.de/?id=62#139
> >
> > unfortunately in german, but you should be able to read most of the stuff
> > ;-)
> >
> > Cheers,
> > Arne
> >
> > -Ursprüngliche Nachricht-
> > Von: Rohit Kelapure [mailto:kelap...@gmail.com]
> > Gesendet: Donnerstag, 22. März 2012 19:49
> > An: dev@openwebbeans.apache.org
> > Betreff: Recent presentations on CDI
> >
> > Team,
> >
> > Have you recently come across or given advanced level presentations on
> > topics like CDI best practices, Extensions, CDI 1.1, CODI, Seam 3,
> > DeltaSpike, JSF 2.2-CDI integration. If so I would be obliged if you
> could
> > please bring them to my notice.
> >
> > --Thanks,
> > Rohit Kelapure
> >
>


Re: Recent presentations on CDI

2012-03-22 Thread Rohit Kelapure
Thanks Mark!  I am preparing a presentation on CDI best practices and
extensions. Will contribute back to community as soon as I am done.

On Thu, Mar 22, 2012 at 2:55 PM, Mark Struberg  wrote:

> Hi Rohit!
>
> You can find a few of my conference talks on my people account:
> http://people.apache.org/~struberg
>
> Gerhard might have some good presentations for CODi and DS as well.
>
> LieGrue,
> strub
>
>
>
> - Original Message -
> > From: Rohit Kelapure 
> > To: dev@openwebbeans.apache.org
> > Cc:
> > Sent: Thursday, March 22, 2012 7:48 PM
> > Subject: Recent presentations on CDI
> >
> >T eam,
> >
> > Have you recently come across or given advanced level presentations on
> > topics like CDI best practices, Extensions, CDI 1.1, CODI, Seam 3,
> > DeltaSpike, JSF 2.2-CDI integration. If so I would be obliged if you
> could
> > please bring them to my notice.
> >
> > --Thanks,
> > Rohit Kelapure
> >
>


Recent presentations on CDI

2012-03-22 Thread Rohit Kelapure
Team,

Have you recently come across or given advanced level presentations on
topics like CDI best practices, Extensions, CDI 1.1, CODI, Seam 3,
DeltaSpike, JSF 2.2-CDI integration. If so I would be obliged if you could
please bring them to my notice.

--Thanks,
Rohit Kelapure


Re: [DISCUSS] remove webbeans-openejb module from OWB

2012-03-21 Thread Rohit Kelapure
agreed. For reference implementations we can point to  OpenEJB  or TomEE.

--cheers,
Rohit

On Wed, Mar 21, 2012 at 5:15 PM, Mark Struberg  wrote:

> Hi!
>
> webbeans-openejb is legacy code afaik.
>
>
> OpenEJB is using a codebase which was originally copied over and is
> already heavily extended.
>
> It also makes much more sense to implement those parts over at OpenEJB imo.
>
> Thus I'd like to remove the webbeans-openejb module from OWB.
>
> Please speak out if you are still using it. Otherwise I gonna kill the
> kitty tomorrow evening ;)
>
> LieGrue,
> strub
>
>


Re: [FYI] blogpost about the performance tricks in OpenWebBeans

2012-03-20 Thread Rohit Kelapure
This is awesome! Thanks Mark.

On Tue, Mar 20, 2012 at 9:39 AM, Mark Struberg  wrote:

> Hi folks!
>
> I did put together a blog post which explains a few of the performance
> tricks we use in OpenWebBeans:
>
> http://struberg.wordpress.com/2012/03/20/why-is-openwebbeans-so-fast/
>
>
> And there is also a new JavaTechJournal out today. This months edition
> covers CDI and contains articles co-written by Gerhard, Arne and me + the
> help of Matt Benson + lots of other folks from the CDI universe (Pete,
> Aslak, Andrew, Dan, Jason, Shane, Ronald, etc)
>
> http://jaxenter.com/java-tech-journal
>
>
> LieGrue,
> strub
>
>


Re: [ANNOUNCE] Welcome Romain Manni-Bucau as new Committer!

2012-03-12 Thread Rohit Kelapure
Congrats and welcome!

On Mon, Mar 12, 2012 at 5:30 AM, Gurkan Erdogdu wrote:

> Welcome on board Romain!
>
> Gurkan
>
>
> 
>  Kimden: Mark Struberg 
> Kime: openwebbeans-dev ; "
> u...@openwebbeans.apache.org" 
> Gönderildiği Tarih: 12 Mart 2012 9:23 Pazartesi
> Konu: [ANNOUNCE] Welcome Romain Manni-Bucau as new Committer!
>
> All,
>
> The OpenWebBeans PMC is pleased to announce that Romain Manni-Bucau has
> accepted our invitation to join the OpenWebBeans project as a
> committer.
>
> Congratulations and welcome Romain!
>
> the OpenWebBeans PMC
>


Re: [jira] [Commented] (OWB-626) Conversation Scope isn't accessible after RENDER_RESPONSE phase

2012-03-05 Thread Rohit Kelapure
28.4. Seam-managed persistence contexts
http://docs.jboss.org/seam/3/latest/reference/en-US/html_single/

On Mon, Mar 5, 2012 at 10:02 AM, Rohit Kelapure  wrote:
>
> For SEAM 3 the most pertinent information in the defect is this 
>
> Seam uses @ConversationScoped scope to manage his extended persistenceContext 
> which is one of the most convenient features.
>
> I will do some research and find out how they are using @ConversationScoped
> and if there is a sample application that illustrates this issue.
>
> -cheers,
> Rohit
>
>
>
> On Mon, Mar 5, 2012 at 9:43 AM, Mark Struberg (Commented) (JIRA) 
>  wrote:
>>
>>
>>    [ 
>> https://issues.apache.org/jira/browse/OWB-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222377#comment-13222377
>>  ]
>>
>> Mark Struberg commented on OWB-626:
>> ---
>>
>> For DeltaSpike and CODI I can guarantee that this is not needed. As for 
>> Seam3: do you have any forum references or other links for me? We might 
>> reach out to JBoss to fix this in Seam3.
>>
>> > Conversation Scope isn't accessible after RENDER_RESPONSE phase
>> > ---
>> >
>> >                 Key: OWB-626
>> >                 URL: https://issues.apache.org/jira/browse/OWB-626
>> >             Project: OpenWebBeans
>> >          Issue Type: Bug
>> >          Components: Core
>> >    Affects Versions: 1.1.1
>> >            Reporter: Thierry Robin
>> >            Assignee: Mark Struberg
>> >             Fix For: 1.2.0
>> >
>> >         Attachments: OWB626ConversationPhaseListener.java
>> >
>> >
>> > In CDI 1.0, the Conversation Scope is normaly accessible from after 
>> > RESTORE_VIEW phase in JSF, to the end of the Response.
>> > But It's not the case during the after phase(RENDER_RESPONSE) of any 
>> > PhaseListener implementation.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA 
>> administrators: 
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>


Re: [jira] [Commented] (OWB-626) Conversation Scope isn't accessible after RENDER_RESPONSE phase

2012-03-05 Thread Rohit Kelapure
For SEAM 3 the most pertinent information in the defect is this 

Seam uses @ConversationScoped scope to manage his extended
persistenceContext which is one of the most convenient features.

I will do some research and find out how they are using @ConversationScoped
and if there is a sample application that illustrates this issue.

-cheers,
Rohit



On Mon, Mar 5, 2012 at 9:43 AM, Mark Struberg (Commented) (JIRA) <
j...@apache.org> wrote:

>
>[
> https://issues.apache.org/jira/browse/OWB-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222377#comment-13222377]
>
> Mark Struberg commented on OWB-626:
> ---
>
> For DeltaSpike and CODI I can guarantee that this is not needed. As for
> Seam3: do you have any forum references or other links for me? We might
> reach out to JBoss to fix this in Seam3.
>
> > Conversation Scope isn't accessible after RENDER_RESPONSE phase
> > ---
> >
> > Key: OWB-626
> > URL: https://issues.apache.org/jira/browse/OWB-626
> > Project: OpenWebBeans
> >  Issue Type: Bug
> >  Components: Core
> >Affects Versions: 1.1.1
> >Reporter: Thierry Robin
> >Assignee: Mark Struberg
> > Fix For: 1.2.0
> >
> > Attachments: OWB626ConversationPhaseListener.java
> >
> >
> > In CDI 1.0, the Conversation Scope is normaly accessible from after
> RESTORE_VIEW phase in JSF, to the end of the Response.
> > But It's not the case during the after phase(RENDER_RESPONSE) of any
> PhaseListener implementation.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>


Re: [jira] [Commented] (OWB-626) Conversation Scope isn't accessible after RENDER_RESPONSE phase

2012-03-05 Thread Rohit Kelapure
Mark,

I am afraid that customers may claim that OWB-626 is needed  for seam 3 /
delta -spike. I am trying to understand the problem and see if a fix can be
provided. This fix based on your comments regarding spec compliance will be
disabled by default and ONLY enabled via some JVM system property or an
openwebbeans property, till the (CDI & JSF) specs. provides better
guidance. Thanks for the info.  on when we destroy the conversation scope.

what do you think ?

--cheers,
Rohit



On Sun, Mar 4, 2012 at 2:51 AM, Mark Struberg (Commented) (JIRA) <
j...@apache.org> wrote:

>
>[
> https://issues.apache.org/jira/browse/OWB-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221823#comment-13221823]
>
> Mark Struberg commented on OWB-626:
> ---
>
> Hi Rohit!
>
> Do you really need this for a customer? Actually I think the spec is not
> 100% clear as it says 'until the end of the request' but doesn't say if it
> means the servlet request or the faces request. In OWB we decided to end
> the conversation at the end of the faces request because afterwards the JSF
> behaviour is undefined anyway. We played through quite some use cases and
> didn't find a sane usage but quite some arguments against it.
> E.g. if you manually close your session, then the CDI conversation would
> continue per the strict spec, even if the session (containing the
> conversation) doesn't exist anymore. This interpretation also would brake
> the asyncSupported use case in the future, I fear.
>
> > Conversation Scope isn't accessible after RENDER_RESPONSE phase
> > ---
> >
> > Key: OWB-626
> > URL: https://issues.apache.org/jira/browse/OWB-626
> > Project: OpenWebBeans
> >  Issue Type: Bug
> >  Components: Core
> >Affects Versions: 1.1.1
> >Reporter: Thierry Robin
> >Assignee: Mark Struberg
> > Fix For: 1.2.0
> >
> > Attachments: OWB626ConversationPhaseListener.java
> >
> >
> > In CDI 1.0, the Conversation Scope is normaly accessible from after
> RESTORE_VIEW phase in JSF, to the end of the Response.
> > But It's not the case during the after phase(RENDER_RESPONSE) of any
> PhaseListener implementation.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>


Re: svn commit: r1293457 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans: component/InjectionPointBean.java container/BeanManagerImpl.java

2012-02-24 Thread Rohit Kelapure
Lesson learnt. Will take care next time to run the TCK as well.

--cheers,
Rohit

On Fri, Feb 24, 2012 at 5:48 PM, Mark Struberg  wrote:
> Hi Rohit,
>
> also thanks to you for fixing the underlying bug :)
>
> For now I just applied the fix to trunk. Do you need it as well on any other 
> branch?
>
>
> Btw, if you do such intense changes, then it's always a good idea to run both 
> TCKs
>
> $> mvn clean install -Ptck -Pjsr330-tck
>
> This will run both the CDI (standalone part) and the atinject TCK.
>
> LieGrue,
> strub
>
>
>
> - Original Message -
>> From: Rohit Kelapure 
>> To: dev@openwebbeans.apache.org
>> Cc: comm...@openwebbeans.apache.org
>> Sent: Friday, February 24, 2012 11:33 PM
>> Subject: Re: svn commit: r1293457 - in 
>> /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans: 
>> component/InjectionPointBean.java container/BeanManagerImpl.java
>>
>>T hank you Mark and Romain for investigating and fixing!!
>> - Rohit
>>
>> On Fri, Feb 24, 2012 at 5:31 PM,   wrote:
>>>  Author: struberg
>>>  Date: Fri Feb 24 22:31:49 2012
>>>  New Revision: 1293457
>>>
>>>  URL: http://svn.apache.org/viewvc?rev=1293457&view=rev
>>>  Log:
>>>  OWB-648 fix TCK
>>>
>>>  txs to Romain Manni-Bucau for the patch!
>>>
>>>  Modified:
>>>
>>  openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
>>>
>>  openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>>
>>>  Modified:
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
>>>  URL:
>> http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java?rev=1293457&r1=1293456&r2=1293457&view=diff
>>>
>> ==
>>>  ---
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
>> (original)
>>>  +++
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
>> Fri Feb 24 22:31:49 2012
>>>  @@ -31,7 +31,6 @@ public class InjectionPointBean extends
>>>   {
>>>      private static final WebBeansLogger logger =
>> WebBeansLogger.getLogger(InjectionPointBean.class);
>>>
>>>  -    //X TODO refactor. public static variables are utterly ugly
>>>      private static ThreadLocal>
>> localThreadlocalStack = new ThreadLocal>();
>>>
>>>      private static Stack getStackOfInjectionPoints()
>>>  @@ -80,6 +79,11 @@ public class InjectionPointBean extends
>>>          addApiType(Object.class);
>>>      }
>>>
>>>  +    public static boolean isStackEmpty()
>>>  +    {
>>>  +        return getStackOfInjectionPoints().isEmpty();
>>>  +    }
>>>  +
>>>      @Override
>>>      protected InjectionPoint
>> createInstance(CreationalContext creationalContext)
>>>      {
>>>
>>>  Modified:
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>>  URL:
>> http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java?rev=1293457&r1=1293456&r2=1293457&view=diff
>>>
>> ==
>>>  ---
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>> (original)
>>>  +++
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>> Fri Feb 24 22:31:49 2012
>>>  @@ -62,6 +62,7 @@ import javax.naming.Referenceable;
>>>   import javax.naming.StringRefAddr;
>>>   import org.apache.webbeans.component.AbstractOwbBean;
>>>   import org.apache.webbeans.component.EnterpriseBeanMarker;
>>>  +import org.apache.webbeans.component.InjectionPointBean;
>>>   import org.apache.webbeans.component.InjectionTargetBean;
>>>   import org.apache.webbeans.component.InjectionTargetWrapper;
>>>   import org.apache.webbeans.component.JmsBeanMarker;
>>>  @@ -827,17 +828,34 @@ public class BeanManagerImpl implements
>>>              InjectionResolver.injectionPoints.set(injectionPoint);
>>>         

Re: svn commit: r1293457 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans: component/InjectionPointBean.java container/BeanManagerImpl.java

2012-02-24 Thread Rohit Kelapure
Thank you Mark and Romain for investigating and fixing!!
- Rohit

On Fri, Feb 24, 2012 at 5:31 PM,   wrote:
> Author: struberg
> Date: Fri Feb 24 22:31:49 2012
> New Revision: 1293457
>
> URL: http://svn.apache.org/viewvc?rev=1293457&view=rev
> Log:
> OWB-648 fix TCK
>
> txs to Romain Manni-Bucau for the patch!
>
> Modified:
>    
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
>    
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>
> Modified: 
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
> URL: 
> http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java?rev=1293457&r1=1293456&r2=1293457&view=diff
> ==
> --- 
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
>  (original)
> +++ 
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/InjectionPointBean.java
>  Fri Feb 24 22:31:49 2012
> @@ -31,7 +31,6 @@ public class InjectionPointBean extends
>  {
>     private static final WebBeansLogger logger = 
> WebBeansLogger.getLogger(InjectionPointBean.class);
>
> -    //X TODO refactor. public static variables are utterly ugly
>     private static ThreadLocal> localThreadlocalStack = 
> new ThreadLocal>();
>
>     private static Stack getStackOfInjectionPoints()
> @@ -80,6 +79,11 @@ public class InjectionPointBean extends
>         addApiType(Object.class);
>     }
>
> +    public static boolean isStackEmpty()
> +    {
> +        return getStackOfInjectionPoints().isEmpty();
> +    }
> +
>     @Override
>     protected InjectionPoint createInstance(CreationalContext 
> creationalContext)
>     {
>
> Modified: 
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
> URL: 
> http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java?rev=1293457&r1=1293456&r2=1293457&view=diff
> ==
> --- 
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>  (original)
> +++ 
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>  Fri Feb 24 22:31:49 2012
> @@ -62,6 +62,7 @@ import javax.naming.Referenceable;
>  import javax.naming.StringRefAddr;
>  import org.apache.webbeans.component.AbstractOwbBean;
>  import org.apache.webbeans.component.EnterpriseBeanMarker;
> +import org.apache.webbeans.component.InjectionPointBean;
>  import org.apache.webbeans.component.InjectionTargetBean;
>  import org.apache.webbeans.component.InjectionTargetWrapper;
>  import org.apache.webbeans.component.JmsBeanMarker;
> @@ -827,17 +828,34 @@ public class BeanManagerImpl implements
>             InjectionResolver.injectionPoints.set(injectionPoint);
>         }
>
> -        if(WebBeansUtil.isDependent(injectedBean))
> -        {
> -            //Using owner creational context
> -            //Dependents use parent creational context
> -            instance = getReference(injectedBean, injectionPoint.getType(), 
> ownerCreationalContext);
> +        boolean ijbSet = false;
> +        if (InjectionPointBean.isStackEmpty())
> +        {
> +            ijbSet = true;
> +            InjectionPointBean.setThreadLocal(injectionPoint);
>         }
> -        else
> -        {
> -            //New creational context for normal scoped beans
> -            CreationalContextImpl injectedCreational = 
> (CreationalContextImpl)createCreationalContext(injectedBean);
> -            instance = getReference(injectedBean, injectionPoint.getType(), 
> injectedCreational);
> +
> +        try
> +        {
> +            if(WebBeansUtil.isDependent(injectedBean))
> +            {
> +                //Using owner creational context
> +                //Dependents use parent creational context
> +                instance = getReference(injectedBean, 
> injectionPoint.getType(), ownerCreationalContext);
> +            }
> +            else
> +            {
> +                //New creational context for normal scoped beans
> +                CreationalContextImpl injectedCreational = 
> (CreationalContextImpl)createCreationalContext(injectedBean);
> +                instance = getReference(injectedBean, 
> injectionPoint.getType(), injectedCreational);
> +            }
> +        }
> +        finally
> +        {
> +            if (ijbSet)
> +            {
> +                InjectionPointBean.unsetThreadLocal();
> +            }
>         }
>
>         if(isSetIPForProducers)
>
>


Re: regression on tck

2012-02-20 Thread Rohit Kelapure
This could be due to recent changes made in
https://issues.apache.org/jira/browse/OWB-645
I will investigate and get back.

-Rohit


On Fri, Feb 17, 2012 at 8:30 AM, Romain Manni-Bucau
 wrote:
> Hi,
>
> it seems recent change(s) introduced a regression on TCKs:
>
> Failed tests:
> testGetInjectableReferenceOnBeanManager(org.jboss.jsr299.tck.tests.lookup.injectionpoint.InjectableReferenceTest)
>
> any idea?
>
> - Romain


Re: [VOTE] drop outdated (and unused) openwebbeans-openejb plugin

2011-12-27 Thread Rohit Kelapure
Yes drop it .
[+1]
WebSphere Application Server has its own plugin

On Tue, Dec 27, 2011 at 2:35 PM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:

> +1
>
> regards,
> gerhard
>
>
>
> 2011/12/27 Mark Struberg 
>
> > Hi!
> >
> > I was made aware by David that our openwebbeans-openejb plugin is
> >
> >
> > a.) not needed anymore because the OpenEJB project maintains a much
> deeper
> > integration already
> > b.) It doesn't even compile against the latest trunk anymore, because
> > DeploymentInfo got removed.
> >
> > Thus I hereby ask to drop the openwebbeans-openejb plugin form our SVN
> > repo.
> >
> > Anyone using it?
> >
> >
> >
> > [+1] get rid of it, it is just broken and not used anymore
> >
> > [+0] I don't care
> >
> > [-1] nope I'm using it and it must remain maintained
> >
> >
> > The VOTE is open for 72h with lazy consensus.
> >
> >
> > here is my
> >
> >
> > +1 for dropping it
> >
> >
> > LieGrue,
> > strub
> >
> >
>


Re: [VOTE] Release Apache OpenWebBeans-1.1.1

2011-08-30 Thread Rohit Kelapure
+0

--Thanks,
Rohit

On Tue, Aug 30, 2011 at 8:21 AM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:

> +1
>
> regards,
> gerhard
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
>
> 2011/8/30 Mark Struberg 
>
> > +1
> >
> > tested and reviewed now.
> >
> > LieGrue,
> > strub
> >
> > --- On Mon, 8/29/11, Mark Struberg  wrote:
> >
> > > From: Mark Struberg 
> > > Subject: [VOTE] Release Apache OpenWebBeans-1.1.1
> > > To: dev@openwebbeans.apache.org, u...@openwebbeans.apache.org
> > > Date: Monday, August 29, 2011, 9:16 PM
> > > Hi!
> > >
> > > I'd like to call a VOTE on releasing Apache
> > > OpenWebBeans-1.1.1 .
> > >
> > > This is a bugfix release of OpenWebBeans-1.1.x, thus no
> > > branch has been created.
> > > The ReleaseNotes are available online:
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310844&version=12316311
> > >
> > >
> > > Maven staging repo:
> > >
> >
> https://repository.apache.org/content/repositories/orgapacheopenwebbeans-072/
> > >
> > > SVN source tag (1085208):
> > > https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.1/
> > >
> > > Source release:
> > >
> >
> https://repository.apache.org/content/repositories/orgapacheopenwebbeans-072/org/apache/openwebbeans/openwebbeans/1.1.1/openwebbeans-1.1.1-source-release.zip
> > >
> > > Binary release:
> > >
> >
> https://repository.apache.org/content/repositories/orgapacheopenwebbeans-072/org/apache/openwebbeans/openwebbeans-distribution/1.1.1/openwebbeans-distribution-1.1.1-binary.tar.gz
> > >
> > > PGP release key 2FDB81B1
> > > http://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS
> > >
> > > Vote will be open for 72 hours.
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 veto (and reason why)
> > >
> > >
> > > txs and LieGrue,
> > > strub
> > >
> >
>


Re: OWB performance

2011-07-18 Thread Rohit Kelapure
Thank you. That helped!

On Mon, Jul 18, 2011 at 1:25 PM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:

> hi rohit,
>
> you don't need the demo template for it. just step into the folder
> "internal".
> however, the module has a new id (since v1).
> thx for the info - i've pushed the updated config.
>
> regards,
> gerhard
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
>
> 2011/7/18 Rohit Kelapure 
>
> > Please pardon me for my maven naivette. I ran into the following error
> > while
> > building the benchmark
> >
> > Failed to execute goal on project demo_template: Could not resolve
> > dependencies for project
> > org.apache.extras.myfaces.codi.examples:demo_template:war:1.0.0-SNAPSHOT:
> > Could not find artifact
> >
> >
> org.apache.myfaces.extensions.cdi:myfaces-extcdi-dist-jsf20:jar:1.0.0-SNAPSHOT
> > in apache-snapshot-repository (
> > https://repository.apache.org/content/repositories/snapshots/) -> [Help
> 1]
> >
> > I can't find the 1.0.0-SNAPSHOT  and 1.0.1-SNAPSHOT snapshots for
> >  org.apache.myfaces.extensions.cdi:myfaces-extcdi-dist-jsf20:jar in
> > https://repository.apache.org/content/repositories/snapshots/
> >
> > Should I add some other repository  to the pom.xm.
> > Can you give me some pointers that will help me proceed.
> >
> > --Thanks,
> > Rohit
> >
> >
> > On Sun, Jul 17, 2011 at 11:07 AM, Gerhard Petracek <
> > gerhard.petra...@gmail.com> wrote:
> >
> > > hi @ all,
> > >
> > > the source as well as the jmeter config of the newest benchmarks is
> > > available at [1].
> > >
> > > fyi:
> > > some benchmarks have a special maven profile for the ee config.
> however,
> > > you
> > > can also use the std. owb config. in the resulting war-file you just
> have
> > > to
> > > remove the libs (don't remove the jar-files of codi) and you also have
> to
> > > remove the listener of owb in the web.xml
> > >
> > > (with the settings button, you can configure the number of
> > value-bindings)
> > >
> > > regards,
> > > gerhard
> > >
> > > [1]
> > >
> > >
> >
> http://code.google.com/a/apache-extras.org/p/myfaces-codi-examples/source/browse/#hg%2Finternal%2Fsimple_benchmarks
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> > >
> > > 2011/7/17 Rohit Kelapure 
> > >
> > > > +1. Good work Gerhard!
> > > >
> > > > On Sun, Jul 17, 2011 at 7:47 AM, Mark Struberg 
> > > wrote:
> > > >
> > > > > Hi folks!
> > > > >
> > > > > Recently there have been lot of tweets and rumours about fast EE6
> > > > > application servers. Sadly if they say fast they only speak from
> > > startup
> > > > > performance. Of course it is a big benefit to not have to wait 15
> > > minutes
> > > > > before a server is ready, but that doesn't say anything about how
> > fast
> > > > the
> > > > > server is regarding runtime performance.
> > > > >
> > > > > Yesterday Gerhard posted a nice blog comparing the _runtime_
> > > performance
> > > > of
> > > > > various EE servers - with a clear winner: OWB
> > > > >
> > > > >
> > > >
> > >
> >
> http://os890.blogspot.com/2011/07/benchmark-myfaces-codi-scopes-owb-vs.html
> > > > >
> > > > > And yes, I like to keep it that way ;)
> > > > >
> > > > > LieGrue,
> > > > > strub
> > > > >
> > > >
> > >
> >
>


Re: OWB performance

2011-07-18 Thread Rohit Kelapure
Please pardon me for my maven naivette. I ran into the following error while
building the benchmark

Failed to execute goal on project demo_template: Could not resolve
dependencies for project
org.apache.extras.myfaces.codi.examples:demo_template:war:1.0.0-SNAPSHOT:
Could not find artifact
org.apache.myfaces.extensions.cdi:myfaces-extcdi-dist-jsf20:jar:1.0.0-SNAPSHOT
in apache-snapshot-repository (
https://repository.apache.org/content/repositories/snapshots/) -> [Help 1]

I can't find the 1.0.0-SNAPSHOT  and 1.0.1-SNAPSHOT snapshots for
 org.apache.myfaces.extensions.cdi:myfaces-extcdi-dist-jsf20:jar in
https://repository.apache.org/content/repositories/snapshots/

Should I add some other repository  to the pom.xm.
Can you give me some pointers that will help me proceed.

--Thanks,
Rohit


On Sun, Jul 17, 2011 at 11:07 AM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:

> hi @ all,
>
> the source as well as the jmeter config of the newest benchmarks is
> available at [1].
>
> fyi:
> some benchmarks have a special maven profile for the ee config. however,
> you
> can also use the std. owb config. in the resulting war-file you just have
> to
> remove the libs (don't remove the jar-files of codi) and you also have to
> remove the listener of owb in the web.xml
>
> (with the settings button, you can configure the number of value-bindings)
>
> regards,
> gerhard
>
> [1]
>
> http://code.google.com/a/apache-extras.org/p/myfaces-codi-examples/source/browse/#hg%2Finternal%2Fsimple_benchmarks
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
> 2011/7/17 Rohit Kelapure 
>
> > +1. Good work Gerhard!
> >
> > On Sun, Jul 17, 2011 at 7:47 AM, Mark Struberg 
> wrote:
> >
> > > Hi folks!
> > >
> > > Recently there have been lot of tweets and rumours about fast EE6
> > > application servers. Sadly if they say fast they only speak from
> startup
> > > performance. Of course it is a big benefit to not have to wait 15
> minutes
> > > before a server is ready, but that doesn't say anything about how fast
> > the
> > > server is regarding runtime performance.
> > >
> > > Yesterday Gerhard posted a nice blog comparing the _runtime_
> performance
> > of
> > > various EE servers - with a clear winner: OWB
> > >
> > >
> >
> http://os890.blogspot.com/2011/07/benchmark-myfaces-codi-scopes-owb-vs.html
> > >
> > > And yes, I like to keep it that way ;)
> > >
> > > LieGrue,
> > > strub
> > >
> >
>


Re: OWB performance

2011-07-17 Thread Rohit Kelapure
+1. Good work Gerhard!

On Sun, Jul 17, 2011 at 7:47 AM, Mark Struberg  wrote:

> Hi folks!
>
> Recently there have been lot of tweets and rumours about fast EE6
> application servers. Sadly if they say fast they only speak from startup
> performance. Of course it is a big benefit to not have to wait 15 minutes
> before a server is ready, but that doesn't say anything about how fast the
> server is regarding runtime performance.
>
> Yesterday Gerhard posted a nice blog comparing the _runtime_ performance of
> various EE servers - with a clear winner: OWB
>
> http://os890.blogspot.com/2011/07/benchmark-myfaces-codi-scopes-owb-vs.html
>
> And yes, I like to keep it that way ;)
>
> LieGrue,
> strub
>


Re: OWB performance

2011-07-17 Thread Rohit Kelapure
Gerhard,

Is your benchmark publicly accessible. I would like to run the same for
WebSphere Application Server 8 which includes OWB.

--Thanks,
Rohit Kelapure

On Sun, Jul 17, 2011 at 8:02 AM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:

> hi @ all,
>
> i'll announce some new benchmark results soon. the link posted by mark
> contains benchmark results of some scopes based on a fine grained
> benchmark.
> compared to the previous benchmarks i used jmeter for the new benchmarks
> [1].
>
> regards,
> gerhard
>
> [1]
>
> http://os890.blogspot.com/2011/07/benchmark-myfaces-codi-scopes-weld-vs.html
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
> 2011/7/17 Mark Struberg 
>
> > Hi folks!
> >
> > Recently there have been lot of tweets and rumours about fast EE6
> > application servers. Sadly if they say fast they only speak from startup
> > performance. Of course it is a big benefit to not have to wait 15 minutes
> > before a server is ready, but that doesn't say anything about how fast
> the
> > server is regarding runtime performance.
> >
> > Yesterday Gerhard posted a nice blog comparing the _runtime_ performance
> of
> > various EE servers - with a clear winner: OWB
> >
> >
> http://os890.blogspot.com/2011/07/benchmark-myfaces-codi-scopes-owb-vs.html
> >
> > And yes, I like to keep it that way ;)
> >
> > LieGrue,
> > strub
> >
>


Re: owb logo

2011-04-29 Thread Rohit Kelapure
Very Nice. Thank you Adonis!

On Fri, Apr 29, 2011 at 10:31 AM, Jakob Korherr wrote:

> Really nice work, Adonis!
>
> Regards,
> Jakob
>
> 2011/4/29 Joseph Bergmark :
> > Agreed, they are excellent!
> >
> > Joe
> >
> > On Fri, Apr 29, 2011 at 9:31 AM, Mark Struberg 
> wrote:
> >
> >> wow, they all look great!
> >>
> >> LieGrue,
> >> strub
> >>
> >> --- On Fri, 4/29/11, Gerhard Petracek  wrote:
> >>
> >> > From: Gerhard Petracek 
> >> > Subject: Re: owb logo
> >> > To: dev@openwebbeans.apache.org
> >> > Cc: "Adonis Raduca" 
> >> > Date: Friday, April 29, 2011, 1:26 PM
> >> > hi @ all,
> >> >
> >> > adonis sent me some nice drafts!
> >> > i uploaded them to:
> http://people.apache.org/~gpetracek/owb/logo_drafts/
> >> >
> >> > regards,
> >> > gerhard
> >> >
> >> >
> >> >
> >> > 2011/4/18 Rohit Kelapure 
> >> >
> >> > > Very nice. Thank you Gerhard and Adonis!
> >> > >
> >> > > On Mon, Apr 18, 2011 at 2:59 AM, Gerhard Petracek
> >> > <
> >> > > gerhard.petra...@gmail.com>
> >> > wrote:
> >> > >
> >> > > > i've great news!
> >> > > >
> >> > > > adonis will create a logo for us. he designed the
> >> > whole style of apache
> >> > > > myfaces.
> >> > > > usually he comes up with an awesome draft. so we
> >> > just have to wait some
> >> > > > time
> >> > > > until we can talk about the first draft.
> >> > > >
> >> > > > regards,
> >> > > > gerhard
> >> > > >
> >> > > > http://www.irian.at
> >> > > >
> >> > > > Your JSF powerhouse -
> >> > > > JSF Consulting, Development and
> >> > > > Courses in English and German
> >> > > >
> >> > > > Professional Support for Apache MyFaces
> >> > > >
> >> > > >
> >> > > >
> >> > > > 2011/4/9 Mark Struberg 
> >> > > >
> >> > > > > +1 This is on our list for too long ;) But
> >> > who is going to do it?
> >> > > > >
> >> > > > > LieGrue,
> >> > > > > strub
> >> > > > >
> >> > > > > --- On Sat, 4/9/11, Gerhard Petracek <
> gerhard.petra...@gmail.com>
> >> > > wrote:
> >> > > > >
> >> > > > > > From: Gerhard Petracek 
> >> > > > > > Subject: owb logo
> >> > > > > > To: dev@openwebbeans.apache.org
> >> > > > > > Date: Saturday, April 9, 2011, 6:31 PM
> >> > > > > > hi @ all,
> >> > > > > >
> >> > > > > > what do you think about creating a new
> >> > owb logo?
> >> > > > > >
> >> > > > > > regards,
> >> > > > > > gerhard
> >> > > > > >
> >> > > > > > http://www.irian.at
> >> > > > > >
> >> > > > > > Your JSF powerhouse -
> >> > > > > > JSF Consulting, Development and
> >> > > > > > Courses in English and German
> >> > > > > >
> >> > > > > > Professional Support for Apache
> >> > MyFaces
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
>
>
>
> --
> Jakob Korherr
>
> blog: http://www.jakobk.com
> twitter: http://twitter.com/jakobkorherr
> work: http://www.irian.at
>


Re: owb logo

2011-04-18 Thread Rohit Kelapure
Very nice. Thank you Gerhard and Adonis!

On Mon, Apr 18, 2011 at 2:59 AM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:

> i've great news!
>
> adonis will create a logo for us. he designed the whole style of apache
> myfaces.
> usually he comes up with an awesome draft. so we just have to wait some
> time
> until we can talk about the first draft.
>
> regards,
> gerhard
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
>
> 2011/4/9 Mark Struberg 
>
> > +1 This is on our list for too long ;) But who is going to do it?
> >
> > LieGrue,
> > strub
> >
> > --- On Sat, 4/9/11, Gerhard Petracek  wrote:
> >
> > > From: Gerhard Petracek 
> > > Subject: owb logo
> > > To: dev@openwebbeans.apache.org
> > > Date: Saturday, April 9, 2011, 6:31 PM
> > > hi @ all,
> > >
> > > what do you think about creating a new owb logo?
> > >
> > > regards,
> > > gerhard
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
>


Re: [INFO] Article

2011-03-25 Thread Rohit Kelapure
Mark,

You have to subscribe and click on the  *JAXenter.com is allowed to inform
me about new issues of JAXmag and related offerings of S&S Media* checkbox.
:)

Congrats *Gurkan*!
--Rohit



On Fri, Mar 25, 2011 at 8:53 AM, Mark Struberg  wrote:

> Hi Gurkan!
>
> I could not find the article on jaxcenter.com. Is it already released?
>
> AnywayCongrats Gurkan!
>
> I have attached the entire issue for everyone's reading issue that includes
> the Siwpas issue.
>
> You have to subscribe and click on the  JAXenter.com is allowed to inform
> me about new issues of JAXmag and related offerings of S&S Media checkbox.
>
> --Thanks,
> Rohit, congratulatio to siwpas. Seems to hit the needs of lots of projects
> pretty well.
>
> LieGrue,
> strub
>
> --- On Fri, 3/25/11, Gurkan Erdogdu  wrote:
>
> > From: Gurkan Erdogdu 
> > Subject: [INFO] Article
> > To: dev@openwebbeans.apache.org
> > Date: Friday, March 25, 2011, 7:30 AM
>  > Hi,
> >
> > I have written an article about Siwpas( contains ASF
> > Projects) on
> > http://jaxenter.com/jaxmag/ latest issue, Java EE 6 At
> > A Glance
> >
> > Enjoy!
> >
> > --Gurkan
> >
> >
> >
>
>
>
>


Re: [jira] Resolved: (OWB-507) our samples should be prepared for EE as default

2010-12-20 Thread Rohit Kelapure
I like this change.
This makes it easier to consume OWB samples by other JEE servers.

--Thanks,
Rohit



On Mon, Dec 20, 2010 at 11:14 AM, Mark Struberg (JIRA)  wrote:
>
>     [ 
> https://issues.apache.org/jira/browse/OWB-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
>
> Mark Struberg resolved OWB-507.
> ---
>
>    Resolution: Fixed
>
>> our samples should be prepared for EE as default
>> 
>>
>>                 Key: OWB-507
>>                 URL: https://issues.apache.org/jira/browse/OWB-507
>>             Project: OpenWebBeans
>>          Issue Type: Improvement
>>    Affects Versions: 1.0.0
>>            Reporter: Mark Struberg
>>            Assignee: Mark Struberg
>>             Fix For: 1.1.0
>>
>>
>> We should not pack fully blown standalone tomcat WARs but instead generate 
>> EE WARs per default.
>> This has a few benefits
>> a) we must not _distribute_ a few of our dependencies without further NOTICE 
>> bundling and processing
>> b) our WARs are unnecessarily fat
>> c) our binary distribution is unnecessarily fat
>> Of course, our samples should still be able to generate those results by 
>> using a 'jetty' or 'tomcat' profile. So all I gonna do is to change the 
>> _default_ bundling!
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


Re: [jira] Commented: (OWB-498) Java EE Resource Injections for CDI Interceptors & Decorators

2010-11-25 Thread Rohit Kelapure
Same here. We use the ResouceIjectionService SPI to inject these java ee
resources.

On Thu, Nov 25, 2010 at 5:07 AM, Gurkan Erdogdu (JIRA) wrote:

>
>[
> https://issues.apache.org/jira/browse/OWB-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935708#action_12935708]
>
> Gurkan Erdogdu commented on OWB-498:
> 
>
> We use ResouceIjectionService SPI
>
> > Java EE Resource Injections for CDI Interceptors & Decorators
> > -
> >
> > Key: OWB-498
> > URL: https://issues.apache.org/jira/browse/OWB-498
> > Project: OpenWebBeans
> >  Issue Type: Bug
> >  Components: Core
> >Affects Versions: 1.0.0
> >Reporter: Gurkan Erdogdu
> >Assignee: Gurkan Erdogdu
> > Fix For: 1.1.0, 1.0.1
> >
> >
> > Currently OWB does not inject Java EE resources to CDI interceptors and
> decorators. For example
> > @Resource UserTransaction transaction does not work!
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


Weld memory leak

2010-11-10 Thread Rohit Kelapure
Team,

https://glassfish.dev.java.net/issues/show_bug.cgi?id=12368
Could we have a similar issue with Apache Open Web Beans ?

--Thanks,
Rohit


CDI presentation for Apachecon 2010

2010-11-06 Thread Rohit Kelapure
Dear Users and Committers,

Please see the presentation that I made to Apachecon 2010 on CDI @
http://slidesha.re/bNpooG
http://dl.dropbox.com/u/12872475/CDI.ppt
http://dl.dropbox.com/u/12872475/CDI_apachecon.pdf
Please feel free to modify this presentation and use it in your efforts for
education and evangelism.

--Thank you,
Rohit Kelapure


Re: [ANNOUNCE] Welcome David Jencks as an OpenWebBeans committer

2010-11-04 Thread Rohit Kelapure
Congrats David!

On Thu, Nov 4, 2010 at 8:38 AM, Paul J. Reder  wrote:

> Congratulations David!
>
>
>
>
> On 11/04/2010 06:23 AM, Kevan Miller wrote:
>
>> Great. Congrats David!
>>
>> --kevan
>> On Nov 4, 2010, at 3:02 AM, Mark Struberg wrote:
>>
>>  Hi folks!
>>>
>>> The Apache OpenWebBeans PMC is pleased to announce that David Jencks has
>>> accepted our invitation to join OpenWebBeans as a committer.
>>>
>>> Congratulations and welcome David!
>>>
>>> txs and LieGrue,
>>> the OpenWebBeans PMC
>>>
>>>
>>>
>>>
>>
>>
> --
> Paul J. Reder
> ---
> "The strength of the Constitution lies entirely in the determination of
> each
> citizen to defend it.  Only if every single citizen feels duty bound to do
> his share in this defense are the constitutional rights secure."
> -- Albert Einstein
>
>


Re: OWB Release Lifecycle

2010-10-21 Thread Rohit Kelapure
Does 4 releases mean four major releases  like 1.0.0, 2.0.0, 3.0.0  or minor
ones like 1.1.0, 1.2.0et al

--Thanks,
Rohit



On Thu, Oct 21, 2010 at 9:37 AM, Gurkan Erdogdu wrote:

> Hi;
>
> OpenEJB has been discussing release lifecycle! I think we can also discuss
> it
> for OWB. What do you think about the release cycle for OWB?
>
>
> From my perspective,  - 4 - release in one year is fantastico! But we also
> think
> about maintenance releases!
>
> Thanks;
>
> Gurkan
>
>
>


Re: [VOTE] release Apache OpenWebBeans-1.0.0 2nd try

2010-10-12 Thread Rohit Kelapure
+1

--Thanks,
Rohit Kelapure

On Tue, Oct 12, 2010 at 8:08 AM, Mark Struberg  wrote:
> Hi!
>
> I've re-rolled the release with the fixed readme and now like to call a 2nd 
> VOTE on releasing Apache OpenWebBeans-1.0.0 .
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapacheopenwebbeans-002/
>
> SVN source tag (1021752):
> https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.0.0/
>
> Source release:
> https://repository.apache.org/content/repositories/orgapacheopenwebbeans-002/org/apache/openwebbeans/openwebbeans/1.0.0/openwebbeans-1.0.0-source-release.zip
>
> Binary release:
> https://repository.apache.org/content/repositories/orgapacheopenwebbeans-002/org/apache/openwebbeans/openwebbeans-distribution/1.0.0/openwebbeans-distribution-1.0.0-binary.tar.gz
>
> PGP release key 2FDB81B1 
> http://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS
>
> Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 veto 
> (and reason why)
>
> still valid:
>> A small note: I've created a owb_1.0.x branch which will contain
>> the maintenance work on OWB-1.0.x.
>> Feature development will be performed in trunk which
>> now has a version of 1.1.0-SNAPSHOT
>
> txs and LieGrue,
> strub
>
>
>
>


Re: conversation.getInUsed() and phase listener (was: Re: NPE in InterceptorHandler)

2010-10-05 Thread Rohit Kelapure
Martin,

Checking in a finally block sounds like a good idea.
The only thing I would add is to check if conversation == null before
calling conversation.setInUsed(false);

--Thanks,
Rohit



On Mon, Oct 4, 2010 at 5:16 PM, Martin Koci
 wrote:
> Hi,
>
> I tracked down how conversation can be locked forever. It is simple:
>
> 1) WebBeansPhaseListener.beforePhase (before restoreView): sets inUsed
> to true
>
> 2) JSF lifecycle  throws a exception and servlet container shows http
> 500 error page
>
> 3) WebBeansPhaseListener.afterPhase will be never called to
> setInUse(false)
>
> You can try in with jsf2sample - just put throw new NPE() in
> ConversationData.getNumber()
>
>
> JSF PhaseListener is probably not the safe place for handling such
> locks. JSF cannot guarantee that there will be render response phase as
> reaction to faces request. At least this is true for cases:
> 1) Faces Request generates Non-Faces Response
> (facesContext.responseComplete()) - see "Request Processing Lifecycle"
> in JSF spec
> 2) error page (for example pure JSP based) as reaction to exception
> ( element in web.xml)
> 3) bug in JSF implementation which makes lifecycle crash (for example
> bug in myfaces :) )
>
>
> This needs something more robust, something like finally {} with some
> sort of lock timeout. At first sight
> org.apache.webbeans.jsf.WebBeansJSFFilter looks like the right place. I
> think that servlet container must propagate exception up in filter chain
> and we can put there:
>
> try {
>                chaindoFilter(request, responseWrapper);
>        } finally {
>                conversation.setInUsed(false)
>        }
>
>
> WDYT?
>
>
> Regards,
>
> Kočičák
>
>
>
> Mark Struberg píše v Pá 01. 10. 2010 v 21:51 +:
>> Hi Martin!
>>
>> Please fill a Jira to track this issue!
>> Just in case to keep track of the status.
>>
>> txs and LieGrue,
>> strub
>>
>> --- On Fri, 10/1/10, Martin Koci  wrote:
>>
>> > From: Martin Koci 
>> > Subject: NPE in InterceptorHandler
>> > To: dev@openwebbeans.apache.org
>> > Date: Friday, October 1, 2010, 6:42 PM
>> > Hi,
>> >
>> > I do some stress testing and accidentally this NPE
>> > happens:
>> >
>> > java.lang.NullPointerException
>> > java.util.ArrayList.(ArrayList.java:131)
>> > org.apache.webbeans.intercept.InterceptorHandler.invoke(InterceptorHandler.java:256)
>> > org.apache.webbeans.intercept.NormalScopedBeanInterceptorHandler.invoke(NormalScopedBeanInterceptorHandler.java:98)
>> > com.foo.bazz.Clazz$$_javassist_157.getFoo()
>> > sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>> > Method)
>> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> >
>> >
>> > OWB build-up from trunk two weeks ago, problematic line 256
>> > contains:
>> >
>> > List filteredInterceptorStack = new
>> > ArrayList(this.interceptedMethodMap.get(method));
>> >
>> > Is this something what was fixed recently or should I
>> > create an issue?
>> > I'm rerunning tests with current OWB trunk right now.
>> >
>> >
>> > Other issue is that after this NPE occurs, subsequents
>> > requests obtains
>> > ConversionBusyException - probably some kind of lock is not
>> > released if
>> > lifecycle ends with error.
>> >
>> >
>> > Thanks,
>> >
>> >
>> > Martin Kočí
>> >
>> >
>>
>>
>>
>>
>
>
>


Re: I'm now starting of release process

2010-09-30 Thread Rohit Kelapure
sorry meant logo file .

On Thu, Sep 30, 2010 at 3:01 PM, Rohit Kelapure  wrote:
> Can we update our log file after the first release ?
>
> --Thanks,
> Rohit
>
> On Thu, Sep 30, 2010 at 2:57 PM, Mark Struberg  wrote:
>> Hi folks!
>>
>> I'm starting the preparation for the 1.0.0 release in about 15 minutes.
>>
>> So please abstain from checking in until I'll ping you again.
>>
>> Txs and LieGrue,
>> strub
>>
>>
>>
>>
>


Re: I'm now starting of release process

2010-09-30 Thread Rohit Kelapure
Can we update our log file after the first release ?

--Thanks,
Rohit

On Thu, Sep 30, 2010 at 2:57 PM, Mark Struberg  wrote:
> Hi folks!
>
> I'm starting the preparation for the 1.0.0 release in about 15 minutes.
>
> So please abstain from checking in until I'll ping you again.
>
> Txs and LieGrue,
> strub
>
>
>
>


Re: [jira] Updated: (OWB-462) Refactor AnnotationUtil.hasAnnotationMember()

2010-09-29 Thread Rohit Kelapure
This is an excellent patch.  Thanks Jakob!

We ran into a similar issue discovered by Paul Reder where in
   
org.apache.webbeans.inject.impl.InjectionPointImpl.readObject(ObjectInputStream)

the owner bean filtering
   this.ownerBean = BeanManagerImpl.getManager().getBeans(beanClass,
anns.toArray(new Annotation[0])).iterator().next();

did NOT work.because checkEquality does NOT correctly compare the
owner bean deserialized annotations with the resolvedComponent
qualifiers.

how this patch affects InjectionPointImpl deserialization ...
method hierarchy -->
org.apache.webbeans.util.AnnotationUtil.checkEquality(String, String,
List)
   org.apache.webbeans.util.AnnotationUtil.hasAnnotationMember(Class, Annotation, Annotation)
   
org.apache.webbeans.container.InjectionResolver.findByQualifier(Set>,
Annotation...)
  
org.apache.webbeans.container.InjectionResolver.implResolveByType(Type,
Annotation...)
   org.apache.webbeans.container.BeanManagerImpl.getBeans(Type,
Annotation...)

org.apache.webbeans.inject.impl.InjectionPointImpl.readObject(ObjectInputStream)


--Thanks,
Rohit Kelapure

On Tue, Sep 28, 2010 at 5:24 PM, Jakob Korherr (JIRA)  wrote:
>
>     [ 
> https://issues.apache.org/jira/browse/OWB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
>
> Jakob Korherr updated OWB-462:
> --
>
>    Attachment: OWB-462.patch
>
> The patch contains the refactored code and some test cases.
>
>> Refactor AnnotationUtil.hasAnnotationMember()
>> -
>>
>>                 Key: OWB-462
>>                 URL: https://issues.apache.org/jira/browse/OWB-462
>>             Project: OpenWebBeans
>>          Issue Type: Task
>>          Components: Core
>>    Affects Versions: 1.0.0-alpha-2
>>            Reporter: Jakob Korherr
>>            Assignee: Gurkan Erdogdu
>>         Attachments: OWB-462.patch
>>
>>
>> We needed a method to compare qualifiers for MyFaces CODI and stumbled upon 
>> AnnotationUtil.hasAnnotationMember().
>> However this method is really messy, because it uses the String 
>> representation of an annotation to compare it and thus fails in various 
>> cases (e.g. when using annotation instances which implement toString() 
>> differently or by using array values in the qualifier). Furthermore it does 
>> not detect @Nonbinding fields correctly, if there is more than one 
>> annotation on the annotation-method.
>> Also it's kinda weird that the method takes the Annotation-Class as an extra 
>> parameter, but it could just get it from one of the Annotation instances. I 
>> checked all usages and found out that this argument can be dropped. In 
>> addition I think it's better to rename the method to isQualifierEqual() - 
>> the usage is just a lot clearer.
>> I implemented a custom solution for MyFaces CODI and I think it should also 
>> be applied here.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


Javaone 2010 CDI presentations

2010-09-28 Thread Rohit Kelapure
Team,

You will be interested in  JSR-299 (CDI), Weld & the Future of Seam
presentation:
http://www.slideshare.net/mojavelinux/jsr299-cdi-weld-the-future-of-seam-javaone-2010

Also see
http://blogs.sun.com/alexismp/entry/javaone_2010_java_ee_6

--Thanks,
Rohit


Re: [DISCUSS] releasing owb-1.0.0-alpha-3

2010-09-28 Thread Rohit Kelapure
I have looked into OWB-444.  The changes looked invasive, touching a
lot of files.
A list of  *ALL* the the utility classes that are mentioned in the
defect will certainly help.

Another thing that is confusing is that the defect has been opened for
two separate issues
- Remove static loggers in Shared classloader
- Remove BeanManagerImp.getManager()  lookups.

We could open another JIRA issue for the BeanManagerImp.getManager()
lookup reduction.

--just my 2 cents, Cheers,
Rohit


On Tue, Sep 28, 2010 at 6:38 AM, Gerhard  wrote:
> hello,
>
> basically i would vote +1.
> however, as mentioned earlier it would be great if we finish OWB-444 before
> the release of v1.
>
> regards,
> gerhard
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
>
> 2010/9/28 Mark Struberg 
>
>> cool thanks!
>>
>> I'll commit a few pom changes and fix our ugly site today ;)
>>
>>
>> LieGrue,
>> strub
>>
>> --- On Tue, 9/28/10, Eric Covener  wrote:
>>
>> > From: Eric Covener 
>> > Subject: Re: [DISCUSS] releasing owb-1.0.0-alpha-3
>> > To: dev@openwebbeans.apache.org
>> > Date: Tuesday, September 28, 2010, 9:43 AM
>> > FYI trying to get OWB-456 in today
>> > before tag
>> >
>>
>>
>>
>>
>


Re: [jira] Created: (OWB-457) we must not create a SessionContext for static resource reqeusts

2010-09-22 Thread Rohit Kelapure
An application could specify these exclude paths or mime types as
context parameters in the web.xml

  
OWB_SESSION_CONTEXT_EXCLUDE_PATH
/openBooks/static/images/
  

  
OWB_SESSION_CONTEXT_EXCLUDE_MIME_TYPE
*.jpeg, *.gif 
  

OWB could pull this out in
WebBeansConfigurationListener.requestInitialized(ServletRequestEvent)
- 
event.getServletContext().getInitParameter("OWB_SESSION_CONTEXT_EXCLUDE_MIME_TYPE");
- 
event.getServletContext().getInitParameter("OWB_SESSION_CONTEXT_EXCLUDE_PATH");

& compare with
- httpRequest.getContentType()
- httpRequest.getPathInfo(), httpRequest.getContextPath()


and NOT create the session context when the path/mime-type in the
request matches the param values defined in the web.xml

Does this proposal sound reasonable ?

--Thanks,
Rohit


On Wed, Sep 22, 2010 at 10:55 AM, Mark Struberg (JIRA)  wrote:
>
> we must not create a SessionContext for static resource reqeusts
> 
>
>                 Key: OWB-457
>                 URL: https://issues.apache.org/jira/browse/OWB-457
>             Project: OpenWebBeans
>          Issue Type: Bug
>            Reporter: Mark Struberg
>            Assignee: Gurkan Erdogdu
>
>
> we currently trigger the creation of a new session in 
> WebBeansConfigurationListener#requestInitialized.
>
> This leads to unnecessarily creating tons of SessionContexts if a static 
> resource like an image gets requested.
>
> We should seek a way to either configurably exclude paths from this mechanism 
> or to only create the SessionContext if a SessionContext gets requested 
> inside the BeanManager
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>


Re: Please reopen OWB-318, patch attached

2010-09-09 Thread Rohit Kelapure
Done. Attached to JIRA. Attaching here as well.

--Thanks,
Rohit


On Thu, Sep 9, 2010 at 4:40 PM, Eric Covener  wrote:

> > After applying the attached patch (owb-318-patch.diff) this TCK test
> passes
> > successfully.
>
> reopened, but didn't see an email attachment. Can you attach it to OWB-318?
>
> https://issues.apache.org/jira/browse/OWB-318
>
>
> --
> Eric Covener
> cove...@gmail.com
>


Please reopen OWB-318, patch attached

2010-09-09 Thread Rohit Kelapure
Dear Apache Open WebBeans Committers,

We need to reopen JIRA issue
OWB-318<https://issues.apache.org/jira/browse/OWB-318>
opened for multiple methods with same EJB @interceptors(foo.class) in same
bean class get multiple interceptor instances.
When I run this TCK test
(org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest)
on a very recent OWB code revision 995059 from the trunk I see that the
testInterceptorCanBeAppliedToMoreThanOneMethod is  failing like so...
java.lang.AssertionError at
org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testInterceptorCanBeAppliedToMoreThanOneMethod(MethodLevelInterceptorTest.java:45)


After applying the attached patch (owb-318-patch.diff) this TCK test passes
successfully.
[Invoker 1452037772] Invoking @AfterClass
org.jboss.testharness.AbstractTest.afterClass()
*** INVOKED METHODS
org.jboss.testharness.AbstractTest.beforeClass() 1015168130
org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testExcludeClassInterceptors()
1015168130
org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testInterceptorCanBeAppliedToMoreThanOneMethod()
1015168130
org.jboss.testharness.AbstractTest.afterClass() 1015168130
***
Creating
C:\eclipse3.5\owb-cdi\openwebbeans\webbeans-tck\test-output\openwebbeans-tck\org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.html
Creating
C:\eclipse3.5\owb-cdi\openwebbeans\webbeans-tck\test-output\openwebbeans-tck\org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.xml
PASSED: testExcludeClassInterceptors
PASSED: testInterceptorCanBeAppliedToMoreThanOneMethod

If you are agree to the changes, can you please commit the patch to the svn
trunk.

*Can someone tell me why this TCK test does not get run with our standalone
and web suite,*

--Thank You,
Rohit Kelapure


Re: CIA bot on #openwebbeans?

2010-07-25 Thread Rohit Kelapure
+1

On Sun, Jul 25, 2010 at 1:28 PM, Eric Covener  wrote:
> How do people feel / who do we ask to turn on a CIA bot for commit
> messages in #openwebbeans?
>
> I am personally +1
>
> --
> Eric Covener
> cove...@gmail.com
>


Re: svn commit: r960716 - in /openwebbeans/trunk/distribution: pom.xml src/assembly/dist-all.xml src/assembly/dist-binary.xml src/assembly/dist-sources.xml

2010-07-12 Thread Rohit Kelapure
Mark,

I don't understand why you had to delete dist-all.xml or dist-sources.xml.

Could we not have kept these descriptors around and called the
relevant lifecycle/phase/goal like so
mvn assembly:assembly -Ddescriptor=distribution/src/assembly/dist-sources.xml
mvn assembly:assembly -Ddescriptor=distribution/src/assembly/dist-binary.xml

---Thanks,
Rohit Kelapure

On Mon, Jul 5, 2010 at 5:56 PM,  wrote:
>
> Author: struberg
> Date: Mon Jul  5 21:56:21 2010
> New Revision: 960716
>
> URL: http://svn.apache.org/viewvc?rev=960716&view=rev
> Log:
> release preparation: only build binary release with our distribution project
>
> Removed:
>    openwebbeans/trunk/distribution/src/assembly/dist-all.xml
>    openwebbeans/trunk/distribution/src/assembly/dist-sources.xml
> Modified:
>    openwebbeans/trunk/distribution/pom.xml
>    openwebbeans/trunk/distribution/src/assembly/dist-binary.xml
>
> Modified: openwebbeans/trunk/distribution/pom.xml
> URL: 
> http://svn.apache.org/viewvc/openwebbeans/trunk/distribution/pom.xml?rev=960716&r1=960715&r2=960716&view=diff
> ==
> --- openwebbeans/trunk/distribution/pom.xml (original)
> +++ openwebbeans/trunk/distribution/pom.xml Mon Jul  5 21:56:21 2010
> @@ -27,11 +27,10 @@
>         openwebbeans
>         1.0.0-SNAPSHOT
>         ../pom.xml
> -        ../pom.xml
>     
>
>     org.apache.openwebbeans
> -    apache-openwebbeans
> +    openwebbeans-distribution
>     pom
>
>     OpenWebBeans :: Distribution
> @@ -42,51 +41,54 @@
>         true
>     
>
> -    
> -        
> -            
> -                org.apache.maven.plugins
> -                maven-assembly-plugin
> -                2.2-beta-2
> -                
> -                    gnu
> -                    
> -                        
> -                        
> src/assembly/dist-sources.xml
> -                        src/assembly/dist-binary.xml
> -                    
> -                
> -                
> -                    
> -                        package
> -                        
> -                            single
> -                        
> -                    
> -                
> -            
> -            
> -                org.apache.maven.plugins
> -                maven-install-plugin
> -                
> -                    true
> -                
> -            
> -            
> -                org.apache.maven.plugins
> -                maven-gpg-plugin
> -                
> -                    
> -                        sign-artifacts
> -                        verify
> -                        
> -                            sign
> -                        
> -                    
> -                
> -            
> -        
> -    
> +    
> +        
> +            apache-release
> +            
> +                
> +                    
> +                        org.apache.maven.plugins
> +                        maven-assembly-plugin
> +                        2.2-beta-5
> +                        
> +                            gnu
> +                            
> +                                
> src/assembly/dist-binary.xml
> +                            
> +                        
> +                        
> +                            
> +                                package
> +                                
> +                                    single
> +                                
> +                            
> +                        
> +                    
> +                    
> +                        org.apache.maven.plugins
> +                        maven-install-plugin
> +                        
> +                            true
> +                        
> +                    
> +                    
> +                        org.apache.maven.plugins
> +                        maven-gpg-plugin
> +                        
> +                            
> +                                sign-artifacts
> +                                verify
> +                                
> +                                    sign
> +                                
> +                            
> +                        
> +                    
> +                
> +            
> +        
> +    
>
>     

Re: Call for Participation: Technical Talks -- ApacheCon North America 2010

2010-06-03 Thread Rohit Kelapure
Gurkan,

Yes we have had a lot of success integrating OWB in our application Server.
We have injection of EE resources in CDI beans and injection of CDI beans
into EE resources working successfully.
We have implemented our own Scanner to scan bean classes based on the
application classpath. We have  JSR299 interception and decoration working
with older EJB style interceptors.

In some cases, we overlay/replace the open source files with our version
because the open source version does not have enough logging or does thing
differently. We have also run into other challenges and hurdles with
classloading which I will articulate properly in a separate email. We intend
to open JIRA issues to fix all the issues discovered.

Eventually once the integrarion is complete, we intend to contribute towards
to a user guide explaining OpenWebBeans integration with other application
servers and containers.

--Thanks,
Rohit Kelapure


On Sat, May 29, 2010 at 2:02 AM, Gurkan Erdogdu wrote:

> Hi;
>
> Fantastico and very good news Rohit! In the mean time, did you able to
> integrate OWB in your environment successfully?
>
>
> Thanks;
>
> --Gurkan
>
>
> ____
> From: Rohit Kelapure 
> To: dev@openwebbeans.apache.org
> Sent: Fri, May 28, 2010 2:58:21 AM
> Subject: Re: Call for Participation: Technical Talks -- ApacheCon North
>  America 2010
>
> Team,
>
> I have submitted  an abstract on "Getting started with Java Contexts and
> Dependency Injection in JEE6 using OpenWebBeans" to apachecon 2010.
>
> --Thanks,
> Rohit
>
> On Sun, May 2, 2010 at 11:44 AM, Gurkan Erdogdu  >wrote:
>
> > Hello Eric;
> >
> >
> > I really would like to be there this time, maybe I could present some
> topic
> > on OWB.
> >
> >
> > Thanks;
> >
> > --Gurkan
> >
> >
> > 
> > From: Eric Covener 
> > To: dev@openwebbeans.apache.org
> > Sent: Fri, April 30, 2010 9:47:50 PM
> > Subject: Re: Call for Participation: Technical Talks -- ApacheCon North
> >  America 2010
> >
> > On Fri, Apr 30, 2010 at 2:46 PM, Kevan Miller 
> > wrote:
> > > FYI. Forwarding the ApacheCon CFP from annou...@apachecon.com
> >
> > Any CDI folks plan to attend in Atlanta?
> >
> >
> > --
> > Eric Covener
> > cove...@gmail.com
> >
> >
> >
>
>
>


Re: preparation for 1.0.0 release

2010-06-03 Thread Rohit Kelapure
Team,

I would like to add that if possible we need to add the following to make
OpenWebBeans consumable by users of OpenWebBeans

- Quick Start Guide & Samples
   --  How to get a sample JCDI application running in an OpenWebBeans
integrated application server.
   --  How to build and run these samples with OpenWebBeans.

--Tutorial on Using OpenWebBeans
  -- Something like
http://openjpa.apache.org/begin-using-openjpa-the-basics.html


--Thanks,
Rohit Kelapure


On Wed, Jun 2, 2010 at 7:48 AM, Mark Struberg  wrote:

> Hi folks!
>
> I'd like to kick off preparations for a 1.0.0 release of OWB.
>
> I've already found the following parts which I will fix this weekend
>
>
> 1.) fix our site. There are a few dead links (e.g. a few FAQ links - txs to
> aslak for reporting this)
>
> 2.) fix our ASL headers
>
> 3.) enable checkstyle reporting. I'd like to get rid of all the tabs in our
> sources again ...
>
> I'll create JIRAs for those items.
>
> Please feel free to continue this list and report other things you like to
> see fixed before releasing a 1.0.0.
>
> txs and LieGrue,
> strub
>
>
>
>


Re: Call for Participation: Technical Talks -- ApacheCon North America 2010

2010-05-27 Thread Rohit Kelapure
Team,

I have submitted  an abstract on "Getting started with Java Contexts and
Dependency Injection in JEE6 using OpenWebBeans" to apachecon 2010.

--Thanks,
Rohit

On Sun, May 2, 2010 at 11:44 AM, Gurkan Erdogdu wrote:

> Hello Eric;
>
>
> I really would like to be there this time, maybe I could present some topic
> on OWB.
>
>
> Thanks;
>
> --Gurkan
>
>
> 
> From: Eric Covener 
> To: dev@openwebbeans.apache.org
> Sent: Fri, April 30, 2010 9:47:50 PM
> Subject: Re: Call for Participation: Technical Talks -- ApacheCon North
>  America 2010
>
> On Fri, Apr 30, 2010 at 2:46 PM, Kevan Miller 
> wrote:
> > FYI. Forwarding the ApacheCon CFP from annou...@apachecon.com
>
> Any CDI folks plan to attend in Atlanta?
>
>
> --
> Eric Covener
> cove...@gmail.com
>
>
>


Re: About TCK

2010-05-03 Thread Rohit Kelapure
Gurkan,

Congrats!

We would like to run the TCK on our EE container as well. Can you give us
some hints on setting up and running the TCK.

--Thanks,
Rohit


On Mon, May 3, 2010 at 12:22 PM, Gurkan Erdogdu wrote:

> Hello folks,
>
> Finally I have achieved passing of standalone TCK and Java Web profile TCK
> on Tomcat :). I have run the CDI-TCK 1.0.2-SNAPSHOT version that resolves
> some bugs. I have also issued some new bugs for CDI-TCK.
>
> On Tomcat, I have excluded on WebService End point injection test.
>
>
> Enjoy!
>
> --Gurkan
>
>
>


Re: EE-Integration Question: How does one do CDI injection on Java EE component classes ?

2010-04-13 Thread Rohit Kelapure
Perfect ! Will dig into OWBInjector !

On Tue, Apr 13, 2010 at 3:40 PM, Gurkan Erdogdu wrote:

> Hi Rohit;
>
> I did it for Apache Tomcat integration for injecting CDI Beans into
> Servlets/Filters/Tag Libraries. I use OWBInjector class. You could look at
> org.apache.webbeans.web.tomcat.TomcatInstanceListener, TomcatAnnotProcessor
> in tomcat6 module.
>
> OWBInjector is a generic class not related with EJB. It takes Java EE
> components instance and inject CDI beans into it.
>
> Thanks;
>
> --Gurkan
>
>
>
>
> ____
> From: Rohit Kelapure 
> To: dev@openwebbeans.apache.org
> Sent: Tue, April 13, 2010 7:49:53 PM
> Subject: Re: EE-Integration Question: How does one do CDI injection on Java
> EE  component classes ?
>
> Gurkan,
>
> This will work with EJBs.  How does a container provide injection of
> CDI beans into other EE types say JAX-WS Web Services or HTTPServlets
> ?
>
> Does OpenWebBeans expose an extension point for EE containers to
> plugin their own injection service  for injection of CDI managed beans
> into EE types.
> The mirror image of ResourceInjectionService ?
>
> --Thanks,
> Rohit Kelapure
>
>
> On Mon, Apr 12, 2010 at 10:25 AM, Gurkan Erdogdu
>  wrote:
> > Hello Rohit;
> >
> > Could you look at the OWBInjector utility class? This is responsible for
> > injecting into EE components instances.
> >
> > When EE container destroys EE component, you will also destroy creational
> > contexts via OWBInjector.
> >
> > OWBInjector injector = new OWBInjector();
> > injector.inject(instance, creational);
> > injector.release(); //on ee component destroying
> >
> > For EJB case, I have updated OpenWebBeansEJBInterceptor. Please look at
> it.
> > Basically, you will add it to every EJB Beans that is contained in JSR299
> > module.
> >
> > Thanks;
> >
> > --Gurkan
> >
> > 2010/4/12 Rohit Kelapure 
> >
> >> Team,
> >>
> >> OpenWebBeans provides the ResourceInjectionService API  for injection
> >> of Java EE injectable resources into CDI managed beans.  This works
> >> well and we have integrated the ResourceInjectionService API in our EE
> >> container.
> >>
> >> We need guidance on how OWB handles CDI managed bean injection  into
> >> EE components.
> >>
> >> Are we to follow the WELD approach of achieving this through the CDI
> >> defined InjectionTarget SPI. Should an EE container extend/compose the
> >> BeanManager and expose a fireProcessInjectionTarget(Class) utility
> >> method ? How does this integrate with the OpenWebBeansEjbPlugin. ?
> >>
> >> I am looking for a high level overview of how this will work in OWB
> >> and the code that currently supports this feature and what is yet to
> >> be written ?
> >>
> >> --Thanks,
> >> Rohit Kelapure
> >>
> >
> >
> >
> > --
> > Gurkan Erdogdu
> > http://gurkanerdogdu.blogspot.com
> >
>
>
>
>   ___
> Yahoo! Türkiye açıldı!  http://yahoo.com.tr
> İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
>


Re: EE-Integration Question: How does one do CDI injection on Java EE component classes ?

2010-04-13 Thread Rohit Kelapure
Gurkan,

This will work with EJBs.  How does a container provide injection of
CDI beans into other EE types say JAX-WS Web Services or HTTPServlets
?

Does OpenWebBeans expose an extension point for EE containers to
plugin their own injection service  for injection of CDI managed beans
into EE types.
The mirror image of ResourceInjectionService ?

--Thanks,
Rohit Kelapure


On Mon, Apr 12, 2010 at 10:25 AM, Gurkan Erdogdu
 wrote:
> Hello Rohit;
>
> Could you look at the OWBInjector utility class? This is responsible for
> injecting into EE components instances.
>
> When EE container destroys EE component, you will also destroy creational
> contexts via OWBInjector.
>
> OWBInjector injector = new OWBInjector();
> injector.inject(instance, creational);
> injector.release(); //on ee component destroying
>
> For EJB case, I have updated OpenWebBeansEJBInterceptor. Please look at it.
> Basically, you will add it to every EJB Beans that is contained in JSR299
> module.
>
> Thanks;
>
> --Gurkan
>
> 2010/4/12 Rohit Kelapure 
>
>> Team,
>>
>> OpenWebBeans provides the ResourceInjectionService API  for injection
>> of Java EE injectable resources into CDI managed beans.  This works
>> well and we have integrated the ResourceInjectionService API in our EE
>> container.
>>
>> We need guidance on how OWB handles CDI managed bean injection  into
>> EE components.
>>
>> Are we to follow the WELD approach of achieving this through the CDI
>> defined InjectionTarget SPI. Should an EE container extend/compose the
>> BeanManager and expose a fireProcessInjectionTarget(Class) utility
>> method ? How does this integrate with the OpenWebBeansEjbPlugin. ?
>>
>> I am looking for a high level overview of how this will work in OWB
>> and the code that currently supports this feature and what is yet to
>> be written ?
>>
>> --Thanks,
>> Rohit Kelapure
>>
>
>
>
> --
> Gurkan Erdogdu
> http://gurkanerdogdu.blogspot.com
>


EE-Integration Question: How does one do CDI injection on Java EE component classes ?

2010-04-12 Thread Rohit Kelapure
Team,

OpenWebBeans provides the ResourceInjectionService API  for injection
of Java EE injectable resources into CDI managed beans.  This works
well and we have integrated the ResourceInjectionService API in our EE
container.

We need guidance on how OWB handles CDI managed bean injection  into
EE components.

Are we to follow the WELD approach of achieving this through the CDI
defined InjectionTarget SPI. Should an EE container extend/compose the
BeanManager and expose a fireProcessInjectionTarget(Class) utility
method ? How does this integrate with the OpenWebBeansEjbPlugin. ?

I am looking for a high level overview of how this will work in OWB
and the code that currently supports this feature and what is yet to
be written ?

--Thanks,
Rohit Kelapure


JSR-299 based interceptors and decorators are not supported for EJB Beans

2010-03-17 Thread Rohit Kelapure
Currently the InterceptorHandler javadoc states that OWB delegates
calling of "EJB Beans" interceptors to the EJB container. It does not
provide built-in interceptor and decorator support for EJB beans.
 i.e. if an EJB bean has JSR299 interceptors and decorators, they will
not be called.

How would I go about adding this support to OWB ? I would like to
provide a hook point for other EE containers to call into the OWB
interceptor and decorator processing after they have finished
processing the EJB 3.0 interceptors on the EJB bean

I expect we will need to create some sort of a
DelegatingInterceptorInvocationContext to call the JSR299 interceptor
bindings and decorators.

Any thoughts ?

--Thanks,
Rohit


Questions on OpenWebBeansEjbPlugin and OWB-EJB integration

2010-03-16 Thread Rohit Kelapure
I am integrating OWB into a Java EE EJB container and need more information
on the role of the
Session bean proxy returned by  OpenWebBeansEjbPlugin in
public Object getSessionBeanProxy(Bean bean, Class iface,
CreationalContext creationalContext);

The openejb code defines a EjbBeanProxy method handler that calls
OpenWebBeansEjbInterceptor.setThreadLocal(...)
and OpenWebBeansEjbInterceptor.unsetThreadLocal() before an after the method
invoke.
Is this code pattern specific to openejb or are other java ee containers are
also expected to do the same in their EjbBeanProxyHandlers ?

Will OWB ejb integration work with other EE containers if
BeansDeployer.discoverEjb is set to false ?

>From looking at the code the only integration point of OWB with an
EJBContainer is the OpenWebBeansEjbPlugin ?

Does a Java EE container need to extend
org.apache.webbeans.ejb.common.component.BaseEjbBean
?

--Thanks,
Rohit Kelapure