[jira] [Resolved] (QPID-4759) qpidd --help should show sasl config path default

[michael goulish (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

michael goulish resolved QPID-4759.
---

Resolution: Fixed

fixed in rev 1477435.

> qpidd --help should show sasl config path default
> -
>
> Key: QPID-4759
> URL: https://issues.apache.org/jira/browse/QPID-4759
> Project: Qpid
>  Issue Type: Bug
>Reporter: michael goulish
>Assignee: michael goulish
> Fix For: 0.22
>
>
> --help output does not show the sasl config path default, which the Cyrus 
> SASL library sets as "/etc/sasl2"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Request for inclusion into 0.22 - cmake-uninstall file not in -cpp source tarball

[Gordon Sim]

On 04/18/2013 02:32 PM, Justin Ross wrote:

On Thu, Apr 11, 2013 at 9:45 AM, Chuck Rolke  wrote:

I think we ought to go ahead with the inclusion based on, as Steve says, our 
push to cmake.


I'm afraid I disagree.  That was our goal, but we missed.  The absence
of the uninstall target can't be considered a critical problem.
Rejected for 0.22.


I think it may be worse than simply the uninstall target not working. It 
looks to me like an autotools based source release can't be built with 
cmake... of course it may be something specific to me.



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4339) flow to disk replacement

[Gordon Sim (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644912#comment-13644912
 ] 

Gordon Sim commented on QPID-4339:
--

Committed patch as http://svn.apache.org/r1477236

> flow to disk replacement
> 
>
> Key: QPID-4339
> URL: https://issues.apache.org/jira/browse/QPID-4339
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.19
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.23
>
>
> QPID-4178 removed the flow-to-disk 'feature' from the broker. It should be 
> replaced by a more effective solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4403) C++ Broker Timer warnings are still too verbose and frequent

[Chuck Rolke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved QPID-4403.
---

   Resolution: Fixed
Fix Version/s: 0.20

Fixed in Committed revision 1405316.
http://svn.apache.org/viewvc?view=revision&revision=1405316

> C++ Broker Timer warnings are still too verbose and frequent
> 
>
> Key: QPID-4403
> URL: https://issues.apache.org/jira/browse/QPID-4403
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Broker
>Affects Versions: 0.18
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
> Fix For: 0.20
>
>
> Continuing issue QPID-3476.
> 1) Further reducing the timer warning message log level.
> Between 0.12 and 0.13 timer warning messages were demoted from warning to 
> informational log levels. In 0.19 the external store produces overrun info 
> messages every time leading to log file bloat.
> The proposal here is to demote the information statements to debug statements 
> for the same reasons that they were demoted from warnings:
> "Demoting the warnings to debug statements would avoid undue alarm and 
> prevent excess noise in log files. Should there be a need to see the 
> information it is a lot easier to enable it (--log-enable debug+:Timer) than 
> it is to turn it off at present."
> 2) Increasing the timer warning interval.
> Another consideration is to change the hard-coded five second warning 
> interval to something longer. I suggest that one minute would be a good 
> choice. The timer warning code already accumulates the number of warnings for 
> the warning interval to prevent a flood of warnings. Increasing the warning 
> interval further reduces the flood.
> 3) Performance improvement.
> When Issue 3476 was patched from warning to info there was a corresponding 
> QPID_LOG_TEST in Timer.cpp that was not patched. This causes the late and 
> overrun calculations to run even though the results will never be logged.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4672) C++ Broker deadlock detaching XmlExchange sessions

[Chuck Rolke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved QPID-4672.
---

   Resolution: Fixed
Fix Version/s: 0.22

Fixed and back ported to 0.22

> C++ Broker deadlock detaching XmlExchange sessions
> --
>
> Key: QPID-4672
> URL: https://issues.apache.org/jira/browse/QPID-4672
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.20
> Environment: C++ Broker, autotools build, make check or 
> run_federation_tests
>Reporter: Chuck Rolke
>Priority: Critical
> Fix For: 0.22
>
>
> Self test federation.FederationTests.test_dynamic_topic locks up. Pstack 
> shows three threads with the same trace:
> #0  pthread_rwlock_wrlock ()
> #1  qpid::broker::XmlExchange::unbind()
> #2  qpid::broker::XmlExchange::fedUnbind()
> #3  qpid::broker::XmlExchange::bind()
> #4  qpid::broker::Queue::bind()
> #5  qpid::broker::Broker::bind()
> #6  qpid::broker::SemanticState::unbindSessionBindings()
> #7  qpid::broker::SemanticState::closed()
> #8  qpid::broker::SessionState::~SessionState()
> #9  qpid::broker::SessionState::~SessionState()
> #10 qpid::broker::SessionHandler::handleDetach()
> #11 qpid::amqp_0_10::SessionHandler::detach()
> The lock occurs because there are two simultaneous session detach calls going 
> on. Each takes out the Rlock and then tries to take out the Wlock. Neither 
> will get the Wlock until everyone else releases their Rlock. Subsequent 
> detach calls fall into the same catch as they get the Rlock but not the Wlock.
> This condition is present in both the XmlExchange and DirectExchange. I'll 
> have a patch for review shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4720) C++ Broker Headers exchange match comparison self tests use stale comparison code

[Chuck Rolke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke updated QPID-4720:
--

Summary: C++ Broker Headers exchange match comparison self tests use stale 
comparison code  (was: C++ Broker Headers exchange match comparison issue with 
value types)

> C++ Broker Headers exchange match comparison self tests use stale comparison 
> code
> -
>
> Key: QPID-4720
> URL: https://issues.apache.org/jira/browse/QPID-4720
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.20
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
> Fix For: 0.23
>
>
> Steps to Reproduce:
> 1. Use the old Python client API and do this:
> session.exchange_bind(exchange="MyHeadersExchange", queue="MyQueue", 
> arguments={"x-match":"all", "MyHeader":1})
> 2. Use the new C++ messaging API to send a message like this:
> Message msg(;
> msg.getProperties()["MyHeader"] = boost::uint16_t(1);
> 3. Use qpid-stat to see if the exchange routed the message to the queue, or 
> if it was dropped.  In this case, it will be incorrectly dropped.
>   
> Actual results: Message is dropped
> Expected results: Message is delivered into queue MyQueue
> Additional info: It looks like the binding generated via Python is a match on 
> the value 1L.  If we create a C++ client to set up the binding, it creates a 
> match based on 1.  It looks like the headers exchange thinks that 1 (2-bytes) 
> isn't the same as 1L (4-bytes).
> --
> Headers exchange looks at the value type and sees that they are different and 
> so does not compare the value data.
> I'm comfortable saying that the comparison is based on the header entry's 
> type and data value. If the types don't match then the comparison fails. This 
> is how the code works now.
> To match "comparable" data types then the match must cover [int uint]_[8 16 
> 32 64], and possibly float and double. Even a string data type could be 
> matched "1", "0x1", and so on. This could be an awful lot of development 
> effort and testing.
> What is the correct behavior?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4720) C++ Broker Headers exchange match comparison issue with value types

[Chuck Rolke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved QPID-4720.
---

   Resolution: Fixed
Fix Version/s: 0.23

Fixed at Committed revision 1477317.

Bug with comparing float types tracked in QPID-4740.

> C++ Broker Headers exchange match comparison issue with value types
> ---
>
> Key: QPID-4720
> URL: https://issues.apache.org/jira/browse/QPID-4720
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.20
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
> Fix For: 0.23
>
>
> Steps to Reproduce:
> 1. Use the old Python client API and do this:
> session.exchange_bind(exchange="MyHeadersExchange", queue="MyQueue", 
> arguments={"x-match":"all", "MyHeader":1})
> 2. Use the new C++ messaging API to send a message like this:
> Message msg(;
> msg.getProperties()["MyHeader"] = boost::uint16_t(1);
> 3. Use qpid-stat to see if the exchange routed the message to the queue, or 
> if it was dropped.  In this case, it will be incorrectly dropped.
>   
> Actual results: Message is dropped
> Expected results: Message is delivered into queue MyQueue
> Additional info: It looks like the binding generated via Python is a match on 
> the value 1L.  If we create a C++ client to set up the binding, it creates a 
> match based on 1.  It looks like the headers exchange thinks that 1 (2-bytes) 
> isn't the same as 1L (4-bytes).
> --
> Headers exchange looks at the value type and sees that they are different and 
> so does not compare the value data.
> I'm comfortable saying that the comparison is based on the header entry's 
> type and data value. If the types don't match then the comparison fails. This 
> is how the code works now.
> To match "comparable" data types then the match must cover [int uint]_[8 16 
> 32 64], and possibly float and double. Even a string data type could be 
> matched "1", "0x1", and so on. This could be an awful lot of development 
> effort and testing.
> What is the correct behavior?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4788) Dispatch - Re-schedule of an "immediate" timer causes crash

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved QPID-4788.


Resolution: Fixed

Fixed in commit:  http://svn.apache.org/r1477300

> Dispatch - Re-schedule of an "immediate" timer causes crash
> ---
>
> Key: QPID-4788
> URL: https://issues.apache.org/jira/browse/QPID-4788
> Project: Qpid
>  Issue Type: Bug
>  Components: Qpid Dispatch
>Reporter: Ted Ross
>Assignee: Ted Ross
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-4788) Dispatch - Re-schedule of an "immediate" timer causes crash

[Ted Ross (JIRA)]

Ted Ross created QPID-4788:
--

 Summary: Dispatch - Re-schedule of an "immediate" timer causes 
crash
 Key: QPID-4788
 URL: https://issues.apache.org/jira/browse/QPID-4788
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Dispatch
Reporter: Ted Ross
Assignee: Ted Ross




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4781) cmake build of perl bindings fails in RC2

[Darryl L. Pierce (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644767#comment-13644767
 ] 

Darryl L. Pierce commented on QPID-4781:


I'm not sure what issue is surfacing in the original bug report, but the output 
from the build should be a file named libcqpid_perl.so, not cqpid_perl.so.

> cmake build of perl bindings fails in RC2
> -
>
> Key: QPID-4781
> URL: https://issues.apache.org/jira/browse/QPID-4781
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
> Environment: RHEL5
>Reporter: Jimmy Jones
>
> Running cmake .. && make && make install
> -- Installing: /usr/local/etc/qpid/qpidd.conf
> CMake Error at bindings/qpid/perl/cmake_install.cmake:36 (FILE):
>   file INSTALL cannot find file
>   "/home/test/qpid-0.22-rc2/cpp/bld/bindings/qpid/perl/libcqpid_perl.so" to
>   install.
> Call Stack (most recent call first):
>   bindings/cmake_install.cmake:37 (INCLUDE)
>   cmake_install.cmake:63 (INCLUDE)
> make: *** [install] Error 1
> The library in that directory is cqpid_perl.so, not libcqpid_perl.so

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: 0.22 inclusion request: QPID-4781

[Darryl L. Pierce]

On Mon, Apr 29, 2013 at 02:32:27PM -0400, Darryl L. Pierce wrote:
> QPID-4781: cmake build of perl bindings fails in RC2
> 
> Alan committed a fix which addresses this issue.

I responded without verifying for myself that this fixed an issue. I'm
going to withdraw asking this be included. The commit mentioned doesn't
fix an issue and introduced a new one. So I'm reverting that change.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpRQNKpzwpL9.pgp
Description: PGP signature

Re: 0.22 inclusion request: QPID-4781

[Darryl L. Pierce]

On Mon, Apr 29, 2013 at 02:42:05PM -0400, Justin Ross wrote:
> Why have there been so many small cmake patches for the perl binding?
> I'd feel much better if I had some sense that we had tested, collected
> our patches together, and set it right all at once for 0.22.  Instead,
> it looks like each time we fix one thing, we're just hoping it's the
> last one.

I'm not sure why there are so many edge cases popping up. I'll do a more
thorough round of tests with the RC2 candidate + current patches.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpn_cuHkzGuC.pgp
Description: PGP signature

Re: 0.22 inclusion request: QPID-4781

[Justin Ross]

Why have there been so many small cmake patches for the perl binding?
I'd feel much better if I had some sense that we had tested, collected
our patches together, and set it right all at once for 0.22.  Instead,
it looks like each time we fix one thing, we're just hoping it's the
last one.

Justin

On Mon, Apr 29, 2013 at 2:32 PM, Darryl L. Pierce  wrote:
> QPID-4781: cmake build of perl bindings fails in RC2
>
> Alan committed a fix which addresses this issue.
>
> --
> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
>

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

0.22 inclusion request: QPID-4781

[Darryl L. Pierce]

QPID-4781: cmake build of perl bindings fails in RC2

Alan committed a fix which addresses this issue.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpDkjJyzdu1E.pgp
Description: PGP signature

Re: Request for inclusion into 0.22 - cmake-uninstall file not in -cpp source tarball

[Justin Ross]

Without this, is the windows build broken, or does it just have
useless files hanging around in the windows distribution?

Justin

On Tue, Apr 23, 2013 at 10:36 AM, Alan Conway  wrote:
> On 04/18/2013 09:35 AM, Justin Ross wrote:
>>
>> Hey, Alan.  It looks like this one was garbled.  Were there other
>> things you meant to request?
>>
> Wow, that was garbled! I think this is the only one worth considering:
>
>
> commit 25eaa7e072a1f4bdfc592ac3c4ca57e265a04d40
> Author: Alan Conway 
> Commit: Alan Conway 
>
> QPID-4733: Fix windows problem introduced by installation of init
> scripts
>
> Do init script installation conditional on UNIX only.
> SYSCONF_INSTALL_DIR is not set on windows.
>
> git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1467054
> 13f79535-47bb-0310-9956-ffa450edef68
>
> diff --git a/qpid/cpp/etc/CMakeLists.txt b/qpid/cpp/etc/CMakeLists.txt
> index f2dbc85..a8aae0e 100644
> --- a/qpid/cpp/etc/CMakeLists.txt
> +++ b/qpid/cpp/etc/CMakeLists.txt
> @@ -17,18 +17,23 @@
>  # under the License.
>  #
>
> -# Use automake variable names as these files are also configured by
> automake.
> -set_absolute_install_path (bindir ${QPID_INSTALL_BINDIR})
> -set_absolute_install_path (sysconfdir ${SYSCONF_INSTALL_DIR})
> -set_absolute_install_path (sbindir ${QPID_INSTALL_SBINDIR})
> -
> -configure_file(qpidd.in
> -${CMAKE_CURRENT_BINARY_DIR}/qpidd
> -@ONLY)
> -
> -configure_file(qpidd-primary.in
> -${CMAKE_CURRENT_BINARY_DIR}/qpidd-primary
> -@ONLY)
> +if (UNIX)
> +
> +  # Use automake variable names as these files are also configured by
> automake.
> +  # Use absolute paths as these are substituted into init scripts.
> +  set_absolute_install_path (bindir ${QPID_INSTALL_BINDIR})
> +  set_absolute_install_path (sysconfdir ${SYSCONF_INSTALL_DIR})
> +  set_absolute_install_path (sbindir ${QPID_INSTALL_SBINDIR})
> +
> +  configure_file(qpidd.in
> +${CMAKE_CURRENT_BINARY_DIR}/qpidd
> +@ONLY)
> +
> +  configure_file(qpidd-primary.in
> +${CMAKE_CURRENT_BINARY_DIR}/qpidd-primary
> +@ONLY)
> +
> +endif (UNIX)
>
>  install(FILES ${CMAKE_CURRENT_BINARY_DIR}/qpidd
> ${CMAKE_CURRENT_BINARY_DIR}/qpidd-primary
>  PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ
> GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> For additional commands, e-mail: dev-h...@qpid.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: 0.22 release update - RC2 is available

[Justin Ross]

This is because r1463540 (aconway, QPID-4687: Add uninstall make
target to cmake build) still needs to be reverted.  See discussion
here:

  
http://qpid.2158936.n2.nabble.com/Request-for-inclusion-into-0-22-cmake-uninstall-file-not-in-cpp-source-tarball-td7591386.html#a7591423

Alan, would you revert rev 1463540?

Justin


On Mon, Apr 29, 2013 at 12:12 PM, Gordon Sim  wrote:
> On 04/23/2013 12:57 PM, Justin Ross wrote:
>>
>> Hi, everyone.  RC2 from revision 1470549 is now available:
>>
>>http://people.apache.org/~jross/qpid-0.22-rc2/
>>http://people.apache.org/~jross/qpid-0.22-rc2-testing.txt
>>
>> My testing (Fedora 16 x86-64, still autotools based) showed no failures.
>>
>> Since the last update, we decided to add some time between RC1 and
>> RC2.  I expect RC3 to land in one to two weeks, and I feel there's a
>> pretty good chance that RC will represent the GA bits.
>>
>> So we're getting close.  Please test the RC and report your findings.
>> I'll be sending out candidate release notes this week.
>
>
> Using http://people.apache.org/~jross/qpid-0.22-rc2/qpid-cpp-0.22-rc2.tar.gz
> I was unable to build with cmake:
>
>> CMake Error: File
>> /home/gordon/qpid-releases/0.22rc2/qpidc-0.22/cmake_uninstall.cmake.in does
>> not exist.
>> CMake Error at CMakeLists.txt:105 (configure_file):
>>   configure_file Problem configuring file
>
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> For additional commands, e-mail: dev-h...@qpid.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

[Chug Rolke]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10020/
---

(Updated April 29, 2013, 6:12 p.m.)


Review request for qpid, Gordon Sim and Ted Ross.


Changes
---

Another review answering all of Alan's review comments of April 25.


Description
---

To get a true 'atomic rebind' one should (1) freeze all traffic going through 
all exchanges that have bindings to be changed. 
Failing that, one could (2) freeze all traffic going through each exchange 
while that exchange's bindings are changed. 
A third option would be (3) to freeze each individual binding while it is 
moved. 

Options (1) and (2) require per-message locking at the exchange level; these 
locks do not exist today and adding them would undoubtedly introduce 
performance degredation. For discussion please see 
https://issues.apache.org/jira/browse/QPID-4616 and review comments at 
https://reviews.apache.org/r/9698/
Option (3) requires no new locking and could leverage the locking methods that 
the exchanges already use.

The change proposed here is a prototype that implements lightweight strategy #3.

This review exposes what the feature is trying to accomplish and the basic 
framework is complete. It has:
* Queue settings and status.
* Management method to trigger the rebind.
* Exchange methods to effect the rebind for each exchange type.
* Broker changes to handle queues in the 'rebound' state where bind/unbind 
operations on them actually go to other queues.
* Some test suite code to trigger the rebind method and its error paths.
* A qpid.rebind exchange for backup agents to use to refill queues that are in 
rebind state and not accessable through normal bindings.

Before this feature could transition to 'Ship It' it still needs:
* An ACL property to control specification of rebind queues.
* A handler for queue deletion while the queue is part of a rebind set.
* Code to restore a queue from rebind state back to normal.
* Proof that traffic can be properly recovered through a rebind


This addresses bug QPID-4650.
https://issues.apache.org/jira/browse/QPID-4650


Diffs (updated)
-

  trunk/qpid/cpp/src/qpid/broker/Broker.h 1477103 
  trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1477103 
  trunk/qpid/cpp/src/qpid/broker/Queue.h 1477103 
  trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1477103 
  trunk/qpid/cpp/src/tests/CMakeLists.txt 1477103 
  trunk/qpid/cpp/src/tests/queue_redirect.py PRE-CREATION 
  trunk/qpid/cpp/src/tests/run_queue_redirect PRE-CREATION 
  trunk/qpid/specs/management-schema.xml 1477103 
  trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1477103 

Diff: https://reviews.apache.org/r/10020/diff/


Testing
---

Several tests to exercise rebind code paths.


Thanks,

Chug Rolke

Re: 0.22 Request for inclusion: QPID-4781

[Jimmy Jones]

QPID-4781 cmake build of perl bindings fails in RC2

Small change to cmake install target to fix typo. Without this fix, perl 
bindings can't be installed with either cmake or automake (separate unresolved 
issue).

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

0.22 Request for inclusion: QPID-4781

[Jimmy Jones]

QPID-4781 cmake build of perl bindings fails in RC2


-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4781) cmake build of perl bindings fails in RC2

[Jimmy Jones (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644624#comment-13644624
 ] 

Jimmy Jones commented on QPID-4781:
---

The commit can be found at:

https://svn.apache.org/viewvc?view=revision&revision=1477150

> cmake build of perl bindings fails in RC2
> -
>
> Key: QPID-4781
> URL: https://issues.apache.org/jira/browse/QPID-4781
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
> Environment: RHEL5
>Reporter: Jimmy Jones
>
> Running cmake .. && make && make install
> -- Installing: /usr/local/etc/qpid/qpidd.conf
> CMake Error at bindings/qpid/perl/cmake_install.cmake:36 (FILE):
>   file INSTALL cannot find file
>   "/home/test/qpid-0.22-rc2/cpp/bld/bindings/qpid/perl/libcqpid_perl.so" to
>   install.
> Call Stack (most recent call first):
>   bindings/cmake_install.cmake:37 (INCLUDE)
>   cmake_install.cmake:63 (INCLUDE)
> make: *** [install] Error 1
> The library in that directory is cqpid_perl.so, not libcqpid_perl.so

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4781) cmake build of perl bindings fails in RC2

[Jimmy Jones (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Jones resolved QPID-4781.
---

Resolution: Fixed

> cmake build of perl bindings fails in RC2
> -
>
> Key: QPID-4781
> URL: https://issues.apache.org/jira/browse/QPID-4781
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
> Environment: RHEL5
>Reporter: Jimmy Jones
>
> Running cmake .. && make && make install
> -- Installing: /usr/local/etc/qpid/qpidd.conf
> CMake Error at bindings/qpid/perl/cmake_install.cmake:36 (FILE):
>   file INSTALL cannot find file
>   "/home/test/qpid-0.22-rc2/cpp/bld/bindings/qpid/perl/libcqpid_perl.so" to
>   install.
> Call Stack (most recent call first):
>   bindings/cmake_install.cmake:37 (INCLUDE)
>   cmake_install.cmake:63 (INCLUDE)
> make: *** [install] Error 1
> The library in that directory is cqpid_perl.so, not libcqpid_perl.so

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4781) cmake build of perl bindings fails in RC2

[Jimmy Jones (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644622#comment-13644622
 ] 

Jimmy Jones commented on QPID-4781:
---

Looks as if this issue was fixed in rev 1477150 - 
cpp/bindings/qpid/perl/CMakeLists.txt

> cmake build of perl bindings fails in RC2
> -
>
> Key: QPID-4781
> URL: https://issues.apache.org/jira/browse/QPID-4781
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
> Environment: RHEL5
>Reporter: Jimmy Jones
>
> Running cmake .. && make && make install
> -- Installing: /usr/local/etc/qpid/qpidd.conf
> CMake Error at bindings/qpid/perl/cmake_install.cmake:36 (FILE):
>   file INSTALL cannot find file
>   "/home/test/qpid-0.22-rc2/cpp/bld/bindings/qpid/perl/libcqpid_perl.so" to
>   install.
> Call Stack (most recent call first):
>   bindings/cmake_install.cmake:37 (INCLUDE)
>   cmake_install.cmake:63 (INCLUDE)
> make: *** [install] Error 1
> The library in that directory is cqpid_perl.so, not libcqpid_perl.so

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: 0.22 release update - RC2 is available

[Gordon Sim]

On 04/23/2013 12:57 PM, Justin Ross wrote:

Hi, everyone.  RC2 from revision 1470549 is now available:

   http://people.apache.org/~jross/qpid-0.22-rc2/
   http://people.apache.org/~jross/qpid-0.22-rc2-testing.txt

My testing (Fedora 16 x86-64, still autotools based) showed no failures.

Since the last update, we decided to add some time between RC1 and
RC2.  I expect RC3 to land in one to two weeks, and I feel there's a
pretty good chance that RC will represent the GA bits.

So we're getting close.  Please test the RC and report your findings.
I'll be sending out candidate release notes this week.


Using 
http://people.apache.org/~jross/qpid-0.22-rc2/qpid-cpp-0.22-rc2.tar.gz I 
was unable to build with cmake:



CMake Error: File 
/home/gordon/qpid-releases/0.22rc2/qpidc-0.22/cmake_uninstall.cmake.in does not 
exist.
CMake Error at CMakeLists.txt:105 (configure_file):
  configure_file Problem configuring file






-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (QPID-4787) HA brokers find self-address in brokers_url.

[Alan Conway (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644598#comment-13644598
 ] 

Alan Conway edited comment on QPID-4787 at 4/29/13 4:03 PM:


Fixed on trunk


r1477165 | aconway | 2013-04-29 11:57:59 -0400 (Mon, 29 Apr 2013) | 7 lines

QPID-4787: HA brokers find self-address in brokers_url.

HA brokers need to know their own addresses, but it is not safe to simply use
local hosts name and Broker::getPort() since the broker may be listening on
multiple addresses. The solution is to have brokers check the ha-rokers-url for
their own address while doing the initial status check of the cluster.




  was (Author: aconway):
Fixed on trunk


r1477165 | Use of uninitialized value in concatenation (.) or string at 
/usr/libexec/git-core/git-svn line 5605, <$fh> line 12.
 | 2013-04-29 12:01:33 -0400 (Mon, 29 Apr 2013) | 7 lines

QPID-4787: HA brokers find self-address in brokers_url.

HA brokers need to know their own addresses, but it is not safe to simply use
local hosts name and Broker::getPort() since the broker may be listening on
multiple addresses. The solution is to have brokers check the ha-rokers-url for
their own address while doing the initial status check of the cluster.



  
> HA brokers find self-address in brokers_url.
> 
>
> Key: QPID-4787
> URL: https://issues.apache.org/jira/browse/QPID-4787
> Project: Qpid
>  Issue Type: Bug
>Affects Versions: 0.22
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.23
>
>
> HA brokers need to know their own addresses, but it is not safe to simply use
> local hosts name and Broker::getPort() since the broker may be listening on
> multiple addresses. The solution is to have brokers check the ha-rokers-url 
> for their own address while doing the initial status check of the cluster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4787) HA brokers find self-address in brokers_url.

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved QPID-4787.
---

Resolution: Fixed

Fixed on trunk


r1477165 | Use of uninitialized value in concatenation (.) or string at 
/usr/libexec/git-core/git-svn line 5605, <$fh> line 12.
 | 2013-04-29 12:01:33 -0400 (Mon, 29 Apr 2013) | 7 lines

QPID-4787: HA brokers find self-address in brokers_url.

HA brokers need to know their own addresses, but it is not safe to simply use
local hosts name and Broker::getPort() since the broker may be listening on
multiple addresses. The solution is to have brokers check the ha-rokers-url for
their own address while doing the initial status check of the cluster.




> HA brokers find self-address in brokers_url.
> 
>
> Key: QPID-4787
> URL: https://issues.apache.org/jira/browse/QPID-4787
> Project: Qpid
>  Issue Type: Bug
>Affects Versions: 0.22
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.23
>
>
> HA brokers need to know their own addresses, but it is not safe to simply use
> local hosts name and Broker::getPort() since the broker may be listening on
> multiple addresses. The solution is to have brokers check the ha-rokers-url 
> for their own address while doing the initial status check of the cluster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-4787) HA brokers find self-address in brokers_url.

[Alan Conway (JIRA)]

Alan Conway created QPID-4787:
-

 Summary: HA brokers find self-address in brokers_url.
 Key: QPID-4787
 URL: https://issues.apache.org/jira/browse/QPID-4787
 Project: Qpid
  Issue Type: Bug
Affects Versions: 0.22
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.23


HA brokers need to know their own addresses, but it is not safe to simply use
local hosts name and Broker::getPort() since the broker may be listening on
multiple addresses. The solution is to have brokers check the ha-rokers-url for 
their own address while doing the initial status check of the cluster.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request: Fix for concurrent fetch()/get() calls on a session

[Gordon Sim]

> On April 29, 2013, 3:02 p.m., Alan Conway wrote:
> > I don't see any bugs but it is  more complicated than I'd like.
> > 
> > Would it be simpler to keep a map of thread safe dequeues by destination? 
> > As well as simplifying the locking logic it would get rid of the liner 
> > search that is there now. So you'd have a lock for the overall 
> > IncomingMessages protecting the map and a lock per destination for threads 
> > waiting to push or pull on that destination.

The issue is that you need to keep both session order (for 
session::nextReceiver()) _and_ when requested process a specific receiver only. 
So if we kept a map it would need to be in addition to some other structure 
recording session order. It would also require a change in the interface to 
IncomingMessages (would need to signal closing of receivers and would need to 
pass in the destination to get), and therefore to SessionImpl also.

I did consider doing that, but felt a fix with smaller impact was preferable at 
this stage.


> On April 29, 2013, 3:02 p.m., Alan Conway wrote:
> > /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp, line 135
> > 
> >
> > Is this valid if timeout==INFINITE?

Yes. (Annoyingly however you can't then get the correct Duration back via 
AbsTime(AbsTime::now(), deadline) - however thats a separate issue).


> On April 29, 2013, 3:02 p.m., Alan Conway wrote:
> > /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp, line 1234
> > 
> >
> > Do you have performance test results that verify we fetch faster in 
> > multiple threads?

No. However to be clear the issue isn't one of performance, its that when you 
have concurrent fetches, they can incorrectly get blocked until the timeout.


- Gordon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10839/#review19858
---


On April 29, 2013, 2:18 p.m., Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10839/
> ---
> 
> (Updated April 29, 2013, 2:18 p.m.)
> 
> 
> Review request for qpid, Alan Conway and Kenneth Giusti.
> 
> 
> Description
> ---
> 
> Only one thread at a time now pops off the underlying incoming session queue. 
> Other threads either wait for that to complete or for it to queue up some 
> received messages that it was not interested in. (Note:  this could be made 
> more efficient where either you have a very large number of concurrent 
> fetches, or where there are a large number of unreceived messages that are 
> not of interest to any of the fetching threads. However this seemed to be 
> less of a concern at present, so I've left further optimisation as a separate 
> task for the future).
> 
> 
> This addresses bug QPID-4786.
> https://issues.apache.org/jira/browse/QPID-4786
> 
> 
> Diffs
> -
> 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1475717 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1475717 
>   /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1475717 
> 
> Diff: https://reviews.apache.org/r/10839/diff/
> 
> 
> Testing
> ---
> 
> New test added; make test passes.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

[jira] [Commented] (QPID-4776) Unable to build Ruby language bindings with Cmake 2.6

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644561#comment-13644561
 ] 

Justin Ross commented on QPID-4776:
---

Patch from Irina reviewed by Darryl.  Approved for 0.22.

> Unable to build Ruby language bindings with Cmake 2.6
> -
>
> Key: QPID-4776
> URL: https://issues.apache.org/jira/browse/QPID-4776
> Project: Qpid
>  Issue Type: Bug
>  Components: Ruby Client
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.22
>
>
> Cmake 2.6 does not include the RUBY_FOUND macro. We need to provide this 
> check for older versions of Cmake.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4631) C++ Broker interbroker links should be protected by ACL

[Chuck Rolke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved QPID-4631.
---

   Resolution: Fixed
Fix Version/s: 0.23

Fixed at Committed revision 1477112.


> C++ Broker interbroker links should be protected by ACL
> ---
>
> Key: QPID-4631
> URL: https://issues.apache.org/jira/browse/QPID-4631
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.20
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
> Fix For: 0.23
>
>
> This issue addresses CVE-2012-4446
> Federated interbroker links may be opened by client programs and not just by 
> brokers. By default the creation of these links is not protected any formal 
> authorization.
> Users concerned about this issue may immediately lock their systems down by 
> creating ACL rules that allow links to be created only by authorized users. 
> For instance the following ACL rules on each broker would provide the 
> lockdown necessary:
>   group proxies   ...
>   acl allowproxies create link
>   acl deny-log all create link
> A better solution is for the ACL module to deny the creation of links unless 
> ACL rules are specified to specifically allow them.
> In pseudo code the solution is in two parts. Part one observes CREATE LINK 
> rules in the acl file. Part two authorizes link creation only if ACL is 
> loaded, CREATE LINK ACL rules are specified, and the specific user is 
> authorized to create the link in question:
> function readAclFile()
>   ...
>   if (CREATE LINK rules are specified)
> set acl->createLinkFlag
>   endif
>   ...
> end function
> function brokerCreateLink()
>   if (aclLoaded)
> if (acl->createLinkFlag)
>   if (acl->authorise(user, create, link, properties))
> 
>   else
> 
>   endif
> else
>   
> endif
>   else
> 
>   endif
> end function
> This Jira will track the implementation of this restriction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request: Fix for concurrent fetch()/get() calls on a session

[Alan Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10839/#review19858
---


I don't see any bugs but it is  more complicated than I'd like.

Would it be simpler to keep a map of thread safe dequeues by destination? As 
well as simplifying the locking logic it would get rid of the liner search that 
is there now. So you'd have a lock for the overall IncomingMessages protecting 
the map and a lock per destination for threads waiting to push or pull on that 
destination.


/trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp


Is this valid if timeout==INFINITE?



/trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp


Do you have performance test results that verify we fetch faster in 
multiple threads?


- Alan Conway


On April 29, 2013, 2:18 p.m., Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10839/
> ---
> 
> (Updated April 29, 2013, 2:18 p.m.)
> 
> 
> Review request for qpid, Alan Conway and Kenneth Giusti.
> 
> 
> Description
> ---
> 
> Only one thread at a time now pops off the underlying incoming session queue. 
> Other threads either wait for that to complete or for it to queue up some 
> received messages that it was not interested in. (Note:  this could be made 
> more efficient where either you have a very large number of concurrent 
> fetches, or where there are a large number of unreceived messages that are 
> not of interest to any of the fetching threads. However this seemed to be 
> less of a concern at present, so I've left further optimisation as a separate 
> task for the future).
> 
> 
> This addresses bug QPID-4786.
> https://issues.apache.org/jira/browse/QPID-4786
> 
> 
> Diffs
> -
> 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1475717 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1475717 
>   /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1475717 
> 
> Diff: https://reviews.apache.org/r/10839/diff/
> 
> 
> Testing
> ---
> 
> New test added; make test passes.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

[jira] [Reopened] (QPID-4401) New HA - bindings for QMF exchanges not replicated

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway reopened QPID-4401:
---


This issue has been raised again, there may be a way to fix it.

The problem is that the replica queue is bound to 2 active qmf exchanges, on 
primary and on backup. Instead we could defer the binding on the backup until 
that backup becomes a primary - mark them "primary only" bindings.

> New HA - bindings for QMF exchanges not replicated
> --
>
> Key: QPID-4401
> URL: https://issues.apache.org/jira/browse/QPID-4401
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Clustering
>Reporter: Andy Goldstein
>Assignee: Alan Conway
>Priority: Minor
>
> If I manually create a binding from qmf.default.topic to a queue, that 
> binding is not replicated to backup brokers.  When a failover occurs, the 
> binding is gone.
> My use case, which is for a test harness, is that I have several 
> active-passive broker clusters.  Each active broker binds all queue-related 
> events to a queue.  A separate, standalone broker used to gather statistics 
> uses a queue route to pull the queue-related QMF statistics from each 
> cluster.  In effect, I'm aggregating all QMF stats from all clusters into a 
> single stats broker.  When I initiate a failover for one of my clusters, I 
> lose the binding for queue-related events, so I no longer get stats from that 
> cluster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

0.22 Request for inclusion: QPID-4719

[Darryl L. Pierce]

QPID-4719: Problem building perl bindings from qpid 0.22 RC1 tarball

http://issues.apache.org/jira/browse/QPID-4719

The change involves adding three entries to the upstream sources created
by release.sh via Makefile.am.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpmpFAvdjn9W.pgp
Description: PGP signature

[jira] [Commented] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

[Darryl L. Pierce (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644516#comment-13644516
 ] 

Darryl L. Pierce commented on QPID-4719:


This commit can be found:

http://svn.apache.org/viewvc?view=revision&revision=1477096

> Problem building perl bindings from qpid 0.22 RC1 tarball
> -
>
> Key: QPID-4719
> URL: https://issues.apache.org/jira/browse/QPID-4719
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
>Reporter: Jimmy Jones
>Assignee: Darryl L. Pierce
> Fix For: 0.22
>
>
> Tarball 
> http://people.apache.org/~jross/qpid-0.22-rc1/qpid-cpp-0.22-rc1.tar.gz is 
> missing:
> bindings/qpid/perl/Makefile.PL
> bindings/qpid/perl/Makefile.PL.in
> bindings/qpid/perl/qpid.pm
> bindings/qpid/perl/lib
> which prevents the perl bindings from being built from this tarball. I 
> presume perl-qpid-0.22-rc1.tar.gz is the new home for the perl bindings, but 
> this doesn't build either:
> Running perl Makefile.PL from perl-qpid-0.22-rc1.tar.gz, after installing 
> qpid-cpp-0.22-rc1.tar.gz (with automake):
> Note (probably harmless): No library found for -lqpidmessaging
> Note (probably harmless): No library found for -lqpidtypes
> Writing Makefile for cqpid_perl
> Weird... libqpidmessaging/types seems to be in /usr/lib rather than lib64 on 
> my 64-bit system, and its linked against other libs in lib64.
> Anyway, if then run make:
> cp lib/qpid/messaging/Address.pm blib/lib/qpid/messaging/Address.pm
> cp lib/qpid/messaging/Duration.pm blib/lib/qpid/messaging/Duration.pm
> cp qpid.pm blib/lib/qpid.pm
> cp lib/qpid/messaging/codec.pm blib/lib/qpid/messaging/codec.pm
> cp lib/qpid/messaging/Message.pm blib/lib/qpid/messaging/Message.pm
> cp lib/qpid/messaging/Connection.pm blib/lib/qpid/messaging/Connection.pm
> cp lib/qpid/messaging/Sender.pm blib/lib/qpid/messaging/Sender.pm
> cp lib/qpid_messaging.pm blib/lib/qpid_messaging.pm
> cp lib/qpid/messaging/Receiver.pm blib/lib/qpid/messaging/Receiver.pm
> cp lib/qpid/messaging/Session.pm blib/lib/qpid/messaging/Session.pm
> Running Mkbootstrap for cqpid_perl ()
> chmod 644 cqpid_perl.bs
> rm -f blib/arch/auto/cqpid_perl/cqpid_perl.so
> gcc -shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
> -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic cqpid_perl.o 
> -o blib/arch/auto/cqpid_perl/cqpid_perl.so \
> \
> gcc: cqpid_perl.o: No such file or directory
> gcc: no input files
> make: *** [blib/arch/auto/cqpid_perl/cqpid_perl.so] Error 1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

[Darryl L. Pierce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl L. Pierce resolved QPID-4719.


   Resolution: Fixed
Fix Version/s: 0.22

This should be fixed now.

NOTE: Makefile.PL.in is deprecated and should not be used. 

> Problem building perl bindings from qpid 0.22 RC1 tarball
> -
>
> Key: QPID-4719
> URL: https://issues.apache.org/jira/browse/QPID-4719
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
>Reporter: Jimmy Jones
>Assignee: Darryl L. Pierce
> Fix For: 0.22
>
>
> Tarball 
> http://people.apache.org/~jross/qpid-0.22-rc1/qpid-cpp-0.22-rc1.tar.gz is 
> missing:
> bindings/qpid/perl/Makefile.PL
> bindings/qpid/perl/Makefile.PL.in
> bindings/qpid/perl/qpid.pm
> bindings/qpid/perl/lib
> which prevents the perl bindings from being built from this tarball. I 
> presume perl-qpid-0.22-rc1.tar.gz is the new home for the perl bindings, but 
> this doesn't build either:
> Running perl Makefile.PL from perl-qpid-0.22-rc1.tar.gz, after installing 
> qpid-cpp-0.22-rc1.tar.gz (with automake):
> Note (probably harmless): No library found for -lqpidmessaging
> Note (probably harmless): No library found for -lqpidtypes
> Writing Makefile for cqpid_perl
> Weird... libqpidmessaging/types seems to be in /usr/lib rather than lib64 on 
> my 64-bit system, and its linked against other libs in lib64.
> Anyway, if then run make:
> cp lib/qpid/messaging/Address.pm blib/lib/qpid/messaging/Address.pm
> cp lib/qpid/messaging/Duration.pm blib/lib/qpid/messaging/Duration.pm
> cp qpid.pm blib/lib/qpid.pm
> cp lib/qpid/messaging/codec.pm blib/lib/qpid/messaging/codec.pm
> cp lib/qpid/messaging/Message.pm blib/lib/qpid/messaging/Message.pm
> cp lib/qpid/messaging/Connection.pm blib/lib/qpid/messaging/Connection.pm
> cp lib/qpid/messaging/Sender.pm blib/lib/qpid/messaging/Sender.pm
> cp lib/qpid_messaging.pm blib/lib/qpid_messaging.pm
> cp lib/qpid/messaging/Receiver.pm blib/lib/qpid/messaging/Receiver.pm
> cp lib/qpid/messaging/Session.pm blib/lib/qpid/messaging/Session.pm
> Running Mkbootstrap for cqpid_perl ()
> chmod 644 cqpid_perl.bs
> rm -f blib/arch/auto/cqpid_perl/cqpid_perl.so
> gcc -shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
> -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic cqpid_perl.o 
> -o blib/arch/auto/cqpid_perl/cqpid_perl.so \
> \
> gcc: cqpid_perl.o: No such file or directory
> gcc: no input files
> make: *** [blib/arch/auto/cqpid_perl/cqpid_perl.so] Error 1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4786) Delayed response for concurrent fetches

[Gordon Sim (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644507#comment-13644507
 ] 

Gordon Sim commented on QPID-4786:
--

Patch available for review: https://reviews.apache.org/r/10839/

> Delayed response for concurrent fetches
> ---
>
> Key: QPID-4786
> URL: https://issues.apache.org/jira/browse/QPID-4786
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.22
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.23
>
>
> Where a session has two concurrent fetch() (or indeed get()) operations in 
> progress, one of them may be delayed up to the timeout even if there is in 
> fact a message much earlier than that.
> This is due to the design whereby the threads pop off the next message from a 
> session queue, and put it into a received buffer if its not one they are 
> interested in. The wrong thread can get the message, and the other thread 
> remains waiting for another one before re-checking the received buffer (which 
> now has a message that matches its interest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Review Request: Fix for concurrent fetch()/get() calls on a session

[Gordon Sim]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10839/
---

Review request for qpid, Alan Conway and Kenneth Giusti.


Description
---

Only one thread at a time now pops off the underlying incoming session queue. 
Other threads either wait for that to complete or for it to queue up some 
received messages that it was not interested in. (Note:  this could be made 
more efficient where either you have a very large number of concurrent fetches, 
or where there are a large number of unreceived messages that are not of 
interest to any of the fetching threads. However this seemed to be less of a 
concern at present, so I've left further optimisation as a separate task for 
the future).


This addresses bug QPID-4786.
https://issues.apache.org/jira/browse/QPID-4786


Diffs
-

  /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1475717 
  /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1475717 
  /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1475717 

Diff: https://reviews.apache.org/r/10839/diff/


Testing
---

New test added; make test passes.


Thanks,

Gordon Sim

[jira] [Created] (QPID-4786) Delayed response for concurrent fetches

[Gordon Sim (JIRA)]

Gordon Sim created QPID-4786:


 Summary: Delayed response for concurrent fetches
 Key: QPID-4786
 URL: https://issues.apache.org/jira/browse/QPID-4786
 Project: Qpid
  Issue Type: Bug
  Components: C++ Client
Affects Versions: 0.22
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.23


Where a session has two concurrent fetch() (or indeed get()) operations in 
progress, one of them may be delayed up to the timeout even if there is in fact 
a message much earlier than that.

This is due to the design whereby the threads pop off the next message from a 
session queue, and put it into a received buffer if its not one they are 
interested in. The wrong thread can get the message, and the other thread 
remains waiting for another one before re-checking the received buffer (which 
now has a message that matches its interest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4724) qpid-cpp-0.22-rc1 RHEL6 cmake issues

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644491#comment-13644491
 ] 

Justin Ross commented on QPID-4724:
---

Reviewed by me.  Approved for 0.22.

> qpid-cpp-0.22-rc1 RHEL6 cmake issues
> 
>
> Key: QPID-4724
> URL: https://issues.apache.org/jira/browse/QPID-4724
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
> Environment: RHEL6
>Reporter: Jimmy Jones
>Assignee: Darryl L. Pierce
> Fix For: 0.22
>
> Attachments: 0001-QPID-4724-Fixes-Perl-bindings-for-Cmake-2.8.patch
>
>
> Running mkdir BLD; cd BLD; cmake ..
> -- Could NOT find PerlLibs  (missing:  PERL_LIBRARY PERL_INCLUDE_PATH)
> -- Configuring incomplete, errors occurred!
> should it autodetect this (automake does)? If then run:
> cmake .. -DPERL_LIBRARY=/usr/lib64/perl5/CORE/libperl.so 
> -DPERL_INCLUDE_PATH=/usr/lib64/perl5
> errors with:
> -- Found Perl: /usr/bin/perl
> -- Found PerlLibs: /usr/lib64/perl5/CORE/libperl.so
> CMake Error at bindings/CMakeLists.txt:62 (string):
>   string sub-command REPLACE requires four arguments.
> CMake Error at bindings/qpid/perl/CMakeLists.txt:38 (install):
>   install FILES given no DESTINATION!
> -- Configuring incomplete, errors occurred!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-4785) [Java Broker] relax restrictions on editing ports outwith management-mode

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-4785:
-

Description: 
QPID-4657 added the ability to create/edit/delete ports via the web management 
interface, however the REST interface restricts editing/deletion of active 
ports to only be allowed in management-mode, necessitating two broker restarts 
(once into management mode, once back to normal mode) to actually achieve the 
desired result.

To simplify administration of the broker, this change will enable editing and 
deletion of active ports without restarting into management mode, with the 
caveat that port deletion, port number changes, and SSL configuration changes 
will only actually take effect after the broker is finally restarted (which 
will be documented via QPID-4685).

  was:
QPID-4657 added the ability to create/edit/delete ports via the web management 
interface, however the REST interface restricts editing/deletion of active 
ports to only be allowed in management-mode, necessitating two broker restarts 
(once into management mode, once back to normal mode) to actually achieve the 
desired result.

To simplify administration of the broker, this change will enable editing and 
deletion of active ports without restarting into management mode, with the 
caveat that port deletion, port number changes, and SSL configuration changes 
will only actually take effect after the broker is finally restarted (which 
will be documented via QPID-4685.


> [Java Broker] relax restrictions on editing ports outwith management-mode
> -
>
> Key: QPID-4785
> URL: https://issues.apache.org/jira/browse/QPID-4785
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.22
>
>
> QPID-4657 added the ability to create/edit/delete ports via the web 
> management interface, however the REST interface restricts editing/deletion 
> of active ports to only be allowed in management-mode, necessitating two 
> broker restarts (once into management mode, once back to normal mode) to 
> actually achieve the desired result.
> To simplify administration of the broker, this change will enable editing and 
> deletion of active ports without restarting into management mode, with the 
> caveat that port deletion, port number changes, and SSL configuration changes 
> will only actually take effect after the broker is finally restarted (which 
> will be documented via QPID-4685).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-4785) [Java Broker] relax restrictions on editing ports outwith management-mode

[Robbie Gemmell (JIRA)]

Robbie Gemmell created QPID-4785:


 Summary: [Java Broker] relax restrictions on editing ports outwith 
management-mode
 Key: QPID-4785
 URL: https://issues.apache.org/jira/browse/QPID-4785
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: 0.22


QPID-4657 added the ability to create/edit/delete ports via the web management 
interface, however the REST interface restricts editing/deletion of active 
ports to only be allowed in management-mode, necessitating two broker restarts 
(once into management mode, once back to normal mode) to actually achieve the 
desired result.

To simplify administration of the broker, this change will enable editing and 
deletion of active ports without restarting into management mode, with the 
caveat that port deletion, port number changes, and SSL configuration changes 
will only actually take effect after the broker is finally restarted (which 
will be documented via QPID-4685.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4714) AMQConnection close can leak socket connections if exceptions occur earlier in the process

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644479#comment-13644479
 ] 

Justin Ross commented on QPID-4714:
---

Reviewed by Robbie.  Approved for 0.22.

> AMQConnection close can leak socket connections if exceptions occur earlier 
> in the process
> --
>
> Key: QPID-4714
> URL: https://issues.apache.org/jira/browse/QPID-4714
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: 0.20
>Reporter: Rajith Attapattu
> Fix For: Future
>
>
> If any of the operations throws an exception before the call to 
> _delegate.closeConnection(timeout); then we will leak socket connections.
> I already see this happening when running performance tests, where 
> session/connection close operations are timing out. The number of connections 
> keeps growing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-4784) [Java Broker] simplify PrincipalDatabaseAuthentication manager SASL handling for clarity and to prevent logging erroneous errors when creating additional instances

[Robbie Gemmell (JIRA)]

Robbie Gemmell created QPID-4784:


 Summary: [Java Broker] simplify PrincipalDatabaseAuthentication 
manager SASL handling for clarity and to prevent logging erroneous errors when 
creating additional instances
 Key: QPID-4784
 URL: https://issues.apache.org/jira/browse/QPID-4784
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: 0.22


Currently, the PrincipalDatabaseAuthenticationManager has an elaborate system 
to register SASL mechanisms, which eventually get looked up basically by doing 
a hasmap retrieval operation. This process can be simplied for clarity. This 
will also prevent erroneous error logging from occuring when subsequent 
isntances of PDAM are created when the broekr is running and it fails to 
register the mechanisms (because they are already registerd).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

CORRECT: 0.22 Request For Inclusion: QPID-4724

[Darryl L. Pierce]

On Fri, Apr 26, 2013 at 08:29:57PM +0200, Jimmy Jones wrote:
> Do you mean QPID-4724?

Yes, thank you.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpI9IgO0Ad_G.pgp
Description: PGP signature

Re: Review Request: NO-JIRA: HA updates to migration guide.

[Pavel Moravec]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10376/#review19856
---


My comments (sorry for later review):

- it is not stated what ha-* broker options are mandatory and what are optional.
- `link-*-interval` options are valid for inter-broker links, I guess (but not 
evident from the description). I suggest changing:
  - "to check link health" to "to check inter-broker 
management/failover/whatever-fits-best link health", and 
  - "for replication links" to "for inter-broker replication links"
  (both in README-HA.txt and the xml file)
- cluster.conf example has VIP 20.0.20.200 while further 20.0.10.200 is used 
(e.g. ha-public-url and in text)
- MECH vs. MECHANISM: compare lines 302 and 797 of the xml

- Pavel Moravec


On April 11, 2013, 4:04 p.m., Alan Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10376/
> ---
> 
> (Updated April 11, 2013, 4:04 p.m.)
> 
> 
> Review request for qpid, Andy Goldstein, Jason Dillaman, mick goulish, Pavel 
> Moravec, and Justin Ross.
> 
> 
> Description
> ---
> 
> NO-JIRA: HA updates to migration guide.
> 
> git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1466933 
> 13f79535-47bb-0310-9956-ffa450edef68
> 
> 
> Diffs
> -
> 
>   /trunk/qpid/cpp/README-HA.txt 1466895 
>   /trunk/qpid/doc/book/src/cpp-broker/Active-Passive-Cluster.xml 1466895 
> 
> Diff: https://reviews.apache.org/r/10376/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alan Conway
> 
>

Re: Review Request: Change federation link creation default to deny; allow only by ACL authorization

[Alan Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10658/#review19855
---

Ship it!


Ship It!

- Alan Conway


On April 26, 2013, 7:45 p.m., Chug Rolke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10658/
> ---
> 
> (Updated April 26, 2013, 7:45 p.m.)
> 
> 
> Review request for qpid, Alan Conway and Gordon Sim.
> 
> 
> Description
> ---
> 
> Lock down federation link creation to be allowed only by ACL approval. When 
> no ACL file is specified then no federation links are allowed.
> This version is more forgiving than the description in QPID-4631 as no 
> explicit CREATE LINK rules are required. Simple 'allow all all' ACL rules are 
> sufficient.
> 
> ACL files are added to all diagnostics broker instances so that cmake 'make 
> check' and autotools 'make test' work.
> 
> 
> This addresses bug QPID-4631.
> https://issues.apache.org/jira/browse/QPID-4631
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/src/qpid/acl/AclConnectionCounter.cpp 1476311 
>   trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1476311 
>   trunk/qpid/cpp/src/tests/ha_test.py 1476311 
>   trunk/qpid/cpp/src/tests/run_acl_tests 1476311 
>   trunk/qpid/cpp/src/tests/sasl_fed 1476311 
> 
> Diff: https://reviews.apache.org/r/10658/diff/
> 
> 
> Testing
> ---
> 
> The ACL self test is enhanced to show that brokers running without the ACL 
> module/file loaded cannot create federation links.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>

[jira] [Commented] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

[Darryl L. Pierce (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1365#comment-1365
 ] 

Darryl L. Pierce commented on QPID-4719:


Okay, I see where my confusion is. I'm looking solely at the larger qpid-0.22 
tarball and not the qpid-cpp-0.22 tarball. In the former all files are present 
and accounted for, in the latter they're not.

> Problem building perl bindings from qpid 0.22 RC1 tarball
> -
>
> Key: QPID-4719
> URL: https://issues.apache.org/jira/browse/QPID-4719
> Project: Qpid
>  Issue Type: Bug
>  Components: Perl Client
>Affects Versions: 0.22
>Reporter: Jimmy Jones
>Assignee: Darryl L. Pierce
>
> Tarball 
> http://people.apache.org/~jross/qpid-0.22-rc1/qpid-cpp-0.22-rc1.tar.gz is 
> missing:
> bindings/qpid/perl/Makefile.PL
> bindings/qpid/perl/Makefile.PL.in
> bindings/qpid/perl/qpid.pm
> bindings/qpid/perl/lib
> which prevents the perl bindings from being built from this tarball. I 
> presume perl-qpid-0.22-rc1.tar.gz is the new home for the perl bindings, but 
> this doesn't build either:
> Running perl Makefile.PL from perl-qpid-0.22-rc1.tar.gz, after installing 
> qpid-cpp-0.22-rc1.tar.gz (with automake):
> Note (probably harmless): No library found for -lqpidmessaging
> Note (probably harmless): No library found for -lqpidtypes
> Writing Makefile for cqpid_perl
> Weird... libqpidmessaging/types seems to be in /usr/lib rather than lib64 on 
> my 64-bit system, and its linked against other libs in lib64.
> Anyway, if then run make:
> cp lib/qpid/messaging/Address.pm blib/lib/qpid/messaging/Address.pm
> cp lib/qpid/messaging/Duration.pm blib/lib/qpid/messaging/Duration.pm
> cp qpid.pm blib/lib/qpid.pm
> cp lib/qpid/messaging/codec.pm blib/lib/qpid/messaging/codec.pm
> cp lib/qpid/messaging/Message.pm blib/lib/qpid/messaging/Message.pm
> cp lib/qpid/messaging/Connection.pm blib/lib/qpid/messaging/Connection.pm
> cp lib/qpid/messaging/Sender.pm blib/lib/qpid/messaging/Sender.pm
> cp lib/qpid_messaging.pm blib/lib/qpid_messaging.pm
> cp lib/qpid/messaging/Receiver.pm blib/lib/qpid/messaging/Receiver.pm
> cp lib/qpid/messaging/Session.pm blib/lib/qpid/messaging/Session.pm
> Running Mkbootstrap for cqpid_perl ()
> chmod 644 cqpid_perl.bs
> rm -f blib/arch/auto/cqpid_perl/cqpid_perl.so
> gcc -shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
> -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic cqpid_perl.o 
> -o blib/arch/auto/cqpid_perl/cqpid_perl.so \
> \
> gcc: cqpid_perl.o: No such file or directory
> gcc: no input files
> make: *** [blib/arch/auto/cqpid_perl/cqpid_perl.so] Error 1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request: Change federation link creation default to deny; allow only by ACL authorization

[Gordon Sim]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10658/#review19854
---

Ship it!


As I understand it, the 'create link' permission is considered special only 
because it implies the permission to send messages on behalf of another 
authenticated user (i.e. to send messages with a userid other than that of the 
connection over which they are sent). Thus tying this to authentication and 
requiring explicitly granted permission is not unreasonable.

- Gordon Sim


On April 26, 2013, 7:45 p.m., Chug Rolke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10658/
> ---
> 
> (Updated April 26, 2013, 7:45 p.m.)
> 
> 
> Review request for qpid, Alan Conway and Gordon Sim.
> 
> 
> Description
> ---
> 
> Lock down federation link creation to be allowed only by ACL approval. When 
> no ACL file is specified then no federation links are allowed.
> This version is more forgiving than the description in QPID-4631 as no 
> explicit CREATE LINK rules are required. Simple 'allow all all' ACL rules are 
> sufficient.
> 
> ACL files are added to all diagnostics broker instances so that cmake 'make 
> check' and autotools 'make test' work.
> 
> 
> This addresses bug QPID-4631.
> https://issues.apache.org/jira/browse/QPID-4631
> 
> 
> Diffs
> -
> 
>   trunk/qpid/cpp/src/qpid/acl/AclConnectionCounter.cpp 1476311 
>   trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1476311 
>   trunk/qpid/cpp/src/tests/ha_test.py 1476311 
>   trunk/qpid/cpp/src/tests/run_acl_tests 1476311 
>   trunk/qpid/cpp/src/tests/sasl_fed 1476311 
> 
> Diff: https://reviews.apache.org/r/10658/diff/
> 
> 
> Testing
> ---
> 
> The ACL self test is enhanced to show that brokers running without the ACL 
> module/file loaded cannot create federation links.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>

[jira] [Updated] (QPID-4596) [Java Broker] Add ability to create/delete/update virtual host, authentication provider, port via REST interfaces

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-4596:
-

Fix Version/s: (was: 0.21)
   0.22

> [Java Broker] Add ability to create/delete/update virtual host, 
> authentication provider, port via REST interfaces
> -
>
> Key: QPID-4596
> URL: https://issues.apache.org/jira/browse/QPID-4596
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: 0.22
>
> Attachments: 
> 0001-QPID-4596-Add-validation-and-ACL-checks-for-the-mana.patch, 
> 0001-QPID-4596-Invoke-onCreate-on-re-creation-of-authenti.patch, 
> 0002-WIP-Introduce-a-new-attribute-requiresSSL-for-authen.patch
>
>
> Add ability to create/delete/update the following configured objects:
> * virtual host
> * authentication provider
> * port

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4596) [Java Broker] Add ability to create/delete/update virtual host, authentication provider, port via REST interfaces

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644379#comment-13644379
 ] 

Robbie Gemmell commented on QPID-4596:
--

r1475825 was merged to the 0.22 release branch in http://svn.apache.org/r1476104

> [Java Broker] Add ability to create/delete/update virtual host, 
> authentication provider, port via REST interfaces
> -
>
> Key: QPID-4596
> URL: https://issues.apache.org/jira/browse/QPID-4596
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: 0.21
>
> Attachments: 
> 0001-QPID-4596-Add-validation-and-ACL-checks-for-the-mana.patch, 
> 0001-QPID-4596-Invoke-onCreate-on-re-creation-of-authenti.patch, 
> 0002-WIP-Introduce-a-new-attribute-requiresSSL-for-authen.patch
>
>
> Add ability to create/delete/update the following configured objects:
> * virtual host
> * authentication provider
> * port

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Issue Comment Deleted] (QPID-4596) [Java Broker] Add ability to create/delete/update virtual host, authentication provider, port via REST interfaces

[Alex Rudyy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-4596:
-

Comment: was deleted

(was: Robbie's comments about invoking AuthenticationManager#onCreate() only on 
creation of authentication provider are addressed in revision 
http://svn.apache.org/r1475825 .)

> [Java Broker] Add ability to create/delete/update virtual host, 
> authentication provider, port via REST interfaces
> -
>
> Key: QPID-4596
> URL: https://issues.apache.org/jira/browse/QPID-4596
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: 0.22
>
> Attachments: 
> 0001-QPID-4596-Add-validation-and-ACL-checks-for-the-mana.patch, 
> 0001-QPID-4596-Invoke-onCreate-on-re-creation-of-authenti.patch, 
> 0002-WIP-Introduce-a-new-attribute-requiresSSL-for-authen.patch
>
>
> Add ability to create/delete/update the following configured objects:
> * virtual host
> * authentication provider
> * port

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4596) [Java Broker] Add ability to create/delete/update virtual host, authentication provider, port via REST interfaces

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-4596.
--

Resolution: Fixed

> [Java Broker] Add ability to create/delete/update virtual host, 
> authentication provider, port via REST interfaces
> -
>
> Key: QPID-4596
> URL: https://issues.apache.org/jira/browse/QPID-4596
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: 0.21
>
> Attachments: 
> 0001-QPID-4596-Add-validation-and-ACL-checks-for-the-mana.patch, 
> 0001-QPID-4596-Invoke-onCreate-on-re-creation-of-authenti.patch, 
> 0002-WIP-Introduce-a-new-attribute-requiresSSL-for-authen.patch
>
>
> Add ability to create/delete/update the following configured objects:
> * virtual host
> * authentication provider
> * port

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4596) [Java Broker] Add ability to create/delete/update virtual host, authentication provider, port via REST interfaces

[Alex Rudyy (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644377#comment-13644377
 ] 

Alex Rudyy commented on QPID-4596:
--

Robbie's comments about invoking AuthenticationManager#onCreate() only on 
creation of authentication provider are addressed in revision 
http://svn.apache.org/r1475825 .

> [Java Broker] Add ability to create/delete/update virtual host, 
> authentication provider, port via REST interfaces
> -
>
> Key: QPID-4596
> URL: https://issues.apache.org/jira/browse/QPID-4596
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: 0.21
>
> Attachments: 
> 0001-QPID-4596-Add-validation-and-ACL-checks-for-the-mana.patch, 
> 0001-QPID-4596-Invoke-onCreate-on-re-creation-of-authenti.patch, 
> 0002-WIP-Introduce-a-new-attribute-requiresSSL-for-authen.patch
>
>
> Add ability to create/delete/update the following configured objects:
> * virtual host
> * authentication provider
> * port

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4596) [Java Broker] Add ability to create/delete/update virtual host, authentication provider, port via REST interfaces

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644375#comment-13644375
 ] 

Robbie Gemmell commented on QPID-4596:
--

Alex made changes to the above efect in http://svn.apache.org/r1475825

> [Java Broker] Add ability to create/delete/update virtual host, 
> authentication provider, port via REST interfaces
> -
>
> Key: QPID-4596
> URL: https://issues.apache.org/jira/browse/QPID-4596
> Project: Qpid
>  Issue Type: Task
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: 0.21
>
> Attachments: 
> 0001-QPID-4596-Add-validation-and-ACL-checks-for-the-mana.patch, 
> 0001-QPID-4596-Invoke-onCreate-on-re-creation-of-authenti.patch, 
> 0002-WIP-Introduce-a-new-attribute-requiresSSL-for-authen.patch
>
>
> Add ability to create/delete/update the following configured objects:
> * virtual host
> * authentication provider
> * port

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org