DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35087>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35087 Summary: New DownloadAction adjusting buffer size Product: Struts Version: 1.2.6 Beta Platform: All OS/Version: other Status: NEW Severity: normal Priority: P3 Component: Standard Actions AssignedTo: dev@struts.apache.org ReportedBy: [EMAIL PROTECTED] A review of the new DownloadAction code seems to have the following problem: The getBufferSize method is defined: protected int getBufferSize() { return DEFAULT_BUFFER_SIZE; } But it does not appear to be used: byte[] buffer = new byte[DEFAULT_BUFFER_SIZE]; A search of the code does indicate the getBufferSize method is actually called anywhere, so overriding the method does not seem useful. (Minor nits aside, the DownloadAction is very helpful -- thanks!) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
