Re: [OMPI devel] RFC: Revamped topo framework
As an FYI on this RFC, the implementation of the new MPI-2.2 topology functions is taking a little longer than expected. Especially with the Forum meeting later this week and SC09 next week, it may be a little time before I completely finish it and commit it back to the trunk (I mention this because the RFC times out today). On Nov 4, 2009, at 9:13 PM, Jeff Squyres wrote: WHAT: Revamp the topo framework to be more consistent with the rest of the code base WHY: The code was ancient, inconsistent with the rest of the code base, and had some latent bugs. It would actually have been impossible to have a 2nd topo component. WHEN: Now WHERE: ompi/mca/topo/*, ompi/debuggers/*, ompi/communicator/*, ompi/ mpi/c TIMEOUT: COB Monday, 9 Nov 2009 As discussed a few days ago on this list, I revamped the OMPI topo framework to make it more modern / like all the other frameworks (it was written way back near the very beginning of this project and has barely been modified since). I fixed some latent bugs (which weren't evident because we only have the 1 topo component -- unity) and made the selection scheme much more consistent with the rest of the code base. The code can be found here: http://bitbucket.org/jsquyres/ompi-topo-fixes/ Attached is a patch against the SVN trunk, r22197. If no one has any objections / suggestions / comments, I plan to commit this work by COB next Monday, 9 Nov 2009. This RFC has a short timeout because I expect this to not be controversial and I already mentioned this on the list a few days ago. -- Jeff Squyres jsquy...@cisco.com -- Jeff Squyres jsquy...@cisco.com
[OMPI devel] opal_convertor / ompi_convertor
Hi, I was porting a 3rd party btl module that was originally written for openmpi 1.0.x to the current release. Now, even after some googling, I am a little confused about ompi_convertor and opal_convertor. The OLD code includes opal/datatype/convertor.h and calls several functions starting opal_convertor_...(). That header file didn't seem to exist in 1.3.3 though. The 1.3.3 btl_tcp code I referenced uses ompi_convertor. Thus I understood that at some point in history opal_convertor was obsoleted and replaced by ompi_convertor. It happened so that I overlooked a single occurence of opal_convertor_need_buffers() in my code. Although I thought I removed all headers related to opal_convertor the code actually compiled, and only failed during the linking stage (no such symbol). Now since I thought that rather strange (I thought maybe there was some obsolete header still astray or something), I checked with google. There I actually found a few rather current patches (e.g. http://www.open-mpi.org/community/lists/devel/2009/07/6457.php) that seem to suggest that actually ompi_datatype is obsoleted in favour of opal_datatype... Can anybody give me a small overview what's going on here? Greetings, Christian
Re: [OMPI devel] opal_convertor / ompi_convertor
Christian, I'm puzzled by your questions as I don't remember that at any past moment in the lifetime of Open MPI the convertor or datatype was in OPAL. So I don't see how your "OLD" code could have included "opal/ datatype/convertor.h". This only ended in the 1.3 series starting from 1.3.4. To your last question the short answer is: the obsolete one is the ompi_convertor. About two months ago, most of the datatype was moved from the OMPI layer into the OPAL one. When I say most this means everything not MPI specific was moved in OPAL, everything else was kept in OMPI. The convertor is MPI agnostic so it ended in OPAL. george. On Nov 9, 2009, at 16:33 , Christian Bendele wrote: Hi, I was porting a 3rd party btl module that was originally written for openmpi 1.0.x to the current release. Now, even after some googling, I am a little confused about ompi_convertor and opal_convertor. The OLD code includes opal/datatype/convertor.h and calls several functions starting opal_convertor_...(). That header file didn't seem to exist in 1.3.3 though. The 1.3.3 btl_tcp code I referenced uses ompi_convertor. Thus I understood that at some point in history opal_convertor was obsoleted and replaced by ompi_convertor. It happened so that I overlooked a single occurence of opal_convertor_need_buffers() in my code. Although I thought I removed all headers related to opal_convertor the code actually compiled, and only failed during the linking stage (no such symbol). Now since I thought that rather strange (I thought maybe there was some obsolete header still astray or something), I checked with google. There I actually found a few rather current patches (e.g. http://www.open-mpi.org/community/lists/devel/2009/07/6457.php ) that seem to suggest that actually ompi_datatype is obsoleted in favour of opal_datatype... Can anybody give me a small overview what's going on here? Greetings, Christian ___ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel
Re: [OMPI devel] opal_convertor / ompi_convertor
On Nov 9, 2009, at 10:56 AM, George Bosilca wrote: To your last question the short answer is: the obsolete one is the ompi_convertor. About two months ago, most of the datatype was moved from the OMPI layer into the OPAL one. When I say most this means everything not MPI specific was moved in OPAL, everything else was kept in OMPI. The convertor is MPI agnostic so it ended in OPAL. To be clear about this: if you're using the convertor from the MPI layer, you should probably be using ompi_convertor. ompi_convertor wasn't fully deprecated -- as George mentioned, a bunch of it just moved down to OPAL. If you're using the convertor from ORTE or OPAL, you should be using opal_convertor. -- Jeff Squyres jsquy...@cisco.com
Re: [OMPI devel] opal_convertor / ompi_convertor
On Nov 9, 2009, at 17:06 , Jeff Squyres wrote: To be clear about this: if you're using the convertor from the MPI layer, you should probably be using ompi_convertor. ompi_convertor wasn't fully deprecated -- as George mentioned, a bunch of it just moved down to OPAL. There is nothing such as ompi_convertor neither in the 1.3.4 or trunk. The convertor now only resides in the OPAL layer. george. If you're using the convertor from ORTE or OPAL, you should be using opal_convertor. -- Jeff Squyres jsquy...@cisco.com ___ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel
Re: [OMPI devel] opal_convertor / ompi_convertor
Doh! My bad -- I thought there was still an ompi_convertor_t... /me slinks off into the darkness On Nov 9, 2009, at 11:20 AM, George Bosilca wrote: On Nov 9, 2009, at 17:06 , Jeff Squyres wrote: > To be clear about this: if you're using the convertor from the MPI > layer, you should probably be using ompi_convertor. ompi_convertor > wasn't fully deprecated -- as George mentioned, a bunch of it just > moved down to OPAL. There is nothing such as ompi_convertor neither in the 1.3.4 or trunk. The convertor now only resides in the OPAL layer. george. > > If you're using the convertor from ORTE or OPAL, you should be using > opal_convertor. > > -- > Jeff Squyres > jsquy...@cisco.com > > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel ___ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel -- Jeff Squyres jsquy...@cisco.com
