Re: django_bash_completion in Pypi Package

[Shai Berger]

Hi Brett,

On Monday 06 January 2014 08:57:50 Brett Nekolny wrote:
> 
> I can't seem to get to django_bash_completion from a pypi package install
> 

You don't really need one. django-bash-completion has had one significant 
change in almost four years. To find the completions, it invokes your "working" 
Django copy (that is, Django from your current virtualenv or equivalent) -- 
so, essentially, you can install it once, manually, and forget about it.

Shai.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/201401061534.45750.shai%40platonix.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: django_bash_completion in Pypi Package

[Florian Apolloner]

On Monday, January 6, 2014 7:57:50 AM UTC+1, Brett Nekolny wrote:
>
> Please let me know if anyone has thoughts regarding this proposed diff. I 
> would love to be able to get django_bash_completion from my pypi install of 
> Django, but that just doesn't seem to be possible without this fix.
>

>From what I understand your patch would install the extras as 
python-package, which would clutter site-packages. That's not something we 
should do.

Cheers,
Florian 

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/e0d13a36-226c-4872-bde1-0be4b9a841c7%40googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

django_bash_completion in Pypi Package

[Brett Nekolny]

Hello!

I previously created a django 
ticket for 
an issue that I was having, but the developer asked me to post my question 
here for feedback and pending the result of the feedback further 
consideration on the proposed ticket and fix.

I can't seem to get to django_bash_completion from a pypi package install 
> of Django. I believe this is due to not including the package for "extras". 
> Additionally, if django_bash_completion was added as an explicit script, it 
> would be placed in the $VIRTUAL_ENV/bin/ folder for easier use.


As per the initial feedback from the developer, aaugustin, it might be 
disadvantageous to have multiple tab complete options in the 
$VIRTUAL_ENV/bin/ folder, so I've since removed django_bash_completion from 
the scripts portion of the package and the resulting diff is: 
https://gist.github.com/bnekolny/c7f7bf3c016695d6cbbd

diff --git a/setup.py b/setup.py
> index 11de0c1..a1d4042 100644
> --- a/setup.py
> +++ b/setup.py
> @@ -59,6 +59,9 @@ for dirpath, dirnames, filenames in os.walk(django_dir):
>  elif filenames:
>  data_files.append([dirpath, [os.path.join(dirpath, f) for f in 
> filenames]])
>  
> +# Adding the extras package so that we can get the django_bash_completion 
> script
> +packages.append('extras')
> +
>  # Small hack for working with bdist_wininst.
>  # See http://mail.python.org/pipermail/distutils-sig/2004-August/004134.html
>  if len(sys.argv) > 1 and sys.argv[1] == 'bdist_wininst':
>
>  

Please let me know if anyone has thoughts regarding this proposed diff. I 
would love to be able to get django_bash_completion from my pypi install of 
Django, but that just doesn't seem to be possible without this fix.

Thank you for any feedback!

Brett Nekolny

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/9025a61b-626d-40c9-915f-eda5e1981425%40googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.