Re: importing threading and dummy_threading

2015-01-28 Thread Tim Graham 
Done in https://github.com/django/django/pull/4003

On a related note, I am curious if anyone is running Django on a platform 
that lacks cPickle these days. We use this pattern in several places:

try:
from django.utils.six.moves import cPickle as pickle
except ImportError:
import pickle

On Wednesday, January 28, 2015 at 9:37:52 AM UTC-5, Marc Tamlyn wrote:
>
> Given that it already doesn't worth without full threading in the previous 
> LTS, I don't think we need to worry about it.
>
> On 28 January 2015 at 14:32, Tim Graham > 
> wrote:
>
>> Here's a 9 year old ticket referencing freebsd5.1...
>>
>> https://code.djangoproject.com/ticket/2052
>>
>>
>> On Wednesday, January 28, 2015 at 8:51:16 AM UTC-5, Tim Graham wrote:
>>>
>>> As far back as Django 1.4 (didn't check earlier), we use both these 
>>> patterns in the code:
>>>
>>> import threading
>>>
>>> try:
>>> import threading
>>> except ImportError:
>>> import dummy_threading as threading
>>>
>>> We also have logic in tests to skip if threading isn't available, 
>>> however, I can't believe that Django is usable without threading given we 
>>> use the first style of import (without a fallback) in many places 
>>> (db.models.loading, db.utils, test.testcases, + more).
>>>
>>> Docs say: 
>>>
>>> "The dummy_threading 
>>> 
>>>  
>>> module is provided for situations where threading 
>>>  
>>> cannot be used because thread 
>>>  is 
>>> missing."
>>> https://docs.python.org/2/library/threading.html
>>>
>>> "The [thread] module is optional. It is supported on Windows, Linux, SGI 
>>> IRIX, Solaris 2.x, as well as on systems that have a POSIX thread (a.k.a. 
>>> “pthread”) implementation."
>>> https://docs.python.org/2/library/thread.html#module-thread
>>>
>>> This doesn't answer the question of what systems it *is* needed on. 
>>> Unless there's an objection, I think we can remove dummy_threading 
>>> fallbacks?
>>>
>>  -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-develop...@googlegroups.com .
>> To post to this group, send email to django-d...@googlegroups.com 
>> .
>> Visit this group at http://groups.google.com/group/django-developers.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/2147f7e7-1251-42ff-81e2-ad3b453060a5%40googlegroups.com
>>  
>> 
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/50302f33-bb4d-4fe0-bb80-4e027e63d631%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: importing threading and dummy_threading

2015-01-28 Thread Marc Tamlyn 
Given that it already doesn't worth without full threading in the previous
LTS, I don't think we need to worry about it.

On 28 January 2015 at 14:32, Tim Graham  wrote:

> Here's a 9 year old ticket referencing freebsd5.1...
>
> https://code.djangoproject.com/ticket/2052
>
>
> On Wednesday, January 28, 2015 at 8:51:16 AM UTC-5, Tim Graham wrote:
>>
>> As far back as Django 1.4 (didn't check earlier), we use both these
>> patterns in the code:
>>
>> import threading
>>
>> try:
>> import threading
>> except ImportError:
>> import dummy_threading as threading
>>
>> We also have logic in tests to skip if threading isn't available,
>> however, I can't believe that Django is usable without threading given we
>> use the first style of import (without a fallback) in many places
>> (db.models.loading, db.utils, test.testcases, + more).
>>
>> Docs say:
>>
>> "The dummy_threading
>> 
>> module is provided for situations where threading
>> 
>> cannot be used because thread
>>  is
>> missing."
>> https://docs.python.org/2/library/threading.html
>>
>> "The [thread] module is optional. It is supported on Windows, Linux, SGI
>> IRIX, Solaris 2.x, as well as on systems that have a POSIX thread (a.k.a.
>> “pthread”) implementation."
>> https://docs.python.org/2/library/thread.html#module-thread
>>
>> This doesn't answer the question of what systems it *is* needed on.
>> Unless there's an objection, I think we can remove dummy_threading
>> fallbacks?
>>
>  --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at http://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/2147f7e7-1251-42ff-81e2-ad3b453060a5%40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMwjO1GiQaYb0_qc8xDat9mMW35xThogqfqynRwSFKfcRgTOPQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: importing threading and dummy_threading

2015-01-28 Thread Tim Graham 
Here's a 9 year old ticket referencing freebsd5.1...

https://code.djangoproject.com/ticket/2052

On Wednesday, January 28, 2015 at 8:51:16 AM UTC-5, Tim Graham wrote:
>
> As far back as Django 1.4 (didn't check earlier), we use both these 
> patterns in the code:
>
> import threading
>
> try:
> import threading
> except ImportError:
> import dummy_threading as threading
>
> We also have logic in tests to skip if threading isn't available, however, 
> I can't believe that Django is usable without threading given we use the 
> first style of import (without a fallback) in many places 
> (db.models.loading, db.utils, test.testcases, + more).
>
> Docs say: 
>
> "The dummy_threading 
> 
>  
> module is provided for situations where threading 
>  
> cannot be used because thread 
>  is missing."
> https://docs.python.org/2/library/threading.html
>
> "The [thread] module is optional. It is supported on Windows, Linux, SGI 
> IRIX, Solaris 2.x, as well as on systems that have a POSIX thread (a.k.a. 
> “pthread”) implementation."
> https://docs.python.org/2/library/thread.html#module-thread
>
> This doesn't answer the question of what systems it *is* needed on. Unless 
> there's an objection, I think we can remove dummy_threading fallbacks?
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/2147f7e7-1251-42ff-81e2-ad3b453060a5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

importing threading and dummy_threading

2015-01-28 Thread Tim Graham 
As far back as Django 1.4 (didn't check earlier), we use both these 
patterns in the code:

import threading

try:
import threading
except ImportError:
import dummy_threading as threading

We also have logic in tests to skip if threading isn't available, however, 
I can't believe that Django is usable without threading given we use the 
first style of import (without a fallback) in many places 
(db.models.loading, db.utils, test.testcases, + more).

Docs say: 

"The dummy_threading 
 
module is provided for situations where threading 
 cannot 
be used because thread 
 is missing."
https://docs.python.org/2/library/threading.html

"The [thread] module is optional. It is supported on Windows, Linux, SGI 
IRIX, Solaris 2.x, as well as on systems that have a POSIX thread (a.k.a. 
“pthread”) implementation."
https://docs.python.org/2/library/thread.html#module-thread

This doesn't answer the question of what systems it *is* needed on. Unless 
there's an objection, I think we can remove dummy_threading fallbacks?

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/08135f96-7429-4641-8a82-0cd47395ac09%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.