Re: [DNSOP] Lars Eggert's No Objection on draft-ietf-dnsop-alt-tld-23: (with COMMENT)

2023-04-26 Thread Warren Kumari
On Mon, Apr 24, 2023 at 10:11 AM, Lars Eggert  wrote:

> Lars Eggert has entered the following ballot position for
> draft-ietf-dnsop-alt-tld-23: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
> Please refer to https://www.ietf.org/about/groups/iesg/statements/
> handling-ballot-positions/ for more information about how to handle
> DISCUSS and COMMENT positions.
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-dnsop-alt-tld/
>
> --
> COMMENT:
> --
>
> # GEN AD review of draft-ietf-dnsop-alt-tld-23
>
> CC @larseggert
>
> Thanks to Behcet Sarikaya for the General Area Review Team (Gen-ART)
> review
> (https://mailarchive.ietf.org/arch/msg/gen-art/1LB6_ujGseyZRWPgTQZrP2pS8zk).
>
>
> ## Comments
>
> ### DOWNREFs
>
> DOWNREF `[RFC8244]` from this Proposed Standard to Informational
> `RFC8244`.
> (For IESG discussion. It seems this DOWNREF was not mentioned in the Last
> Call and also seems to not appear in the DOWNREF registry.)
>
> I think RFC8244 could be cited informatively?
>


It probably could be, but it does quite a lot feel like something very
useful for the readers to, erm, read…


> ## Nits
>
> All comments below are about very minor potential issues that you may
> choose to address in some way - or ignore - as you see fit. Some were
> flagged by automated tools (via https://github.com/larseggert/
> ietf-reviewtool), so there will likely be some false positives. There is
> no need to let me know what you did with these suggestions.
>
> ### Grammar/style
>
>  Section 2, paragraph 7
> ```
> performing aggressive use of DNSSEC- validated caches (described in
> [RFC8198
> ^
> ```
> This word seems to be formatted incorrectly. Consider fixing the spacing
> or removing the hyphen completely.
>


Thank you - it was a hidden space in the XML line break - fixed in PR.


>  Section 2, paragraph 8
> ```
> will cover all names under .alt. Currently deployed projects and protocols
> t
> ^
> ```
> A comma may be missing after the conjunctive/linking adverb "Currently".
>


I disagree on this one - we are discussing currently deployed projects, not
describing how things currently are.


>  Section 7.1, paragraph 2
> ```
> and P. Hoffman, "DNS Query Name Minimisation to Improve Privacy", RFC
> 9156,
> 
> ```
> Do not mix variants of the same word ("minimisation" and "minimization")
> within a single text.
>

This is an UK vs US spelling difference, but seeing as the RFC uses the 's'
form I've updated it in the editors copy / Pull Request.

Thank you,
W


> ## Notes
>
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use
> the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
>
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments
> [IRT]: https://github.com/larseggert/ietf-reviewtool
>
___
DNSOP mailing list
DNSOP@ietf.org
https://www.ietf.org/mailman/listinfo/dnsop


[DNSOP] Lars Eggert's No Objection on draft-ietf-dnsop-alt-tld-23: (with COMMENT)

2023-04-24 Thread Lars Eggert via Datatracker
Lars Eggert has entered the following ballot position for
draft-ietf-dnsop-alt-tld-23: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to 
https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-dnsop-alt-tld/



--
COMMENT:
--


# GEN AD review of draft-ietf-dnsop-alt-tld-23

CC @larseggert

Thanks to Behcet Sarikaya for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/1LB6_ujGseyZRWPgTQZrP2pS8zk).

## Comments

### DOWNREFs

DOWNREF `[RFC8244]` from this Proposed Standard to Informational `RFC8244`.
(For IESG discussion. It seems this DOWNREF was not mentioned in the Last Call
and also seems to not appear in the DOWNREF registry.)

I think RFC8244 could be cited informatively?

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Grammar/style

 Section 2, paragraph 7
```
 performing aggressive use of DNSSEC- validated caches (described in [RFC8198
  ^
```
This word seems to be formatted incorrectly. Consider fixing the spacing or
removing the hyphen completely.

 Section 2, paragraph 8
```
will cover all names under .alt. Currently deployed projects and protocols t
 ^
```
A comma may be missing after the conjunctive/linking adverb "Currently".

 Section 7.1, paragraph 2
```
and P. Hoffman, "DNS Query Name Minimisation to Improve Privacy", RFC 9156,

```
Do not mix variants of the same word ("minimisation" and "minimization") within
a single text.

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool



___
DNSOP mailing list
DNSOP@ietf.org
https://www.ietf.org/mailman/listinfo/dnsop