[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[kuba at et dot pl]

--- Comment #8 from kuba at et dot pl  2007-01-28 00:02 ---
Subject: Re:  incorrect warning when using
firstprivate and lastprivate clauses

I realised that maybe is just better to set
TREE_NO_WARNING (fd->v) = 1;
instead of set it (fd->v) to 0.
We are sure that fd->v won't be read before is set, so there is no need
to add one more instruction.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[jakub at gcc dot gnu dot org]

--- Comment #7 from jakub at gcc dot gnu dot org  2007-01-26 23:46 ---
Fixed in SVN.


-- 

jakub at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[jakub at gcc dot gnu dot org]

--- Comment #6 from jakub at gcc dot gnu dot org  2007-01-24 21:02 ---
Subject: Bug 30421

Author: jakub
Date: Wed Jan 24 21:01:37 2007
New Revision: 121134

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121134
Log:
PR middle-end/30421
* omp-low.c (lower_omp_for_lastprivate): Add dlist argument.
If lower_lastprivate_clauses emits some statements, append them
to dlist rather than body_p and to body_p append an initializer.
(lower_omp_for): Adjust caller.

* gcc.dg/gomp/pr30421.c: New test.

Added:
branches/gcc-4_2-branch/gcc/testsuite/gcc.dg/gomp/pr30421.c
Modified:
branches/gcc-4_2-branch/gcc/ChangeLog
branches/gcc-4_2-branch/gcc/omp-low.c
branches/gcc-4_2-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[jakub at gcc dot gnu dot org]

--- Comment #5 from jakub at gcc dot gnu dot org  2007-01-24 20:53 ---
Subject: Bug 30421

Author: jakub
Date: Wed Jan 24 20:53:08 2007
New Revision: 121131

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121131
Log:
PR middle-end/30421
* omp-low.c (lower_omp_for_lastprivate): Add dlist argument.
If lower_lastprivate_clauses emits some statements, append them
to dlist rather than body_p and to body_p append an initializer.
(lower_omp_for): Adjust caller.

* gcc.dg/gomp/pr30421.c: New test.

Added:
trunk/gcc/testsuite/gcc.dg/gomp/pr30421.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/omp-low.c
trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[jakub at gcc dot gnu dot org]

--- Comment #4 from jakub at gcc dot gnu dot org  2007-01-18 18:23 ---
Testing a fix.


-- 

jakub at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
   |dot org |
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2007-01-18 18:23:03
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[manu at gcc dot gnu dot org]

--- Comment #3 from manu at gcc dot gnu dot org  2007-01-15 08:55 ---
Thanks for your patch but if you want it to be reviewed, it is better to send
it to [EMAIL PROTECTED] .


-- 

manu at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[kuba at et dot pl]

--- Comment #2 from kuba at et dot pl  2007-01-10 03:08 ---
Ok, I've found that my patch doesn't work when we also you schedule clause :>
I'll try to correct that, but I would like to know if my first patch is
correct.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

   Severity|minor   |normal
   Keywords||diagnostic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421

[Bug middle-end/30421] incorrect warning when using firstprivate and lastprivate clauses

[kuba at et dot pl]

--- Comment #1 from kuba at et dot pl  2007-01-10 02:49 ---
Created an attachment (id=12877)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12877&action=view)
in 'expand_omp_for_static_nochunk'  iterator is set before first condition.

This is my first patch for GCC. Please be lenient :)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30421