Re: [PATCH 6/6] [DJGPP] configure.ac: enable LTO
On 01/09/2016 01:29 AM, Jeff Law wrote: On 12/21/2015 11:22 PM, Andris Pavenis wrote: 12/21/2015, 10:00 PM, Jeff Law kirjoitti: On 12/17/2015 10:51 PM, Andris Pavenis wrote: On 12/13/2015 08:12 PM, DJ Delorie wrote: You can list me as your sponsor. I've been wanting him to be a djgpp target/host maintainer for years anyway, so +1 from me :-) Approved part of patches are in (except 6th which I commit after 5th) In middle come a problem with mailing list (collected outgoing patches in a batch and did not notice that I had written wrong address). Noticed it only after sending when it was too late. Is there anything in this series that still needs review? Well. I understood that new version of patch could require new approving. I comments about 5th patch which I took into account in new patch version or responded. There were however no "OK for trunk" or equivalent. Sorry if I'm too pedantic No worries. We're always happy when folks are conservative, particularly when they're just getting engaged with the community. Can you post the updated #5 patch. DJ or I will give it a final yes/no so that you can move forward. It was actually already sent a month ago with comments corresponding review notices:: https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01328.html Andris
Re: [PATCH 6/6] [DJGPP] configure.ac: enable LTO
> You can list me as your sponsor. I've been wanting him to be a djgpp target/host maintainer for years anyway, so +1 from me :-)
Re: [PATCH 6/6] [DJGPP] configure.ac: enable LTO
On 12/12/2015 09:40 AM, Andris Pavenis wrote: On 12/11/2015 12:32 AM, Jeff Law wrote: On 12/05/2015 10:25 AM, Andris Pavenis wrote: Patch enables LTO support for DJGPP in top level configure.ac Andris 2015-12-05 Andris Pavenis * configure.ac: enable LTO for *-*-msdosdjgpp OK once prereqs have gone in. Note you should to the autoconf dance to update the generated files. Mention them in your ChangeLog as * configure: Regenerated jeff Updated patch is in attachment. Andris PS. Somebody other should apply this and my other DJGPP related patches as I do not have SVN write access. I think the better solution is to get you write access :-) https://gcc.gnu.org/svnwrite.html You can list me as your sponsor. Cheers, Jeff
Re: [PATCH 6/6] [DJGPP] configure.ac: enable LTO
On 12/11/2015 12:32 AM, Jeff Law wrote: On 12/05/2015 10:25 AM, Andris Pavenis wrote: Patch enables LTO support for DJGPP in top level configure.ac Andris 2015-12-05 Andris Pavenis * configure.ac: enable LTO for *-*-msdosdjgpp OK once prereqs have gone in. Note you should to the autoconf dance to update the generated files. Mention them in your ChangeLog as * configure: Regenerated jeff Updated patch is in attachment. Andris PS. Somebody other should apply this and my other DJGPP related patches as I do not have SVN write access. 2015-12-05 Andris Pavenis * configure.ac: Enable LTO for *-*-msdosdjgpp. * configure: Regenerate. >From d001fa0866e6bf1f4b879329841f7674f0e90eab Mon Sep 17 00:00:00 2001 From: Andris Pavenis Date: Sat, 12 Dec 2015 10:15:42 +0200 Subject: [PATCH 6/6] [DJGPP] configure.ac: enable LTO --- configure| 4 ++-- configure.ac | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 090615f..0cde5a2 100755 --- a/configure +++ b/configure @@ -6122,7 +6122,7 @@ if test $target_elf = yes; then : else if test x"$default_enable_lto" = x"yes" ; then case $target in - *-apple-darwin9* | *-cygwin* | *-mingw*) ;; + *-apple-darwin9* | *-cygwin* | *-mingw* | *djgpp*) ;; # On other non-ELF platforms, LTO has yet to be validated. *) enable_lto=no ;; esac @@ -6133,7 +6133,7 @@ else # warn during gcc/ subconfigure; unless you're bootstrapping with # -flto it won't be needed until after installation anyway. case $target in - *-cygwin* | *-mingw* | *-apple-darwin*) ;; + *-cygwin* | *-mingw* | *-apple-darwin* | *djgpp*) ;; *) if test x"$enable_lto" = x"yes"; then as_fn_error "LTO support is not enabled for this target." "$LINENO" 5 fi diff --git a/configure.ac b/configure.ac index a6998ff..ee4fd23 100644 --- a/configure.ac +++ b/configure.ac @@ -1817,7 +1817,7 @@ ACX_ELF_TARGET_IFELSE([# ELF platforms build the lto-plugin always. build_lto_plugin=yes ],[if test x"$default_enable_lto" = x"yes" ; then case $target in - *-apple-darwin9* | *-cygwin* | *-mingw*) ;; + *-apple-darwin9* | *-cygwin* | *-mingw* | *djgpp*) ;; # On other non-ELF platforms, LTO has yet to be validated. *) enable_lto=no ;; esac @@ -1828,7 +1828,7 @@ ACX_ELF_TARGET_IFELSE([# ELF platforms build the lto-plugin always. # warn during gcc/ subconfigure; unless you're bootstrapping with # -flto it won't be needed until after installation anyway. case $target in - *-cygwin* | *-mingw* | *-apple-darwin*) ;; + *-cygwin* | *-mingw* | *-apple-darwin* | *djgpp*) ;; *) if test x"$enable_lto" = x"yes"; then AC_MSG_ERROR([LTO support is not enabled for this target.]) fi -- 2.5.0
Re: [PATCH 6/6] [DJGPP] configure.ac: enable LTO
On 12/05/2015 10:25 AM, Andris Pavenis wrote: Patch enables LTO support for DJGPP in top level configure.ac Andris 2015-12-05 Andris Pavenis * configure.ac: enable LTO for *-*-msdosdjgpp OK once prereqs have gone in. Note you should to the autoconf dance to update the generated files. Mention them in your ChangeLog as * configure: Regenerated jeff
[PATCH 6/6] [DJGPP] configure.ac: enable LTO
Patch enables LTO support for DJGPP in top level configure.ac Andris 2015-12-05 Andris Pavenis * configure.ac: enable LTO for *-*-msdosdjgpp >From 9df385353dd1f6c275e0ce9266ab4bbb3a80cd44 Mon Sep 17 00:00:00 2001 From: Andris Pavenis Date: Sat, 14 Nov 2015 20:38:32 +0200 Subject: [PATCH 6/6] [DJGPP] configure.ac: enable LTO --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index a6998ff..ee4fd23 100644 --- a/configure.ac +++ b/configure.ac @@ -1817,7 +1817,7 @@ ACX_ELF_TARGET_IFELSE([# ELF platforms build the lto-plugin always. build_lto_plugin=yes ],[if test x"$default_enable_lto" = x"yes" ; then case $target in - *-apple-darwin9* | *-cygwin* | *-mingw*) ;; + *-apple-darwin9* | *-cygwin* | *-mingw* | *djgpp*) ;; # On other non-ELF platforms, LTO has yet to be validated. *) enable_lto=no ;; esac @@ -1828,7 +1828,7 @@ ACX_ELF_TARGET_IFELSE([# ELF platforms build the lto-plugin always. # warn during gcc/ subconfigure; unless you're bootstrapping with # -flto it won't be needed until after installation anyway. case $target in - *-cygwin* | *-mingw* | *-apple-darwin*) ;; + *-cygwin* | *-mingw* | *-apple-darwin* | *djgpp*) ;; *) if test x"$enable_lto" = x"yes"; then AC_MSG_ERROR([LTO support is not enabled for this target.]) fi -- 2.4.3
