Re: gEDA-user: Open Collector Error Checking
Bert Timmerman: ... > Peter Clifton: > > On Mon, 2011-02-14 at 13:31 -0800, Jared Casper wrote: > > > > > Maybe make an "official" LP tag of "vetted" or something that "junior" > > > developers can add to a patch, allowing a senior dev to concentrate on > > > those first, not spending on time on patches that need work. > > Sounds like a good idea - call it "patch-tested" or something? > > > > We should probably set up a team as a place-holder to get > > assigned as a job-list for patches which are ready to be pushed. > > Maybe add a LP user "geda-push" and/or "pcb-push" (or "geda-dev" and/or > "pcb-dev"), and assign to this user. What about "bug-squad", and then we might need a "bug-meister" for coordination (and only the bug-meister would need commit permisson). I can participate in the sense that you can send me a bug to investigate, and I'll look into that. I'd nominate Kai-Martin as bug-meister if he is willing. Regards, /Karl Hammar --- Aspö Data Lilla Aspö 148 S-742 94 Östhammar Sweden +46 173 140 57 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Kai-Martin: ... > There should probably be more active core developers in the first > place. What is the process to become one? Who are candidates? I'm interested in be able to have sub-layouts, removing the distinction between footprint/pcb and sym/sch files, and removing annoying small things that comes in my way, mostly backend things. I migth be interested in working with the lesstiff hid. Regards, /Karl Hammar --- Aspö Data Lilla Aspö 148 S-742 94 Östhammar Sweden +46 173 140 57 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Hi Peter, > -Original Message- > From: geda-user-boun...@moria.seul.org > [mailto:geda-user-boun...@moria.seul.org] On Behalf Of Peter Clifton > Sent: Monday, February 14, 2011 10:34 PM > To: gEDA user mailing list > Subject: Re: gEDA-user: Open Collector Error Checking > > On Mon, 2011-02-14 at 13:31 -0800, Jared Casper wrote: > > > Maybe make an "official" LP tag of "vetted" or something > that "junior" > > developers can add to a patch, allowing a senior dev to > concentrate on > > those first, not spending on time on patches that need work. > > Sounds like a good idea - call it "patch-tested" or something? > > We should probably set up a team as a place-holder to get > assigned as a job-list for patches which are ready to be pushed. > > -- > Peter Clifton > > Electrical Engineering Division, > Engineering Department, > University of Cambridge, > 9, JJ Thomson Avenue, > Cambridge > CB3 0FA > > Tel: +44 (0)7729 980173 - (No signal in the lab!) > Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) > Maybe add a LP user "geda-push" and/or "pcb-push" (or "geda-dev" and/or "pcb-dev"), and assign to this user. Just my EUR 0.02 Kind regards, Bert Timmerman ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Peter Clifton wrote: >> Maybe make an "official" LP tag of "vetted" or something that "junior" >> developers can add to a patch, allowing a senior dev to concentrate on >> those first, not spending on time on patches that need work. > > Sounds like a good idea - call it "patch-tested" or something? > > We should probably set up a team as a place-holder to get assigned as a > job-list for patches which are ready to be pushed. There should probably be more active core developers in the first place. What is the process to become one? Who are candidates? ---<)kaimartin(>--- -- Kai-Martin Knaak Email: k...@familieknaak.de Öffentlicher PGP-Schlüssel: http://pool.sks-keyservers.net:11371/pks/lookup?search=0x6C0B9F53 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Karl Hammar wrote: > I understand the hint etc., but we should have one or more person > that could actually *commit* thoose simple fixes, ack. Patches are the result of non-trivial efforts. The contributers deserve some attention. Even a short note, that the patch will not applied is way better than let the patch rot until forever and a day. IMHO, this kind of ignorance is a sure way to drive away potential developers. See bug 699454 by Ineiev: https://bugs.launchpad.net/pcb/+bug/699454 The patch was filed in October 2008. danmc asked for some clarification in November. Ineiev responded in December and updated the patch. In February somebody not logged in suggested to split the patch into smaller blobs. Ineiev resonded the next day and provided a series of patches two weeks later in March 2009. Then nothing until today. > either at the official or a seperate site. I could possible set > up a git repo for thoose simple fixes. Do anyone want to join? Not another semi fork, please. It is already a pain to have the OpenGL only in Peter Cliftons version. ---<)kaimartin(>--- -- Kai-Martin Knaak Email: k...@familieknaak.de Öffentlicher PGP-Schlüssel: http://pool.sks-keyservers.net:11371/pks/lookup?search=0x6C0B9F53 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
On Mon, 2011-02-14 at 13:31 -0800, Jared Casper wrote: > Maybe make an "official" LP tag of "vetted" or something that "junior" > developers can add to a patch, allowing a senior dev to concentrate on > those first, not spending on time on patches that need work. Sounds like a good idea - call it "patch-tested" or something? We should probably set up a team as a place-holder to get assigned as a job-list for patches which are ready to be pushed. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) signature.asc Description: This is a digitally signed message part ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
2011/2/14 DJ Delorie : > A separate git repo would make it harder for me to review patches. > I'm much more interested in the history and discussion of the patch, > than in the actual patch itself, and if there's anything wrong with > the patch, LP/SF is a better way to manage those issues than git. > github's pull request/code review system works pretty well for discussing a patch (https://github.com/features/projects/codereview). I also like the way Google Project hosting does code reviews, especially the voting system. I'm not sure if github has something similar. Thought I'd throw that out there, even though we should probably just stick to LP for everything since we just moved over to it. (Although I'm still unclear how to differentiate bugs and patches in the LP tracker) I think maybe what Karl was getting at was a group of "Junior" devs that commit to a repo to indicate they have looked at and agree with the patch. The senior dev, if he trusts the junior dev's judgement, issues a few git commands and the patch is in. Perhaps now that we are on LP, the ideas in this thread are more realizable: http://www.seul.org/pipermail/geda-user/2010-March/045968.html Maybe make an "official" LP tag of "vetted" or something that "junior" developers can add to a patch, allowing a senior dev to concentrate on those first, not spending on time on patches that need work. Jared ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
> In what way a git repo would be better than separate patches? A separate git repo would make it harder for me to review patches. I'm much more interested in the history and discussion of the patch, than in the actual patch itself, and if there's anything wrong with the patch, LP/SF is a better way to manage those issues than git. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
On Mon, Feb 14, 2011 at 02:39:38PM +0100, Karl Hammar wrote: > > To change this habit, was one of the motivations for the with the > > switch from sourceforge to launchpad (hint, hint...) > > At least patches can be more easily retrieved on the trackers. > > I understand the hint etc., but we should have one or more person > that could actually *commit* thoose simple fixes, either at the > official or a seperate site. I could possible set up a git repo for > thoose simple fixes. Do anyone want to join? In what way a git repo would be better than separate patches? For testing? Each separate set of changes would still have to be reviewed, and I suppose that (together with the discussion/suggestion of improvements) constitutes the main effort for accepting changes to the main source tree. -- Krzysztof Kościuszkiewicz "Simplicity is the ultimate sophistication" -- Leonardo da Vinci ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
> At least patches can be more easily retrieved on the trackers. When I have time to work on PCB (rare though that is), usually the FIRST thing I do is go through the patches in the tracker and apply whatever I can. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Kai-Martin: > Karl Hammar wrote: > > The patches of (numslots=0 thing, oc/oe drc2): ... > > are so small and obvious. Do we really need the overhead of a bug > > tracker for them? > Well, developers of geda and/or pcb, those with write access to the > source, tend to ignore patches on the mailing list. That said, patches > on the tracker have been on hold indefinitely in the past, too. One dev have said [1] we should nag them about theese patches. > To change this habit, was one of the motivations for the with the > switch from sourceforge to launchpad (hint, hint...) > At least patches can be more easily retrieved on the trackers. I understand the hint etc., but we should have one or more person that could actually *commit* thoose simple fixes, either at the official or a seperate site. I could possible set up a git repo for thoose simple fixes. Do anyone want to join? Regards, /Karl Hammar [1] http://www.seul.org/pipermail/geda-user/2009-October/021044.html --- Aspö Data Lilla Aspö 148 S-742 94 Östhammar Sweden +46 173 140 57 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Karl Hammar wrote: > The patches of (numslots=0 thing, oc/oe drc2): > > http://www.seul.org/pipermail/geda-user/2010-September/049354.html > http://www.seul.org/pipermail/geda-user/2011-February/052384.html > > are so small and obvious. Do we really need the overhead of a bug > tracker for them? Well, developers of geda and/or pcb, those with write access to the source, tend to ignore patches on the mailing list. That said, patches on the tracker have been on hold indefinitely in the past, too. To change this habit, was one of the motivations for the with the switch from sourceforge to launchpad (hint, hint...) At least patches can be more easily retrieved on the trackers. ---<)kaimartin(>--- -- Kai-Martin Knaak Email: k...@familieknaak.de Öffentlicher PGP-Schlüssel: http://pool.sks-keyservers.net:11371/pks/lookup?search=0x6C0B9F53 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Krzysztof: > On Fri, Feb 11, 2011 at 08:38:47AM +0100, Karl Hammar wrote: ... > > Attached patch corrects that. > Can you file the patch on the tracker so it isn't forgotten? > http://bugs.launchpad.net/geda/+filebug The patches of (numslots=0 thing, oc/oe drc2): http://www.seul.org/pipermail/geda-user/2010-September/049354.html http://www.seul.org/pipermail/geda-user/2011-February/052384.html are so small and obvious. Do we really need the overhead of a bug tracker for them? But I wouldn't mind if you upload them. Regards, /Karl Hammar --- Aspö Data Lilla Aspö 148 S-742 94 Östhammar Sweden +46 173 140 57 ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
On Fri, Feb 11, 2011 at 08:38:47AM +0100, Karl Hammar wrote: > > ERROR: Pin(s) with pintype 'open collector': U70:2 U70:4 > > are connected by net 'unnamed_net204' > > to pin(s) with pintype 'open collector': U70:2 U70:4 > ... > > Attached patch corrects that. Can you file the patch on the tracker so it isn't forgotten? http://bugs.launchpad.net/geda/+filebug ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
Oliver: ... > ERROR: Pin(s) with pintype 'open collector': U70:2 U70:4 > are connected by net 'unnamed_net204' > to pin(s) with pintype 'open collector': U70:2 U70:4 ... Attached patch corrects that. Regards, /Karl Hammar --- Aspö Data Lilla Aspö 148 S-742 94 Östhammar Sweden +46 173 140 57 diff --git a/gnetlist/scheme/gnet-drc2.scm b/gnetlist/scheme/gnet-drc2.scm index 380f588..281c454 100644 --- a/gnetlist/scheme/gnet-drc2.scm +++ b/gnetlist/scheme/gnet-drc2.scm @@ -145,9 +145,9 @@ ;;;io ;; '(#\c #\c #\w #\c) ;;;oc -;; '(#\c #\c #\e #\w #\e) +;; '(#\c #\c #\e #\w #\c) ;;;oe -;; '(#\c #\c #\e #\w #\c #\e) +;; '(#\c #\c #\e #\w #\e #\c) ;;;pas ;; '(#\c #\c #\c #\c #\c #\c #\c) ;;;tp ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
On Thu, 10 Feb 2011 16:47:39 -0700 John Doty wrote: > > On Feb 10, 2011, at 4:40 PM, Oliver King-Smith wrote: > > > I am getting this error when I run the DRC2 > > ERROR: Pin(s) with pintype 'open collector': U70:2 U70:4 > > are connected by net 'unnamed_net204' > > to pin(s) with pintype 'open collector': U70:2 U70:4 > > The above statement is absolutely correct, these two pins are > > both open collector, and indeed they are wire together. But why > > would I want to report this as an error? Isn't part of the idea > > behind open_collector outputs the concept of wiring them together? > > Oliver, drc2 is a deeply flawed program. It reports many, many > perfectly reasonable things as errors. That doesn't make it useless: > by sifting through all the crud you'll find real problems. But assume > that most warnings it emits are wrong. I agree with Oliver that the essence of open collector signals is to in fact allow multiple drivers of the line to share it! Thus this drc message is particularly annoying. However, I do find running the gnetlist drc useful to find bonehead errors like forgetting to connect a certain "input port" symbol to the corresponding "output port" symbol, or typos in the net names of such symbols, etc. It's too bad that it has so many flaws, I guess, since it has the potential of being a very powerful tool. Regards, Colin ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Open Collector Error Checking
On Feb 10, 2011, at 4:40 PM, Oliver King-Smith wrote: > I am getting this error when I run the DRC2 > ERROR: Pin(s) with pintype 'open collector': U70:2 U70:4 > are connected by net 'unnamed_net204' > to pin(s) with pintype 'open collector': U70:2 U70:4 > The above statement is absolutely correct, these two pins are both open > collector, and indeed they are wire together. But why would I want to > report this as an error? Isn't part of the idea behind open_collector > outputs the concept of wiring them together? Oliver, drc2 is a deeply flawed program. It reports many, many perfectly reasonable things as errors. That doesn't make it useless: by sifting through all the crud you'll find real problems. But assume that most warnings it emits are wrong. John Doty Noqsi Aerospace, Ltd. http://www.noqsi.com/ j...@noqsi.com ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
