Re: [GNC-dev] Gnucash 3.7 released

2019-09-09 Thread Frank H. Ellenberger 
Hi,

Am Mo., 9. Sept. 2019 um 17:52 Uhr schrieb John Ralls :
> > On Sep 9, 2019, at 8:30 AM, Benno Schulenberg 
> >  wrote:
> >
> >
> > Hello John,
> >
> >> Tarball at 
> >> https://github.com/Gnucash/gnucash/releases/download/3.7/gnucash-3.7.tar.bz2
> > The POT file (and therefore probably the source) still contains three
> > translator hints like this:
> >
> >  #. Translators: This string has a disambiguation prefix [...]
> >
> > B
>
> Benno,
>
> So it does, and I think we can remove the comments as the code now uses the 
> Q_ macro to generate a separate msgctxt and msgid in the potfile, making it 
> obvious. The one comment about translating only the bit after the '|' is 
> wrong as the Q_ macro strips out the '|'.
>
> Regards,
> John Ralls

fixed in commit fa4fc55.
Thanks for heads up!

Frank
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] Gnucash 3.7 released

2019-09-09 Thread John Ralls 



> On Sep 9, 2019, at 8:30 AM, Benno Schulenberg 
>  wrote:
> 
> 
> Hello John,
> 
>> Tarball at 
>> https://github.com/Gnucash/gnucash/releases/download/3.7/gnucash-3.7.tar.bz2
> The POT file (and therefore probably the source) still contains three
> translator hints like this:
> 
>  #. Translators: This string has a disambiguation prefix [...]
> 
> B

Benno,

So it does, and I think we can remove the comments as the code now uses the Q_ 
macro to generate a separate msgctxt and msgid in the potfile, making it 
obvious. The one comment about translating only the bit after the '|' is wrong 
as the Q_ macro strips out the '|'.

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel