Re: [classlib] Build failure messages

[Nathan Beyer]

I looked at adding the nowarn arg for the tests, but 'build-test.xml'
doesn't have a single large compile statement like 'buid-java.xml'
does. The arg would need to be added to the compile-test of every
module's build, which can be done, I was just feeling lazy at the
moment, sorry. :( Also, I had the thought of creating a compile
indirection in the build scripts using an Ant macro. This way any
global compiler tweaks could be performed in the macro. I haven't
convinced myself of the value of that though.

-Nathan

On 10/20/06, Paulex Yang <[EMAIL PROTECTED]> wrote:

Nathan Beyer wrote:
> I added a compiler arg to the main 'build-java.xml' compile to disable
> all of the warnings.
Thanks a lot, Nathan, but how about also add that arg to build-test.xml?
I think the ECJ probably feels more unhappy with the test cases:).
>
> This should take care of the warnings.
>
> -Nathan
>
> On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
>> Can we just shut them off for now?  it's a good project for someone to
>> go and clean those up, but there's no need for all of us to see them.
>>
>> geir
>>
>> Mark Hindess wrote:
>> > These messages aren't getting through on the commits list on due to
>> the
>> > large number of warnings since switching to ecj.  I've modified the
>> > summary process so that it ignores these for the moment.
>> >
>> > Hopefully this means that the failure messages that haven't been
>> making
>> > the commits list will start getting through.
>> >
>> > Regards,
>> >  Mark.
>> >
>> >
>> >
>> >
>> > -
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > For additional commands, e-mail: [EMAIL PROTECTED]
>> >
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


--
Paulex Yang
China Software Development Lab
IBM



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Paulex Yang]

Nathan Beyer wrote:

I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.
Thanks a lot, Nathan, but how about also add that arg to build-test.xml? 
I think the ECJ probably feels more unhappy with the test cases:).


This should take care of the warnings.

-Nathan

On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:

Can we just shut them off for now?  it's a good project for someone to
go and clean those up, but there's no need for all of us to see them.

geir

Mark Hindess wrote:
> These messages aren't getting through on the commits list on due to 
the

> large number of warnings since switching to ecj.  I've modified the
> summary process so that it ignores these for the moment.
>
> Hopefully this means that the failure messages that haven't been 
making

> the commits list will start getting through.
>
> Regards,
>  Mark.
>
>
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Paulex Yang
China Software Development Lab
IBM



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Denis Kishenko]

Added patch for SUID wanings to the same issue.H-1926

2006/10/20, Tim Ellison <[EMAIL PROTECTED]>:

Denis Kishenko wrote:
> Almost all unused variables are local. Only two of them are class
> fields and they are not using in native code. Build and all tests are
> successful.

Thanks Denis!

Regards,
Tim

--

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Denis M. Kishenko
Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Tim Ellison]

Denis Kishenko wrote:
> Almost all unused variables are local. Only two of them are class
> fields and they are not using in native code. Build and all tests are
> successful.

Thanks Denis!

Regards,
Tim

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Denis Kishenko]

Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.

2006/10/20, Tim Ellison <[EMAIL PROTECTED]>:

Denis Kishenko wrote:
> I have made fix[1]  for "unused" category (only java code). If nobody
> has objections I could fix other caterogies.
>
> [1] http://issues.apache.org/jira/browse/HARMONY-1926

See Nathan's comments about unused vars -- they cannot be fixed safely
with the Java wizard.  Unused imports should be ok to fix that way.

Regards,
Tim

--

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Denis M. Kishenko
Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Ilya Okomin]

On 10/20/06, Tim Ellison <[EMAIL PROTECTED]> wrote:


Denis Kishenko wrote:
> I have made fix[1]  for "unused" category (only java code). If nobody
> has objections I could fix other caterogies.
>
> [1] http://issues.apache.org/jira/browse/HARMONY-1926

See Nathan's comments about unused vars -- they cannot be fixed safely
with the Java wizard.  Unused imports should be ok to fix that way.



I see one step to be added to the unused vars removing: to check if 'unused
var' is unused in the native code:)
However I think it is related only for unused fields, local variables from
subroutines and methods can be deleted without any checks.

Regards,
Ilya.

Regards,

Tim

--

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
--
Ilya Okomin
Intel Middleware Products Division

Re: [classlib] Build failure messages

[Tim Ellison]

Denis Kishenko wrote:
> I have made fix[1]  for "unused" category (only java code). If nobody
> has objections I could fix other caterogies.
> 
> [1] http://issues.apache.org/jira/browse/HARMONY-1926

See Nathan's comments about unused vars -- they cannot be fixed safely
with the Java wizard.  Unused imports should be ok to fix that way.

Regards,
Tim

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Tim Ellison]

Nathan Beyer wrote:
> * unused - unused private fields, methods; these are tough as some of
> them are seemingly used by native code

yes, as you say some of these slots are used by native code to stash
state; and some are there for serialization compatibility even though
our impl doesn't use them.

Each case will have to be determined (and documented in the code!) then
neutralized with the suppress warnings annotation.

Regards,
Tim

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Denis Kishenko]

I have made fix[1]  for "unused" category (only java code). If nobody
has objections I could fix other caterogies.

[1] http://issues.apache.org/jira/browse/HARMONY-1926

2006/10/20, Nathan Beyer <[EMAIL PROTECTED]>:

I've been trying to work through many of the warnings, module by
module. Most of the warnings fall into the following categories.
* serial - Serializable classes that don't have explicit serialVersionUID fields
* unchecked - missing type variables, mostly collection references
* unused - unused private fields, methods; these are tough as some of
them are seemingly used by native code
* missing @Override - methods that override other methods are
annotated for safety

-Nathan

On 10/19/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> Nathan has turned off all warnings.  I suggest that we start to turn
> them back on incrementally and fix the warnings we see.
>
> Regards,
> Tim
>
> Denis Kishenko wrote:
> > I also worried about a lot of warnings and I think warnings like these
> > can be fixed
> >
> > 
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
> >
> >[javac]  (at line 26)
> >[javac] import java.io.ObjectInputStream;
> >[javac]^
> >[javac] The import java.io.ObjectInputStream is never used
> >
> >[javac] 34. WARNING in
> > 
C:\Work\Projects\Harmony-last\modules\concurrent\standard\src\main\java\java\util\concurrent\CountDownLatch.java
> >
> >[javac]  (at line 130)
> >[javac] private static final class Sync extends
> > AbstractQueuedSynchronizer {
> >[javac]
> >[javac] The serializable class Sync does not declare a static
> > final serialVersionUID field of type long
> >
> > 2006/10/19, Nathan Beyer <[EMAIL PROTECTED]>:
> >> I added a compiler arg to the main 'build-java.xml' compile to disable
> >> all of the warnings.
> >>
> >> This should take care of the warnings.
> >>
> >> -Nathan
> >>
> >> On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
> >> > Can we just shut them off for now?  it's a good project for someone to
> >> > go and clean those up, but there's no need for all of us to see them.
> >> >
> >> > geir
> >> >
> >> > Mark Hindess wrote:
> >> > > These messages aren't getting through on the commits list on due
> >> to the
> >> > > large number of warnings since switching to ecj.  I've modified the
> >> > > summary process so that it ignores these for the moment.
> >> > >
> >> > > Hopefully this means that the failure messages that haven't been
> >> making
> >> > > the commits list will start getting through.
> >> > >
> >> > > Regards,
> >> > >  Mark.
> >> > >
> >> > >
> >> > >
> >> > >
> >> > > -
> >> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> > > For additional commands, e-mail:
> >> [EMAIL PROTECTED]
> >> > >
> >> >
> >> > -
> >> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> > For additional commands, e-mail: [EMAIL PROTECTED]
> >> >
> >> >
> >>
> >> -
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> >
> >
>
> --
>
> Tim Ellison ([EMAIL PROTECTED])
> IBM Java technology centre, UK.
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Denis M. Kishenko
Enterprise Solutions Software Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Geir Magnusson Jr.]

You have patience I can only dream about...

geir

Nathan Beyer wrote:

I've been trying to work through many of the warnings, module by
module. Most of the warnings fall into the following categories.
* serial - Serializable classes that don't have explicit 
serialVersionUID fields

* unchecked - missing type variables, mostly collection references
* unused - unused private fields, methods; these are tough as some of
them are seemingly used by native code
* missing @Override - methods that override other methods are
annotated for safety

-Nathan

On 10/19/06, Tim Ellison <[EMAIL PROTECTED]> wrote:

Nathan has turned off all warnings.  I suggest that we start to turn
them back on incrementally and fix the warnings we see.

Regards,
Tim

Denis Kishenko wrote:
> I also worried about a lot of warnings and I think warnings like these
> can be fixed
>
> 
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java 


>
>[javac]  (at line 26)
>[javac] import java.io.ObjectInputStream;
>[javac]^
>[javac] The import java.io.ObjectInputStream is never used
>
>[javac] 34. WARNING in
> 
C:\Work\Projects\Harmony-last\modules\concurrent\standard\src\main\java\java\util\concurrent\CountDownLatch.java 


>
>[javac]  (at line 130)
>[javac] private static final class Sync extends
> AbstractQueuedSynchronizer {
>[javac]
>[javac] The serializable class Sync does not declare a static
> final serialVersionUID field of type long
>
> 2006/10/19, Nathan Beyer <[EMAIL PROTECTED]>:
>> I added a compiler arg to the main 'build-java.xml' compile to disable
>> all of the warnings.
>>
>> This should take care of the warnings.
>>
>> -Nathan
>>
>> On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
>> > Can we just shut them off for now?  it's a good project for 
someone to
>> > go and clean those up, but there's no need for all of us to see 
them.

>> >
>> > geir
>> >
>> > Mark Hindess wrote:
>> > > These messages aren't getting through on the commits list on due
>> to the
>> > > large number of warnings since switching to ecj.  I've modified 
the

>> > > summary process so that it ignores these for the moment.
>> > >
>> > > Hopefully this means that the failure messages that haven't been
>> making
>> > > the commits list will start getting through.
>> > >
>> > > Regards,
>> > >  Mark.
>> > >
>> > >
>> > >
>> > >
>> > > 
-

>> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > > To unsubscribe, e-mail: 
[EMAIL PROTECTED]

>> > > For additional commands, e-mail:
>> [EMAIL PROTECTED]
>> > >
>> >
>> > 
-

>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > For additional commands, e-mail: 
[EMAIL PROTECTED]

>> >
>> >
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>

--

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Geir Magnusson Jr.]

coolio - thx

Nathan Beyer wrote:

I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.

This should take care of the warnings.

-Nathan

On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:

Can we just shut them off for now?  it's a good project for someone to
go and clean those up, but there's no need for all of us to see them.

geir

Mark Hindess wrote:
> These messages aren't getting through on the commits list on due to the
> large number of warnings since switching to ecj.  I've modified the
> summary process so that it ignores these for the moment.
>
> Hopefully this means that the failure messages that haven't been making
> the commits list will start getting through.
>
> Regards,
>  Mark.
>
>
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Nathan Beyer]

I've been trying to work through many of the warnings, module by
module. Most of the warnings fall into the following categories.
* serial - Serializable classes that don't have explicit serialVersionUID fields
* unchecked - missing type variables, mostly collection references
* unused - unused private fields, methods; these are tough as some of
them are seemingly used by native code
* missing @Override - methods that override other methods are
annotated for safety

-Nathan

On 10/19/06, Tim Ellison <[EMAIL PROTECTED]> wrote:

Nathan has turned off all warnings.  I suggest that we start to turn
them back on incrementally and fix the warnings we see.

Regards,
Tim

Denis Kishenko wrote:
> I also worried about a lot of warnings and I think warnings like these
> can be fixed
>
> 
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
>
>[javac]  (at line 26)
>[javac] import java.io.ObjectInputStream;
>[javac]^
>[javac] The import java.io.ObjectInputStream is never used
>
>[javac] 34. WARNING in
> 
C:\Work\Projects\Harmony-last\modules\concurrent\standard\src\main\java\java\util\concurrent\CountDownLatch.java
>
>[javac]  (at line 130)
>[javac] private static final class Sync extends
> AbstractQueuedSynchronizer {
>[javac]
>[javac] The serializable class Sync does not declare a static
> final serialVersionUID field of type long
>
> 2006/10/19, Nathan Beyer <[EMAIL PROTECTED]>:
>> I added a compiler arg to the main 'build-java.xml' compile to disable
>> all of the warnings.
>>
>> This should take care of the warnings.
>>
>> -Nathan
>>
>> On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
>> > Can we just shut them off for now?  it's a good project for someone to
>> > go and clean those up, but there's no need for all of us to see them.
>> >
>> > geir
>> >
>> > Mark Hindess wrote:
>> > > These messages aren't getting through on the commits list on due
>> to the
>> > > large number of warnings since switching to ecj.  I've modified the
>> > > summary process so that it ignores these for the moment.
>> > >
>> > > Hopefully this means that the failure messages that haven't been
>> making
>> > > the commits list will start getting through.
>> > >
>> > > Regards,
>> > >  Mark.
>> > >
>> > >
>> > >
>> > >
>> > > -
>> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > For additional commands, e-mail:
>> [EMAIL PROTECTED]
>> > >
>> >
>> > -
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > For additional commands, e-mail: [EMAIL PROTECTED]
>> >
>> >
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>

--

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Tim Ellison]

Nathan has turned off all warnings.  I suggest that we start to turn
them back on incrementally and fix the warnings we see.

Regards,
Tim

Denis Kishenko wrote:
> I also worried about a lot of warnings and I think warnings like these
> can be fixed
> 
> last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
> 
>[javac]  (at line 26)
>[javac] import java.io.ObjectInputStream;
>[javac]^
>[javac] The import java.io.ObjectInputStream is never used
> 
>[javac] 34. WARNING in
> C:\Work\Projects\Harmony-last\modules\concurrent\standard\src\main\java\java\util\concurrent\CountDownLatch.java
> 
>[javac]  (at line 130)
>[javac] private static final class Sync extends
> AbstractQueuedSynchronizer {
>[javac]
>[javac] The serializable class Sync does not declare a static
> final serialVersionUID field of type long
> 
> 2006/10/19, Nathan Beyer <[EMAIL PROTECTED]>:
>> I added a compiler arg to the main 'build-java.xml' compile to disable
>> all of the warnings.
>>
>> This should take care of the warnings.
>>
>> -Nathan
>>
>> On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
>> > Can we just shut them off for now?  it's a good project for someone to
>> > go and clean those up, but there's no need for all of us to see them.
>> >
>> > geir
>> >
>> > Mark Hindess wrote:
>> > > These messages aren't getting through on the commits list on due
>> to the
>> > > large number of warnings since switching to ecj.  I've modified the
>> > > summary process so that it ignores these for the moment.
>> > >
>> > > Hopefully this means that the failure messages that haven't been
>> making
>> > > the commits list will start getting through.
>> > >
>> > > Regards,
>> > >  Mark.
>> > >
>> > >
>> > >
>> > >
>> > > -
>> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > For additional commands, e-mail:
>> [EMAIL PROTECTED]
>> > >
>> >
>> > -
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > For additional commands, e-mail: [EMAIL PROTECTED]
>> >
>> >
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> 

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Mikhail Fursov]

+1
I never know if it's something important or not.


On 10/19/06, Denis Kishenko <[EMAIL PROTECTED]> wrote:


I also worried about a lot of warnings and I think warnings like these
can be fixed


last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
[javac]  (at line 26)
[javac] import java.io.ObjectInputStream;
[javac]^
[javac] The import java.io.ObjectInputStream is never used

[javac] 34. WARNING in

C:\Work\Projects\Harmony-last\modules\concurrent\standard\src\main\java\java\util\concurrent\CountDownLatch.java
[javac]  (at line 130)
[javac] private static final class Sync extends
AbstractQueuedSynchronizer {
[javac]
[javac] The serializable class Sync does not declare a static
final serialVersionUID field of type long

2006/10/19, Nathan Beyer <[EMAIL PROTECTED]>:
> I added a compiler arg to the main 'build-java.xml' compile to disable
> all of the warnings.
>
> This should take care of the warnings.
>
> -Nathan
>
> On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
> > Can we just shut them off for now?  it's a good project for someone to
> > go and clean those up, but there's no need for all of us to see them.
> >
> > geir
> >
> > Mark Hindess wrote:
> > > These messages aren't getting through on the commits list on due to
the
> > > large number of warnings since switching to ecj.  I've modified the
> > > summary process so that it ignores these for the moment.
> > >
> > > Hopefully this means that the failure messages that haven't been
making
> > > the commits list will start getting through.
> > >
> > > Regards,
> > >  Mark.
> > >
> > >
> > >
> > >
> > >
-
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail:
[EMAIL PROTECTED]
> > >
> >
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


--
Denis M. Kishenko
Enterprise Solutions Software Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Mikhail Fursov

Re: [classlib] Build failure messages

[Denis Kishenko]

I also worried about a lot of warnings and I think warnings like these
can be fixed

last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
   [javac]  (at line 26)
   [javac]  import java.io.ObjectInputStream;
   [javac] ^
   [javac] The import java.io.ObjectInputStream is never used

   [javac] 34. WARNING in
C:\Work\Projects\Harmony-last\modules\concurrent\standard\src\main\java\java\util\concurrent\CountDownLatch.java
   [javac]  (at line 130)
   [javac]  private static final class Sync extends
AbstractQueuedSynchronizer {
   [javac] 
   [javac] The serializable class Sync does not declare a static
final serialVersionUID field of type long

2006/10/19, Nathan Beyer <[EMAIL PROTECTED]>:

I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.

This should take care of the warnings.

-Nathan

On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
> Can we just shut them off for now?  it's a good project for someone to
> go and clean those up, but there's no need for all of us to see them.
>
> geir
>
> Mark Hindess wrote:
> > These messages aren't getting through on the commits list on due to the
> > large number of warnings since switching to ecj.  I've modified the
> > summary process so that it ignores these for the moment.
> >
> > Hopefully this means that the failure messages that haven't been making
> > the commits list will start getting through.
> >
> > Regards,
> >  Mark.
> >
> >
> >
> >
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Denis M. Kishenko
Enterprise Solutions Software Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Nathan Beyer]

I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.

This should take care of the warnings.

-Nathan

On 10/18/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:

Can we just shut them off for now?  it's a good project for someone to
go and clean those up, but there's no need for all of us to see them.

geir

Mark Hindess wrote:
> These messages aren't getting through on the commits list on due to the
> large number of warnings since switching to ecj.  I've modified the
> summary process so that it ignores these for the moment.
>
> Hopefully this means that the failure messages that haven't been making
> the commits list will start getting through.
>
> Regards,
>  Mark.
>
>
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] Build failure messages

[Geir Magnusson Jr.]

Can we just shut them off for now?  it's a good project for someone to 
go and clean those up, but there's no need for all of us to see them.


geir

Mark Hindess wrote:

These messages aren't getting through on the commits list on due to the
large number of warnings since switching to ecj.  I've modified the
summary process so that it ignores these for the moment.

Hopefully this means that the failure messages that haven't been making
the commits list will start getting through.

Regards,
 Mark.




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Salikh Zakirov]

Mikhail Loenko wrote:
> Works fine on a fresh ws.
> 
> could you please update up to 454342:
> missed one file (was: moving HARMONY-1609 (Applet, ImageIO and Print
> modules) files to correct locations)
> 
> and try "ant rebuild"

Verified.

Classlib builds and works okay on revision
r454349 cyrillic characters in comments replaced with latins
(just next to 
r454342 missed one file (was: moving HARMONY-1609 (Applet, ImageIO and Print 
modules) files to correct locations)
)


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Oliver Deakin]

yup, Ive just updated and rebuilt, and it works fine for me too.


Mikhail Loenko wrote:

Works fine on a fresh ws.

could you please update up to 454342:
missed one file (was: moving HARMONY-1609 (Applet, ImageIO and Print
modules) files to correct locations)

and try "ant rebuild"

Thanks,
Mikhail

2006/10/9, Mikhail Loenko <[EMAIL PROTECTED]>:

I couldn't reproduce that - worked fine before I committed

Now trying on a fresh ws

2006/10/9, Alexey Petrenko <[EMAIL PROTECTED]>:
> Yes, this happens because HARMONY-1729 was not integrated yet.
> HARMONY-1729 consists of build files diff and connetced to 
HARMONY-1609.

>
> SY, Alexey
>
>
> 2006/10/9, Salikh Zakirov <[EMAIL PROTECTED]>:
> > Hi,
> >
> > I cannot build classlib on the latest revision ([r454318] moving 
HARMONY-1609 (Applet, ImageIO and Print modules) fil

> > es to) with the following errors:
> >
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:31: 
error: Class or interface declaration expected.

> >[javac] public AccessibleRelationSet() {
> >[javac]   ^
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:32: 
error: Class or interface declaration expected.

> >[javac] initStorage();
> >[javac]^
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java:32: 
warning: .
> >[javac] public static final String FLOWS_TO = "flowsTo"; 
//$NON-NLS-1$
> >
[javac] 
^
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:33: 
error: Class or interface declaration expected.

> >... many more errors snipped ...
> >
> > Reverting back to [r454268] helps.
> >
> > Can it be that latest contribution was not integrated properly?
> > Is anyone else seeing (or fixing) this?
> >
> >
> > 
-

> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: 
[EMAIL PROTECTED]

> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




--
Oliver Deakin
IBM United Kingdom Limited


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Mikhail Loenko]

Works fine on a fresh ws.

could you please update up to 454342:
missed one file (was: moving HARMONY-1609 (Applet, ImageIO and Print
modules) files to correct locations)

and try "ant rebuild"

Thanks,
Mikhail

2006/10/9, Mikhail Loenko <[EMAIL PROTECTED]>:

I couldn't reproduce that - worked fine before I committed

Now trying on a fresh ws

2006/10/9, Alexey Petrenko <[EMAIL PROTECTED]>:
> Yes, this happens because HARMONY-1729 was not integrated yet.
> HARMONY-1729 consists of build files diff and connetced to HARMONY-1609.
>
> SY, Alexey
>
>
> 2006/10/9, Salikh Zakirov <[EMAIL PROTECTED]>:
> > Hi,
> >
> > I cannot build classlib on the latest revision ([r454318] moving 
HARMONY-1609 (Applet, ImageIO and Print modules) fil
> > es to) with the following errors:
> >
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:31:
 error: Class or interface declaration expected.
> >[javac] public AccessibleRelationSet() {
> >[javac]   ^
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:32:
 error: Class or interface declaration expected.
> >[javac] initStorage();
> >[javac]^
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java:32:
 warning: .
> >[javac] public static final String FLOWS_TO = "flowsTo"; 
//$NON-NLS-1$
> >[javac]  
   ^
> >[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:33:
 error: Class or interface declaration expected.
> >... many more errors snipped ...
> >
> > Reverting back to [r454268] helps.
> >
> > Can it be that latest contribution was not integrated properly?
> > Is anyone else seeing (or fixing) this?
> >
> >
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Mikhail Loenko]

I couldn't reproduce that - worked fine before I committed

Now trying on a fresh ws

2006/10/9, Alexey Petrenko <[EMAIL PROTECTED]>:

Yes, this happens because HARMONY-1729 was not integrated yet.
HARMONY-1729 consists of build files diff and connetced to HARMONY-1609.

SY, Alexey


2006/10/9, Salikh Zakirov <[EMAIL PROTECTED]>:
> Hi,
>
> I cannot build classlib on the latest revision ([r454318] moving HARMONY-1609 
(Applet, ImageIO and Print modules) fil
> es to) with the following errors:
>
>[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:31:
 error: Class or interface declaration expected.
>[javac] public AccessibleRelationSet() {
>[javac]   ^
>[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:32:
 error: Class or interface declaration expected.
>[javac] initStorage();
>[javac]^
>[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java:32:
 warning: .
>[javac] public static final String FLOWS_TO = "flowsTo"; //$NON-NLS-1$
>[javac]
 ^
>[javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:33:
 error: Class or interface declaration expected.
>... many more errors snipped ...
>
> Reverting back to [r454268] helps.
>
> Can it be that latest contribution was not integrated properly?
> Is anyone else seeing (or fixing) this?
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


--
Alexey A. Petrenko
Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Alexey Petrenko]

Yes, this happens because HARMONY-1729 was not integrated yet.
HARMONY-1729 consists of build files diff and connetced to HARMONY-1609.

SY, Alexey


2006/10/9, Salikh Zakirov <[EMAIL PROTECTED]>:

Hi,

I cannot build classlib on the latest revision ([r454318] moving HARMONY-1609 
(Applet, ImageIO and Print modules) fil
es to) with the following errors:

   [javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:31:
 error: Class or interface declaration expected.
   [javac] public AccessibleRelationSet() {
   [javac]   ^
   [javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:32:
 error: Class or interface declaration expected.
   [javac] initStorage();
   [javac]^
   [javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java:32:
 warning: .
   [javac] public static final String FLOWS_TO = "flowsTo"; //$NON-NLS-1$
   [javac] ^
   [javac] 
/export/users/salikh/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelationSet.java:33:
 error: Class or interface declaration expected.
   ... many more errors snipped ...

Reverting back to [r454268] helps.

Can it be that latest contribution was not integrated properly?
Is anyone else seeing (or fixing) this?


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Alexey A. Petrenko
Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Leo Li]

Dear Mark:
   You are right. Thank you. It really works.
   I will try to set -Werror option to see if all reported warning. can
be fixed.


On 9/20/06, Mark Hindess <[EMAIL PROTECTED]> wrote:



On 20 September 2006 at 10:06, Mark Hindess <[EMAIL PROTECTED] >
wrote:
>
> On 20 September 2006 at 10:03, "Leo Li" <[EMAIL PROTECTED]> wrote:
> >
> > Hi, all:
> >
> > Since I am not an expert of gcc, I think we need a guru to set the
flags in
> > makefile of linux:
> > 1. It will report any required warnings and regard it as error to lead
a
> > failure build so that it is forced for us to correct it.
> >
> > 2. It can avoid to stop building due to such warnings:
> >
> > In OSFileSystem.c, we have:
> > JNIEXPORT jlong JNICALL
> > Java_org_apache_harmony_luni_platform_OSFileSystem_readDirectImpl
> >   (JNIEnv * env, jobject thiz, jlong fd, jlong buf, jint offset, jint
> > nbytes)
> > {
> >   PORT_ACCESS_FROM_ENV (env);
> >   return (jlong) hyfile_read ((IDATA) fd, (void *) (buf+offset),
(IDATA)
> > nbytes);
> > }
> > Actually, the hyfile_read returns a int32 while the jlong is int64. I
think
> > the warning seems to be not avoidable.
>
> I don't think that is the problem.  Casting from 32bit to 64bit is going
> to lead to a loss of information.

Oops.  I meant "isn't going to".
-Mark.

> > I have had tried some flags, but I have not got what I want.
> > Any good suggestion?
>
> The problem occurs because (buf+offset) is a 64bit value (since buf is
> 64bit) and void* is a 32bit value (on x86).  If we cast (buf+offset) to
> a 32bit value before casting to (void*) the warning will be removed.
>
> IDATA (and UDATA) are defined to be integers of the same size as
> pointers for a given platform so if them for the cast then the warning
> can be avoided (and the code will still be correct on x86_64).
>
> So something like:
>
>   return (jlong) hyfile_read ((IDATA) fd,
>   (void *) ((IDATA)(buf+offset)),
>   (IDATA) nbytes);
>
> (I've not tested this and each case should be looked at to see if the
> cast is really valid.)
>
> Regards,
>  Mark.
>
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Leo Li
China Software Development Lab, IBM

Re: [classlib][build] failure?

[Mark Hindess]

On 20 September 2006 at 10:06, Mark Hindess <[EMAIL PROTECTED]> wrote:
> 
> On 20 September 2006 at 10:03, "Leo Li" <[EMAIL PROTECTED]> wrote:
> >
> > Hi, all:
> > 
> > Since I am not an expert of gcc, I think we need a guru to set the flags in
> > makefile of linux:
> > 1. It will report any required warnings and regard it as error to lead a
> > failure build so that it is forced for us to correct it.
> > 
> > 2. It can avoid to stop building due to such warnings:
> > 
> > In OSFileSystem.c, we have:
> > JNIEXPORT jlong JNICALL
> > Java_org_apache_harmony_luni_platform_OSFileSystem_readDirectImpl
> >   (JNIEnv * env, jobject thiz, jlong fd, jlong buf, jint offset, jint
> > nbytes)
> > {
> >   PORT_ACCESS_FROM_ENV (env);
> >   return (jlong) hyfile_read ((IDATA) fd, (void *) (buf+offset), (IDATA)
> > nbytes);
> > }
> > Actually, the hyfile_read returns a int32 while the jlong is int64. I think
> > the warning seems to be not avoidable.
> 
> I don't think that is the problem.  Casting from 32bit to 64bit is going
> to lead to a loss of information.

Oops.  I meant "isn't going to".
-Mark.

> > I have had tried some flags, but I have not got what I want.
> > Any good suggestion?
> 
> The problem occurs because (buf+offset) is a 64bit value (since buf is
> 64bit) and void* is a 32bit value (on x86).  If we cast (buf+offset) to
> a 32bit value before casting to (void*) the warning will be removed.
> 
> IDATA (and UDATA) are defined to be integers of the same size as 
> pointers for a given platform so if them for the cast then the warning
> can be avoided (and the code will still be correct on x86_64).
> 
> So something like:
> 
>   return (jlong) hyfile_read ((IDATA) fd,
>   (void *) ((IDATA)(buf+offset)),
>   (IDATA) nbytes);
> 
> (I've not tested this and each case should be looked at to see if the
> cast is really valid.)
> 
> Regards,
>  Mark.
> 
> 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Mark Hindess]

On 20 September 2006 at 10:03, "Leo Li" <[EMAIL PROTECTED]> wrote:
>
> Hi, all:
> 
> Since I am not an expert of gcc, I think we need a guru to set the flags in
> makefile of linux:
> 1. It will report any required warnings and regard it as error to lead a
> failure build so that it is forced for us to correct it.
> 
> 2. It can avoid to stop building due to such warnings:
> 
> In OSFileSystem.c, we have:
> JNIEXPORT jlong JNICALL
> Java_org_apache_harmony_luni_platform_OSFileSystem_readDirectImpl
>   (JNIEnv * env, jobject thiz, jlong fd, jlong buf, jint offset, jint
> nbytes)
> {
>   PORT_ACCESS_FROM_ENV (env);
>   return (jlong) hyfile_read ((IDATA) fd, (void *) (buf+offset), (IDATA)
> nbytes);
> }
> Actually, the hyfile_read returns a int32 while the jlong is int64. I think
> the warning seems to be not avoidable.

I don't think that is the problem.  Casting from 32bit to 64bit is going
to lead to a loss of information.

> I have had tried some flags, but I have not got what I want.
> Any good suggestion?

The problem occurs because (buf+offset) is a 64bit value (since buf is
64bit) and void* is a 32bit value (on x86).  If we cast (buf+offset) to
a 32bit value before casting to (void*) the warning will be removed.

IDATA (and UDATA) are defined to be integers of the same size as 
pointers for a given platform so if them for the cast then the warning
can be avoided (and the code will still be correct on x86_64).

So something like:

  return (jlong) hyfile_read ((IDATA) fd,
  (void *) ((IDATA)(buf+offset)),
  (IDATA) nbytes);

(I've not tested this and each case should be looked at to see if the
cast is really valid.)

Regards,
 Mark.



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Leo Li]

Hi, all:

Since I am not an expert of gcc, I think we need a guru to set the flags in
makefile of linux:
1. It will report any required warnings and regard it as error to lead a
failure build so that it is forced for us to correct it.

2. It can avoid to stop building due to such warnings:

In OSFileSystem.c, we have:
JNIEXPORT jlong JNICALL
Java_org_apache_harmony_luni_platform_OSFileSystem_readDirectImpl
 (JNIEnv * env, jobject thiz, jlong fd, jlong buf, jint offset, jint
nbytes)
{
 PORT_ACCESS_FROM_ENV (env);
 return (jlong) hyfile_read ((IDATA) fd, (void *) (buf+offset), (IDATA)
nbytes);
}
Actually, the hyfile_read returns a int32 while the jlong is int64. I think
the warning seems to be not avoidable.

I have had tried some flags, but I have not got what I want.
Any good suggestion?




On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:


Really - I think the explanation was totally reasonable.  I didn't
understand before why it was asymmetric.

On Sep 19, 2006, at 8:40 AM, Mark Hindess wrote:

>
> Well, I was just pointing out a further inconsistency (awt/
> windows).  I
> don't recall when/why linux errors were downgraded so that might have
> happened before I started hacking the natives around.
>
> Regards,
>  Mark.
>
> On 19 September 2006 at 7:10, "Geir Magnusson Jr." <[EMAIL PROTECTED]>
> wrote:
>> Ok, good - there's a totally reasonable explanation :)
>>
>> geir
>>
>> On Sep 19, 2006, at 7:05 AM, Mark Hindess wrote:
>>
>>>
>>> Incidentally, I had to override the default windows flags to turn
>>> off
>>> the warnings-as-error for the awt native code in order to integrate
>>> it.
>>> I mentioned this on the -dev list at the time hoping to see some
>>> patches
>>> to fix the issues but there haven't been any as yet.
>>>
>>> I agree it would be a good thing to fix for all the native code on
>>> both
>>> platforms.
>>>
>>> Regards,
>>>  Mark.
>>>
>>> On 19 September 2006 at 4:46, "Geir Magnusson Jr." <[EMAIL PROTECTED]>
>>> wrote:
 There is no way to get rid of the warnings in our codebase on
 linux?

 geir

 On Sep 19, 2006, at 4:03 AM, Leo Li wrote:

> Hi, Geir:
>  The warning level is set to level 3 while the warning as error
> option is
> off in linux.
>  Actually, I would like to set it on in linux since it will
> help me
> to pick
> some error out, for example, wrongly use pointers. However, I have
> tried to
> set it on, but some unavoidable warning will lead to a failure in
> Harmony
> building. Any good idea?:)
>
> Good luck!
>
> On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
>>
>> Lets get these aligned...  I tend to work on linux, so it had no
>> problem building..
>>
>> geir
>>
>> On Sep 18, 2006, at 10:14 PM, Leo Li wrote:
>>
>>> Just comment it out since it is just a warning treated as error.
>>> It compiles successfully and runs well.
>>> Maybe it will not lead to such an error on Linux due to the
>>> configuration of
>>> make rules.:)
>>>
>>> Good luck!
>>>
>>>
>>> On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:

 Hi All:
 When building today's(Sep 19, r447671) classlib on window xp, I
 got the
 following error message:
 [exec] main.c
 [exec] ..\shared\main.c(628) : error C2220: warning
 treated as
 error - no o
 bject file generated
 [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
 unreferenced lo
 cal variable
 [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
 [exec] Stop.
 [exec] NMAKE : fatal error U1077: '"c:\Program Files
 \Microsoft
 Visual Studi
 o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
 [exec] Stop.

 BUILD FAILED
 C:\spark\harmony\build.xml:95: The following error occurred
 while
 executing this
 line:
 C:\spark\harmony\make\build-native.xml:75: The following error
 occurred
 while ex
 ecuting this line:
 C:\spark\harmony\modules\luni\build.xml:167: The following
 error
 occurred while
 executing this line:
 C:\spark\harmony\make\properties.xml:258: exec returned: 2

 Could any one check it?

 Best regards

 --
 Spark Shen
 China Software Development Lab, IBM



>> -
>> --
>> --
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: harmony-dev-
>> [EMAIL PROTECTED]
 For additional commands, e-mail: harmony-dev-
 [EMAIL PROTECTED]


>>>
>>>
>>> --
>>> Leo Li
>>> China Software Development Lab

Re: [classlib][build] failure?

[Geir Magnusson Jr.]

Really - I think the explanation was totally reasonable.  I didn't  
understand before why it was asymmetric.


On Sep 19, 2006, at 8:40 AM, Mark Hindess wrote:



Well, I was just pointing out a further inconsistency (awt/ 
windows).  I

don't recall when/why linux errors were downgraded so that might have
happened before I started hacking the natives around.

Regards,
 Mark.

On 19 September 2006 at 7:10, "Geir Magnusson Jr." <[EMAIL PROTECTED]>  
wrote:

Ok, good - there's a totally reasonable explanation :)

geir

On Sep 19, 2006, at 7:05 AM, Mark Hindess wrote:



Incidentally, I had to override the default windows flags to turn  
off

the warnings-as-error for the awt native code in order to integrate
it.
I mentioned this on the -dev list at the time hoping to see some
patches
to fix the issues but there haven't been any as yet.

I agree it would be a good thing to fix for all the native code on
both
platforms.

Regards,
 Mark.

On 19 September 2006 at 4:46, "Geir Magnusson Jr." <[EMAIL PROTECTED]>
wrote:
There is no way to get rid of the warnings in our codebase on  
linux?


geir

On Sep 19, 2006, at 4:03 AM, Leo Li wrote:


Hi, Geir:
 The warning level is set to level 3 while the warning as error
option is
off in linux.
 Actually, I would like to set it on in linux since it will  
help me

to pick
some error out, for example, wrongly use pointers. However, I have
tried to
set it on, but some unavoidable warning will lead to a failure in
Harmony
building. Any good idea?:)

Good luck!

On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:


Lets get these aligned...  I tend to work on linux, so it had no
problem building..

geir

On Sep 18, 2006, at 10:14 PM, Leo Li wrote:


Just comment it out since it is just a warning treated as error.
It compiles successfully and runs well.
Maybe it will not lead to such an error on Linux due to the
configuration of
make rules.:)

Good luck!


On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:


Hi All:
When building today's(Sep 19, r447671) classlib on window xp, I
got the
following error message:
[exec] main.c
[exec] ..\shared\main.c(628) : error C2220: warning
treated as
error - no o
bject file generated
[exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
unreferenced lo
cal variable
[exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
[exec] Stop.
[exec] NMAKE : fatal error U1077: '"c:\Program Files
\Microsoft
Visual Studi
o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
[exec] Stop.

BUILD FAILED
C:\spark\harmony\build.xml:95: The following error occurred  
while

executing this
line:
C:\spark\harmony\make\build-native.xml:75: The following error
occurred
while ex
ecuting this line:
C:\spark\harmony\modules\luni\build.xml:167: The following  
error

occurred while
executing this line:
C:\spark\harmony\make\properties.xml:258: exec returned: 2

Could any one check it?

Best regards

--
Spark Shen
China Software Development Lab, IBM



- 
--

--

Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-

[EMAIL PROTECTED]

For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]





--
Leo Li
China Software Development Lab, IBM



- 
--

--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-
[EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]





--
Leo Li
China Software Development Lab, IBM



--- 
--

Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev- 
[EMAIL PROTECTED]

For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]





 
-

Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev- 
[EMAIL PROTECTED]





-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev- 
[EMAIL PROTECTED]






-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Mark Hindess]

Well, I was just pointing out a further inconsistency (awt/windows).  I
don't recall when/why linux errors were downgraded so that might have
happened before I started hacking the natives around.

Regards,
 Mark.

On 19 September 2006 at 7:10, "Geir Magnusson Jr." <[EMAIL PROTECTED]> wrote:
> Ok, good - there's a totally reasonable explanation :)
> 
> geir
> 
> On Sep 19, 2006, at 7:05 AM, Mark Hindess wrote:
> 
> >
> > Incidentally, I had to override the default windows flags to turn off
> > the warnings-as-error for the awt native code in order to integrate  
> > it.
> > I mentioned this on the -dev list at the time hoping to see some  
> > patches
> > to fix the issues but there haven't been any as yet.
> >
> > I agree it would be a good thing to fix for all the native code on  
> > both
> > platforms.
> >
> > Regards,
> >  Mark.
> >
> > On 19 September 2006 at 4:46, "Geir Magnusson Jr." <[EMAIL PROTECTED]>  
> > wrote:
> >> There is no way to get rid of the warnings in our codebase on linux?
> >>
> >> geir
> >>
> >> On Sep 19, 2006, at 4:03 AM, Leo Li wrote:
> >>
> >>> Hi, Geir:
> >>>  The warning level is set to level 3 while the warning as error
> >>> option is
> >>> off in linux.
> >>>  Actually, I would like to set it on in linux since it will help me
> >>> to pick
> >>> some error out, for example, wrongly use pointers. However, I have
> >>> tried to
> >>> set it on, but some unavoidable warning will lead to a failure in
> >>> Harmony
> >>> building. Any good idea?:)
> >>>
> >>> Good luck!
> >>>
> >>> On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
> 
>  Lets get these aligned...  I tend to work on linux, so it had no
>  problem building..
> 
>  geir
> 
>  On Sep 18, 2006, at 10:14 PM, Leo Li wrote:
> 
> > Just comment it out since it is just a warning treated as error.
> > It compiles successfully and runs well.
> > Maybe it will not lead to such an error on Linux due to the
> > configuration of
> > make rules.:)
> >
> > Good luck!
> >
> >
> > On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:
> >>
> >> Hi All:
> >> When building today's(Sep 19, r447671) classlib on window xp, I
> >> got the
> >> following error message:
> >> [exec] main.c
> >> [exec] ..\shared\main.c(628) : error C2220: warning  
> >> treated as
> >> error - no o
> >> bject file generated
> >> [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
> >> unreferenced lo
> >> cal variable
> >> [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
> >> [exec] Stop.
> >> [exec] NMAKE : fatal error U1077: '"c:\Program Files 
> >> \Microsoft
> >> Visual Studi
> >> o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
> >> [exec] Stop.
> >>
> >> BUILD FAILED
> >> C:\spark\harmony\build.xml:95: The following error occurred while
> >> executing this
> >> line:
> >> C:\spark\harmony\make\build-native.xml:75: The following error
> >> occurred
> >> while ex
> >> ecuting this line:
> >> C:\spark\harmony\modules\luni\build.xml:167: The following error
> >> occurred while
> >> executing this line:
> >> C:\spark\harmony\make\properties.xml:258: exec returned: 2
> >>
> >> Could any one check it?
> >>
> >> Best regards
> >>
> >> --
> >> Spark Shen
> >> China Software Development Lab, IBM
> >>
> >>
> >>
>  --- 
>  --
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-
>  [EMAIL PROTECTED]
> >> For additional commands, e-mail: harmony-dev-
> >> [EMAIL PROTECTED]
> >>
> >>
> >
> >
> > --
> > Leo Li
> > China Software Development Lab, IBM
> 
> 
>  --- 
>  --
>  Terms of use : http://incubator.apache.org/harmony/mailing.html
>  To unsubscribe, e-mail: harmony-dev- 
>  [EMAIL PROTECTED]
>  For additional commands, e-mail: harmony-dev-
>  [EMAIL PROTECTED]
> 
> 
> >>>
> >>>
> >>> -- 
> >>> Leo Li
> >>> China Software Development Lab, IBM
> >>
> >>
> >> -
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: harmony-dev- 
> >> [EMAIL PROTECTED]
> >>
> >
> >
> >
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> 
> 
> -
> Terms of use : http://incubator.apache.

Re: [classlib][build] failure?

[Geir Magnusson Jr.]

Ok, good - there's a totally reasonable explanation :)

geir

On Sep 19, 2006, at 7:05 AM, Mark Hindess wrote:



Incidentally, I had to override the default windows flags to turn off
the warnings-as-error for the awt native code in order to integrate  
it.
I mentioned this on the -dev list at the time hoping to see some  
patches

to fix the issues but there haven't been any as yet.

I agree it would be a good thing to fix for all the native code on  
both

platforms.

Regards,
 Mark.

On 19 September 2006 at 4:46, "Geir Magnusson Jr." <[EMAIL PROTECTED]>  
wrote:

There is no way to get rid of the warnings in our codebase on linux?

geir

On Sep 19, 2006, at 4:03 AM, Leo Li wrote:


Hi, Geir:
 The warning level is set to level 3 while the warning as error
option is
off in linux.
 Actually, I would like to set it on in linux since it will help me
to pick
some error out, for example, wrongly use pointers. However, I have
tried to
set it on, but some unavoidable warning will lead to a failure in
Harmony
building. Any good idea?:)

Good luck!

On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:


Lets get these aligned...  I tend to work on linux, so it had no
problem building..

geir

On Sep 18, 2006, at 10:14 PM, Leo Li wrote:


Just comment it out since it is just a warning treated as error.
It compiles successfully and runs well.
Maybe it will not lead to such an error on Linux due to the
configuration of
make rules.:)

Good luck!


On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:


Hi All:
When building today's(Sep 19, r447671) classlib on window xp, I
got the
following error message:
[exec] main.c
[exec] ..\shared\main.c(628) : error C2220: warning  
treated as

error - no o
bject file generated
[exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
unreferenced lo
cal variable
[exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
[exec] Stop.
[exec] NMAKE : fatal error U1077: '"c:\Program Files 
\Microsoft

Visual Studi
o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
[exec] Stop.

BUILD FAILED
C:\spark\harmony\build.xml:95: The following error occurred while
executing this
line:
C:\spark\harmony\make\build-native.xml:75: The following error
occurred
while ex
ecuting this line:
C:\spark\harmony\modules\luni\build.xml:167: The following error
occurred while
executing this line:
C:\spark\harmony\make\properties.xml:258: exec returned: 2

Could any one check it?

Best regards

--
Spark Shen
China Software Development Lab, IBM



--- 
--

Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-

[EMAIL PROTECTED]

For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]





--
Leo Li
China Software Development Lab, IBM



--- 
--

Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev- 
[EMAIL PROTECTED]

For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]





--
Leo Li
China Software Development Lab, IBM



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev- 
[EMAIL PROTECTED]






-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Mark Hindess]

Incidentally, I had to override the default windows flags to turn off
the warnings-as-error for the awt native code in order to integrate it.
I mentioned this on the -dev list at the time hoping to see some patches
to fix the issues but there haven't been any as yet.

I agree it would be a good thing to fix for all the native code on both
platforms.

Regards,
 Mark.

On 19 September 2006 at 4:46, "Geir Magnusson Jr." <[EMAIL PROTECTED]> wrote:
> There is no way to get rid of the warnings in our codebase on linux?
> 
> geir
> 
> On Sep 19, 2006, at 4:03 AM, Leo Li wrote:
> 
> > Hi, Geir:
> >  The warning level is set to level 3 while the warning as error  
> > option is
> > off in linux.
> >  Actually, I would like to set it on in linux since it will help me  
> > to pick
> > some error out, for example, wrongly use pointers. However, I have  
> > tried to
> > set it on, but some unavoidable warning will lead to a failure in  
> > Harmony
> > building. Any good idea?:)
> >
> > Good luck!
> >
> > On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
> >>
> >> Lets get these aligned...  I tend to work on linux, so it had no
> >> problem building..
> >>
> >> geir
> >>
> >> On Sep 18, 2006, at 10:14 PM, Leo Li wrote:
> >>
> >> > Just comment it out since it is just a warning treated as error.
> >> > It compiles successfully and runs well.
> >> > Maybe it will not lead to such an error on Linux due to the
> >> > configuration of
> >> > make rules.:)
> >> >
> >> > Good luck!
> >> >
> >> >
> >> > On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:
> >> >>
> >> >> Hi All:
> >> >> When building today's(Sep 19, r447671) classlib on window xp, I
> >> >> got the
> >> >> following error message:
> >> >> [exec] main.c
> >> >> [exec] ..\shared\main.c(628) : error C2220: warning treated as
> >> >> error - no o
> >> >> bject file generated
> >> >> [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
> >> >> unreferenced lo
> >> >> cal variable
> >> >> [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
> >> >> [exec] Stop.
> >> >> [exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
> >> >> Visual Studi
> >> >> o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
> >> >> [exec] Stop.
> >> >>
> >> >> BUILD FAILED
> >> >> C:\spark\harmony\build.xml:95: The following error occurred while
> >> >> executing this
> >> >> line:
> >> >> C:\spark\harmony\make\build-native.xml:75: The following error
> >> >> occurred
> >> >> while ex
> >> >> ecuting this line:
> >> >> C:\spark\harmony\modules\luni\build.xml:167: The following error
> >> >> occurred while
> >> >> executing this line:
> >> >> C:\spark\harmony\make\properties.xml:258: exec returned: 2
> >> >>
> >> >> Could any one check it?
> >> >>
> >> >> Best regards
> >> >>
> >> >> --
> >> >> Spark Shen
> >> >> China Software Development Lab, IBM
> >> >>
> >> >>
> >> >>  
> >> -
> >> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> >> To unsubscribe, e-mail: harmony-dev- 
> >> [EMAIL PROTECTED]
> >> >> For additional commands, e-mail: harmony-dev-
> >> >> [EMAIL PROTECTED]
> >> >>
> >> >>
> >> >
> >> >
> >> > --
> >> > Leo Li
> >> > China Software Development Lab, IBM
> >>
> >>
> >> -
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: harmony-dev- 
> >> [EMAIL PROTECTED]
> >>
> >>
> >
> >
> > -- 
> > Leo Li
> > China Software Development Lab, IBM
> 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Geir Magnusson Jr.]

There is no way to get rid of the warnings in our codebase on linux?

geir

On Sep 19, 2006, at 4:03 AM, Leo Li wrote:


Hi, Geir:
 The warning level is set to level 3 while the warning as error  
option is

off in linux.
 Actually, I would like to set it on in linux since it will help me  
to pick
some error out, for example, wrongly use pointers. However, I have  
tried to
set it on, but some unavoidable warning will lead to a failure in  
Harmony

building. Any good idea?:)

Good luck!

On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:


Lets get these aligned...  I tend to work on linux, so it had no
problem building..

geir

On Sep 18, 2006, at 10:14 PM, Leo Li wrote:

> Just comment it out since it is just a warning treated as error.
> It compiles successfully and runs well.
> Maybe it will not lead to such an error on Linux due to the
> configuration of
> make rules.:)
>
> Good luck!
>
>
> On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:
>>
>> Hi All:
>> When building today's(Sep 19, r447671) classlib on window xp, I
>> got the
>> following error message:
>> [exec] main.c
>> [exec] ..\shared\main.c(628) : error C2220: warning treated as
>> error - no o
>> bject file generated
>> [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
>> unreferenced lo
>> cal variable
>> [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
>> [exec] Stop.
>> [exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
>> Visual Studi
>> o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
>> [exec] Stop.
>>
>> BUILD FAILED
>> C:\spark\harmony\build.xml:95: The following error occurred while
>> executing this
>> line:
>> C:\spark\harmony\make\build-native.xml:75: The following error
>> occurred
>> while ex
>> ecuting this line:
>> C:\spark\harmony\modules\luni\build.xml:167: The following error
>> occurred while
>> executing this line:
>> C:\spark\harmony\make\properties.xml:258: exec returned: 2
>>
>> Could any one check it?
>>
>> Best regards
>>
>> --
>> Spark Shen
>> China Software Development Lab, IBM
>>
>>
>>  
-

>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev- 
[EMAIL PROTECTED]

>> For additional commands, e-mail: harmony-dev-
>> [EMAIL PROTECTED]
>>
>>
>
>
> --
> Leo Li
> China Software Development Lab, IBM


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev- 
[EMAIL PROTECTED]






--
Leo Li
China Software Development Lab, IBM



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Leo Li]

The warning level is set to level 3 on windows, I mean.

On 9/19/06, Leo Li <[EMAIL PROTECTED]> wrote:


 Hi, Geir:
  The warning level is set to level 3 while the warning as error option is
off in linux.
  Actually, I would like to set it on in linux since it will help me to
pick some error out, for example, wrongly use pointers. However, I have
tried to set it on, but some unavoidable warning will lead to a failure in
Harmony building. Any good idea?:)

Good luck!

 On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
>
> Lets get these aligned...  I tend to work on linux, so it had no
> problem building..
>
> geir
>
> On Sep 18, 2006, at 10:14 PM, Leo Li wrote:
>
> > Just comment it out since it is just a warning treated as error.
> > It compiles successfully and runs well.
> > Maybe it will not lead to such an error on Linux due to the
> > configuration of
> > make rules.:)
> >
> > Good luck!
> >
> >
> > On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:
> >>
> >> Hi All:
> >> When building today's(Sep 19, r447671) classlib on window xp, I
> >> got the
> >> following error message:
> >> [exec] main.c
> >> [exec] ..\shared\main.c(628) : error C2220: warning treated as
> >> error - no o
> >> bject file generated
> >> [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
> >> unreferenced lo
> >> cal variable
> >> [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
> >> [exec] Stop.
> >> [exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
> >> Visual Studi
> >> o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
> >> [exec] Stop.
> >>
> >> BUILD FAILED
> >> C:\spark\harmony\build.xml:95: The following error occurred while
> >> executing this
> >> line:
> >> C:\spark\harmony\make\build-native.xml:75: The following error
> >> occurred
> >> while ex
> >> ecuting this line:
> >> C:\spark\harmony\modules\luni\build.xml:167: The following error
> >> occurred while
> >> executing this line:
> >> C:\spark\harmony\make\properties.xml:258: exec returned: 2
> >>
> >> Could any one check it?
> >>
> >> Best regards
> >>
> >> --
> >> Spark Shen
> >> China Software Development Lab, IBM
> >>
> >>
> >> -
>
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: harmony-dev-
> >> [EMAIL PROTECTED]
> >>
> >>
> >
> >
> > --
> > Leo Li
> > China Software Development Lab, IBM
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


--
Leo Li
China Software Development Lab, IBM





--
Leo Li
China Software Development Lab, IBM

Re: [classlib][build] failure?

[Leo Li]

Hi, Geir:
 The warning level is set to level 3 while the warning as error option is
off in linux.
 Actually, I would like to set it on in linux since it will help me to pick
some error out, for example, wrongly use pointers. However, I have tried to
set it on, but some unavoidable warning will lead to a failure in Harmony
building. Any good idea?:)

Good luck!

On 9/19/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:


Lets get these aligned...  I tend to work on linux, so it had no
problem building..

geir

On Sep 18, 2006, at 10:14 PM, Leo Li wrote:

> Just comment it out since it is just a warning treated as error.
> It compiles successfully and runs well.
> Maybe it will not lead to such an error on Linux due to the
> configuration of
> make rules.:)
>
> Good luck!
>
>
> On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:
>>
>> Hi All:
>> When building today's(Sep 19, r447671) classlib on window xp, I
>> got the
>> following error message:
>> [exec] main.c
>> [exec] ..\shared\main.c(628) : error C2220: warning treated as
>> error - no o
>> bject file generated
>> [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
>> unreferenced lo
>> cal variable
>> [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
>> [exec] Stop.
>> [exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
>> Visual Studi
>> o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
>> [exec] Stop.
>>
>> BUILD FAILED
>> C:\spark\harmony\build.xml:95: The following error occurred while
>> executing this
>> line:
>> C:\spark\harmony\make\build-native.xml:75: The following error
>> occurred
>> while ex
>> ecuting this line:
>> C:\spark\harmony\modules\luni\build.xml:167: The following error
>> occurred while
>> executing this line:
>> C:\spark\harmony\make\properties.xml:258: exec returned: 2
>>
>> Could any one check it?
>>
>> Best regards
>>
>> --
>> Spark Shen
>> China Software Development Lab, IBM
>>
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: harmony-dev-
>> [EMAIL PROTECTED]
>>
>>
>
>
> --
> Leo Li
> China Software Development Lab, IBM


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Leo Li
China Software Development Lab, IBM

Re: [classlib][build] failure?

[Geir Magnusson Jr.]

Lets get these aligned...  I tend to work on linux, so it had no  
problem building..


geir

On Sep 18, 2006, at 10:14 PM, Leo Li wrote:


Just comment it out since it is just a warning treated as error.
It compiles successfully and runs well.
Maybe it will not lead to such an error on Linux due to the  
configuration of

make rules.:)

Good luck!


On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:


Hi All:
When building today's(Sep 19, r447671) classlib on window xp, I  
got the

following error message:
[exec] main.c
[exec] ..\shared\main.c(628) : error C2220: warning treated as
error - no o
bject file generated
[exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
unreferenced lo
cal variable
[exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
[exec] Stop.
[exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
Visual Studi
o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
[exec] Stop.

BUILD FAILED
C:\spark\harmony\build.xml:95: The following error occurred while
executing this
line:
C:\spark\harmony\make\build-native.xml:75: The following error  
occurred

while ex
ecuting this line:
C:\spark\harmony\modules\luni\build.xml:167: The following error
occurred while
executing this line:
C:\spark\harmony\make\properties.xml:258: exec returned: 2

Could any one check it?

Best regards

--
Spark Shen
China Software Development Lab, IBM


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev- 
[EMAIL PROTECTED]






--
Leo Li
China Software Development Lab, IBM



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Spark Shen]

Nathan Beyer 写道:

I just checked in a fix for this. The jarRunner variable needed to be
commented out, as the code that used it was commented out.

Try it now and see if it compiles.
  

Seems caused by restored the capability to do
java -jar foo.jar :-)

And now, it builds. Thanks a lot.

Best regards

-Nathan

  

-Original Message-
From: Spark Shen [mailto:[EMAIL PROTECTED]
Sent: Monday, September 18, 2006 8:49 PM
To: harmony-dev@incubator.apache.org
Subject: [classlib][build] failure?

Hi All:
When building today's(Sep 19, r447671) classlib on window xp, I got the
following error message:
 [exec] main.c
 [exec] ..\shared\main.c(628) : error C2220: warning treated as
error - no o
bject file generated
 [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
unreferenced lo
cal variable
 [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
 [exec] Stop.
 [exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
Visual Studi
o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
 [exec] Stop.

BUILD FAILED
C:\spark\harmony\build.xml:95: The following error occurred while
executing this
 line:
C:\spark\harmony\make\build-native.xml:75: The following error occurred
while ex
ecuting this line:
C:\spark\harmony\modules\luni\build.xml:167: The following error
occurred while
executing this line:
C:\spark\harmony\make\properties.xml:258: exec returned: 2

Could any one check it?

Best regards

--
Spark Shen
China Software Development Lab, IBM


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


  



--
Spark Shen
China Software Development Lab, IBM


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib][build] failure?

[Leo Li]

Just comment it out since it is just a warning treated as error.
It compiles successfully and runs well.
Maybe it will not lead to such an error on Linux due to the configuration of
make rules.:)

Good luck!


On 9/19/06, Spark Shen <[EMAIL PROTECTED]> wrote:


Hi All:
When building today's(Sep 19, r447671) classlib on window xp, I got the
following error message:
[exec] main.c
[exec] ..\shared\main.c(628) : error C2220: warning treated as
error - no o
bject file generated
[exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
unreferenced lo
cal variable
[exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
[exec] Stop.
[exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
Visual Studi
o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
[exec] Stop.

BUILD FAILED
C:\spark\harmony\build.xml:95: The following error occurred while
executing this
line:
C:\spark\harmony\make\build-native.xml:75: The following error occurred
while ex
ecuting this line:
C:\spark\harmony\modules\luni\build.xml:167: The following error
occurred while
executing this line:
C:\spark\harmony\make\properties.xml:258: exec returned: 2

Could any one check it?

Best regards

--
Spark Shen
China Software Development Lab, IBM


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Leo Li
China Software Development Lab, IBM

RE: [classlib][build] failure?

[Nathan Beyer]

I just checked in a fix for this. The jarRunner variable needed to be
commented out, as the code that used it was commented out.

Try it now and see if it compiles.

-Nathan

> -Original Message-
> From: Spark Shen [mailto:[EMAIL PROTECTED]
> Sent: Monday, September 18, 2006 8:49 PM
> To: harmony-dev@incubator.apache.org
> Subject: [classlib][build] failure?
> 
> Hi All:
> When building today's(Sep 19, r447671) classlib on window xp, I got the
> following error message:
>  [exec] main.c
>  [exec] ..\shared\main.c(628) : error C2220: warning treated as
> error - no o
> bject file generated
>  [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' :
> unreferenced lo
> cal variable
>  [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2'
>  [exec] Stop.
>  [exec] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft
> Visual Studi
> o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
>  [exec] Stop.
> 
> BUILD FAILED
> C:\spark\harmony\build.xml:95: The following error occurred while
> executing this
>  line:
> C:\spark\harmony\make\build-native.xml:75: The following error occurred
> while ex
> ecuting this line:
> C:\spark\harmony\modules\luni\build.xml:167: The following error
> occurred while
> executing this line:
> C:\spark\harmony\make\properties.xml:258: exec returned: 2
> 
> Could any one check it?
> 
> Best regards
> 
> --
> Spark Shen
> China Software Development Lab, IBM
> 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Geir Magnusson Jr]

so a message size limit doesn't sound like the problem

hm...

did you see any bouncebacks?

Mark Hindess wrote:
> On 9 June 2006 at 13:09, Tim Ellison <[EMAIL PROTECTED]> wrote:
>> Geir Magnusson Jr wrote:
>>> do you mean larger?
>> It may be larger if the last test fails with a walkback ;-) but
>> generally the build fails part way through, with a message, and the rest
>> of the log is not written, so it is smaller overall.
> 
> That's what I was thinking.
> 
> I decided to check the size of the build logs, since that's what the
> messages are (plus a bit for message headers), and the recent ones are
> smaller since they don't have the "self-build" with eclipse step (that I
> plan to switch on again soon).
> 
> The log sizes varied from 203 bytes to 876391 bytes.
> 
> Regards,
>  Mark.
> 
>> Regards,
>> Tim
>>
>> I was wondering what the size is so I can see if
>>> it's the threshold set on the list, or something else...
>>>
>>> geir
>>>
>>>
>>> Mark Hindess wrote:
 Just about to go offline, but I'd guess smaller since not as much works!
 ;-)

 -Mark.

 On 9 June 2006 at 7:01, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> any clue about how big a failed message is (if you can figure that out...
>> )?
> geir
>
> Mark Hindess wrote:
>> The most recent success message was 343k at approximately 
>> Fri, 09 Jun 06 11:26:34 +0100.
>>
>> -Mark.
>>
>> On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
>>> A large message should still generate a bounce...
>>>
>>> I'll go look to see what the size is.
>>>
>>> How large are these messages?
>>>
>>> Mark Hindess wrote:
 On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> w
>> rot
> e:
> Hi Tim,
>
> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
>> I see it too.
>>
>> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putt
>> ing
>> in new code until this is resolved?
>  I didn't update this particular file because I work separately with
> security module only.
> But I think that you are right - it'd better to stop putting new code
>>  on
> ce
> we get notification that the build is broken.
>
> BTW, where is classlib build status emails? I didn't get any notifica
>> tio
> n.
 I think they are failing to get to the list because they are too large
>> .
 I tried changing the envelope sender to my gmail account - which is
 subscribed to the -commits list, but they still don't make the list
 or generate any bounce messages.  I've changed the sender back to
 <[EMAIL PROTECTED]> as it was originally.

 Regards,
  Mark.



 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>> -- 
>>
>> Tim Ellison ([EMAIL PROTECTED])
>> IBM Java technology centre, UK.
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

--

Re: [classlib] build failure

[Geir Magnusson Jr]

Ok.

What I'm trying to determine is if the messages that are being generated
now are larger than the last message that went through.

If they aren't, then it's probably not a message-size limit imposed by
the list and we have to look elsewhere.

So, is the message that is trying to be sent now bigger or smaller then
the last message that went through?

geir



Tim Ellison wrote:
> Geir Magnusson Jr wrote:
>> do you mean larger?
> 
> It may be larger if the last test fails with a walkback ;-) but
> generally the build fails part way through, with a message, and the rest
> of the log is not written, so it is smaller overall.
> 
> Regards,
> Tim
> 
> I was wondering what the size is so I can see if
>> it's the threshold set on the list, or something else...
>>
>> geir
>>
>>
>> Mark Hindess wrote:
>>> Just about to go offline, but I'd guess smaller since not as much works!
>>> ;-)
>>>
>>> -Mark.
>>>
>>> On 9 June 2006 at 7:01, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
 any clue about how big a failed message is (if you can figure that out...)?

 geir

 Mark Hindess wrote:
> The most recent success message was 343k at approximately 
> Fri, 09 Jun 06 11:26:34 +0100.
>
> -Mark.
>
> On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
>> A large message should still generate a bounce...
>>
>> I'll go look to see what the size is.
>>
>> How large are these messages?
>>
>> Mark Hindess wrote:
>>> On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrot
 e:
 Hi Tim,

 On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> I see it too.
>
> Stepan / Mikhail, do you get build failures?  Shouldn't we stop 
> putting
> in new code until this is resolved?
  I didn't update this particular file because I work separately with
 security module only.
 But I think that you are right - it'd better to stop putting new code 
 on
 ce
 we get notification that the build is broken.

 BTW, where is classlib build status emails? I didn't get any 
 notificatio
 n.
>>> I think they are failing to get to the list because they are too large.
>>> I tried changing the envelope sender to my gmail account - which is
>>> subscribed to the -commits list, but they still don't make the list
>>> or generate any bounce messages.  I've changed the sender back to
>>> <[EMAIL PROTECTED]> as it was originally.
>>>
>>> Regards,
>>>  Mark.
>>>
>>>
>>>
>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Mark Hindess]

On 9 June 2006 at 13:09, Tim Ellison <[EMAIL PROTECTED]> wrote:
> Geir Magnusson Jr wrote:
> > do you mean larger?
> 
> It may be larger if the last test fails with a walkback ;-) but
> generally the build fails part way through, with a message, and the rest
> of the log is not written, so it is smaller overall.

That's what I was thinking.

I decided to check the size of the build logs, since that's what the
messages are (plus a bit for message headers), and the recent ones are
smaller since they don't have the "self-build" with eclipse step (that I
plan to switch on again soon).

The log sizes varied from 203 bytes to 876391 bytes.

Regards,
 Mark.

> Regards,
> Tim
> 
> I was wondering what the size is so I can see if
> > it's the threshold set on the list, or something else...
> > 
> > geir
> > 
> > 
> > Mark Hindess wrote:
> >> Just about to go offline, but I'd guess smaller since not as much works!
> >> ;-)
> >>
> >> -Mark.
> >>
> >> On 9 June 2006 at 7:01, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> >>> any clue about how big a failed message is (if you can figure that out...
> )?
> >>>
> >>> geir
> >>>
> >>> Mark Hindess wrote:
>  The most recent success message was 343k at approximately 
>  Fri, 09 Jun 06 11:26:34 +0100.
> 
>  -Mark.
> 
>  On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> > A large message should still generate a bounce...
> >
> > I'll go look to see what the size is.
> >
> > How large are these messages?
> >
> > Mark Hindess wrote:
> >> On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> w
> rot
> >>> e:
> >>> Hi Tim,
> >>>
> >>> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
>  I see it too.
> 
>  Stepan / Mikhail, do you get build failures?  Shouldn't we stop putt
> ing
>  in new code until this is resolved?
> >>>  I didn't update this particular file because I work separately with
> >>> security module only.
> >>> But I think that you are right - it'd better to stop putting new code
>  on
> >>> ce
> >>> we get notification that the build is broken.
> >>>
> >>> BTW, where is classlib build status emails? I didn't get any notifica
> tio
> >>> n.
> >> I think they are failing to get to the list because they are too large
> .
> >> I tried changing the envelope sender to my gmail account - which is
> >> subscribed to the -commits list, but they still don't make the list
> >> or generate any bounce messages.  I've changed the sender back to
> >> <[EMAIL PROTECTED]> as it was originally.
> >>
> >> Regards,
> >>  Mark.
> >>
> >>
> >>
> >> -
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> 
>  -
>  Terms of use : http://incubator.apache.org/harmony/mailing.html
>  To unsubscribe, e-mail: [EMAIL PROTECTED]
>  For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> >>> -
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> >> -
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> > 
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> > 
> > 
> 
> -- 
> 
> Tim Ellison ([EMAIL PROTECTED])
> IBM Java technology centre, UK.
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Tim Ellison]

Geir Magnusson Jr wrote:
> do you mean larger?

It may be larger if the last test fails with a walkback ;-) but
generally the build fails part way through, with a message, and the rest
of the log is not written, so it is smaller overall.

Regards,
Tim

I was wondering what the size is so I can see if
> it's the threshold set on the list, or something else...
> 
> geir
> 
> 
> Mark Hindess wrote:
>> Just about to go offline, but I'd guess smaller since not as much works!
>> ;-)
>>
>> -Mark.
>>
>> On 9 June 2006 at 7:01, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
>>> any clue about how big a failed message is (if you can figure that out...)?
>>>
>>> geir
>>>
>>> Mark Hindess wrote:
 The most recent success message was 343k at approximately 
 Fri, 09 Jun 06 11:26:34 +0100.

 -Mark.

 On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> A large message should still generate a bounce...
>
> I'll go look to see what the size is.
>
> How large are these messages?
>
> Mark Hindess wrote:
>> On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrot
>>> e:
>>> Hi Tim,
>>>
>>> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
 I see it too.

 Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
 in new code until this is resolved?
>>>  I didn't update this particular file because I work separately with
>>> security module only.
>>> But I think that you are right - it'd better to stop putting new code on
>>> ce
>>> we get notification that the build is broken.
>>>
>>> BTW, where is classlib build status emails? I didn't get any notificatio
>>> n.
>> I think they are failing to get to the list because they are too large.
>> I tried changing the envelope sender to my gmail account - which is
>> subscribed to the -commits list, but they still don't make the list
>> or generate any bounce messages.  I've changed the sender back to
>> <[EMAIL PROTECTED]> as it was originally.
>>
>> Regards,
>>  Mark.
>>
>>
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Geir Magnusson Jr]

do you mean larger?  I was wondering what the size is so I can see if
it's the threshold set on the list, or something else...

geir


Mark Hindess wrote:
> Just about to go offline, but I'd guess smaller since not as much works!
> ;-)
> 
> -Mark.
> 
> On 9 June 2006 at 7:01, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
>> any clue about how big a failed message is (if you can figure that out...)?
>>
>> geir
>>
>> Mark Hindess wrote:
>>> The most recent success message was 343k at approximately 
>>> Fri, 09 Jun 06 11:26:34 +0100.
>>>
>>> -Mark.
>>>
>>> On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
 A large message should still generate a bounce...

 I'll go look to see what the size is.

 How large are these messages?

 Mark Hindess wrote:
> On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrot
>> e:
>> Hi Tim,
>>
>> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
>>> I see it too.
>>>
>>> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
>>> in new code until this is resolved?
>>  I didn't update this particular file because I work separately with
>> security module only.
>> But I think that you are right - it'd better to stop putting new code on
>> ce
>> we get notification that the build is broken.
>>
>> BTW, where is classlib build status emails? I didn't get any notificatio
>> n.
> I think they are failing to get to the list because they are too large.
> I tried changing the envelope sender to my gmail account - which is
> subscribed to the -commits list, but they still don't make the list
> or generate any bounce messages.  I've changed the sender back to
> <[EMAIL PROTECTED]> as it was originally.
>
> Regards,
>  Mark.
>
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Mark Hindess]

Just about to go offline, but I'd guess smaller since not as much works!
;-)

-Mark.

On 9 June 2006 at 7:01, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> any clue about how big a failed message is (if you can figure that out...)?
> 
> geir
> 
> Mark Hindess wrote:
> > The most recent success message was 343k at approximately 
> > Fri, 09 Jun 06 11:26:34 +0100.
> > 
> > -Mark.
> > 
> > On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> >> A large message should still generate a bounce...
> >>
> >> I'll go look to see what the size is.
> >>
> >> How large are these messages?
> >>
> >> Mark Hindess wrote:
> >>> On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrot
> e:
>  Hi Tim,
> 
>  On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> > I see it too.
> >
> > Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
> > in new code until this is resolved?
>   I didn't update this particular file because I work separately with
>  security module only.
>  But I think that you are right - it'd better to stop putting new code on
> ce
>  we get notification that the build is broken.
> 
>  BTW, where is classlib build status emails? I didn't get any notificatio
> n.
> >>> I think they are failing to get to the list because they are too large.
> >>> I tried changing the envelope sender to my gmail account - which is
> >>> subscribed to the -commits list, but they still don't make the list
> >>> or generate any bounce messages.  I've changed the sender back to
> >>> <[EMAIL PROTECTED]> as it was originally.
> >>>
> >>> Regards,
> >>>  Mark.
> >>>
> >>>
> >>>
> >>> -
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>> For additional commands, e-mail: [EMAIL PROTECTED]
> >>>
> >>>
> >> -
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> > 
> > 
> > 
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> > 
> > 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Geir Magnusson Jr]

any clue about how big a failed message is (if you can figure that out...)?

geir

Mark Hindess wrote:
> The most recent success message was 343k at approximately 
> Fri, 09 Jun 06 11:26:34 +0100.
> 
> -Mark.
> 
> On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
>> A large message should still generate a bounce...
>>
>> I'll go look to see what the size is.
>>
>> How large are these messages?
>>
>> Mark Hindess wrote:
>>> On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrote:
 Hi Tim,

 On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> I see it too.
>
> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
> in new code until this is resolved?
  I didn't update this particular file because I work separately with
 security module only.
 But I think that you are right - it'd better to stop putting new code once
 we get notification that the build is broken.

 BTW, where is classlib build status emails? I didn't get any notification.
>>> I think they are failing to get to the list because they are too large.
>>> I tried changing the envelope sender to my gmail account - which is
>>> subscribed to the -commits list, but they still don't make the list
>>> or generate any bounce messages.  I've changed the sender back to
>>> <[EMAIL PROTECTED]> as it was originally.
>>>
>>> Regards,
>>>  Mark.
>>>
>>>
>>>
>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>> -
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Mark Hindess]

The most recent success message was 343k at approximately 
Fri, 09 Jun 06 11:26:34 +0100.

-Mark.

On 9 June 2006 at 6:33, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
> A large message should still generate a bounce...
> 
> I'll go look to see what the size is.
> 
> How large are these messages?
> 
> Mark Hindess wrote:
> > On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrote:
> >> Hi Tim,
> >>
> >> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> >>> I see it too.
> >>>
> >>> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
> >>> in new code until this is resolved?
> >>
> >>  I didn't update this particular file because I work separately with
> >> security module only.
> >> But I think that you are right - it'd better to stop putting new code once
> >> we get notification that the build is broken.
> >>
> >> BTW, where is classlib build status emails? I didn't get any notification.
> > 
> > I think they are failing to get to the list because they are too large.
> > I tried changing the envelope sender to my gmail account - which is
> > subscribed to the -commits list, but they still don't make the list
> > or generate any bounce messages.  I've changed the sender back to
> > <[EMAIL PROTECTED]> as it was originally.
> > 
> > Regards,
> >  Mark.
> > 
> > 
> > 
> > -
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> > 
> > 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Geir Magnusson Jr]

A large message should still generate a bounce...

I'll go look to see what the size is.

How large are these messages?

Mark Hindess wrote:
> On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrote:
>> Hi Tim,
>>
>> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
>>> I see it too.
>>>
>>> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
>>> in new code until this is resolved?
>>
>>  I didn't update this particular file because I work separately with
>> security module only.
>> But I think that you are right - it'd better to stop putting new code once
>> we get notification that the build is broken.
>>
>> BTW, where is classlib build status emails? I didn't get any notification.
> 
> I think they are failing to get to the list because they are too large.
> I tried changing the envelope sender to my gmail account - which is
> subscribed to the -commits list, but they still don't make the list
> or generate any bounce messages.  I've changed the sender back to
> <[EMAIL PROTECTED]> as it was originally.
> 
> Regards,
>  Mark.
> 
> 
> 
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Geir Magnusson Jr]

I checked the allow list, and

[EMAIL PROTECTED]

is still there.

I'm assuming that this isn't a real account.  Any chance you could
switch to one to test, so you can see the bounceback if there is one?

geir


Tim Ellison wrote:
> Stepan Mishura wrote:
>> Hi Tim,
>>
>> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
>>> I see it too.
>>>
>>> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
>>> in new code until this is resolved?
>>
>> I didn't update this particular file because I work separately with
>> security module only.
>> But I think that you are right - it'd better to stop putting new code once
>> we get notification that the build is broken.
>>
>> BTW, where is classlib build status emails? I didn't get any notification.
> 
> AFAIK they are still being sent out -- possibly a problem with them
> being accepted on the commit list?.
> 
> Regards,
> Tim
> 
>> I am happy to take a look at the error, and if it is not a quick fix I
>>> think we can roll back Collections without trouble.
>>>
>>> Regards,
>>> Tim
>>>
>>>
>>> Geir Magnusson Jr wrote:
 and the beer flowed

 Mark Hindess wrote:
> This breaks the build.  I'm getting:
>
> compile:
> [javac] Compiling 1839 source files to
>>> /pbuilder/tmp/Harmony.clean/build
> [javac]
>>> /pbuilder/tmp/Harmony.clean/modules/luni/src/main/java/java/util/Collections.java:1074:
>>>
>>> name clash: add(java.lang.Object) in
>>> java.util.Collections.UnmodifiableCollection>
>>> and
>>> add(E) in java.util.Set> have the same erasure,
>>> yet neither overrides the other
> [javac] private static class
>>> UnmodifiableEntrySet
>>> extends UnmodifiableSet> {
> [javac]^
>
> w/sun 1.5 javac on linux.
>
> Regards,
>  Mark.
>
> On 9 June 2006 at 4:59, [EMAIL PROTECTED] wrote:
>> Author: ndbeyer
>> Date: Thu Jun  8 21:59:15 2006
>> New Revision: 412928
>>
>> URL: http://svn.apache.org/viewvc?rev=412928&view=rev
>> Log:
>> Generification of methods.
>>
>> Modified:
>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
>> /util/Collections.java
>>
>> Modified:
>>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/jav
>> a/java/util/Collections.java
>> URL:
>>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>>> odules/luni/src/main/java/java/util/Collections.java?rev=412928&r1=412927&r2=
>>>
>> 412928&view=diff
>>> 
>>>
>>
>> --
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
> 

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Mark Hindess]

On 9 June 2006 at 16:55, "Stepan Mishura" <[EMAIL PROTECTED]> wrote:
>
> Hi Tim,
> 
> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
> >
> > I see it too.
> >
> > Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
> > in new code until this is resolved?
> 
> 
>  I didn't update this particular file because I work separately with
> security module only.
> But I think that you are right - it'd better to stop putting new code once
> we get notification that the build is broken.
> 
> BTW, where is classlib build status emails? I didn't get any notification.

I think they are failing to get to the list because they are too large.
I tried changing the envelope sender to my gmail account - which is
subscribed to the -commits list, but they still don't make the list
or generate any bounce messages.  I've changed the sender back to
<[EMAIL PROTECTED]> as it was originally.

Regards,
 Mark.



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Tim Ellison]

Stepan Mishura wrote:
> Hi Tim,
> 
> On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:
>>
>> I see it too.
>>
>> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
>> in new code until this is resolved?
> 
> 
> I didn't update this particular file because I work separately with
> security module only.
> But I think that you are right - it'd better to stop putting new code once
> we get notification that the build is broken.
> 
> BTW, where is classlib build status emails? I didn't get any notification.

AFAIK they are still being sent out -- possibly a problem with them
being accepted on the commit list?.

Regards,
Tim

> I am happy to take a look at the error, and if it is not a quick fix I
>> think we can roll back Collections without trouble.
>>
>> Regards,
>> Tim
>>
>>
>> Geir Magnusson Jr wrote:
>> > and the beer flowed
>> >
>> > Mark Hindess wrote:
>> >> This breaks the build.  I'm getting:
>> >>
>> >> compile:
>> >> [javac] Compiling 1839 source files to
>> /pbuilder/tmp/Harmony.clean/build
>> >> [javac]
>> /pbuilder/tmp/Harmony.clean/modules/luni/src/main/java/java/util/Collections.java:1074:
>>
>> name clash: add(java.lang.Object) in
>> java.util.Collections.UnmodifiableCollection>
>> and
>> add(E) in java.util.Set> have the same erasure,
>> yet neither overrides the other
>> >> [javac] private static class
>> UnmodifiableEntrySet
>> extends UnmodifiableSet> {
>> >> [javac]^
>> >>
>> >> w/sun 1.5 javac on linux.
>> >>
>> >> Regards,
>> >>  Mark.
>> >>
>> >> On 9 June 2006 at 4:59, [EMAIL PROTECTED] wrote:
>> >>> Author: ndbeyer
>> >>> Date: Thu Jun  8 21:59:15 2006
>> >>> New Revision: 412928
>> >>>
>> >>> URL: http://svn.apache.org/viewvc?rev=412928&view=rev
>> >>> Log:
>> >>> Generification of methods.
>> >>>
>> >>> Modified:
>> >>>
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
>> >>> /util/Collections.java
>> >>>
>> >>> Modified:
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/jav
>> >>> a/java/util/Collections.java
>> >>> URL:
>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>> >>>
>> odules/luni/src/main/java/java/util/Collections.java?rev=412928&r1=412927&r2=
>>
>> >>> 412928&view=diff
>> 
>>
> 
> 
> --
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Stepan Mishura]

Hi Tim,

On 6/9/06, Tim Ellison <[EMAIL PROTECTED]> wrote:


I see it too.

Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
in new code until this is resolved?



I didn't update this particular file because I work separately with
security module only.
But I think that you are right - it'd better to stop putting new code once
we get notification that the build is broken.

BTW, where is classlib build status emails? I didn't get any notification.

Thanks,
Stepan.

I am happy to take a look at the error, and if it is not a quick fix I

think we can roll back Collections without trouble.

Regards,
Tim


Geir Magnusson Jr wrote:
> and the beer flowed
>
> Mark Hindess wrote:
>> This breaks the build.  I'm getting:
>>
>> compile:
>> [javac] Compiling 1839 source files to
/pbuilder/tmp/Harmony.clean/build
>> [javac]
/pbuilder/tmp/Harmony.clean/modules/luni/src/main/java/java/util/Collections.java:1074:
name clash: add(java.lang.Object) in
java.util.Collections.UnmodifiableCollection> and
add(E) in java.util.Set> have the same erasure,
yet neither overrides the other
>> [javac] private static class UnmodifiableEntrySet
extends UnmodifiableSet> {
>> [javac]^
>>
>> w/sun 1.5 javac on linux.
>>
>> Regards,
>>  Mark.
>>
>> On 9 June 2006 at 4:59, [EMAIL PROTECTED] wrote:
>>> Author: ndbeyer
>>> Date: Thu Jun  8 21:59:15 2006
>>> New Revision: 412928
>>>
>>> URL: http://svn.apache.org/viewvc?rev=412928&view=rev
>>> Log:
>>> Generification of methods.
>>>
>>> Modified:
>>>
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
>>> /util/Collections.java
>>>
>>> Modified:
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/jav
>>> a/java/util/Collections.java
>>> URL:
http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>>>
odules/luni/src/main/java/java/util/Collections.java?rev=412928&r1=412927&r2=
>>> 412928&view=diff





--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] build failure

[Tim Ellison]

Yep, that was the plan, but it was a trivial fix (in repo >= r412990).

Just wondering how Mikhail/Stepan got it to build?  It may be a
consequence of different compiler versions again since I did not see a
compiler error on the Eclipse compiler either.

Regards,
Tim

Geir Magnusson Jr wrote:
> If it isn't really quick, roll it back and let Nathan fix it...
> 
> geir
> 
> Tim Ellison wrote:
>> I see it too.
>>
>> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
>> in new code until this is resolved?
>>
>> I am happy to take a look at the error, and if it is not a quick fix I
>> think we can roll back Collections without trouble.
>>
>> Regards,
>> Tim
>>
>>
>> Geir Magnusson Jr wrote:
>>> and the beer flowed
>>>
>>> Mark Hindess wrote:
 This breaks the build.  I'm getting:

 compile:
 [javac] Compiling 1839 source files to 
 /pbuilder/tmp/Harmony.clean/build
 [javac] 
 /pbuilder/tmp/Harmony.clean/modules/luni/src/main/java/java/util/Collections.java:1074:
  name clash: add(java.lang.Object) in 
 java.util.Collections.UnmodifiableCollection> and 
 add(E) in java.util.Set> have the same erasure, 
 yet neither overrides the other
 [javac] private static class UnmodifiableEntrySet 
 extends UnmodifiableSet> {
 [javac]^

 w/sun 1.5 javac on linux.

 Regards,
  Mark.

 On 9 June 2006 at 4:59, [EMAIL PROTECTED] wrote:
> Author: ndbeyer
> Date: Thu Jun  8 21:59:15 2006
> New Revision: 412928
>
> URL: http://svn.apache.org/viewvc?rev=412928&view=rev
> Log:
> Generification of methods.
>
> Modified:
> 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
> /util/Collections.java
>
> Modified: 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/jav
> a/java/util/Collections.java
> URL: 
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
> odules/luni/src/main/java/java/util/Collections.java?rev=412928&r1=412927&r2=
> 412928&view=diff
> =
> =
> --- 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
> /util/Collections.java (original)
> +++ 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
> /util/Collections.java Thu Jun  8 21:59:15 2006
> @@ -27,15 +27,15 @@
>   */
>  public class Collections {
>  
> - private static final class CopiesList extends AbstractList implements
> + private static final class CopiesList extends AbstractList implem
> ents
>   Serializable {
>   private static final long serialVersionUID = 273909926839871180
> 0L;
>  
>   private final int n;
>  
> - private final Object element;
> + private final E element;
>  
> - CopiesList(int length, Object object) {
> + CopiesList(int length, E object) {
>   if (length < 0) {
>   throw new IllegalArgumentException();
>   }
> @@ -51,7 +51,7 @@
>   return n;
>   }
>  
> - public Object get(int location) {
> + public E get(int location) {
>   if (0 <= location && location < n)
>   return element;
>   throw new IndexOutOfBoundsException();
> @@ -162,13 +162,13 @@
>  }
>  }
>  
> - private static final class SingletonSet extends AbstractSet implements
> + private static final class SingletonSet extends AbstractSet imple
> ments
>   Serializable {
>   private static final long serialVersionUID = 319368720755043167
> 9L;
>  
> - final Object element;
> + final E element;
>  
> - SingletonSet(Object object) {
> + SingletonSet(E object) {
>   element = object;
>   }
>  
> @@ -180,15 +180,15 @@
>   return 1;
>   }
>  
> - public Iterator iterator() {
> - return new Iterator() {
> + public Iterator iterator() {
> + return new Iterator() {
>   boolean hasNext = true;
>  
>   public boolean hasNext() {
>   return hasNext;
>   }
>  
> - public Object next() {
> + public E next() {
>   if (hasNext) {
>   hasNext = false;
>

Re: [classlib] build failure

[Geir Magnusson Jr]

If it isn't really quick, roll it back and let Nathan fix it...

geir

Tim Ellison wrote:
> I see it too.
> 
> Stepan / Mikhail, do you get build failures?  Shouldn't we stop putting
> in new code until this is resolved?
> 
> I am happy to take a look at the error, and if it is not a quick fix I
> think we can roll back Collections without trouble.
> 
> Regards,
> Tim
> 
> 
> Geir Magnusson Jr wrote:
>> and the beer flowed
>>
>> Mark Hindess wrote:
>>> This breaks the build.  I'm getting:
>>>
>>> compile:
>>> [javac] Compiling 1839 source files to /pbuilder/tmp/Harmony.clean/build
>>> [javac] 
>>> /pbuilder/tmp/Harmony.clean/modules/luni/src/main/java/java/util/Collections.java:1074:
>>>  name clash: add(java.lang.Object) in 
>>> java.util.Collections.UnmodifiableCollection> and 
>>> add(E) in java.util.Set> have the same erasure, 
>>> yet neither overrides the other
>>> [javac] private static class UnmodifiableEntrySet 
>>> extends UnmodifiableSet> {
>>> [javac]^
>>>
>>> w/sun 1.5 javac on linux.
>>>
>>> Regards,
>>>  Mark.
>>>
>>> On 9 June 2006 at 4:59, [EMAIL PROTECTED] wrote:
 Author: ndbeyer
 Date: Thu Jun  8 21:59:15 2006
 New Revision: 412928

 URL: http://svn.apache.org/viewvc?rev=412928&view=rev
 Log:
 Generification of methods.

 Modified:
 
 incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
 /util/Collections.java

 Modified: 
 incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/jav
 a/java/util/Collections.java
 URL: 
 http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
 odules/luni/src/main/java/java/util/Collections.java?rev=412928&r1=412927&r2=
 412928&view=diff
 =
 =
 --- 
 incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
 /util/Collections.java (original)
 +++ 
 incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java
 /util/Collections.java Thu Jun  8 21:59:15 2006
 @@ -27,15 +27,15 @@
   */
  public class Collections {
  
 -  private static final class CopiesList extends AbstractList implements
 +  private static final class CopiesList extends AbstractList implem
 ents
Serializable {
private static final long serialVersionUID = 273909926839871180
 0L;
  
private final int n;
  
 -  private final Object element;
 +  private final E element;
  
 -  CopiesList(int length, Object object) {
 +  CopiesList(int length, E object) {
if (length < 0) {
throw new IllegalArgumentException();
}
 @@ -51,7 +51,7 @@
return n;
}
  
 -  public Object get(int location) {
 +  public E get(int location) {
if (0 <= location && location < n)
return element;
throw new IndexOutOfBoundsException();
 @@ -162,13 +162,13 @@
  }
  }
  
 -  private static final class SingletonSet extends AbstractSet implements
 +  private static final class SingletonSet extends AbstractSet imple
 ments
Serializable {
private static final long serialVersionUID = 319368720755043167
 9L;
  
 -  final Object element;
 +  final E element;
  
 -  SingletonSet(Object object) {
 +  SingletonSet(E object) {
element = object;
}
  
 @@ -180,15 +180,15 @@
return 1;
}
  
 -  public Iterator iterator() {
 -  return new Iterator() {
 +  public Iterator iterator() {
 +  return new Iterator() {
boolean hasNext = true;
  
public boolean hasNext() {
return hasNext;
}
  
 -  public Object next() {
 +  public E next() {
if (hasNext) {
hasNext = false;
return element;
 @@ -203,13 +203,13 @@
}
}
  
 -  private static final class SingletonList extends AbstractList implement
 s
 +  private static final class SingletonList extends AbstractList imp
 lements
Serializable {
private static final long serialVersionUID = 309373661874065295