[PHP-DEV] unsolved issues
Hi! We have the following issues which I'd really like to put behind us before RC (please correct me if they already were resolved): 1. is_a issue - did we resolve it? If not - does anyone have a proper patch and can make it before RC scheduled date? 2. DateTime fixes with TLA timezones 3. tokenizer and HALT_COMPILER issue - was that resolved? Could we address these before RC? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] SVN Account Request: cpriest
On 11/06/2011 02:07 AM, Clint Priest wrote: > Interested in developing the PHP language. I know c and c++ and would like > to contribute. Hi, this document describes how to start contributing to PHP: http://svn.php.net/viewvc/php/php-src/trunk/README.SUBMITTING_PATCH?view=markup Greetings, Florian -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Help w/ Parser
I don't see an attachment. Could you send it again with .txt as file extension?
If you want 'get' to be recognized as T_GET you need to define such a
token in the lexer (zend_language_scanner.l). Did you do that?
On Mon, Nov 7, 2011 at 3:53 AM, wrote:
> I’m having trouble getting some changes to the parser to recognize some new
> syntax. I’ve attached a patch of what I’ve done.
>
>
>
> Here is the syntax I am trying to get to be parsed properly:
>
>
> class TimePeriod {
>
>
>
> public $Seconds;
>
>
>
> public function __construct($Seconds) {
>
> $this->Seconds = $Seconds;
>
> }
>
> // Getters/Setters
>
> public $Hours {
>
> get { return $this->Seconds / 3600; }
>
> set { $this->Seconds = $value * 3600; } // The variable $value
> holds the incoming value to be "set"
>
> }
>
> };
>
> ?>
>
>
>
> After compiling and attempting to execute the above PHP file, I’m getting
> this parse error:
>
>
>
> Parse error: syntax error, unexpected 'get' (T_STRING), expecting get
> (T_GET) or set (T_SET) in /mnt/hgfs/svn/php-src-test/test.php on line 13
>
>
>
> Why is the parse recognizing the ‘get’ as T_STRING rather than get (T_GET)?
>
>
>
> Thanks,
>
>
>
> -Clint
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Help w/ Parser
I'm having trouble getting some changes to the parser to recognize some new
syntax. I've attached a patch of what I've done.
Here is the syntax I am trying to get to be parsed properly:
Seconds = $Seconds;
}
// Getters/Setters
public $Hours {
get { return $this->Seconds / 3600; }
set { $this->Seconds = $value * 3600; } // The variable $value
holds the incoming value to be "set"
}
};
?>
After compiling and attempting to execute the above PHP file, I'm getting
this parse error:
Parse error: syntax error, unexpected 'get' (T_STRING), expecting get
(T_GET) or set (T_SET) in /mnt/hgfs/svn/php-src-test/test.php on line 13
Why is the parse recognizing the 'get' as T_STRING rather than get (T_GET)?
Thanks,
-Clint
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] new foo()->bar()
2011/11/5 Stas Malyshev : > Hi! > > On 11/5/11 2:04 PM, Peter Cowburn wrote: >>> >>> Other examples which describes the feature at >>> http://wiki.php.net/rfc/instance-method-call >>> >>> Thoughts? >> >> Bump. >> >> What's the current status on this? >> >> It would be nice to this teeny little patch in for 5.4.0 if possible. > > I think the brackets one is fine, if all the tests are OK we can have it in. > But I'd like to get it before RC, after RC I don't want to have any > substantial changes. > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > Committed! -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
