[GitHub] carbondata pull request #1290: [CARBONDATA-1407] Fix default end key bug for...
GitHub user QiangCai opened a pull request: https://github.com/apache/carbondata/pull/1290 [CARBONDATA-1407] Fix default end key bug for no-dictionary dimension Now the default end key of no-dictionary dimension is 127 (0xEF), it should be 0xFF. You can merge this pull request into a Git repository by running: $ git pull https://github.com/QiangCai/carbondata non_dictionary Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1290 commit 5d7e382d135d2d19974cff82ac6b41a9eabf171e Author: QiangCai Date: 2017-08-24T04:31:44Z fix default end key for non-dictionary --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (CARBONDATA-1407) The default end key is not correct for plain-text dimension
QiangCai created CARBONDATA-1407: Summary: The default end key is not correct for plain-text dimension Key: CARBONDATA-1407 URL: https://issues.apache.org/jira/browse/CARBONDATA-1407 Project: CarbonData Issue Type: Bug Components: data-query Affects Versions: 1.2.0 Reporter: QiangCai Priority: Minor Now the default end key is 127 (0xEF), we should change it to 0xFF -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CARBONDATA-1342) Fixed bugs for spark conf property and debugging in windows
[ https://issues.apache.org/jira/browse/CARBONDATA-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-1342. - Resolution: Fixed > Fixed bugs for spark conf property and debugging in windows > --- > > Key: CARBONDATA-1342 > URL: https://issues.apache.org/jira/browse/CARBONDATA-1342 > Project: CarbonData > Issue Type: Bug >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > Fixes to be done: > 1. In spark 2, spark conf once set in spark context cannot be modified with > the same context again. Therefore removed setting property in spark conf and > directly getting the property from carbon properties. > 2. Path formation is not proper when we run CarbonSessionExample in windows > as File.Separator in the table path formation > 3. Namenode call is made after completion of each data load for renaming bad > folders -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata issue #1213: [CARBONDATA-1342] Fixed bugs for spark conf property...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1213 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1267: [CARBONDATA-1326] Findbug fixes
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1267 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1289: [CARBONDATA-1406] Fixed the issue with the Qu...
GitHub user PallaviSingh1992 opened a pull request: https://github.com/apache/carbondata/pull/1289 [CARBONDATA-1406] Fixed the issue with the Quotation marks You can merge this pull request into a Git repository by running: $ git pull https://github.com/PallaviSingh1992/carbondata feature/DocCheckForWebsite Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1289.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1289 commit a334d69ebc2cb6cef8402f862fcf2e20bc9180d8 Author: PallaviSingh1992 Date: 2017-08-24T03:52:16Z fixed the issue with the used in the documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (CARBONDATA-1406) Fix inconsistent usage of QUOTATION MARK " and LEFT DOUBLE QUOTATION MARK “ in installation.md file
Pallavi Singh created CARBONDATA-1406: - Summary: Fix inconsistent usage of QUOTATION MARK " and LEFT DOUBLE QUOTATION MARK “ in installation.md file Key: CARBONDATA-1406 URL: https://issues.apache.org/jira/browse/CARBONDATA-1406 Project: CarbonData Issue Type: Bug Components: docs Reporter: Pallavi Singh Assignee: Pallavi Singh Priority: Minor The inconsistent usage of QUOTATION MARK " and LEFT DOUBLE QUOTATION MARK “ in installation.md file are creating conversion issue while generating the documentation for the website from the docs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata issue #1284: [CARBONDATA-1330] Not able to drop temporary table b...
Github user PannerselvamVelmyl commented on the issue: https://github.com/apache/carbondata/pull/1284 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1278: [CARBONDATA-1326] Fixed high priority findbug issues
Github user PannerselvamVelmyl commented on the issue: https://github.com/apache/carbondata/pull/1278 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1288: [CARBONDATA-1405]Added support for gathering ...
GitHub user sraghunandan opened a pull request: https://github.com/apache/carbondata/pull/1288 [CARBONDATA-1405]Added support for gathering coverage information when tests are run Using jacoco for coverage Using coveralls for CI integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/sraghunandan/carbondata-1 configure_coverage Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1288 commit 3ba15a35ed309440bf8c069b04803d406e1047ed Author: Raghunandan S Date: 2017-08-23T21:59:38Z Added coverage configuration Using jacoco for coverage Using coveralls for CI integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (CARBONDATA-1405) Configure Coverage report to be shown for every build
Raghunandan created CARBONDATA-1405: --- Summary: Configure Coverage report to be shown for every build Key: CARBONDATA-1405 URL: https://issues.apache.org/jira/browse/CARBONDATA-1405 Project: CarbonData Issue Type: Bug Reporter: Raghunandan -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata pull request #1287: Fix Findbugs
GitHub user sraghunandan opened a pull request: https://github.com/apache/carbondata/pull/1287 Fix Findbugs You can merge this pull request into a Git repository by running: $ git pull https://github.com/sraghunandan/carbondata-1 fix_findbugs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1287 commit 4a7d21a032062f004983c80cf72aa3e059fe212f Author: Raghunandan S Date: 2017-08-23T19:52:57Z Fix Findbugs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1281#discussion_r134849821 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/FilterExpressionProcessor.java --- @@ -163,17 +163,17 @@ public FilterResolverIntf getFilterResolver(Expression expressionTree, } private String joinByteArray(byte[] bytes, char delimiter) { -StringBuffer byteArrayAsString = new StringBuffer(); -byteArrayAsString.append(""); +String byteArrayAsString = ""; --- End diff -- do not change this to String,Findbugs will give error. though java optimises internally when strings are concatenated, findbugs doesn't recognise that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1285: [CARBONDATA-1403] Compaction log is not correct
Github user chenerlu commented on the issue: https://github.com/apache/carbondata/pull/1285 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r134780421 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/constants/PrestoCommonConstants.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.presto.constants; + +/** + * Constants for presto functionality + */ --- End diff -- Ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r134779856 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSetProvider.java --- @@ -73,27 +60,23 @@ public CarbondataRecordSetProvider(CarbondataConnectorId connectorId, CarbonTabl CarbondataSplit carbondataSplit = checkType(split, CarbondataSplit.class, "split is not class CarbondataSplit"); -checkArgument(carbondataSplit.getConnectorId().equals(connectorId), "split is not for this connector"); +checkArgument(carbondataSplit.getConnectorId().equals(connectorId), +"split is not for this connector"); -StringBuffer targetColsBuffer = new StringBuffer(); String targetCols = ""; // Convert all columns handles ImmutableList.Builder handles = ImmutableList.builder(); for (ColumnHandle handle : columns) { handles.add(checkType(handle, CarbondataColumnHandle.class, "handle")); - targetColsBuffer.append(((CarbondataColumnHandle) handle).getColumnName()).append(","); + targetCols += ((CarbondataColumnHandle) handle).getColumnName() + ","; --- End diff -- Actually last commit was not rebased with my previous one I will correct it again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1259: [Review][CARBONDATA-1381] Add test cases for missing...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1259 SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/294/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1259: [Review][CARBONDATA-1381] Add test cases for missing...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1259 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3424/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1265: [CARBONDATA-1128] Add direct string encoding for sho...
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1265 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1286: [CARBONDATA-1404] Added Unit test cases for H...
GitHub user PallaviSingh1992 opened a pull request: https://github.com/apache/carbondata/pull/1286 [CARBONDATA-1404] Added Unit test cases for Hive Integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/PallaviSingh1992/carbondata feature/HiveUnitTests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1286.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1286 commit ec00023d578a6e28b5c6093e95f2ec42b955a842 Author: shivangi Date: 2017-08-14T06:14:01Z Added Unit test cases for Hive Integration Resolved Review Comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1285: [CARBONDATA-1403] Compaction log is not correct
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1285 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (CARBONDATA-1404) Add Unit test cases for Hive Integration
Pallavi Singh created CARBONDATA-1404: - Summary: Add Unit test cases for Hive Integration Key: CARBONDATA-1404 URL: https://issues.apache.org/jira/browse/CARBONDATA-1404 Project: CarbonData Issue Type: Test Components: test Reporter: Pallavi Singh Assignee: Pallavi Singh Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata issue #1259: [Review][CARBONDATA-1381] Add test cases for missing...
Github user sraghunandan commented on the issue: https://github.com/apache/carbondata/pull/1259 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1259: [Review][CARBONDATA-1381] Add test cases for missing...
Github user sraghunandan commented on the issue: https://github.com/apache/carbondata/pull/1259 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1259: [Review][CARBONDATA-1381] Add test cases for missing...
Github user sraghunandan commented on the issue: https://github.com/apache/carbondata/pull/1259 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Github user bhavya411 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r134712614 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSet.java --- @@ -79,30 +81,27 @@ private Expression parseConstraint2Expression(TupleDomain constrai @Override public RecordCursor cursor() { List tableBlockInfoList = new ArrayList(); -tableBlockInfoList.add(new TableBlockInfo(split.getLocalInputSplit().getPath().toString(), +tableBlockInfoList.add(new TableBlockInfo(split.getLocalInputSplit().getPath(), split.getLocalInputSplit().getStart(), split.getLocalInputSplit().getSegmentId(), split.getLocalInputSplit().getLocations().toArray(new String[0]), split.getLocalInputSplit().getLength(), new BlockletInfos(), //blockletInfos, ColumnarFormatVersion.valueOf(split.getLocalInputSplit().getVersion()), null)); -queryModel.setTableBlockInfos(tableBlockInfoList); +queryModel.setTableBlockInfos(tableBlockInfoList); queryExecutor = QueryExecutorFactory.getQueryExecutor(queryModel); -try { +CarbonProperties.getInstance().addProperty("carbon.detail.batch.size", --- End diff -- Actually in DataBlockIteratoImpl we are using this property to create the batches, we are setting this property here to ensure that the batchsize of Presto and carbondata match so we have better efficiency --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1284: [CARBONDATA-1330] Not able to drop temporary table b...
Github user PannerselvamVelmyl commented on the issue: https://github.com/apache/carbondata/pull/1284 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1278: [CARBONDATA-1326] Fixed high priority findbug issues
Github user PannerselvamVelmyl commented on the issue: https://github.com/apache/carbondata/pull/1278 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1285: [CARBONDATA-1403] Compaction log is not corre...
GitHub user chenerlu opened a pull request: https://github.com/apache/carbondata/pull/1285 [CARBONDATA-1403] Compaction log is not correct Modify reason: The log of compaction is not correct, So change it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenerlu/incubator-carbondata fixcompactlog Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1285.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1285 commit b24c5411d1f4621a1600032646d1e39e26db75f9 Author: chenerlu Date: 2017-08-23T09:23:38Z fix CARBONDATA-1403 compaction log is not correct --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (CARBONDATA-1403) Compaction log is not correct
chenerlu created CARBONDATA-1403: Summary: Compaction log is not correct Key: CARBONDATA-1403 URL: https://issues.apache.org/jira/browse/CARBONDATA-1403 Project: CarbonData Issue Type: Bug Reporter: chenerlu Assignee: chenerlu Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata issue #1282: [CARBONDATA-1221] Documentation - removed the unused...
Github user Ayushi93 commented on the issue: https://github.com/apache/carbondata/pull/1282 @chenliang It is already configured. âºï¸ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1278: [CARBONDATA-1326] Fixed high priority findbug...
GitHub user PannerselvamVelmyl reopened a pull request: https://github.com/apache/carbondata/pull/1278 [CARBONDATA-1326] Fixed high priority findbug issues No new test cases are required. Few of the findbugs issues fixed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PannerselvamVelmyl/carbondata FindBugFixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1278.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1278 commit 83b084dd86fe921f02989f17d3422fdbb917ab0b Author: root Date: 2017-08-21T07:41:08Z FindBugs Fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1278: [CARBONDATA-1326] Fixed high priority findbug...
Github user PannerselvamVelmyl closed the pull request at: https://github.com/apache/carbondata/pull/1278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1278: [CARBONDATA-1326] Fixed high priority findbug issues
Github user PannerselvamVelmyl commented on the issue: https://github.com/apache/carbondata/pull/1278 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r134694501 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSet.java --- @@ -79,30 +81,27 @@ private Expression parseConstraint2Expression(TupleDomain constrai @Override public RecordCursor cursor() { List tableBlockInfoList = new ArrayList(); -tableBlockInfoList.add(new TableBlockInfo(split.getLocalInputSplit().getPath().toString(), +tableBlockInfoList.add(new TableBlockInfo(split.getLocalInputSplit().getPath(), split.getLocalInputSplit().getStart(), split.getLocalInputSplit().getSegmentId(), split.getLocalInputSplit().getLocations().toArray(new String[0]), split.getLocalInputSplit().getLength(), new BlockletInfos(), //blockletInfos, ColumnarFormatVersion.valueOf(split.getLocalInputSplit().getVersion()), null)); -queryModel.setTableBlockInfos(tableBlockInfoList); +queryModel.setTableBlockInfos(tableBlockInfoList); queryExecutor = QueryExecutorFactory.getQueryExecutor(queryModel); -try { +CarbonProperties.getInstance().addProperty("carbon.detail.batch.size", --- End diff -- I can't find where code use this property(carbon.detail.batch.size)? don't know need to add property at here ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r134692412 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSetProvider.java --- @@ -73,27 +60,23 @@ public CarbondataRecordSetProvider(CarbondataConnectorId connectorId, CarbonTabl CarbondataSplit carbondataSplit = checkType(split, CarbondataSplit.class, "split is not class CarbondataSplit"); -checkArgument(carbondataSplit.getConnectorId().equals(connectorId), "split is not for this connector"); +checkArgument(carbondataSplit.getConnectorId().equals(connectorId), +"split is not for this connector"); -StringBuffer targetColsBuffer = new StringBuffer(); String targetCols = ""; // Convert all columns handles ImmutableList.Builder handles = ImmutableList.builder(); for (ColumnHandle handle : columns) { handles.add(checkType(handle, CarbondataColumnHandle.class, "handle")); - targetColsBuffer.append(((CarbondataColumnHandle) handle).getColumnName()).append(","); + targetCols += ((CarbondataColumnHandle) handle).getColumnName() + ","; --- End diff -- i didn't see any code to resolve this comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r134691842 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/constants/PrestoCommonConstants.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.presto.constants; + +/** + * Constants for presto functionality + */ --- End diff -- Please don't add the new class : PrestoCommonConstants.java, keep to define the parameter in CarbondataPageSource.java as below: private static final int ROWS_PER_REQUEST = 4096; --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1266: [CARBONDATA-1393] Avoid to throw NPE when execute 'f...
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/1266 @ravipesala @jackylk please review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1282: [CARBONDATA-1221] Documentation - removed the unused...
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1282 @Ayushi93 please config your email info in your local git environment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1282: [CARBONDATA-1221] Documentation - removed the unused...
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1282 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1278: [CARBONDATA-1326] Fixed high priority findbug issues
Github user PannerselvamVelmyl commented on the issue: https://github.com/apache/carbondata/pull/1278 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1248: [CARBONDATA-1371] Support creating decoder ba...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1248: [CARBONDATA-1371] Support creating decoder based on ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1248 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---