[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread QiangCai
Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
LGTM


---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1832/



---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
LGTM


---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1384/



---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread QiangCai
Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
@chenerlu 
can you unify the variable name to "hadoopConf"?


---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1378/



---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1827/



---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread chenerlu
Github user chenerlu commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
retest this please


---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1374/



---


[GitHub] carbondata issue #1554: [CARBONDATA-1717] Fix issue of no sort when data in ...

2017-11-22 Thread chenliang613
Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/1554
  
@chenerlu  please follow the below template to provide description.

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 


---