[jira] [Commented] (RNG-127) Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number Generators
[
https://issues.apache.org/jira/browse/RNG-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395309#comment-17395309
]
Gilles Sadowski commented on RNG-127:
-
[Video|https://inside.java/2021/07/29/insidejava-newscast-009/] introduction to
the new {{RandomGenerator}} hierarchy.
> Assess future compatibility with JEP 356: Enhanced Pseudo-Random Number
> Generators
> ---
>
> Key: RNG-127
> URL: https://issues.apache.org/jira/browse/RNG-127
> Project: Commons RNG
> Issue Type: Task
> Components: client-api
>Affects Versions: 1.3
>Reporter: Alex Herbert
>Priority: Minor
>
> JEP 356 specifies an enhancement to the random number generators. This is
> targeted to JDK 17.
> [JEP 356: Enhanced Pseudo-Random Number
> Generators|https://openjdk.java.net/jeps/356]
> The enhancement will add interfaces to the JDK for random number generation:
> * SplittableRandomGenerator extends RandomGenerator and also provides
> methods named split and splits. Splittability allows the user to spawn a new
> RandomGenerator from an existing RandomGenerator that will generally produce
> statistically independent results.
> * JumpableRandomGenerator extends RandomGenerator and also provides
> methods named jump and jumps. Jumpability allows a user to jump ahead a
> moderate number of draws.
> * LeapableRandomGenerator extends RandomGenerator and also provides
> methods named leap and leaps. Leapability allows a user to jump ahead a
> large number of draws.
> * ArbitrarilyJumpableRandomGenerator extends LeapableRandomGenerator and
> also provides additional variations of jump and jumps that allow an arbitrary
> jump distance to be specified.
> The specification describes the development of abstract classes that would
> allow different algorithms to be easily implemented by developers and used
> with a Java application through a common interface. This would replicate the
> functionality of the Common RNG API and core modules within the JDK.
> The JDK interfaces should be compared with the current client API in Commons
> RNG with the aim to assess:
> # Compatibility
> # Potential to back-port functionality
> JEP 356 also mentions the implementation of the LXM family of RNGs and a
> change to the algorithm used by SplittableRandom to address two weaknesses
> identified in 2016. These could be included in the current codebase pending
> license compatibility checks.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-statistics] aherbert merged pull request #29: Improvements:
aherbert merged pull request #29: URL: https://github.com/apache/commons-statistics/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] arturobernalg commented on a change in pull request #29: Improvements:
arturobernalg commented on a change in pull request #29:
URL: https://github.com/apache/commons-statistics/pull/29#discussion_r684646167
##
File path:
commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
##
@@ -494,12 +494,7 @@ void testDensityIntegrals() {
final double tol = 1e-9;
final BaseAbstractUnivariateIntegrator integrator =
new IterativeLegendreGaussIntegrator(5, 1e-12, 1e-10);
-final UnivariateFunction d = new UnivariateFunction() {
-@Override
-public double value(double x) {
-return distribution.density(x);
-}
-};
+final UnivariateFunction d = x -> distribution.density(x);
Review comment:
Yes. changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (LANG-1657) DiffBuilder: Type constraint for method append(..., DiffResult) too strict
[
https://issues.apache.org/jira/browse/LANG-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395247#comment-17395247
]
Andrew Thomas commented on LANG-1657:
-
Opened a PR here: [Lang-1657|https://github.com/apache/commons-lang/pull/786]
> DiffBuilder: Type constraint for method append(..., DiffResult) too strict
> --
>
> Key: LANG-1657
> URL: https://issues.apache.org/jira/browse/LANG-1657
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.builder.*
>Affects Versions: 3.12.0
>Reporter: Matthias Welz
>Priority: Major
>
> The DiffBuilder has a method append which allows to append an existing
> DiffResult for a property. The example illustrates this the following way:
>
> {code:java}
> public class Person implements Diffable {
>String name;
>Address address; // implements Diffable
>...
>public DiffResult diff(Person obj) {
> return new DiffBuilder(this, obj, ToStringStyle.SHORT_PREFIX_STYLE)
>.append("name", this.name, obj.name)
>.append("address", this.address.diff(obj.address))
>.build();
>}
> }
> {code}
>
> However, the signature of the method was recently changed to:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> As a consequence, the example code won't compile anymore when using generics
> because the a _DiffBuilder_ will only accept _DiffResult_ but
> not _DiffResult_ for its append method.
> The signature should be:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> or:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> instead.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?focusedWorklogId=635614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635614 ] ASF GitHub Bot logged work on LANG-1663: Author: ASF GitHub Bot Created on: 07/Aug/21 15:15 Start Date: 07/Aug/21 15:15 Worklog Time Spent: 10m Work Description: greatmastermario edited a comment on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894667374 I went to go write some test cases, and it looks like there are already test cases that use assertThrows with the correct NullPointerException. So we already have the test coverage, it just didn't reflect in the Javadoc. See NumberUtilsTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635614) Time Spent: 50m (was: 40m) > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 50m > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] greatmastermario edited a comment on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
greatmastermario edited a comment on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894667374 I went to go write some test cases, and it looks like there are already test cases that use assertThrows with the correct NullPointerException. So we already have the test coverage, it just didn't reflect in the Javadoc. See NumberUtilsTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?focusedWorklogId=635613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635613 ] ASF GitHub Bot logged work on LANG-1663: Author: ASF GitHub Bot Created on: 07/Aug/21 15:14 Start Date: 07/Aug/21 15:14 Worklog Time Spent: 10m Work Description: greatmastermario commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894667374 I went to go write some test cases, and it looks like there are already test cases that use assertThrows with the correct NullPointerException. So we already have the test coverage, it just didn't reflect in the Javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635613) Time Spent: 40m (was: 0.5h) > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] greatmastermario commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
greatmastermario commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894667374 I went to go write some test cases, and it looks like there are already test cases that use assertThrows with the correct NullPointerException. So we already have the test coverage, it just didn't reflect in the Javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1622) "SimplexOptimizer" hybridation with simulated annealing
[
https://issues.apache.org/jira/browse/MATH-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395228#comment-17395228
]
Gilles Sadowski commented on MATH-1622:
---
Implemented in commit 50ca244b38e130923b5426092895c587e207f4a2 ("master"
branch). Please review.
> "SimplexOptimizer" hybridation with simulated annealing
> ---
>
> Key: MATH-1622
> URL: https://issues.apache.org/jira/browse/MATH-1622
> Project: Commons Math
> Issue Type: Wish
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 4.0
>
>
> It is proposed to modify the API of [simplex-based
> optimization|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/SimplexOptimizer.java;h=d95123d8f62ec029f1bd0190ca3c17d028ee9a64;hb=46a0c3ae4140fd34cf8479362192bddb7b7b3e38]
> in order to allow the [simplex transformation
> rule|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/Simplex.java;h=46345c3b7a5c6784a3afda33b490a1bd6a2ce1a3;hb=46a0c3ae4140fd34cf8479362192bddb7b7b3e38#l299]
> to retain less fit states with some probability, as per the "simulated
> annealing" heuristics.
> A {{SimulatedAnnealing}} class will implement
> [{{OptimizationData}}|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/OptimizationData.java;h=adb42ee040852971594520777ece3391e19052a8;hb=46a0c3ae4140fd34cf8479362192bddb7b7b3e38].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (MATH-1573) Redundant local variable
[ https://issues.apache.org/jira/browse/MATH-1573?focusedWorklogId=635597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635597 ] ASF GitHub Bot logged work on MATH-1573: Author: ASF GitHub Bot Created on: 07/Aug/21 12:39 Start Date: 07/Aug/21 12:39 Worklog Time Spent: 10m Work Description: asfgit closed pull request #194: URL: https://github.com/apache/commons-math/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635597) Time Spent: 2h 40m (was: 2.5h) > Redundant local variable > > > Key: MATH-1573 > URL: https://issues.apache.org/jira/browse/MATH-1573 > Project: Commons Math > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 2h 40m > Remaining Estimate: 0h > > Remove redundant local variable -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] asfgit closed pull request #194: MATH-1573 - Redundant local variable
asfgit closed pull request #194: URL: https://github.com/apache/commons-math/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1573) Redundant local variable
[ https://issues.apache.org/jira/browse/MATH-1573?focusedWorklogId=635596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635596 ] ASF GitHub Bot logged work on MATH-1573: Author: ASF GitHub Bot Created on: 07/Aug/21 12:36 Start Date: 07/Aug/21 12:36 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #194: URL: https://github.com/apache/commons-math/pull/194#issuecomment-894057681 [](https://coveralls.io/builds/41978005) Coverage increased (+0.01%) to 90.485% when pulling **84a84000fa9d575e4b4792ac7e50c20cbeaaed00 on arturobernalg:feature/MATH-1573** into **771a21815b4329302fc174ef2ad80b46ed8247f0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635596) Time Spent: 2.5h (was: 2h 20m) > Redundant local variable > > > Key: MATH-1573 > URL: https://issues.apache.org/jira/browse/MATH-1573 > Project: Commons Math > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 2.5h > Remaining Estimate: 0h > > Remove redundant local variable -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] coveralls edited a comment on pull request #194: MATH-1573 - Redundant local variable
coveralls edited a comment on pull request #194: URL: https://github.com/apache/commons-math/pull/194#issuecomment-894057681 [](https://coveralls.io/builds/41978005) Coverage increased (+0.01%) to 90.485% when pulling **84a84000fa9d575e4b4792ac7e50c20cbeaaed00 on arturobernalg:feature/MATH-1573** into **771a21815b4329302fc174ef2ad80b46ed8247f0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] aherbert commented on a change in pull request #29: Improvements:
aherbert commented on a change in pull request #29:
URL: https://github.com/apache/commons-statistics/pull/29#discussion_r684627645
##
File path:
commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
##
@@ -494,12 +494,7 @@ void testDensityIntegrals() {
final double tol = 1e-9;
final BaseAbstractUnivariateIntegrator integrator =
new IterativeLegendreGaussIntegrator(5, 1e-12, 1e-10);
-final UnivariateFunction d = new UnivariateFunction() {
-@Override
-public double value(double x) {
-return distribution.density(x);
-}
-};
+final UnivariateFunction d = x -> distribution.density(x);
Review comment:
Can this be a function reference: `distribution::density`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-numbers] aherbert merged pull request #102: Fix wrong javadoc
aherbert merged pull request #102: URL: https://github.com/apache/commons-numbers/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1572) Simplify Conditions
[ https://issues.apache.org/jira/browse/MATH-1572?focusedWorklogId=635594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635594 ] ASF GitHub Bot logged work on MATH-1572: Author: ASF GitHub Bot Created on: 07/Aug/21 12:26 Start Date: 07/Aug/21 12:26 Worklog Time Spent: 10m Work Description: aherbert commented on pull request #193: URL: https://github.com/apache/commons-math/pull/193#issuecomment-894648368 Closed by commit 1c8d8da63a993c8db554f6afa26c5ea9e8c61b3e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635594) Time Spent: 1h 20m (was: 1h 10m) > Simplify Conditions > --- > > Key: MATH-1572 > URL: https://issues.apache.org/jira/browse/MATH-1572 > Project: Commons Math > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > * Simplifiable boolean expression > * Simplifiable conditional expression > * Redundant 'if' statement -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (MATH-1572) Simplify Conditions
[ https://issues.apache.org/jira/browse/MATH-1572?focusedWorklogId=635593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635593 ] ASF GitHub Bot logged work on MATH-1572: Author: ASF GitHub Bot Created on: 07/Aug/21 12:26 Start Date: 07/Aug/21 12:26 Worklog Time Spent: 10m Work Description: aherbert closed pull request #193: URL: https://github.com/apache/commons-math/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635593) Time Spent: 1h 10m (was: 1h) > Simplify Conditions > --- > > Key: MATH-1572 > URL: https://issues.apache.org/jira/browse/MATH-1572 > Project: Commons Math > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > * Simplifiable boolean expression > * Simplifiable conditional expression > * Redundant 'if' statement -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] aherbert commented on pull request #193: MATH-1572: Simplify conditional expressions
aherbert commented on pull request #193: URL: https://github.com/apache/commons-math/pull/193#issuecomment-894648368 Closed by commit 1c8d8da63a993c8db554f6afa26c5ea9e8c61b3e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] aherbert closed pull request #193: MATH-1572: Simplify conditional expressions
aherbert closed pull request #193: URL: https://github.com/apache/commons-math/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-numbers] coveralls commented on pull request #103: Simplify boolean expressions with an simpler and equivalent.
coveralls commented on pull request #103: URL: https://github.com/apache/commons-numbers/pull/103#issuecomment-894628884 [](https://coveralls.io/builds/41977359) Coverage remained the same at 99.658% when pulling **260a880fd6ffeb36cecba46b85d0d0d4c3d4d53b on arturobernalg:feature/simplifyOperation** into **1394949d2043d5b1ecbbc3d57f84b735e96a22ba on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-numbers] coveralls commented on pull request #102: Fix wrong javadoc
coveralls commented on pull request #102: URL: https://github.com/apache/commons-numbers/pull/102#issuecomment-894628759 [](https://coveralls.io/builds/41977353) Coverage remained the same at 99.658% when pulling **97251f793d0e02e722c4810b7f82bb19c56eff42 on arturobernalg:feature/javadoc** into **1394949d2043d5b1ecbbc3d57f84b735e96a22ba on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-numbers] arturobernalg closed pull request #99: Replace manual copying of array contents by calls to System.arraycopy().
arturobernalg closed pull request #99: URL: https://github.com/apache/commons-numbers/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MATH-1622) "SimplexOptimizer" hybridation with simulated annealing
Gilles Sadowski created MATH-1622:
-
Summary: "SimplexOptimizer" hybridation with simulated annealing
Key: MATH-1622
URL: https://issues.apache.org/jira/browse/MATH-1622
Project: Commons Math
Issue Type: Wish
Reporter: Gilles Sadowski
Fix For: 4.0
It is proposed to modify the API of [simplex-based
optimization|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/SimplexOptimizer.java;h=d95123d8f62ec029f1bd0190ca3c17d028ee9a64;hb=46a0c3ae4140fd34cf8479362192bddb7b7b3e38]
in order to allow the [simplex transformation
rule|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/noderiv/Simplex.java;h=46345c3b7a5c6784a3afda33b490a1bd6a2ce1a3;hb=46a0c3ae4140fd34cf8479362192bddb7b7b3e38#l299]
to retain less fit states with some probability, as per the "simulated
annealing" heuristics.
A {{SimulatedAnnealing}} class will implement
[{{OptimizationData}}|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/OptimizationData.java;h=adb42ee040852971594520777ece3391e19052a8;hb=46a0c3ae4140fd34cf8479362192bddb7b7b3e38].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (COMPRESS-584) IOUtils.readRange() can read more from a channel than asked for
[
https://issues.apache.org/jira/browse/COMPRESS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Lee updated COMPRESS-584:
---
Assignee: Peter Lee
> IOUtils.readRange() can read more from a channel than asked for
> ---
>
> Key: COMPRESS-584
> URL: https://issues.apache.org/jira/browse/COMPRESS-584
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.21
>Reporter: Matthijs Laan
>Assignee: Peter Lee
>Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> When {{IOUtils.readRange(ReadableByteChannel,int)}} gets less than the number
> of bytes asked for in the first read call it does not reduce the buffer size
> for the next read call and may read more than asked for.
> This situation is rare when using a {{FileChannel}} but I wrote a
> {{SeekableByteChannel}} backed by a URI using HTTP range requests and reading
> from a socket can often return less bytes than asked for. When I used this
> channel to read a {{ZipFile}} it only read the ZIP central directory
> partially sometimes because {{IOUtils.readRange()}} called from
> {{ZipFile.readCentralDirectoryEntry()}} read more bytes than asked for and it
> stopped parsing directory entries.
> Fix: [https://github.com/apache/commons-compress/pull/214]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-statistics] arturobernalg opened a new pull request #29: Improvements:
arturobernalg opened a new pull request #29: URL: https://github.com/apache/commons-statistics/pull/29 * inline variable * remove unnecessary return. * Replace Anonymous type with lambda. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?focusedWorklogId=635562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635562 ] ASF GitHub Bot logged work on LANG-1663: Author: ASF GitHub Bot Created on: 07/Aug/21 07:27 Start Date: 07/Aug/21 07:27 Worklog Time Spent: 10m Work Description: HubertWo commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894618605 Regarding Javadoc - good catch! :) Did you consider to add assertThrows in tests for these methods? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635562) Time Spent: 0.5h (was: 20m) > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 0.5h > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] HubertWo commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
HubertWo commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894618605 Regarding Javadoc - good catch! :) Did you consider to add assertThrows in tests for these methods? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
