[GitHub] [flink] dannycranmer commented on pull request #20360: [FLINK-27536][Connectors / Common] Rename method parameter in AsyncSi…

2022-07-27 Thread GitBox


dannycranmer commented on PR #20360:
URL: https://github.com/apache/flink/pull/20360#issuecomment-1196372057

   @DavidLiu001 agree. Given this is a non-functional, tech debt PR, merging 
based on compilation success. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] dannycranmer commented on pull request #20360: [FLINK-27536][Connectors / Common] Rename method parameter in AsyncSi…

2022-07-26 Thread GitBox


dannycranmer commented on PR #20360:
URL: https://github.com/apache/flink/pull/20360#issuecomment-1195928597

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] dannycranmer commented on pull request #20360: [FLINK-27536][Connectors / Common] Rename method parameter in AsyncSi…

2022-07-25 Thread GitBox


dannycranmer commented on PR #20360:
URL: https://github.com/apache/flink/pull/20360#issuecomment-1195076222

   @DavidLiu001 I can see the [CI build has already 
failed](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=38732&view=results).
   
   Before pushing your branch please try to build locally and verify it 
succeeds. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org