[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850515#comment-16850515
]
Hudson commented on HBASE-22467:
Results for branch master
[build #1053 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1053/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850404#comment-16850404
]
Hudson commented on HBASE-22467:
Results for branch branch-2.1
[build #1203 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850277#comment-16850277
]
Hudson commented on HBASE-22467:
Results for branch branch-2
[build #1932 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850263#comment-16850263
]
Hudson commented on HBASE-22467:
Results for branch branch-2.2
[build #300 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850182#comment-16850182 ] stack commented on HBASE-22467: --- ... started RC build. Thanks. > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.1.5, 2.2.1 > > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850045#comment-16850045
]
Josh Elser commented on HBASE-22467:
{quote}Was going to start a new RC build. I can wait if commit will happen soon
else will punt to 2.1.6.
{quote}
If you could wait, that'd be great. Busbey left me feedback on the linked PR
which I'm looking at now.
{quote}Are the *.jamon changes related? Or just cleanup?
{quote}
Yeah, they're related. tl;dr being a little more explicit in the templates
makes it much easier in Knox to create a rewrite rule so that it can generate
proper links.
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850027#comment-16850027 ] stack commented on HBASE-22467: --- You need this in 2.1.5 [~elserj] ? Was going to start a new RC build. I can wait if commit will happen soon else will punt to 2.1.6. Thanks. BTW, changes look good to me. Are the *.jamon changes related? Or just cleanup? > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.1.5, 2.2.1 > > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849941#comment-16849941
]
Josh Elser commented on HBASE-22467:
{quote}Could you put up a PR on GitHub so I can review easier?
{quote}
Yes.
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849901#comment-16849901 ] Sean Busbey commented on HBASE-22467: - Could you put up a PR on GitHub so I can review easier? > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.1.5, 2.2.1 > > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849829#comment-16849829 ] Josh Elser commented on HBASE-22467: Just to be clear, none of these changes should have any impact on users *not* using Knox to proxy the HBase UI. > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.1.5, 2.2.1 > > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847986#comment-16847986
]
HBase QA commented on HBASE-22467:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
49s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 53s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
15s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}252m
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
45s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}312m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/417/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22467 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12969683/HBASE-22467.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 785eaeb531db 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96d2aabfad |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847846#comment-16847846 ] Josh Elser commented on HBASE-22467: .003 adds license, category, and class rule to new test class. > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847831#comment-16847831
]
HBase QA commented on HBASE-22467:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m
38s{color} | {color:red} patch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 34s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
13s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}203m 58s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
42s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}260m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestCheckTestClasses |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/416/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22467 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12969651/HBASE-22467.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 69c5b106705c 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96d2aabfad |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847594#comment-16847594 ] Josh Elser commented on HBASE-22467: .002 fixes the checkstyle and tries to make the findbugs dings happy. Not sure if Findbugs will be happy enough with my quick and dirty sanitizing method. > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847213#comment-16847213
]
HBase QA commented on HBASE-22467:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} hbase-http: The patch generated 3 new + 0 unchanged -
0 fixed = 3 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 34s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
41s{color} | {color:red} hbase-http generated 2 new + 0 unchanged - 0 fixed = 2
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
0s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}132m
39s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}184m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-http |
| | HTTP parameter directly written to HTTP header output in
org.apache.hadoop.hbase.http.ProfileOutputServlet.doGet(HttpServletRequest,
HttpServletResponse) At ProfileOutputServlet.java:HTTP header output in
org.apache.hadoop.hbase.http.ProfileOutputServlet.doGet(HttpServletRequest,
HttpServletResponse) At ProfileOutputServlet.java:[line 59] |
| | HTTP parameter written to Servlet output in
org.apache.hadoop.hbase.http.ProfileOutputServlet.doGet(HttpServletRequest,
HttpServletResp
