[jira] [Commented] (HBASE-27433) DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction is failed

2022-10-21 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-27433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622556#comment-17622556
 ] 

Hudson commented on HBASE-27433:


Results for branch branch-2
[build #667 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/667/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/667/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/667/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/667/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/667/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction 
> is failed
> -
>
> Key: HBASE-27433
> URL: https://issues.apache.org/jira/browse/HBASE-27433
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2
>
>
> When compaction is failed, {{DefaultMobStoreCompactor.performCompaction}}  
> deletes the {{MobStoreFile}} which is writing, but for {{OptimizedMode}}, 
> {{DefaultMobStoreCompactor.performCompaction}}  may create multiple 
> MobStoreFiles, if compaction is failed, all theses MobStoreFiles are useless 
> and should be deleted altogether. We should better not depend on 
> {{RSMobFileCleanerChore}} to clean them because it is mainly used for archive 
> already compacted MobStoreFiles.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27433) DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction is failed

2022-10-21 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-27433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622468#comment-17622468
 ] 

Hudson commented on HBASE-27433:


Results for branch branch-2.5
[build #229 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/229/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/229/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/229/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/229/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/229/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction 
> is failed
> -
>
> Key: HBASE-27433
> URL: https://issues.apache.org/jira/browse/HBASE-27433
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2
>
>
> When compaction is failed, {{DefaultMobStoreCompactor.performCompaction}}  
> deletes the {{MobStoreFile}} which is writing, but for {{OptimizedMode}}, 
> {{DefaultMobStoreCompactor.performCompaction}}  may create multiple 
> MobStoreFiles, if compaction is failed, all theses MobStoreFiles are useless 
> and should be deleted altogether. We should better not depend on 
> {{RSMobFileCleanerChore}} to clean them because it is mainly used for archive 
> already compacted MobStoreFiles.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27433) DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction is failed

2022-10-21 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-27433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622450#comment-17622450
 ] 

Hudson commented on HBASE-27433:


Results for branch master
[build #704 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/704/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/704/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/704/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/704/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction 
> is failed
> -
>
> Key: HBASE-27433
> URL: https://issues.apache.org/jira/browse/HBASE-27433
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2
>
>
> When compaction is failed, {{DefaultMobStoreCompactor.performCompaction}}  
> deletes the {{MobStoreFile}} which is writing, but for {{OptimizedMode}}, 
> {{DefaultMobStoreCompactor.performCompaction}}  may create multiple 
> MobStoreFiles, if compaction is failed, all theses MobStoreFiles are useless 
> and should be deleted altogether. We should better not depend on 
> {{RSMobFileCleanerChore}} to clean them because it is mainly used for archive 
> already compacted MobStoreFiles.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27433) DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction is failed

2022-10-21 Thread chenglei (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-27433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622209#comment-17622209
 ] 

chenglei commented on HBASE-27433:
--

Pushed to 2.5+, thanks [~zhangduo] for review!

> DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction 
> is failed
> -
>
> Key: HBASE-27433
> URL: https://issues.apache.org/jira/browse/HBASE-27433
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2
>
>
> When compaction is failed, {{DefaultMobStoreCompactor.performCompaction}}  
> deletes the {{MobStoreFile}} which is writing, but for {{OptimizedMode}}, 
> {{DefaultMobStoreCompactor.performCompaction}}  may create multiple 
> MobStoreFiles, if compaction is failed, all theses MobStoreFiles are useless 
> and should be deleted altogether. We should better not depend on 
> {{RSMobFileCleanerChore}} to clean them because it is mainly used for archive 
> already compacted MobStoreFiles.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)