[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475484#comment-15475484
]
Eugene Koifman commented on HIVE-14542:
---
committed to master including the nit.
https://github.com/apache/hive/commit/0755348d781ab96a260db2a4fc6a4eabb8986d73
> VirtualColumn::equals() should use object equality
> --
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Transactions
>Affects Versions: 0.14.0
>Reporter: Gopal V
>Assignee: Eugene Koifman
>Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-14542.3.patch, HIVE-14542.4.patch,
> HIVE-14542.5.patch, HIVE-14542.6.patch, HIVE-14542.patch, virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475355#comment-15475355
]
Gopal V commented on HIVE-14542:
LGTM - +1.
Minor nit: there's no break; after the last case statement - that might trip up
the next person who patches it.
> VirtualColumn::equals() should use object equality
> --
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Transactions
>Affects Versions: 0.14.0
>Reporter: Gopal V
>Assignee: Eugene Koifman
>Priority: Minor
> Attachments: HIVE-14542.3.patch, HIVE-14542.4.patch,
> HIVE-14542.5.patch, HIVE-14542.6.patch, HIVE-14542.patch, virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470883#comment-15470883
]
Eugene Koifman commented on HIVE-14542:
---
Test failures are not related.
[~gopalv] could you review please
> VirtualColumn::equals() should use object equality
> --
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Transactions
>Affects Versions: 0.14.0
>Reporter: Gopal V
>Assignee: Eugene Koifman
>Priority: Minor
> Attachments: HIVE-14542.3.patch, HIVE-14542.4.patch,
> HIVE-14542.5.patch, HIVE-14542.6.patch, HIVE-14542.patch, virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469457#comment-15469457
]
Hive QA commented on HIVE-14542:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12827288/HIVE-14542.6.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10453 tests
executed
*Failed tests:*
{noformat}
TestBeeLineWithArgs - did not produce a TEST-*.xml file
TestHiveCli - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hadoop.hive.thrift.TestHadoopAuthBridge23.testDelegationTokenSharedStore
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1117/testReport
Console output:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1117/console
Test logs:
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-1117/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12827288 - PreCommit-HIVE-MASTER-Build
> VirtualColumn::equals() should use object equality
> --
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Transactions
>Affects Versions: 0.14.0
>Reporter: Gopal V
>Assignee: Eugene Koifman
>Priority: Minor
> Attachments: HIVE-14542.3.patch, HIVE-14542.4.patch,
> HIVE-14542.5.patch, HIVE-14542.6.patch, HIVE-14542.patch, virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469166#comment-15469166
]
Hive QA commented on HIVE-14542:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12827277/HIVE-14542.5.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10453 tests
executed
*Failed tests:*
{noformat}
TestBeeLineWithArgs - did not produce a TEST-*.xml file
TestHiveCli - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1115/testReport
Console output:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1115/console
Test logs:
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-1115/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12827277 - PreCommit-HIVE-MASTER-Build
> VirtualColumn::equals() should use object equality
> --
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Transactions
>Affects Versions: 0.14.0
>Reporter: Gopal V
>Assignee: Eugene Koifman
>Priority: Minor
> Attachments: HIVE-14542.3.patch, HIVE-14542.4.patch,
> HIVE-14542.5.patch, HIVE-14542.patch, virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468955#comment-15468955
]
Hive QA commented on HIVE-14542:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12827225/HIVE-14542.4.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10448 tests
executed
*Failed tests:*
{noformat}
TestBeeLineWithArgs - did not produce a TEST-*.xml file
TestHiveCli - did not produce a TEST-*.xml file
TestSparkNegativeCliDriver - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1114/testReport
Console output:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1114/console
Test logs:
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-1114/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12827225 - PreCommit-HIVE-MASTER-Build
> VirtualColumn::equals() should use object equality
> --
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Transactions
>Affects Versions: 0.14.0
>Reporter: Gopal V
>Assignee: Eugene Koifman
>Priority: Minor
> Attachments: HIVE-14542.3.patch, HIVE-14542.4.patch,
> HIVE-14542.patch, virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455106#comment-15455106
]
Hive QA commented on HIVE-14542:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12826541/HIVE-14542.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 96 failed/errored test(s), 6366 tests
executed
*Failed tests:*
{noformat}
TestBeeLineWithArgs - did not produce a TEST-*.xml file
TestHiveCli - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver
org.apache.hadoop.hive.cli.TestCompareCliDriver.org.apache.hadoop.hive.cli.TestCompareCliDriver
org.apache.hadoop.hive.cli.TestContribCliDriver.org.apache.hadoop.hive.cli.TestContribCliDriver
org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.org.apache.hadoop.hive.cli.TestContribNegativeCliDriver
org.apache.hadoop.hive.cli.TestHBaseCliDriver.org.apache.hadoop.hive.cli.TestHBaseCliDriver
org.apache.hadoop.hive.cli.TestHBaseMinimrCliDriver.org.apache.hadoop.hive.cli.TestHBaseMinimrCliDriver
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[cascade_dbdrop]
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[generatehfiles_require_family_path]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.org.apache.hadoop.hive.cli.TestMiniLlapCliDriver
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.org.apache.hadoop.hive.cli.TestMiniTezCliDriver
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver[bucket5]
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver[index_bitmap3]
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver[index_bitmap_auto]
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver[infer_bucket_sort_bucketed_table]
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver[truncate_column_buckets]
org.apache.hadoop.hive.cli.TestNegativeCliDriver.org.apache.hadoop.hive.cli.TestNegativeCliDriver
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver
org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1
org.apache.hadoop.hive.ql.TestTxnCommands.testDelete
org.apache.hadoop.hive.ql.TestTxnCommands.testDeleteIn
org.apache.hadoop.hive.ql.TestTxnCommands.testMultipleDelete
org.apache.hadoop.hive.ql.TestTxnCommands.testUpdateDeleteOfInserts
org.apache.hadoop.hive.ql.TestTxnCommands.testUpdateOfInserts
org.apache.hadoop.hive.ql.TestTxnCommands2.testACIDwithSchemaEvolutionAndCompaction
org.apache.hadoop.hive.ql.TestTxnCommands2.testCompactWithDelete
org.apache.hadoop.hive.ql.TestTxnCommands2.testDeleteIn
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion2
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion3
org.apache.hadoop.hive.ql.TestTxnCommands2.testOrcNoPPD
org.apache.hadoop.hive.ql.TestTxnCommands2.testOrcPPD
org.apache.hadoop.hive.ql.TestTxnCommands2.testOriginalFileReaderWhenNonAcidConvertedToAcid
org.apache.hadoop.hive.ql.TestTxnCommands2.testUpdateMixedCase
org.apache.hadoop.hive.ql.TestTxnCommands2.updateDeletePartitioned
org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testACIDwithSchemaEvolutionAndCompaction
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testCompactWithDelete
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testDeleteIn
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testNonAcidToAcidConversion2
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testNonAcidToAcidConversion3
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testNonAcidToAcidSplitUpdateConversion2
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testNonAcidToAcidSplitUpdateConversion3
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testOrcNoPPD
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testOrcPPD
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testOriginalFileReaderWhenNonAcidConvertedToAcid
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testUpdateMixedCase
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.updateDeletePartitioned
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.writeBetweenWorkerAndCleaner
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testACIDwithSchemaEvolutionAndCompaction
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCompactWithDelete
org.apache.hado
[jira] [Commented] (HIVE-14542) VirtualColumn::equals() should use object equality
[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453687#comment-15453687
]
Eugene Koifman commented on HIVE-14542:
---
[~gopalv]
Since VirtualColumn is immutable and all c'tors are final, each instance is a
singleton. wouldn't
public boolean equals(Object o) {
return this == o;
}
work?
> VirtualColumn::equals() should use object equality
> --
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
>Reporter: Gopal V
>Priority: Minor
> Attachments: virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
