[jira] [Commented] (KARAF-5908) Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace

2018-09-12 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613003#comment-16613003
 ] 

ASF subversion and git services commented on KARAF-5908:


Commit 004d15b156e5dd9875892abce1b1d9a7b1c49269 in karaf's branch 
refs/heads/master from baptistedaroit
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=004d15b ]

[KARAF-5908] Re-add quotes in Windows karaf-wrapper.conf


> Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace 
> -
>
> Key: KARAF-5908
> URL: https://issues.apache.org/jira/browse/KARAF-5908
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.2.1
> Environment: Windows
>Reporter: Baptiste DA ROIT
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.2
>
>
> Service Wrapper fails to start Karaf Service on Windows when JAVA_HOME 
> contains whitespace, throwing the following error:
> {code:java}
> Une erreur système s’est produite.
> L’erreur système 1067 s’est produite.
> Le processus s’est arrêté inopinément.
> {code}
> Following is an extract of the wrapper.log:
> {code:java}
> STATUS | wrapper  | 2018/09/12 15:30:04 | --> Wrapper Started as Service
> STATUS | wrapper  | 2018/09/12 15:30:04 | Launching a JVM...
> INFO   | jvm 1    | 2018/09/12 15:30:04 | Erreur : impossible de trouver ou 
> charger la classe principale 
> Files\Java\jdk1.8.0_162.jre.lib.endorsed;C:\Program
> ERROR  | wrapper  | 2018/09/12 15:30:04 | JVM exited while loading the 
> application.{code}
> (i) Service Wrapper starts Karaf service smoothly when JAVA_HOME does not 
> contain any whitespace
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5908) Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace

2018-09-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613001#comment-16613001
 ] 

ASF GitHub Bot commented on KARAF-5908:
---

jbonofre closed pull request #610: [KARAF-5908] Re-add quotes in Windows 
karaf-wrapper.conf
URL: https://github.com/apache/karaf/pull/610
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
 
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
index b528acd0ae..f0630bb789 100644
--- 
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
+++ 
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
@@ -37,16 +37,16 @@ wrapper.java.library.path.1=%KARAF_BASE%/lib/wrapper/
 
 # JVM Parameters
 # note that n is the parameter number starting from 1.
-wrapper.java.additional.1=-Djava.endorsed.dirs=%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed
-wrapper.java.additional.2=-Djava.ext.dirs=%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext
-wrapper.java.additional.3=-Dkaraf.instances=%KARAF_HOME%/instances
-wrapper.java.additional.4=-Dkaraf.home=%KARAF_HOME%
-wrapper.java.additional.5=-Dkaraf.base=%KARAF_BASE%
-wrapper.java.additional.6=-Dkaraf.data=%KARAF_DATA%
-wrapper.java.additional.7=-Dkaraf.etc=%KARAF_ETC%
+wrapper.java.additional.1=-Djava.endorsed.dirs="%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed"
+wrapper.java.additional.2=-Djava.ext.dirs="%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext"
+wrapper.java.additional.3=-Dkaraf.instances="%KARAF_HOME%/instances"
+wrapper.java.additional.4=-Dkaraf.home="%KARAF_HOME%"
+wrapper.java.additional.5=-Dkaraf.base="%KARAF_BASE%"
+wrapper.java.additional.6=-Dkaraf.data="%KARAF_DATA%"
+wrapper.java.additional.7=-Dkaraf.etc="%KARAF_ETC%"
 wrapper.java.additional.8=-Dkaraf.restart.jvm.supported=true
-wrapper.java.additional.9=-Djava.io.tmpdir=%KARAF_DATA%/tmp
-wrapper.java.additional.10=-Djava.util.logging.config.file=%KARAF_BASE%/etc/java.util.logging.properties
+wrapper.java.additional.9=-Djava.io.tmpdir="%KARAF_DATA%/tmp"
+wrapper.java.additional.10=-Djava.util.logging.config.file="%KARAF_BASE%/etc/java.util.logging.properties"
 wrapper.java.additional.11=-Dcom.sun.management.jmxremote
 wrapper.java.additional.12=-Dkaraf.startLocalConsole=false
 wrapper.java.additional.13=-Dkaraf.startRemoteShell=true
diff --git 
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
 
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
index b528acd0ae..c8cdc3e5d9 100644
--- 
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
+++ 
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
@@ -37,15 +37,15 @@ wrapper.java.library.path.1=%KARAF_BASE%/lib/wrapper/
 
 # JVM Parameters
 # note that n is the parameter number starting from 1.
-wrapper.java.additional.1=-Djava.endorsed.dirs=%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed
-wrapper.java.additional.2=-Djava.ext.dirs=%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext
-wrapper.java.additional.3=-Dkaraf.instances=%KARAF_HOME%/instances
-wrapper.java.additional.4=-Dkaraf.home=%KARAF_HOME%
-wrapper.java.additional.5=-Dkaraf.base=%KARAF_BASE%
-wrapper.java.additional.6=-Dkaraf.data=%KARAF_DATA%
-wrapper.java.additional.7=-Dkaraf.etc=%KARAF_ETC%
+wrapper.java.additional.1=-Djava.endorsed.dirs="%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed"
+wrapper.java.additional.2=-Djava.ext.dirs="%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext"
+wrapper.java.additional.3=-Dkaraf.instances="%KARAF_HOME%/instances"
+wrapper.java.additional.4=-Dkaraf.home="%KARAF_HOME%"
+wrapper.java.additional.5=-Dkaraf.base="%KARAF_BASE%"
+wrapper.java.additional.6=-Dkaraf.data="%KARAF_DATA%"
+wrapper.java.additional.7=-Dkaraf.etc="%KARAF_ETC%"
 wrapper.java.additional.8=-Dkaraf.restart.jvm.supported=true
-wrapper.java.additional.9=-Djava.io.tmpdir=%KARAF_DATA%/tmp
+wrapper.java.additional.9=-Djava.io.tmpdir="%KARAF_DATA%/tmp"
 
wrapper.java.additional.10=-Djava.util.logging.config.file=%KARAF_BASE%/etc/java.util.logging.properties
 wrapper.java.additional.11=-Dcom.sun.management.jmxremote
 wrapper.java.additional.12=-Dkaraf.startLocalConsole=false


 


This is an automated message from t

[jira] [Commented] (KARAF-5908) Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace

2018-09-12 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613004#comment-16613004
 ] 

ASF subversion and git services commented on KARAF-5908:


Commit 2273ceabb3f17190bf66a58a4b6bfa239745fe99 in karaf's branch 
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=2273cea ]

Merge pull request #610 from usu-fr/KARAF-5908

[KARAF-5908] Re-add quotes in Windows karaf-wrapper.conf

> Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace 
> -
>
> Key: KARAF-5908
> URL: https://issues.apache.org/jira/browse/KARAF-5908
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.2.1
> Environment: Windows
>Reporter: Baptiste DA ROIT
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.2
>
>
> Service Wrapper fails to start Karaf Service on Windows when JAVA_HOME 
> contains whitespace, throwing the following error:
> {code:java}
> Une erreur système s’est produite.
> L’erreur système 1067 s’est produite.
> Le processus s’est arrêté inopinément.
> {code}
> Following is an extract of the wrapper.log:
> {code:java}
> STATUS | wrapper  | 2018/09/12 15:30:04 | --> Wrapper Started as Service
> STATUS | wrapper  | 2018/09/12 15:30:04 | Launching a JVM...
> INFO   | jvm 1    | 2018/09/12 15:30:04 | Erreur : impossible de trouver ou 
> charger la classe principale 
> Files\Java\jdk1.8.0_162.jre.lib.endorsed;C:\Program
> ERROR  | wrapper  | 2018/09/12 15:30:04 | JVM exited while loading the 
> application.{code}
> (i) Service Wrapper starts Karaf service smoothly when JAVA_HOME does not 
> contain any whitespace
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5908) Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace

2018-09-12 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613005#comment-16613005
 ] 

ASF subversion and git services commented on KARAF-5908:


Commit 2273ceabb3f17190bf66a58a4b6bfa239745fe99 in karaf's branch 
refs/heads/master from [~j...@nanthrax.net]
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=2273cea ]

Merge pull request #610 from usu-fr/KARAF-5908

[KARAF-5908] Re-add quotes in Windows karaf-wrapper.conf

> Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace 
> -
>
> Key: KARAF-5908
> URL: https://issues.apache.org/jira/browse/KARAF-5908
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.2.1
> Environment: Windows
>Reporter: Baptiste DA ROIT
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 4.2.2
>
>
> Service Wrapper fails to start Karaf Service on Windows when JAVA_HOME 
> contains whitespace, throwing the following error:
> {code:java}
> Une erreur système s’est produite.
> L’erreur système 1067 s’est produite.
> Le processus s’est arrêté inopinément.
> {code}
> Following is an extract of the wrapper.log:
> {code:java}
> STATUS | wrapper  | 2018/09/12 15:30:04 | --> Wrapper Started as Service
> STATUS | wrapper  | 2018/09/12 15:30:04 | Launching a JVM...
> INFO   | jvm 1    | 2018/09/12 15:30:04 | Erreur : impossible de trouver ou 
> charger la classe principale 
> Files\Java\jdk1.8.0_162.jre.lib.endorsed;C:\Program
> ERROR  | wrapper  | 2018/09/12 15:30:04 | JVM exited while loading the 
> application.{code}
> (i) Service Wrapper starts Karaf service smoothly when JAVA_HOME does not 
> contain any whitespace
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5908) Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace

2018-09-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612381#comment-16612381
 ] 

ASF GitHub Bot commented on KARAF-5908:
---

baptistedaroit opened a new pull request #610: [KARAF-5908] Re-add quotes in 
Windows karaf-wrapper.conf
URL: https://github.com/apache/karaf/pull/610
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace 
> -
>
> Key: KARAF-5908
> URL: https://issues.apache.org/jira/browse/KARAF-5908
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.2.1
> Environment: Windows
>Reporter: Baptiste DA ROIT
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>
> Service Wrapper fails to start Karaf Service on Windows when JAVA_HOME 
> contains whitespace, throwing the following error:
> {code:java}
> Une erreur système s’est produite.
> L’erreur système 1067 s’est produite.
> Le processus s’est arrêté inopinément.
> {code}
> Following is an extract of the wrapper.log:
> {code:java}
> STATUS | wrapper  | 2018/09/12 15:30:04 | --> Wrapper Started as Service
> STATUS | wrapper  | 2018/09/12 15:30:04 | Launching a JVM...
> INFO   | jvm 1    | 2018/09/12 15:30:04 | Erreur : impossible de trouver ou 
> charger la classe principale 
> Files\Java\jdk1.8.0_162.jre.lib.endorsed;C:\Program
> ERROR  | wrapper  | 2018/09/12 15:30:04 | JVM exited while loading the 
> application.{code}
> (i) Service Wrapper starts Karaf service smoothly when JAVA_HOME does not 
> contain any whitespace
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5908) Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace

2018-09-12 Thread JIRA


[ 
https://issues.apache.org/jira/browse/KARAF-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612309#comment-16612309
 ] 

Jean-Baptiste Onofré commented on KARAF-5908:
-

Yes, it's what I saw as well. Feel free to create the PR, I will do the review.

> Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace 
> -
>
> Key: KARAF-5908
> URL: https://issues.apache.org/jira/browse/KARAF-5908
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.2.1
> Environment: Windows
>Reporter: Baptiste DA ROIT
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>
> Service Wrapper fails to start Karaf Service on Windows when JAVA_HOME 
> contains whitespace, throwing the following error:
> {code:java}
> Une erreur système s’est produite.
> L’erreur système 1067 s’est produite.
> Le processus s’est arrêté inopinément.
> {code}
> Following is an extract of the wrapper.log:
> {code:java}
> STATUS | wrapper  | 2018/09/12 15:30:04 | --> Wrapper Started as Service
> STATUS | wrapper  | 2018/09/12 15:30:04 | Launching a JVM...
> INFO   | jvm 1    | 2018/09/12 15:30:04 | Erreur : impossible de trouver ou 
> charger la classe principale 
> Files\Java\jdk1.8.0_162.jre.lib.endorsed;C:\Program
> ERROR  | wrapper  | 2018/09/12 15:30:04 | JVM exited while loading the 
> application.{code}
> (i) Service Wrapper starts Karaf service smoothly when JAVA_HOME does not 
> contain any whitespace
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-5908) Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace

2018-09-12 Thread Baptiste DA ROIT (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612300#comment-16612300
 ] 

Baptiste DA ROIT commented on KARAF-5908:
-

[~jbonofre] I think it comes from the missing quotes in karaf-wrapper.conf for 
windows/windows64.

These quotations marks were initially present but have been deleted.

I can fix this and make a PR if it's ok for you.

 

> Service Wrapper fails to start on Windows when JAVA_HOME contains whitespace 
> -
>
> Key: KARAF-5908
> URL: https://issues.apache.org/jira/browse/KARAF-5908
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf-os-integration
>Affects Versions: 4.2.1
> Environment: Windows
>Reporter: Baptiste DA ROIT
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>
> Service Wrapper fails to start Karaf Service on Windows when JAVA_HOME 
> contains whitespace, throwing the following error:
> {code:java}
> Une erreur système s’est produite.
> L’erreur système 1067 s’est produite.
> Le processus s’est arrêté inopinément.
> {code}
> Following is an extract of the wrapper.log:
> {code:java}
> STATUS | wrapper  | 2018/09/12 15:30:04 | --> Wrapper Started as Service
> STATUS | wrapper  | 2018/09/12 15:30:04 | Launching a JVM...
> INFO   | jvm 1    | 2018/09/12 15:30:04 | Erreur : impossible de trouver ou 
> charger la classe principale 
> Files\Java\jdk1.8.0_162.jre.lib.endorsed;C:\Program
> ERROR  | wrapper  | 2018/09/12 15:30:04 | JVM exited while loading the 
> application.{code}
> (i) Service Wrapper starts Karaf service smoothly when JAVA_HOME does not 
> contain any whitespace
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)