[GitHub] olamy commented on a change in pull request #232: MNG-5577 Migrate to JSR 300 - easy part1
olamy commented on a change in pull request #232: MNG-5577 Migrate to JSR 300 -
easy part1
URL: https://github.com/apache/maven/pull/232#discussion_r249300880
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java
##
@@ -132,9 +135,9 @@ public void process( CliRequest cliRequest )
request.getEventSpyDispatcher().onEvent( settingsRequest );
}
-logger.debug( "Reading global settings from "
+LOGGER.debug( "Reading global settings from "
Review comment:
maybe the opportunity to use ` LOGGER.debug( "Reading global settings from
{}", getLocation( settingsRequest.getGlobalSettingsSource(),
settingsRequest.getGlobalSettingsFile() ) ` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] olamy commented on a change in pull request #232: MNG-5577 Migrate to JSR 300 - easy part1
olamy commented on a change in pull request #232: MNG-5577 Migrate to JSR 300 - easy part1 URL: https://github.com/apache/maven/pull/232#discussion_r249300885 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java ## @@ -132,9 +135,9 @@ public void process( CliRequest cliRequest ) request.getEventSpyDispatcher().onEvent( settingsRequest ); } -logger.debug( "Reading global settings from " +LOGGER.debug( "Reading global settings from " + getLocation( settingsRequest.getGlobalSettingsSource(), settingsRequest.getGlobalSettingsFile() ) ); -logger.debug( "Reading user settings from " +LOGGER.debug( "Reading user settings from " Review comment: same comment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false
Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false URL: https://github.com/apache/maven-surefire/pull/213#discussion_r249300371 ## File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java ## @@ -114,7 +114,8 @@ public void platform() throws VerificationException + " surefire-api-*.jar" + " surefire-logger-api-*.jar" + " common-java5-*.jar" -+ " junit-platform-launcher-1.3.1.jar"; ++ " junit-platform-launcher-1.3.1.jar" ++ " maven-surefire-common-*.jar"; Review comment: @mvsoder Here is my fix in a new branch https://github.com/apache/maven-surefire/tree/SUREFIRE-1534 Can you check it out with SNAPSHOT version on your project? We need to add integration tests and add more Mocks to `AbstractSurefireMojoJava7PlusTest`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MJAVADOC-444) Add an 'aggregated-no-fork' goal
[
https://issues.apache.org/jira/browse/MJAVADOC-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747563#comment-16747563
]
Hudson commented on MJAVADOC-444:
-
Build succeeded in Jenkins: Maven TLP » maven-javadoc-plugin » master #135
See
https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/job/master/135/
> Add an 'aggregated-no-fork' goal
>
>
> Key: MJAVADOC-444
> URL: https://issues.apache.org/jira/browse/MJAVADOC-444
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
>Affects Versions: 2.10.3
>Reporter: Karl Heinz Marbaise
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 3.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently you can call maven-javadoc-plugin via {{mvn clean package
> javadoc:aggregate}} which results in deleting all previously created
> artifacts in {{target}} folder. So it would be helpful having a separate goal
> without forking the life cycle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MJAVADOC-444) Add an 'aggregated-no-fork' goal
[
https://issues.apache.org/jira/browse/MJAVADOC-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MJAVADOC-444.
---
Resolution: Fixed
Assignee: Robert Scholte
Fix Version/s: 3.1.0
Fixed in
[16aeaafc7107283882c9d3e268d42739186c6efc|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=16aeaafc7107283882c9d3e268d42739186c6efc]
Thanks for the patch!
> Add an 'aggregated-no-fork' goal
>
>
> Key: MJAVADOC-444
> URL: https://issues.apache.org/jira/browse/MJAVADOC-444
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
>Affects Versions: 2.10.3
>Reporter: Karl Heinz Marbaise
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 3.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently you can call maven-javadoc-plugin via {{mvn clean package
> javadoc:aggregate}} which results in deleting all previously created
> artifacts in {{target}} folder. So it would be helpful having a separate goal
> without forking the life cycle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte merged pull request #2: [MJAVADOC-444] add aggregate-no-fork and aggregate-test-no-fork for non-forking versions of aggregate goals.
rfscholte merged pull request #2: [MJAVADOC-444] add aggregate-no-fork and aggregate-test-no-fork for non-forking versions of aggregate goals. URL: https://github.com/apache/maven-javadoc-plugin/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rfscholte commented on issue #232: MNG-5577 Migrate to JSR 300 - easy part1
rfscholte commented on issue #232: MNG-5577 Migrate to JSR 300 - easy part1 URL: https://github.com/apache/maven/pull/232#issuecomment-455902603 @eolivelli FYI see https://wiki.eclipse.org/Sisu/PlexusMigration This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-5883) Silence unnecessary legacy local repository warning
[
https://issues.apache.org/jira/browse/MNG-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747532#comment-16747532
]
Petr Bodnar commented on MNG-5883:
--
Hi, I agree that the new behavior just doesn't make sense. I also realize this
could be discussed under a special ticket, but whatever... My patience have run
out after all the years, so I blogged about it here:
[https://programmedbycoincidence.blogspot.com/2019/01/the-biggest-wtf-new-feature-ive-ever.html|https://programmedbycoincidence.blogspot.com/2019/01/the-biggest-wtf-new-feature-ive-ever.html.].
I know I'm just a small fish in the sea, but who knows, maybe someone more
powerful and responsible will read it... ;) Or what about making a petition, as
there seems to be a new habit in the gaming industry, for example? :D
> Silence unnecessary legacy local repository warning
> ---
>
> Key: MNG-5883
> URL: https://issues.apache.org/jira/browse/MNG-5883
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.5, 3.3.3, 3.5.0
>Reporter: Ben Caradoc-Davies
>Priority: Trivial
>
> Having been burned on several occasions by the new local repository
> behaviour, which in effect scopes artifacts by their origin (when first
> stored in the local repository), I was delighted by the introduction of the
> -llr command line option in 3.0.3. I now use this behaviour for all builds to
> avoid the build instability caused by remote repository migration. This
> avoids the need to start each build with:
> {code}
> find ~/.m2/repository -name "_*.repositories" -exec rm -f {} \;
> {code}
> Given that users of -llr have made an informed choice to do so, please remove
> the (in my view unnecessary) warning that it generates:
> {code}
> [WARNING] Disabling enhanced local repository: using legacy is strongly
> discouraged to ensure build reproducibility.
> {code}
> Kind regards,
> Ben.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false
Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false URL: https://github.com/apache/maven-surefire/pull/213#discussion_r249286371 ## File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java ## @@ -114,7 +114,8 @@ public void platform() throws VerificationException + " surefire-api-*.jar" + " surefire-logger-api-*.jar" + " common-java5-*.jar" -+ " junit-platform-launcher-1.3.1.jar"; ++ " junit-platform-launcher-1.3.1.jar" ++ " maven-surefire-common-*.jar"; Review comment: The artifact `maven-surefire-common` should present on `in-plugin` CP, but it should not present on forked CP. Let's compare `AbstractSurefireMojo` with the version `2.20.1` and we should see the regression. It would be worth to control `forkCount=0/1` in the parameterized test `JUnitPlatformEnginesIT.java`. In principle the test result should be the same however the provider CP should see the difference with the present of the problematic artifact `maven-surefire-common`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false
Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false URL: https://github.com/apache/maven-surefire/pull/213#discussion_r249286371 ## File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java ## @@ -114,7 +114,8 @@ public void platform() throws VerificationException + " surefire-api-*.jar" + " surefire-logger-api-*.jar" + " common-java5-*.jar" -+ " junit-platform-launcher-1.3.1.jar"; ++ " junit-platform-launcher-1.3.1.jar" ++ " maven-surefire-common-*.jar"; Review comment: The artifact `maven-surefire-common` should present on `in-plugin` CP, but it should not present on forked CP. Let's compare `AbstractSurefireMojo` with the version `2.20.1` and we should see the regression. It would be worth to control `forkCount=0/1` in the parameterized test `JUnitPlatformEnginesIT.java`. In principle the test result should be the same however the provider CP should see the difference with the presence of the problematic artifact `maven-surefire-common`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MDEPLOY-250) add documentation on managing network issues
Hervé Boutemy created MDEPLOY-250:
-
Summary: add documentation on managing network issues
Key: MDEPLOY-250
URL: https://issues.apache.org/jira/browse/MDEPLOY-250
Project: Maven Deploy Plugin
Issue Type: Task
Components: deploy:deploy
Affects Versions: 3.0.0-M1
Reporter: Hervé Boutemy
Fix For: 3.0.0
network issues are happening sometimes, then there are strategies that have
been found to workaround, from simple retries, to 2-steps deploy through local
staging, like done by plc4x:
see in [https://github.com/apache/incubator-plc4x/blob/develop/Jenkinsfile]:
{noformat}
// We'll deploy to a relative directory so we can save
// that and deploy in a later step on a different node
sh 'mvn -P${JENKINS_PROFILE},development ${MVN_TEST_FAIL_IGNORE}
${JQASSISTANT_NEO4J_VERSION}
-DaltDeploymentRepository=snapshot-repo::default::file:./local-snapshots-dir
clean deploy'
{noformat}
followed by:
{noformat}
// Deploy the artifacts using the wagon-maven-plugin.
sh 'mvn -f jenkins.pom -X -P deploy-snapshots wagon:upload'
{noformat}
sharing such strategy can be useful to many
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MSITE-823) Documentation says JDK 1.6 required, doxia dependency requires 1.7
[
https://issues.apache.org/jira/browse/MSITE-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MSITE-823:
---
Fix Version/s: 3.8
> Documentation says JDK 1.6 required, doxia dependency requires 1.7
> --
>
> Key: MSITE-823
> URL: https://issues.apache.org/jira/browse/MSITE-823
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.7, 3.7.1
>Reporter: Adam Voss
>Priority: Major
> Fix For: 3.8
>
>
> [https://maven.apache.org/plugins/maven-site-plugin/plugin-info.html] lists
> System Requirements:
> |JDK|1.6|
>
> However doxia 1.8 is referenced, which requires JDK 1.7
> As a result Java 6 builds will fail after updating to 3.7 or newer
> {quote}
> Caused by: java.lang.UnsupportedClassVersionError:
> org/apache/maven/doxia/module/markdown/MarkdownParserModule : Unsupported
> major.minor version 51.0
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSITE-823) Documentation says JDK 1.6 required, doxia dependency requires 1.7
[
https://issues.apache.org/jira/browse/MSITE-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747491#comment-16747491
]
Sylwester Lachiewicz commented on MSITE-823:
With MSITE-828 we require Java 8 and rules for enforcer has been removed also.
> Documentation says JDK 1.6 required, doxia dependency requires 1.7
> --
>
> Key: MSITE-823
> URL: https://issues.apache.org/jira/browse/MSITE-823
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.7, 3.7.1
>Reporter: Adam Voss
>Priority: Major
>
> [https://maven.apache.org/plugins/maven-site-plugin/plugin-info.html] lists
> System Requirements:
> |JDK|1.6|
>
> However doxia 1.8 is referenced, which requires JDK 1.7
> As a result Java 6 builds will fail after updating to 3.7 or newer
> {quote}
> Caused by: java.lang.UnsupportedClassVersionError:
> org/apache/maven/doxia/module/markdown/MarkdownParserModule : Unsupported
> major.minor version 51.0
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MSITE-833) Remove dependency to maven-compat
Sylwester Lachiewicz created MSITE-833: -- Summary: Remove dependency to maven-compat Key: MSITE-833 URL: https://issues.apache.org/jira/browse/MSITE-833 Project: Maven Site Plugin Issue Type: Improvement Components: Maven 3 Reporter: Sylwester Lachiewicz # Remove usages of the maven-compat classes: org.apache.maven.artifact.manager.WagonManager # Move maven-compat scope to test -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPH-95) Make "plugin" field protected so DescribeMojo can be extended
[ https://issues.apache.org/jira/browse/MPH-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747481#comment-16747481 ] Sylwester Lachiewicz commented on MPH-95: - From maven-plugin-plugin:3.3 output generated from mvn help:describe -Dplugin=javadoc -Dgoal=help -Ddetail and mvn javadoc:help -Dgoal=help -Ddetail are equal. Subclassing DescribeMojo would add a dependency to maven-help-plugin dependencies to every plugin what we want to avoid. > Make "plugin" field protected so DescribeMojo can be extended > - > > Key: MPH-95 > URL: https://issues.apache.org/jira/browse/MPH-95 > Project: Maven Help Plugin > Issue Type: Improvement >Reporter: Sebb >Priority: Major > > The standalone Help Mojo has been updated to handle annotations, but the > generated help mojos added to mojos have not. > Rather than copy the code to every new Mojo, the generated HelpMojo could be > simplified by subclassing DescribeMojo and passing in the plugin Id. > However, the "plugin" field is private. Making it protected (or providing a > protected setter) would allow subclasses to set the field without needing to > use reflection. > A further enhancement might be to support a method whereby the calling plugin > can provide a link to its plugin.xml or other config item that provides the > necessary information, thus reducing the code needed in the calling plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPH-95) Make "plugin" field protected so DescribeMojo can be extended
[ https://issues.apache.org/jira/browse/MPH-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPH-95: Fix Version/s: waiting-for-feedback > Make "plugin" field protected so DescribeMojo can be extended > - > > Key: MPH-95 > URL: https://issues.apache.org/jira/browse/MPH-95 > Project: Maven Help Plugin > Issue Type: Improvement >Reporter: Sebb >Priority: Major > Fix For: waiting-for-feedback > > > The standalone Help Mojo has been updated to handle annotations, but the > generated help mojos added to mojos have not. > Rather than copy the code to every new Mojo, the generated HelpMojo could be > simplified by subclassing DescribeMojo and passing in the plugin Id. > However, the "plugin" field is private. Making it protected (or providing a > protected setter) would allow subclasses to set the field without needing to > use reflection. > A further enhancement might be to support a method whereby the calling plugin > can provide a link to its plugin.xml or other config item that provides the > necessary information, thus reducing the code needed in the calling plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-758) upgrade wagon-api from 1.0 to 3.3.1
[ https://issues.apache.org/jira/browse/MSITE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747480#comment-16747480 ] Hudson commented on MSITE-758: -- Build succeeded in Jenkins: Maven TLP » maven-site-plugin » master #73 See https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/master/73/ > upgrade wagon-api from 1.0 to 3.3.1 > --- > > Key: MSITE-758 > URL: https://issues.apache.org/jira/browse/MSITE-758 > Project: Maven Site Plugin > Issue Type: Dependency upgrade > Components: site:deploy >Affects Versions: 3.4 >Reporter: Hervé Boutemy >Assignee: Robert Scholte >Priority: Major > Fix For: 3.8 > > > I don't really know what changed from wagon-api 1.0 to 2.0 > or from 2.0 to 2.10 (= latest when writing this) > but this is just about the general idea of dropping old wagon 1.0 dependency > to get a newer one > for reference: > - Maven 2..x to 3.0.3 use wagon 1.0-beta > http://maven.apache.org/ref/3.0.3/apache-maven/dependencies.html > - Maven 3.0.4 uses wagon 2.2 > http://maven.apache.org/ref/3.0.4/apache-maven/dependencies.html > - Maven 3.0.5 uses wagon 2.4 > http://maven.apache.org/ref/3.0.5/apache-maven/dependencies.html > ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPH-95) Make "plugin" field protected so DescribeMojo can be extended
[ https://issues.apache.org/jira/browse/MPH-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPH-95: Labels: (was: up-for-grabs) > Make "plugin" field protected so DescribeMojo can be extended > - > > Key: MPH-95 > URL: https://issues.apache.org/jira/browse/MPH-95 > Project: Maven Help Plugin > Issue Type: Improvement >Reporter: Sebb >Priority: Major > > The standalone Help Mojo has been updated to handle annotations, but the > generated help mojos added to mojos have not. > Rather than copy the code to every new Mojo, the generated HelpMojo could be > simplified by subclassing DescribeMojo and passing in the plugin Id. > However, the "plugin" field is private. Making it protected (or providing a > protected setter) would allow subclasses to set the field without needing to > use reflection. > A further enhancement might be to support a method whereby the calling plugin > can provide a link to its plugin.xml or other config item that provides the > necessary information, thus reducing the code needed in the calling plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-758) upgrade wagon-api from 1.0 to 3.3.1
[ https://issues.apache.org/jira/browse/MSITE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747475#comment-16747475 ] Hudson commented on MSITE-758: -- Build succeeded in Jenkins: Maven TLP » maven-site-plugin » MSITE-758 #3 See https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/MSITE-758/3/ > upgrade wagon-api from 1.0 to 3.3.1 > --- > > Key: MSITE-758 > URL: https://issues.apache.org/jira/browse/MSITE-758 > Project: Maven Site Plugin > Issue Type: Dependency upgrade > Components: site:deploy >Affects Versions: 3.4 >Reporter: Hervé Boutemy >Assignee: Robert Scholte >Priority: Major > Fix For: 3.8 > > > I don't really know what changed from wagon-api 1.0 to 2.0 > or from 2.0 to 2.10 (= latest when writing this) > but this is just about the general idea of dropping old wagon 1.0 dependency > to get a newer one > for reference: > - Maven 2..x to 3.0.3 use wagon 1.0-beta > http://maven.apache.org/ref/3.0.3/apache-maven/dependencies.html > - Maven 3.0.4 uses wagon 2.2 > http://maven.apache.org/ref/3.0.4/apache-maven/dependencies.html > - Maven 3.0.5 uses wagon 2.4 > http://maven.apache.org/ref/3.0.5/apache-maven/dependencies.html > ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSITE-758) upgrade wagon-api from 1.0 to 3.3.1
[ https://issues.apache.org/jira/browse/MSITE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MSITE-758: - Summary: upgrade wagon-api from 1.0 to 3.3.1 (was: upgrade wagon-api from 1.0 to 2.x) > upgrade wagon-api from 1.0 to 3.3.1 > --- > > Key: MSITE-758 > URL: https://issues.apache.org/jira/browse/MSITE-758 > Project: Maven Site Plugin > Issue Type: Task > Components: site:deploy >Affects Versions: 3.4 >Reporter: Hervé Boutemy >Priority: Major > > I don't really know what changed from wagon-api 1.0 to 2.0 > or from 2.0 to 2.10 (= latest when writing this) > but this is just about the general idea of dropping old wagon 1.0 dependency > to get a newer one > for reference: > - Maven 2..x to 3.0.3 use wagon 1.0-beta > http://maven.apache.org/ref/3.0.3/apache-maven/dependencies.html > - Maven 3.0.4 uses wagon 2.2 > http://maven.apache.org/ref/3.0.4/apache-maven/dependencies.html > - Maven 3.0.5 uses wagon 2.4 > http://maven.apache.org/ref/3.0.5/apache-maven/dependencies.html > ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSITE-758) upgrade wagon-api from 1.0 to 3.3.1
[ https://issues.apache.org/jira/browse/MSITE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSITE-758. Resolution: Fixed Assignee: Robert Scholte Fix Version/s: 3.8 Fixed in [b9b12fa51b04b97fa08a672f6552efd91047c436|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=b9b12fa51b04b97fa08a672f6552efd91047c436], verified with all latest available 3.x.N versions on builds.a.o > upgrade wagon-api from 1.0 to 3.3.1 > --- > > Key: MSITE-758 > URL: https://issues.apache.org/jira/browse/MSITE-758 > Project: Maven Site Plugin > Issue Type: Dependency upgrade > Components: site:deploy >Affects Versions: 3.4 >Reporter: Hervé Boutemy >Assignee: Robert Scholte >Priority: Major > Fix For: 3.8 > > > I don't really know what changed from wagon-api 1.0 to 2.0 > or from 2.0 to 2.10 (= latest when writing this) > but this is just about the general idea of dropping old wagon 1.0 dependency > to get a newer one > for reference: > - Maven 2..x to 3.0.3 use wagon 1.0-beta > http://maven.apache.org/ref/3.0.3/apache-maven/dependencies.html > - Maven 3.0.4 uses wagon 2.2 > http://maven.apache.org/ref/3.0.4/apache-maven/dependencies.html > - Maven 3.0.5 uses wagon 2.4 > http://maven.apache.org/ref/3.0.5/apache-maven/dependencies.html > ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSITE-758) upgrade wagon-api from 1.0 to 3.3.1
[ https://issues.apache.org/jira/browse/MSITE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MSITE-758: - Issue Type: Dependency upgrade (was: Task) > upgrade wagon-api from 1.0 to 3.3.1 > --- > > Key: MSITE-758 > URL: https://issues.apache.org/jira/browse/MSITE-758 > Project: Maven Site Plugin > Issue Type: Dependency upgrade > Components: site:deploy >Affects Versions: 3.4 >Reporter: Hervé Boutemy >Priority: Major > > I don't really know what changed from wagon-api 1.0 to 2.0 > or from 2.0 to 2.10 (= latest when writing this) > but this is just about the general idea of dropping old wagon 1.0 dependency > to get a newer one > for reference: > - Maven 2..x to 3.0.3 use wagon 1.0-beta > http://maven.apache.org/ref/3.0.3/apache-maven/dependencies.html > - Maven 3.0.4 uses wagon 2.2 > http://maven.apache.org/ref/3.0.4/apache-maven/dependencies.html > - Maven 3.0.5 uses wagon 2.4 > http://maven.apache.org/ref/3.0.5/apache-maven/dependencies.html > ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-758) upgrade wagon-api from 1.0 to 2.x
[ https://issues.apache.org/jira/browse/MSITE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747464#comment-16747464 ] Hudson commented on MSITE-758: -- Build failed in Jenkins: Maven TLP » maven-site-plugin » MSITE-758 #2 See https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/MSITE-758/2/ > upgrade wagon-api from 1.0 to 2.x > - > > Key: MSITE-758 > URL: https://issues.apache.org/jira/browse/MSITE-758 > Project: Maven Site Plugin > Issue Type: Task > Components: site:deploy >Affects Versions: 3.4 >Reporter: Hervé Boutemy >Priority: Major > > I don't really know what changed from wagon-api 1.0 to 2.0 > or from 2.0 to 2.10 (= latest when writing this) > but this is just about the general idea of dropping old wagon 1.0 dependency > to get a newer one > for reference: > - Maven 2..x to 3.0.3 use wagon 1.0-beta > http://maven.apache.org/ref/3.0.3/apache-maven/dependencies.html > - Maven 3.0.4 uses wagon 2.2 > http://maven.apache.org/ref/3.0.4/apache-maven/dependencies.html > - Maven 3.0.5 uses wagon 2.4 > http://maven.apache.org/ref/3.0.5/apache-maven/dependencies.html > ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MPOM-209) The issueManagement entry points to wrong location.
[ https://issues.apache.org/jira/browse/MPOM-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy closed MPOM-209. -- Resolution: Fixed Assignee: Hervé Boutemy https://gitbox.apache.org/repos/asf?p=maven-apache-parent.git&a=commit&h=d4d79240bb0ea224a0ffb10d7c28a2dc46671c2e > The issueManagement entry points to wrong location. > --- > > Key: MPOM-209 > URL: https://issues.apache.org/jira/browse/MPOM-209 > Project: Maven POMs > Issue Type: Bug > Components: asf >Affects Versions: ASF-21 >Reporter: Karl Heinz Marbaise >Assignee: Hervé Boutemy >Priority: Critical > Labels: up-for-grabs > Fix For: ASF-22 > > Attachments: MPOM-209-apache.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The given [link to > jira|http://maven.apache.org/pom/asf/issue-management.html] for this project > is currently not correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPOM-209) The issueManagement entry points to wrong location.
[ https://issues.apache.org/jira/browse/MPOM-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747459#comment-16747459 ] Hudson commented on MPOM-209: - Build succeeded in Jenkins: Maven TLP » maven-apache-parent » master #55 See https://builds.apache.org/job/maven-box/job/maven-apache-parent/job/master/55/ > The issueManagement entry points to wrong location. > --- > > Key: MPOM-209 > URL: https://issues.apache.org/jira/browse/MPOM-209 > Project: Maven POMs > Issue Type: Bug > Components: asf >Affects Versions: ASF-21 >Reporter: Karl Heinz Marbaise >Priority: Critical > Labels: up-for-grabs > Fix For: ASF-22 > > Attachments: MPOM-209-apache.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The given [link to > jira|http://maven.apache.org/pom/asf/issue-management.html] for this project > is currently not correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] hboutemy merged pull request #3: [MPOM-209]. Corrected Jira URL.
hboutemy merged pull request #3: [MPOM-209]. Corrected Jira URL. URL: https://github.com/apache/maven-apache-parent/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ofarganc opened a new pull request #3: [MPOM-209]. Corrected Jira URL.
ofarganc opened a new pull request #3: [MPOM-209]. Corrected Jira URL. URL: https://github.com/apache/maven-apache-parent/pull/3 Thanks for the comments @hboutemy ! I also think this URL is cleaner this way without the whitespaces. I'd prefer to keep the %3D just in case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hboutemy closed pull request #3: [MPOM-209]. Corrected Jira URL.
hboutemy closed pull request #3: [MPOM-209]. Corrected Jira URL. URL: https://github.com/apache/maven-apache-parent/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hboutemy commented on issue #3: [MPOM-209]. Corrected Jira URL.
hboutemy commented on issue #3: [MPOM-209]. Corrected Jira URL. URL: https://github.com/apache/maven-apache-parent/pull/3#issuecomment-455866794 ok, let's remain strict: the current url remains quite easy to understand, now that the %20 are removed thank you, I knew I had to do something but never had the energy to really do it without some help This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MDEPLOY-51) Prompt for username and password if not supplied
[ https://issues.apache.org/jira/browse/MDEPLOY-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MDEPLOY-51: -- Labels: (was: contributers-welcome up-for-grabs) > Prompt for username and password if not supplied > > > Key: MDEPLOY-51 > URL: https://issues.apache.org/jira/browse/MDEPLOY-51 > Project: Maven Deploy Plugin > Issue Type: Improvement >Reporter: Paul Gier >Priority: Major > > Allow the user to supply a user name password for a remote server when the > deploy goal is called. Currently you have to add the repository username and > password to the server.xml file. It would be helpful if the user could be > prompted for a username and password on the command line. The password > should be hidden when it is entered. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-758) upgrade wagon-api from 1.0 to 2.x
[ https://issues.apache.org/jira/browse/MSITE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747450#comment-16747450 ] Robert Scholte commented on MSITE-758: -- This seems to be the reason why the plugin keeps failing on Jenkins, will pick it up. > upgrade wagon-api from 1.0 to 2.x > - > > Key: MSITE-758 > URL: https://issues.apache.org/jira/browse/MSITE-758 > Project: Maven Site Plugin > Issue Type: Task > Components: site:deploy >Affects Versions: 3.4 >Reporter: Hervé Boutemy >Priority: Major > > I don't really know what changed from wagon-api 1.0 to 2.0 > or from 2.0 to 2.10 (= latest when writing this) > but this is just about the general idea of dropping old wagon 1.0 dependency > to get a newer one > for reference: > - Maven 2..x to 3.0.3 use wagon 1.0-beta > http://maven.apache.org/ref/3.0.3/apache-maven/dependencies.html > - Maven 3.0.4 uses wagon 2.2 > http://maven.apache.org/ref/3.0.4/apache-maven/dependencies.html > - Maven 3.0.5 uses wagon 2.4 > http://maven.apache.org/ref/3.0.5/apache-maven/dependencies.html > ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPOM-209) The issueManagement entry points to wrong location.
[ https://issues.apache.org/jira/browse/MPOM-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747444#comment-16747444 ] ASF GitHub Bot commented on MPOM-209: - Github user ofarganc closed the pull request at: https://github.com/apache/maven-pom/pull/4 > The issueManagement entry points to wrong location. > --- > > Key: MPOM-209 > URL: https://issues.apache.org/jira/browse/MPOM-209 > Project: Maven POMs > Issue Type: Bug > Components: asf >Affects Versions: ASF-21 >Reporter: Karl Heinz Marbaise >Priority: Critical > Labels: up-for-grabs > Fix For: ASF-22 > > Attachments: MPOM-209-apache.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The given [link to > jira|http://maven.apache.org/pom/asf/issue-management.html] for this project > is currently not correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ofarganc opened a new pull request #3: [MPOM-209]. Corrected Jira URL.
ofarganc opened a new pull request #3: [MPOM-209]. Corrected Jira URL. URL: https://github.com/apache/maven-apache-parent/pull/3 Thanks for the comments @hboutemy ! I also think this URL is cleaner this way without the whitespaces. I'd prefer to keep the %3D just in case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6522) Prepare Maven's Core Integration Test Suite to test with Java 12 and 13-ea
[ https://issues.apache.org/jira/browse/MNG-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747441#comment-16747441 ] Hudson commented on MNG-6522: - Build failed in Jenkins: Maven TLP » maven » runITsWithJavaEA #5 See https://builds.apache.org/job/maven-box/job/maven/job/runITsWithJavaEA/5/ > Prepare Maven's Core Integration Test Suite to test with Java 12 and 13-ea > -- > > Key: MNG-6522 > URL: https://issues.apache.org/jira/browse/MNG-6522 > Project: Maven > Issue Type: Improvement > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > > * JDK 12 Windows and Linux (/) > - JDK 13 Window and Linux (/) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] eolivelli commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false
eolivelli commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false URL: https://github.com/apache/maven-surefire/pull/213#discussion_r249273282 ## File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java ## @@ -114,7 +114,8 @@ public void platform() throws VerificationException + " surefire-api-*.jar" + " surefire-logger-api-*.jar" + " common-java5-*.jar" -+ " junit-platform-launcher-1.3.1.jar"; ++ " junit-platform-launcher-1.3.1.jar" ++ " maven-surefire-common-*.jar"; Review comment: @Tibor17 This would require us ASF devs to modify this PR. we can guide @mvsoder to make the change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false
Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false URL: https://github.com/apache/maven-surefire/pull/213#discussion_r249273047 ## File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java ## @@ -114,7 +114,8 @@ public void platform() throws VerificationException + " surefire-api-*.jar" + " surefire-logger-api-*.jar" + " common-java5-*.jar" -+ " junit-platform-launcher-1.3.1.jar"; ++ " junit-platform-launcher-1.3.1.jar" ++ " maven-surefire-common-*.jar"; Review comment: The provider classpath must not have surefire-common. This would require us ASF devs to modify this PR. User's motivation is very valuable. The in-plugin classpath is used in two cases: 1. to run tests without forked VM and 2. filter tests before forking The problem is thata subtype (`ModularClasspathConfiguration`) `AbstractPathConfiguration.getInprocClasspath()` returns empty CP. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 opened a new pull request #214: Junit5 displayname
Tibor17 opened a new pull request #214: Junit5 displayname URL: https://github.com/apache/maven-surefire/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
