[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
gnodet commented on pull request #67: URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-765203066 > I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also? The native libraries location have changed a bit with Jansi 2.x, so we need to properly change the maven distribution, see https://github.com/apache/maven/pull/433/commits/151e3494fec519197fb55df97e79f60bb2ef1d24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] medb closed pull request #75: [WAGON-575] Add high-level download retries
medb closed pull request #75: URL: https://github.com/apache/maven-wagon/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] medb commented on pull request #75: [WAGON-575] Add high-level download retries
medb commented on pull request #75: URL: https://github.com/apache/maven-wagon/pull/75#issuecomment-765148607 Closing this PR because root cause of the [WAGON-575](https://issues.apache.org/jira/browse/WAGON-575) is [JDK-8214339](https://bugs.openjdk.java.net/browse/JDK-8214339) bug (see [comment](https://issues.apache.org/jira/browse/WAGON-575?focusedCommentId=17269843&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17269843) for more details). That's why this issue should be fixed in OpenJDK and not Maven Wagon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] medb edited a comment on pull request #75: [WAGON-575] Add high-level download retries
medb edited a comment on pull request #75: URL: https://github.com/apache/maven-wagon/pull/75#issuecomment-765148607 Closing this PR because root cause of the [WAGON-575](https://issues.apache.org/jira/browse/WAGON-575) is [JDK-8214339](https://bugs.openjdk.java.net/browse/JDK-8214339) bug (see [comment](https://issues.apache.org/jira/browse/WAGON-575?focusedCommentId=17269843&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17269843) for more details). That's why this issue should be fixed in OpenJDK, not Maven Wagon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color
gnodet commented on pull request #435: URL: https://github.com/apache/maven/pull/435#issuecomment-764761651 Supersedes https://github.com/apache/maven/pull/415 with a simpler change that allows supporting `mvn -v -l file` too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution
Tibor17 commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764556997 I meant splitting the plugin configurations, not spliting the projects. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] tobiasstadler commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution
tobiasstadler commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764537096 Splitting the plugin would also solve my problem. Do you know when this will happen? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams
gnodet commented on pull request #67: URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-764529402 Rebased on top of #69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #77: [MRESOLVER-145] SyncContext implementations
cstamas commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764908120 @michael-o @rmannibucau My proposal is to merge this PR, we already know current master is broken (see MRESOLVER-153), and while in this PR I did "return" (well, copied to new place) the `NoLockSyncContextFactory` (the `DefaultSyncContextFactory` that was noop, cause of MRESOLVER-153) I am now tempted to drop it, and merge. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764929160 I need to go through another iteration because I wasn't really happy with some things last time, plus I need test myself too. I am currently on a short leash, but will try to go through this month. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator
michael-o commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-764772183 Please note that Maven Core uses this stupid locator too: https://github.com/apache/maven/blob/39641ac803e17360df40288aaeb40ea0c5ccd77d/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] rfscholte commented on pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0
rfscholte commented on pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69#issuecomment-764899882 Merged with https://github.com/apache/maven-shared-utils/commit/c6ae1438bc08fe202fbd699af324ce1a81396dc9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] cquoss commented on a change in pull request #109: [SCM-947]
cquoss commented on a change in pull request #109:
URL: https://github.com/apache/maven-scm/pull/109#discussion_r561290337
##
File path:
maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java
##
@@ -125,24 +145,58 @@ public void execute()
ScmProvider provider = getScmManager().getProviderByRepository(
repository );
-ScmVersion startRev =
-getScmVersion( StringUtils.isEmpty( startScmVersionType ) ?
VERSION_TYPE_REVISION
- : startScmVersionType, startScmVersion );
-ScmVersion endRev =
-getScmVersion( StringUtils.isEmpty( endScmVersionType ) ?
VERSION_TYPE_REVISION
- : endScmVersionType, endScmVersion );
+ChangeLogScmRequest request = new ChangeLogScmRequest( repository,
getFileSet() );
+
+request.setDatePattern( dateFormat );
+
+if ( StringUtils.isNotEmpty( endDate ) )
+{
+request.setEndDate( parseDate( localFormat, endDate ) );
+}
+
+if ( StringUtils.isNotEmpty( endScmVersion ) )
+{
+ScmVersion endRev =
+getScmVersion( StringUtils.isEmpty( endScmVersionType ) ?
VERSION_TYPE_REVISION
+: endScmVersionType, endScmVersion );
+request.setEndRevision( endRev );
+}
+
+request.setLimit(limit);
+
+if ( numDays != null )
+{
+request.setNumDays( numDays );
+}
+
+if ( StringUtils.isNotEmpty( scmVersion ) )
+{
+ScmVersion rev =
+getScmVersion( StringUtils.isEmpty( scmVersionType ) ?
VERSION_TYPE_REVISION
+: scmVersionType, scmVersion );
+request.setRevision( rev );
+}
-ChangeLogScmResult result;
-if ( startRev != null || endRev != null )
+if ( StringUtils.isNotEmpty( scmBranch ) )
{
-result = provider.changeLog( repository, getFileSet(),
startRev, endRev, dateFormat );
+request.setScmBranch( new ScmBranch( scmBranch ) );
}
-else
+
+if ( StringUtils.isNotEmpty( startDate ) )
{
-result = provider.changeLog( repository, getFileSet(),
this.parseDate( localFormat, this.startDate ),
- this.parseDate( localFormat,
this.endDate ), 0,
- (ScmBranch) getScmVersion(
scmVersionType, scmVersion ), dateFormat );
+request.setStartDate( parseDate( localFormat, startDate ) );
}
+
+if ( StringUtils.isNotEmpty( startScmVersion ) )
Review comment:
Hmm. I believe i did some sort of alphabetical ordering.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WAGON-575) Retry for connection issues
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269843#comment-17269843
]
Igor Dvorzhak commented on WAGON-575:
-
After looking closer in the root cause of this issues, I believe that it is
caused by [SSLSocketImpl erroneously wraps
SocketException|https://bugs.openjdk.java.net/browse/JDK-8214339] issue in
OpenJDK. While original issue affects OpenJDK 11 and was already [partially
fixed|https://bugs.openjdk.java.net/browse/JDK-8237578], it was [back-ported to
OpenJDK
8u272|https://github.com/AdoptOpenJDK/openjdk-jdk8u/commit/b03902ff772e9a1638054094a7140d95a6083f1d]
too.
This also confirmed by stack trace:
{code:java}
Failed to download
com/google/code/tempus-fugit/tempus-fugit/1.1/tempus-fugit-1.1.jar to
/home/bigtop/.m2/repository/com/google/code/tempus-fugit/tempus-fugit/1.1/tempus-fugit-1.1.jar.part
(attempt #1):
org.apache.maven.wagon.TransferFailedException: Transfer failed for
https://repo.maven.apache.org/maven2/com/google/code/tempus-fugit/tempus-fugit/1.1/tempus-fugit-1.1.jar
at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:1242)
at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:1138)
at
org.apache.maven.wagon.StreamWagon.getInputStream(StreamWagon.java:167)
at
org.apache.maven.wagon.StreamWagon.getIfNewerInternal(StreamWagon.java:129)
at org.apache.maven.wagon.StreamWagon.getIfNewer(StreamWagon.java:96)
at org.apache.maven.wagon.StreamWagon.get(StreamWagon.java:63)
at
org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run(WagonTransporter.java:567)
at
org.eclipse.aether.transport.wagon.WagonTransporter.execute(WagonTransporter.java:435)
at
org.eclipse.aether.transport.wagon.WagonTransporter.get(WagonTransporter.java:412)
at
org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:457)
at
org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:364)
at
org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:75)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: javax.net.ssl.SSLException: Connection reset
at sun.security.ssl.Alert.createSSLException(Alert.java:127)
at sun.security.ssl.TransportContext.fatal(TransportContext.java:324)
at sun.security.ssl.TransportContext.fatal(TransportContext.java:267)
at sun.security.ssl.TransportContext.fatal(TransportContext.java:262)
at
sun.security.ssl.SSLSocketImpl.handleException(SSLSocketImpl.java:1303)
at sun.security.ssl.SSLSocketImpl.access$300(SSLSocketImpl.java:72)
at
sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:831)
at
org.apache.maven.wagon.providers.http.httpclient.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:137)
at
org.apache.maven.wagon.providers.http.httpclient.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:153)
at
org.apache.maven.wagon.providers.http.httpclient.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:280)
at
org.apache.maven.wagon.providers.http.httpclient.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
at
org.apache.maven.wagon.providers.http.httpclient.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
at
org.apache.maven.wagon.providers.http.httpclient.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
at
org.apache.maven.wagon.providers.http.httpclient.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
at
org.apache.maven.wagon.providers.http.httpclient.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:157)
at
org.apache.maven.wagon.providers.http.httpclient.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
at
org.apache.maven.wagon.providers.http.httpclient.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
at
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
at
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
at
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec.execute(RetryExec.java:89)
at
org.apache.maven.
[GitHub] [maven-scm] cquoss commented on a change in pull request #110: [SCM-948] Make the limit parameter work for git and svn exe
cquoss commented on a change in pull request #110:
URL: https://github.com/apache/maven-scm/pull/110#discussion_r561282580
##
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
##
@@ -96,11 +122,25 @@ public ScmResult executeCommand( ScmProviderRepository
repository, ScmFileSet fi
if ( versionOnly )
{
-return executeChangeLogCommand( repository, fileSet, version,
datePattern );
+if ( limit == null )
+{
+return executeChangeLogCommand( repository, fileSet, version,
datePattern );
+}
+else
+{
+return executeChangeLogCommand( repository, fileSet, version,
datePattern, limit );
Review comment:
OK. Will look into this and change it as requested.
##
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
##
@@ -46,6 +46,15 @@ protected abstract ChangeLogScmResult
executeChangeLogCommand( ScmProviderReposi
String
datePattern )
throws ScmException;
+@Deprecated
+protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repository, ScmFileSet fileSet,
Review comment:
Well, i come from a different angle here. I just want to get the limit
parameter to work. Because we have a use case for this. I am not here to
refactor this to use ChangeLogScmRequest. So i simply duplicated deprecated
methods to make it work. And yes - made them deprecated from the start so that
someone doing the refactoring part sees these also have to be taken into
account.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-shared-utils] rfscholte closed pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0
rfscholte closed pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-358) Cannot build plugin embedding java 13 compiled code
[
https://issues.apache.org/jira/browse/MPLUGIN-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269669#comment-17269669
]
Matthias Fuchs commented on MPLUGIN-358:
What's the reason for not releasing the new version?
> Cannot build plugin embedding java 13 compiled code
> ---
>
> Key: MPLUGIN-358
> URL: https://issues.apache.org/jira/browse/MPLUGIN-358
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.0
>Reporter: Nel Taurisson
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.6.1
>
>
> The ASM version (7) cannot parse java 13 compiled code (see exception
> below). Not tested, but, looking at the ASM version changelog, it probably
> won't work with java 12 compiled code either.
> Compiling plugin tools with asm version 7.3.1 resolves the issue (I can open
> a pull request, but, it is just a matter on replacing
> 7.0 with 7.3.1 in the
> parent pom).
> Thanks
>
>
> {code:java}
> // code placeholder
> {code}
> Execution default-descriptor of goal
> org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor failed:
> Unsupported class file major version 57 at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148) at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117) at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81) at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56) at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute
> (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute
> (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute
> (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute
> (MavenCli.java:956) at org.apache.maven.cli.MavenCli.doMain
> (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62) at
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke
> (Method.java:567) at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:289) at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:356) Caused by:
> org.apache.maven.plugin.PluginExecutionException: Execution
> default-descriptor of goal
> org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor failed:
> Unsupported class file major version 57 at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:148) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148) at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117) at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81) at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56) at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute
> (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute
> (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute
> (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute
> (MavenCli.java:956) at org.apache.maven.cli.MavenCli.doMain
> (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62) at
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke
> (Method.java:567) at
> org.codeh
[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764929160 I need to go through another iteration because I wasn't really happy with some things last time, plus I need test myself too. I am currently on a short leash, but will try to go through this month. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #77: [MRESOLVER-145] SyncContext implementations
cstamas commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764908120 @michael-o @rmannibucau My proposal is to merge this PR, we already know current master is broken (see MRESOLVER-153), and while in this PR I did "return" (well, copied to new place) the `NoLockSyncContextFactory` (the `DefaultSyncContextFactory` that was noop, cause of MRESOLVER-153) I am now tempted to drop it, and merge. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-973) Upgrade Jansi to 2.2.0
[ https://issues.apache.org/jira/browse/MSHARED-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269591#comment-17269591 ] Hudson commented on MSHARED-973: Build succeeded in Jenkins: Maven » Maven TLP » maven-shared-utils » master #32 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-shared-utils/job/master/32/ > Upgrade Jansi to 2.2.0 > -- > > Key: MSHARED-973 > URL: https://issues.apache.org/jira/browse/MSHARED-973 > Project: Maven Shared Components > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Robert Scholte >Priority: Major > Fix For: maven-shared-utils-3.4.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-shared-utils] rfscholte closed pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0
rfscholte closed pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] rfscholte commented on pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0
rfscholte commented on pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69#issuecomment-764899882 Merged with https://github.com/apache/maven-shared-utils/commit/c6ae1438bc08fe202fbd699af324ce1a81396dc9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSHARED-973) Upgrade Jansi to 2.2.0
[ https://issues.apache.org/jira/browse/MSHARED-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHARED-973. -- Fix Version/s: maven-shared-utils-3.4.0 Assignee: Robert Scholte Resolution: Fixed Fixed in [c6ae1438bc08fe202fbd699af324ce1a81396dc9|https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git;a=commit;h=c6ae1438bc08fe202fbd699af324ce1a81396dc9] > Upgrade Jansi to 2.2.0 > -- > > Key: MSHARED-973 > URL: https://issues.apache.org/jira/browse/MSHARED-973 > Project: Maven Shared Components > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Robert Scholte >Priority: Major > Fix For: maven-shared-utils-3.4.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-973) Upgrade Jansi to 2.2.0
[ https://issues.apache.org/jira/browse/MSHARED-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MSHARED-973: --- Issue Type: Dependency upgrade (was: Improvement) > Upgrade Jansi to 2.2.0 > -- > > Key: MSHARED-973 > URL: https://issues.apache.org/jira/browse/MSHARED-973 > Project: Maven Shared Components > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7080) Add a --color argument
[
https://issues.apache.org/jira/browse/MNG-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269577#comment-17269577
]
Michael Osipov commented on MNG-7080:
-
I strongly support this.
> Add a --color argument
> --
>
> Key: MNG-7080
> URL: https://issues.apache.org/jira/browse/MNG-7080
> Project: Maven
> Issue Type: Improvement
>Reporter: Guillaume Nodet
>Priority: Major
>
> This would be cleaner than having to use {{-Dstyle.color=xxx}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] gnodet opened a new pull request #436: Add a --color option to simplify color support
gnodet opened a new pull request #436: URL: https://github.com/apache/maven/pull/436 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator
michael-o commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-764772183 Please note that Maven Core uses this stupid locator too: https://github.com/apache/maven/blob/39641ac803e17360df40288aaeb40ea0c5ccd77d/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7080) Add a --color argument
Guillaume Nodet created MNG-7080:
Summary: Add a --color argument
Key: MNG-7080
URL: https://issues.apache.org/jira/browse/MNG-7080
Project: Maven
Issue Type: Improvement
Reporter: Guillaume Nodet
This would be cleaner than having to use {{-Dstyle.color=xxx}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] gnodet commented on pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color
gnodet commented on pull request #435: URL: https://github.com/apache/maven/pull/435#issuecomment-764761651 Supersedes https://github.com/apache/maven/pull/415 with a simpler change that allows supporting `mvn -v -l file` too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet opened a new pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color
gnodet opened a new pull request #435: URL: https://github.com/apache/maven/pull/435 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6755) Console remains colored on build failed
[ https://issues.apache.org/jira/browse/MNG-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269393#comment-17269393 ] Guillaume Nodet commented on MNG-6755: -- Upgrading to Jansi 2.2.0 has a good chance to help with this issue, as a reset code has been added to the windows platform in 2.x > Console remains colored on build failed > --- > > Key: MNG-6755 > URL: https://issues.apache.org/jira/browse/MNG-6755 > Project: Maven > Issue Type: Bug > Components: Command Line > Environment: windows >Reporter: Peter Rader >Priority: Minor > Attachments: bbbug.png > > > If a build failed the console remains in colors used by the CLI. > This problem occourse occasionally. Reproducable often if a resource is > locked. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6915) Maven console output could be wider
[ https://issues.apache.org/jira/browse/MNG-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269381#comment-17269381 ] Guillaume Nodet commented on MNG-6915: -- Now that Jansi 2.2.0 has been released, I've pushed two PR to allow the help to be formatted according to the terminal width. See https://github.com/apache/maven/pull/434 > Maven console output could be wider > --- > > Key: MNG-6915 > URL: https://issues.apache.org/jira/browse/MNG-6915 > Project: Maven > Issue Type: Improvement > Components: Command Line >Affects Versions: 3.6.3 > Environment: Apache Maven 3.6.3 > (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: C:\Java\apache-maven-3.6.3\bin\.. > Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_251\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Priority: Minor > Attachments: 2020-05-22 18_14_44-Command Prompt.png > > > Maven console output could be wider, either generally or by asking the > console its width. For example, when we build Log4j 2 3.0.0-SNAPSHOT, we get > the non-aligned summary attached as a screenshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-shared-utils] gnodet opened a new pull request #70: [MNG-6915] Add a helper method to get the terminal width
gnodet opened a new pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRESOURCES-265) Resource copying not using specified encoding
[ https://issues.apache.org/jira/browse/MRESOURCES-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269378#comment-17269378 ] Søren Nielsen edited comment on MRESOURCES-265 at 1/21/21, 3:29 PM: I had the same issue and luckily I only had two files in src/main/resources. I solved the problem by opening each file and "Save with encoding..." choosing UTF-8. I suspect that the issue was due to my name being included in the file (ø) After that `mvn clean verify` worked as expected. was (Author: cph.dev): I had the same issue and luckily I only had two files in src/main/resources. I solved the problem by opening each file and "Save with encoding..." choosing UTF-8. There where no special characters in the files but it seems to resolve the issue. After that `mvn clean verify` worked as expected. > Resource copying not using specified encoding > - > > Key: MRESOURCES-265 > URL: https://issues.apache.org/jira/browse/MRESOURCES-265 > Project: Maven Resources Plugin > Issue Type: Bug > Components: copy >Affects Versions: 3.2.0 > Environment: Linux, CentOS 7 > Jenkins 2.251 > Jenkins Maven Integration plugin 3.1.2 > Java 1.8 >Reporter: Duncan Kinnear >Priority: Major > > Overnight our Jenkins builds stopped working. On investigation we found that > maven-resources-plugin version used yesterday was 3.1.0 (which worked fine) > and today it was using 3.2.0. > The stacktrace produced by adding the "e" switch to the maven command line > had the following root cause (truncated for brevity):- > Caused by: java.nio.charset.MalformedInputException: Input length = 1 > at java.nio.charset.CoderResult.throwException (CoderResult.java:281) > at sun.nio.cs.StreamDecoder.implRead (StreamDecoder.java:339) > at sun.nio.cs.StreamDecoder.read (StreamDecoder.java:178) > at java.io.InputStreamReader.read (InputStreamReader.java:184) > at java.io.BufferedReader.read1 (BufferedReader.java:210) > at java.io.BufferedReader.read (BufferedReader.java:286) > at java.io.BufferedReader.fill (BufferedReader.java:161) > at java.io.BufferedReader.read (BufferedReader.java:182) > at org.apache.maven.shared.filtering.BoundedReader.read > (BoundedReader.java:85) > at > org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read > (MultiDelimiterInterpolatorFilterReaderLineEnding.java:235) > at > org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read > (MultiDelimiterInterpolatorFilterReaderLineEnding.java:197) > at java.io.Reader.read (Reader.java:140) > at org.apache.maven.shared.utils.io.IOUtil.copy (IOUtil.java:199) > > After a google search told us this was an encoding issue, we added the > following to the maven command line, but this made no difference: > -Dproject.build.sourceEncoding=UTF-8 -Dproject.reporting.outputEncoding=UTF-8 > > The maven build log has these info messsage just before the error: > [INFO] — maven-resources-plugin:3.2.0:resources (default-cli) @ uniworks — > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Using 'UTF-8' encoding to copy filtered properties files. > [INFO] Copying 430 resources > We only 'fixed' the problem by specifying version 3.1.0 of the plugin in the > projects POM 'pluginManagement' section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRESOURCES-265) Resource copying not using specified encoding
[ https://issues.apache.org/jira/browse/MRESOURCES-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269378#comment-17269378 ] Søren Nielsen commented on MRESOURCES-265: -- I had the same issue and luckily I only had two files in src/main/resources. I solved the problem by opening each file and "Save with encoding..." choosing UTF-8. There where no special characters in the files but it seems to resolve the issue. After that `mvn clean verify` worked as expected. > Resource copying not using specified encoding > - > > Key: MRESOURCES-265 > URL: https://issues.apache.org/jira/browse/MRESOURCES-265 > Project: Maven Resources Plugin > Issue Type: Bug > Components: copy >Affects Versions: 3.2.0 > Environment: Linux, CentOS 7 > Jenkins 2.251 > Jenkins Maven Integration plugin 3.1.2 > Java 1.8 >Reporter: Duncan Kinnear >Priority: Major > > Overnight our Jenkins builds stopped working. On investigation we found that > maven-resources-plugin version used yesterday was 3.1.0 (which worked fine) > and today it was using 3.2.0. > The stacktrace produced by adding the "e" switch to the maven command line > had the following root cause (truncated for brevity):- > Caused by: java.nio.charset.MalformedInputException: Input length = 1 > at java.nio.charset.CoderResult.throwException (CoderResult.java:281) > at sun.nio.cs.StreamDecoder.implRead (StreamDecoder.java:339) > at sun.nio.cs.StreamDecoder.read (StreamDecoder.java:178) > at java.io.InputStreamReader.read (InputStreamReader.java:184) > at java.io.BufferedReader.read1 (BufferedReader.java:210) > at java.io.BufferedReader.read (BufferedReader.java:286) > at java.io.BufferedReader.fill (BufferedReader.java:161) > at java.io.BufferedReader.read (BufferedReader.java:182) > at org.apache.maven.shared.filtering.BoundedReader.read > (BoundedReader.java:85) > at > org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read > (MultiDelimiterInterpolatorFilterReaderLineEnding.java:235) > at > org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read > (MultiDelimiterInterpolatorFilterReaderLineEnding.java:197) > at java.io.Reader.read (Reader.java:140) > at org.apache.maven.shared.utils.io.IOUtil.copy (IOUtil.java:199) > > After a google search told us this was an encoding issue, we added the > following to the maven command line, but this made no difference: > -Dproject.build.sourceEncoding=UTF-8 -Dproject.reporting.outputEncoding=UTF-8 > > The maven build log has these info messsage just before the error: > [INFO] — maven-resources-plugin:3.2.0:resources (default-cli) @ uniworks — > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Using 'UTF-8' encoding to copy filtered properties files. > [INFO] Copying 430 resources > We only 'fixed' the problem by specifying version 3.1.0 of the plugin in the > projects POM 'pluginManagement' section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] gnodet opened a new pull request #434: [MNG-6915] Format help according to the terminal width
gnodet opened a new pull request #434: URL: https://github.com/apache/maven/pull/434 This PR is built on top of #433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet opened a new pull request #433: [MNG-7079] Upgrade to jansi 2.2.0
gnodet opened a new pull request #433: URL: https://github.com/apache/maven/pull/433 This PR depends on https://github.com/apache/maven-shared-utils/pull/69 and the release of `maven-shared-utils`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6719) mvn color output escape keys w/ "| tee xxx.log" on Win with git/bash
[
https://issues.apache.org/jira/browse/MNG-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269244#comment-17269244
]
Guillaume Nodet commented on MNG-6719:
--
I confirm this issue is fixed with MNG-7079 / MSHARED-973
> mvn color output escape keys w/ "| tee xxx.log" on Win with git/bash
>
>
> Key: MNG-6719
> URL: https://issues.apache.org/jira/browse/MNG-6719
> Project: Maven
> Issue Type: Bug
>Reporter: Gerd Aschemann
>Priority: Major
>
> When output of {{mvn}} is redirected to a pipe (e.g., {{mvn verify | tee
> mvn.log}}), on Windows with git (bash), the color escape characters are
> written to the file. This works without a problem on OSX. Obviously the
> detection if the output is a tty does not work correctly with git / bash on
> Windows?
> The git / bash is based on MinGW64. Probably it is not a Maven problem but a
> combination of Maven / JDK / git?
> Used Versions:
> * git version 2.16.2.windows.1 / GNU bash, version 4.4.19(1)-release
> (x86_64-pc-msys)
> * Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T21:00:29+02:00)
> * Java version: 1.8.0_191-1-redhat, vendor: Oracle Corporation
> Probably it could also be a solution to add another CLI option? I currently
> use the {{| tee mvn.log}} approach to have both, output and log. A CLI option
> {{-L}} (as opposed to {{-l}}) could do both, output to stdout/stderr with
> color escape chars and output to a file without color escapes. What do you
> think?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution
Tibor17 commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764556997 I meant splitting the plugin configurations, not spliting the projects. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] tobiasstadler commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution
tobiasstadler commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764537096 Splitting the plugin would also solve my problem. Do you know when this will happen? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MSHARED-822) MessageBuilder should support Paths
[ https://issues.apache.org/jira/browse/MSHARED-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269196#comment-17269196 ] Guillaume Nodet edited comment on MSHARED-822 at 1/21/21, 10:27 AM: Hyperlinks are somewhat supported by recent terminals [https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda] but those seem quite limited, especially for non http urls (at least, using files does not work on OSX iTerm). was (Author: gnt): Hyperlinks are somewhat supported by recent terminals: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda > MessageBuilder should support Paths > --- > > Key: MSHARED-822 > URL: https://issues.apache.org/jira/browse/MSHARED-822 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-shared-utils >Reporter: Robert Scholte >Priority: Major > Labels: infosupport > Attachments: comparing colour schemes.pdf > > Time Spent: 10m > Remaining Estimate: 0h > > The idea behind this is that you can control the output, e.g. just highlight > with a specific color, use relative paths or absolute paths or even translate > them to hyperlinks in case the output is an HTML page. > Since this is a utility class, we should investigate if we can use a > [ServiceLoader|https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html] > to solve such transformation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-822) MessageBuilder should support Paths
[ https://issues.apache.org/jira/browse/MSHARED-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269196#comment-17269196 ] Guillaume Nodet commented on MSHARED-822: - Hyperlinks are somewhat supported by recent terminals: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda > MessageBuilder should support Paths > --- > > Key: MSHARED-822 > URL: https://issues.apache.org/jira/browse/MSHARED-822 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-shared-utils >Reporter: Robert Scholte >Priority: Major > Labels: infosupport > Attachments: comparing colour schemes.pdf > > Time Spent: 10m > Remaining Estimate: 0h > > The idea behind this is that you can control the output, e.g. just highlight > with a specific color, use relative paths or absolute paths or even translate > them to hyperlinks in case the output is an HTML page. > Since this is a utility class, we should investigate if we can use a > [ServiceLoader|https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html] > to solve such transformation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams
gnodet commented on pull request #67: URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-764529402 Rebased on top of #69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] gnodet opened a new pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0
gnodet opened a new pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-1880) Run nested junit test from abstract class
jakob braun created SUREFIRE-1880:
-
Summary: Run nested junit test from abstract class
Key: SUREFIRE-1880
URL: https://issues.apache.org/jira/browse/SUREFIRE-1880
Project: Maven Surefire
Issue Type: Bug
Components: JUnit 5.x support
Affects Versions: 3.0.0-M3
Reporter: jakob braun
Consider the following Junit5 tests:
{code:java}
abstract class AbstractTest{
@Nested
class NestedTest{
@Test
void myTest(){
}
}
}
class TestImpl extends AbstractTest{
}{code}
I would like to run myTest. It seems however like this is not possible using
the failsafe plugin.
Here is what I tried:
* AbstractTest$NestedTest.myTest
* TestImpl$NestedTest.myTest
* AbstractTest$NestedTest#myTest
* TestImpl$NestedTest#myTest
If I'm doing something wrong I would be glad about some help!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
