[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 @phrocker used https://github.com/apache/nifi-minifi-cpp/pull/119 which has a single merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 @benqiu2016 Can you rebase? https://github.com/apache/nifi-minifi-cpp/commit/4042aa0ed2cd16aee740978e3575cc58a7e9cff7 appears to be a merge commit since there are two parents for this commit. Can you rebase and we'll get it merged, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 Thanks for the review. Can we merge the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user kevdoran commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 @benqiu2016 thanks for making that round of changes! They look good. I'll be happy to test the branch when a get a chance to setup a NiFi environment that I can use to test some of the more advanced configurations that are supported (clustered peers, secure client). I should have a chance to do that this week, hopefully in the next couple days. As a general comment, it looks like there are quite a few cases that are not covered by corresponding automated tests so a lot of this will rely manual verification. You may want to open a JIRA ticket for adding some additional unit tests and integration tests as a way to verify this feature over time as changes are made to the codebase. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 @phrocker @kevdoran use lock, extract token code, set default port. we need to support /nifi-api/controller which is common to 1.x and 0.x. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker if we use a stack based lock guard, in order to control the
period of lock, i need to add scope for the lock guard inside {}. it make code
less readable.
Anyway. i can change my code to use that if you prefer the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 Looks good, but am curious about the use of lock vs a stack based lock guard. What was the reason for that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 @phrocker please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #114: site2site port negotiation
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/114 @phrocker please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
