[jira] [Commented] (SPARK-15688) RelationalGroupedDataset.toDF should not add group by expressions that are already added in the aggregate expressions.

2016-06-02 Thread Apache Spark (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313306#comment-15313306
 ] 

Apache Spark commented on SPARK-15688:
--

User 'dilipbiswal' has created a pull request for this issue:
https://github.com/apache/spark/pull/13483

> RelationalGroupedDataset.toDF should not add group by expressions that are 
> already added in the aggregate expressions.
> --
>
> Key: SPARK-15688
> URL: https://issues.apache.org/jira/browse/SPARK-15688
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Reporter: Yin Huai
>
> For {{df.groupBy("col").agg($"col", count("*"))`}}, it is kind of weird to 
> have col appearing twice in the result. Seems we can avoid of output group by 
> expressions twice if it already a part of {{agg}}. Looks like 
> RelationalGroupedDataset.toDF is the place to change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-15688) RelationalGroupedDataset.toDF should not add group by expressions that are already added in the aggregate expressions.

2016-05-31 Thread Xiao Li (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309299#comment-15309299
 ] 

Xiao Li commented on SPARK-15688:
-

Yeah, will ask my teammate to do it ASAP. Thanks!

> RelationalGroupedDataset.toDF should not add group by expressions that are 
> already added in the aggregate expressions.
> --
>
> Key: SPARK-15688
> URL: https://issues.apache.org/jira/browse/SPARK-15688
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Reporter: Yin Huai
>
> For {{df.groupBy("col").agg($"col", count("*"))`}}, it is kind of weird to 
> have col appearing twice in the result. Seems we can avoid of output group by 
> expressions twice if it already a part of {{agg}}. Looks like 
> RelationalGroupedDataset.toDF is the place to change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-15688) RelationalGroupedDataset.toDF should not add group by expressions that are already added in the aggregate expressions.

2016-05-31 Thread Yin Huai (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309293#comment-15309293
 ] 

Yin Huai commented on SPARK-15688:
--

[~smilegator] Anyone from your side can take this?

> RelationalGroupedDataset.toDF should not add group by expressions that are 
> already added in the aggregate expressions.
> --
>
> Key: SPARK-15688
> URL: https://issues.apache.org/jira/browse/SPARK-15688
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Reporter: Yin Huai
>
> For {{df.groupBy("col").agg($"col", count("*"))`}}, it is kind of weird to 
> have col appearing twice in the result. Seems we can avoid of output group by 
> expressions twice if it already a part of {{agg}}. Looks like 
> RelationalGroupedDataset.toDF is the place to change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org