[JIRA] [scm-sync-configuration-plugin] (JENKINS-27591) Improve performance of initial scan by narrowing the job config pattern
Jonas Kåveby commented on JENKINS-27591 Improve performance of initial scan by narrowing the job config pattern I agree with you that JENKINS-19659 is the proper solution to the problem reported in this issue. Thank you for your time analysing this! I've written JENKINS-27649 to track the regexp bug. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [scm-sync-configuration-plugin] (JENKINS-27649) Custom commit message not possible when configuring jobs
Jonas Kåveby commented on JENKINS-27649 Custom commit message not possible when configuring jobs The following regexp matches all the example URIs: "^/*(.*view/+[^/]+/+)?(job/+[^/]+/+)+configure$" This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [scm-sync-configuration-plugin] (JENKINS-27649) Custom commit message not possible when configuring jobs
Jonas Kåveby created JENKINS-27649 Custom commit message not possible when configuring jobs Issue Type: Bug Assignee: Frédéric Camblor Components: scm-sync-configuration-plugin Created: 27/Mar/15 12:14 PM Description: The commit comment form doesn't always appear when saving a job configuration. The fault seems to lie in the PageMatcher regexp. I've tested the current regexp against a couple of different URIs: "view/x//job/a/configure" Passed "view/x//job/a/job/b/configure" Passed "view/x//job/a/job/b/job/c/configure" Passed "/job/a/configure" Passed "/job/a/job/b/configure" Passed "/view/x//job/a/job/b/job/c/configure" Passed "view/x/job/a/job/b/configure" Failed! "/job/ab/job/b/configure" Failed! "view/x/job/a/configure" Failed! "/view/x/job/a/configure" Failed! "job/a/configure" Failed! "///view/x//job//a//job//b/job//c//configure" Failed! Some of the failed URIs are real-life examples of URIs where the commit comment form doesn't appear, others are more hypothetical. I can work around the problem by adding an extra slash to my URIs when I configure jobs. Instead of opening view/All/job/myjob/configure in my browser, I open view/All//job/myjob/configure. Environment: Jenkins 1.580.3, SCM Sync Configuration Plugin 0.0.8 Project: Jenkins Priority: Minor Reporter: Jonas Kåveby This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [scm-sync-configuration-plugin] (JENKINS-27591) Improve performance of initial scan by narrowing the job config pattern
Jonas Kåveby commented on JENKINS-27591 Improve performance of initial scan by narrowing the job config pattern Okay, disabling strategies one by one makes more sense, my misunderstanding. the SCM Sync status footer I was wrong, this doesn't seem to be affected (I was sloppy reading footer.jelly yesterday). detailed commit messages Since the job strategy would be disabled and the manual strategy used instead, the commit messages would be Modification on configuration(s) / Item renamed / File hierarchy deleted instead of Job XYZ configuration updated / Job XYZ hierarchy renamed from ABC to DEF / Job XYZ hierarchy deleted. It makes it less clear what's been changed when skimming the changes in an scm browser, but it's not a blocker. the ability to customize commit messages The decorateOnsubmitForm logic in footer.jelly is only shown if the current page matches a PageMatcher from a strategy. If the job strategy is disabled and the manual strategy used instead, I assume there will be no PageMatcher matching URIs like view/All/job/myjob/configure, so the user won't be given an opportunity to provide a custom commit message when configuring jobs. Not a big issue. So, the tradeoff would be improved performance against less clarity in the SCM history. I think it's an acceptable tradeoff, but the best would be if I could keep both of course. By the way, I found a bug in the PageMatcher regexp in JobConfigScmSyncStrategy. I'll post a separate JIRA issue for that. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [scm-sync-configuration-plugin] (JENKINS-27591) Improve performance of initial scan by narrowing the job config pattern
Jonas Kåveby commented on JENKINS-27591 Improve performance of initial scan by narrowing the job config pattern Thanks, that might be a solution. So, if JENKINS-19659 is implemented, I would be able to disable default includes and then manually add the following includes: config.xml hudson*.xml scm-sync-configuration.xml jobs/*/config.xml users/*/config.xml If I understand the current suggestion in JENKINS-19659 and the SCM Sync Configuration Plugin source code, such a solution would have the drawback of losing the following functionality: the SCM Sync status footer detailed commit messages the ability to customize commit messages Perhaps that is an acceptable tradeoff. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [scm-sync-configuration-plugin] (JENKINS-27591) Improve performance of initial scan by narrowing the job config pattern
Jonas Kåveby commented on JENKINS-27591 Improve performance of initial scan by narrowing the job config pattern Ah, we're not using the Cloudbees folder plugin so unfortunately I missed that feature. Thank you for the information. The problem still remains, but my proposed solution is not valid. I'll see if I can come up with a better solution. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [scm-sync-configuration-plugin] (JENKINS-27591) Improve performance of initial scan by narrowing the job config pattern
Jonas Kåveby
updated JENKINS-27591
Improve performance of initial scan by narrowing the job config pattern
Change By:
Jonas Kåveby
(25/Mar/15 4:10 PM)
Description:
Our Jenkins jobs archive quite a lot of artifacts, and we've been running our jobs for a couple of years. As a result, under our jobs directory there are tens of millions of files and directories.When activating the SCM Sync Configuration Plugin on such a large directory, it will scan for files that matches the pattern
"
{{\
*
\
*/jobs/
\
*/config.xml
"
}}
under the root directory
{{
Hudson.getInstance().getRootDir()
}}
. The initial
"
{{\
*
\
*
"
}}
segment makes this scan recursive, and every directory has to be traversed.In our Jenkins installation, the SCM Sync Configuration Plugin never completes the scan, the data to scan is simply too large. I gave up after a couple of hours of scanning and aborted it.The jobs directory is hardcoded in Jenkins core to be located at
{{
Jenkins.getInstance().getRootDir() + "jobs"
}}
. See
{{
jenkins.model.Jenkins.getRootDirFor(String name)
}}
for an example. So, as far as I can see, there is no use for the initial
"
{{
**
"
}}
segment in the pattern.I suggest that the pattern is narrowed to improve the performance of the initial scan. By changing the
{{
PATTERNS
}}
constant in
{{
hudson.plugins.scm_sync_configuration.strategies.impl.JobConfigScmSyncStrategy
}}
to
"
{{
jobs/
\
*/config.xml
"
}}
, the scan is no longer recursive. I've tested this change on our Jenkins installation, and it allows the scan to finish within seconds as opposed to hours.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [scm-sync-configuration-plugin] (JENKINS-27591) Improve performance of initial scan by narrowing the job config pattern
Jonas Kåveby created JENKINS-27591 Improve performance of initial scan by narrowing the job config pattern Issue Type: Improvement Assignee: Frédéric Camblor Components: scm-sync-configuration-plugin Created: 25/Mar/15 3:37 PM Description: Our Jenkins jobs archive quite a lot of artifacts, and we've been running our jobs for a couple of years. As a result, under our jobs directory there are tens of millions of files and directories. When activating the SCM Sync Configuration Plugin on such a large directory, it will scan for files that matches the pattern "*/jobs//config.xml" under the root directory Hudson.getInstance().getRootDir(). The initial "**" segment makes this scan recursive, and every directory has to be traversed. In our Jenkins installation, the SCM Sync Configuration Plugin never completes the scan, the data to scan is simply too large. I gave up after a couple of hours of scanning and aborted it. The jobs directory is hardcoded in Jenkins core to be located at Jenkins.getInstance().getRootDir() + "jobs". See jenkins.model.Jenkins.getRootDirFor(String name) for an example. So, as far as I can see, there is no use for the initial "**" segment in the pattern. I suggest that the pattern is narrowed to improve the performance of the initial scan. By changing the PATTERNS constant in hudson.plugins.scm_sync_configuration.strategies.impl.JobConfigScmSyncStrategy to "jobs/*/config.xml", the scan is no longer recursive. I've tested this change on our Jenkins installation, and it allows the scan to finish within seconds as opposed to hours. Environment: Jenkins 1.580.3, SCM Sync Configuration Plugin 0.0.8 Project: Jenkins Labels: performance Priority: Blocker Reporter: Jonas Kåveby This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [description-setter] (JENKINS-23097) Set description during build as a build step
Jonas Kåveby assigned JENKINS-23097 to Jonas Kåveby Set description during build as a build step Change By: Jonas Kåveby (21/May/14 7:10 AM) Assignee: huybrechts Jonas Kåveby This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [description-setter] (JENKINS-23097) Set description during build as a build step
Jonas Kåveby started work on JENKINS-23097 Set description during build as a build step Change By: Jonas Kåveby (21/May/14 7:11 AM) Status: Open In Progress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [description-setter] (JENKINS-23097) Set description during build as a build step
Jonas Kåveby created JENKINS-23097 Set description during build as a build step Issue Type: New Feature Affects Versions: current Assignee: huybrechts Components: description-setter Created: 19/May/14 4:36 PM Description: Allow the description of a build to be set as a normal build step. Setting the description early is useful if you have time consuming builds that can be split into several build steps. Project: Jenkins Priority: Minor Reporter: Jonas Kåveby This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
