[JIRA] [p4-plugin] (JENKINS-27068) P4 plugin logs out or invalidates role user login
Title: Message Title Matt Hauck edited a comment on JENKINS-27068 Re: P4 plugin logs out or invalidates role user login Per [ comment|https://issues.jenkins-ci.org/browse/JENKINS-27068?focusedCommentId=230855&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel #comment-230855] above, this change introduced a race condition.The p4 ticket may be valid at the very start of the build when it does this login check, but by the time it has gone through looking up the change history and is about to checkout the actual files, the ticket has expired. This happened more than one might guess for a build that we had setup to trigger every 12 hours, when our p4 tickets were also configured for 12 hours. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-27068) P4 plugin logs out or invalidates role user login
Title: Message Title Matt Hauck commented on JENKINS-27068 Re: P4 plugin logs out or invalidates role user login Per comment-230855 above, this change introduced a race condition. The p4 ticket may be valid at the very start of the build when it does this login check, but by the time it has gone through looking up the change history and is about to checkout the actual files, the ticket has expired. This happened more than one might guess for a build that we had setup to trigger every 12 hours, when our p4 tickets were also configured for 12 hours. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-27068) P4 plugin logs out or invalidates role user login
Title: Message Title Matt Hauck commented on JENKINS-27068 Re: P4 plugin logs out or invalidates role user login So... could we get the original change submitted for this reverted so that it could go back to the older functionality? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-27068) P4 plugin logs out or invalidates role user login
Title: Message Title Matt Hauck commented on JENKINS-27068 Re: P4 plugin logs out or invalidates role user login Just ran into this today – it is actually now causing issues for us! =( We have a P4 ticket expiration of 12 hours, and builds that kick off on a 6 hour interval when changes were made. Every once in awhile, when a build happens only on the 12-hour interval and is timed exactly right, the initial "am I connected?" part passes because the ticket is still valid, but then the ticket expires after the "p4 reconcile" operation (24 seconds), such that the "p4 sync" fails with invalid login. It is really quite amazing that we have run into this a few times already, since it has to be timed exactly right. The ticket has to have only a few seconds of life yet at the start of the build. For now, we'll probably modify our p4 ticket lifetime to be something like 11 or 13 hours instead. But this solution seems unideal. It would be great if the p4 plugin would just always login, since then we wouldn't have to worry about the lifetime of the ticket. Another more advanced option would be to have the `CheckoutTask.invoke()` catch the exception and retry (perhaps only once?) after re-logging in. As for the issue this change was meant to address, it seems to me they should be using a ticket file instead of a password credential, since they are managing the login ticket externally. I do not think this is the standard use case for people using the perforce password credential. I expect the login to just always work since I gave it the password. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-28760) P4 Plugin does not respect line endings for template workspaces
Title: Message Title Matt Hauck commented on JENKINS-28760 Re: P4 Plugin does not respect line endings for template workspaces If you merge in this change, would it be possible to cut a new release with this fix in? It'd be much appreciated. =) Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-28760) P4 Plugin does not respect line endings for template workspaces
Title: Message Title Matt Hauck commented on JENKINS-28760 Re: P4 Plugin does not respect line endings for template workspaces Pull request: https://github.com/jenkinsci/p4-plugin/pull/15 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-28760) P4 Plugin does not respect line endings for template workspaces
Title: Message Title Matt Hauck created an issue Jenkins / JENKINS-28760 P4 Plugin does not respect line endings for template workspaces Issue Type: Bug Assignee: Unassigned Components: p4-plugin Created: 05/Jun/15 3:59 AM Priority: Minor Reporter: Matt Hauck We use the P4 plugin in "template" mode, and we have all our workspaces always set to "Unix" line endings. The templates all have this line ending properly set. When the p4 plugin creates a workspace for a particular job, the created workspace always ends up with line ending setting of "Local". This ends up working fine for the Linux builds, of course, but the Windows builds always fail the first time, leading us to need to manually modify the line endings setting once in P4V for each newly created windows workspace. This may be related to JENKINS-27250, but I think it is a different issue Add Comment
[JIRA] [p4-plugin] (JENKINS-28726) Default matrix execution strategy produces NPE in latest p4 plugin
Title: Message Title Matt Hauck updated an issue Jenkins / JENKINS-28726 Default matrix execution strategy produces NPE in latest p4 plugin Change By: Matt Hauck I recently upgraded to the latest P4 Plugin version (1.2.3), and it started erroring out with a null pointer exception whenever a matrix build would attempt to run. The essence of the problem is PerforceScm#getMatrixOptions (PerforceScm..java, line 330). This function returns null if the execution strategy is not an instance of MatrixOptions. The only thing this appears to be used for is to figure out the "buildParent" configuration option. It seems to me better in this scenario to assume buildParent is meant to be false if it is not explicitly turned on, and if the " Class Classic " execution strategy is used instead. If instead you want to absolutely require people use the perforce execution strategy, then you should document this in an obvious place (like your README?). It was not immediately obvious to us how to fix this. Even better: there should be some kind of validation / warning somewhere in the UI if you don't have "Perforce: Matrix options" set. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-28726) Default matrix execution strategy produces NPE in latest p4 plugin
Title: Message Title Matt Hauck commented on JENKINS-28726 Re: Default matrix execution strategy produces NPE in latest p4 plugin Created pull request: https://github.com/jenkinsci/p4-plugin/pull/13 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-28726) Default matrix execution strategy produces NPE in latest p4 plugin
Title: Message Title Matt Hauck created an issue Jenkins / JENKINS-28726 Default matrix execution strategy produces NPE in latest p4 plugin Issue Type: Bug Assignee: Unassigned Components: p4-plugin Created: 03/Jun/15 4:41 PM Environment: P4 Plugin 1.2.3 Jenkins 1.609.1 Labels: scm Priority: Minor Reporter: Matt Hauck I recently upgraded to the latest P4 Plugin version (1.2.3), and it started erroring out with a null pointer exception whenever a matrix build would attempt to run. The essence of the problem is PerforceScm#getMatrixOptions (PerforceScm..java, line 330). This function returns null if the execution strategy is not an instance of MatrixOptions. The only thing this appears to be used for is to figure out the "buildParent" configuration option. It seems to me better in this scenario to assume buildParent is meant to be false if it is not explicitly turned on, and if the "Class" execution strategy is used instead.
[JIRA] (JENKINS-15572) Should be able to customize command line executable per slave node
Matt Hauck created JENKINS-15572 Should be able to customize command line executable per slave node Issue Type: New Feature Assignee: Deluan Quintão Components: rtc Created: 18/Oct/12 4:24 PM Description: My jenkins master is running on linux, and I have both mac as well as windows slave nodes. There is a "Tool locations" section that git / perforce and other tools allow customizing the location per-node, and this would be nice for RTC as well. Currently, I am pretty much stuck using "scm" instead of "lscm" since it is the one common name that can be recognized across all three platforms. It would be nice to use the more efficient lscm though. Project: Jenkins Priority: Major Reporter: Matt Hauck This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
