[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
kutzi commented on JENKINS-12046 TestNG shouldn't look for result files if build was aborted Thanks! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
nalin_makar resolved JENKINS-12046 as Fixed TestNG shouldn't look for result files if build was aborted Change By: nalin_makar (05/Jan/13 11:57 PM) Status: Reopened Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
SCM/JIRA link daemon commented on JENKINS-12046 TestNG shouldn't look for result files if build was aborted Code changed in jenkins User: Nalin Makar Path: README pom.xml src/main/java/hudson/plugins/testng/Publisher.java src/test/java/hudson/plugins/testng/PublisherTest.java http://jenkins-ci.org/commit/testng-plugin-plugin/fa2df404a99ef2fd27ca48ef2fb3bac5337f539c Log: Fixed: JENKINS-12046 - TestNG shouldn't look for result files if build was aborted (again!) Also added a test for this. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
nalin_makar commented on JENKINS-12046 TestNG shouldn't look for result files if build was aborted Kutzi, I'll make the change to not look for results in case build is aborted. And, continue looking for reports in case of build failures. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
kutzi commented on JENKINS-12046 TestNG shouldn't look for result files if build was aborted Could you please reconsider this issue? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
kutzi reopened JENKINS-12046 TestNG shouldn't look for result files if build was aborted Reopening, as I still think my last comment stays. IMO there's a clear difference between aborted and failed builds and I can see no value in parsing test results for aborted builds. Change By: kutzi (04/Sep/12 6:46 AM) Resolution: Won't Fix Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
[ https://issues.jenkins-ci.org/browse/JENKINS-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159103#comment-159103 ] kutzi commented on JENKINS-12046: - I agree that the plugin should look for results if a build is a failure (not looking for them in that case was btw never requested in this issue) I don't agree with looking for results in case of aborted builds. In the worst case an aborted build could leave broken, invalid result files which could let the reporter crash. Even in the best case that all results are written already, I don't see any good reason to parse them when the build is already aborted, as: a) it takes unnecessary time (often I abort build, becuase I want the next build for theat job to start immediately) b) the results are of no real value as the user doesn't know how many of all test have already been running. So deltas are of no value Also, other reporters seem to do the same (can not speak for all obviously). See e.g. above in the log string: "17:48:11 [WARNINGS] Skipping publisher since build result is ABORTED" > TestNG shouldn't look for result files if build was aborted > --- > > Key: JENKINS-12046 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12046 > Project: Jenkins > Issue Type: Improvement > Components: testng >Reporter: kutzi >Assignee: nalin_makar >Priority: Minor > > When the build was aborted the plugin still seems to scan the workspace for > TestNG result files. > This is only a minor issue, but could save some time. See build log below > where we could have spared 50 seconds by this. > 17:48:11 Build was aborted > 17:48:11 [WARNINGS] Skipping publisher since build result is ABORTED > 17:48:11 Archiving artifacts > 17:48:11 ERROR: Ignore Problem expanding maven opts macros > org.jenkinsci.plugins.tokenmacro.TokenMacro > 17:48:11 Checking console output > 17:48:11 Looking for TestNG results report in workspace using pattern: > **/target/surefire-reports/**/testng-results.xml > 17:49:08 [ci-game] evaluating rule: Build result > 17:49:08 [ci-game] evaluating rule: Increased number of failed tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
[ https://issues.jenkins-ci.org/browse/JENKINS-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159074#comment-159074 ] SCM/JIRA link daemon commented on JENKINS-12046: Code changed in jenkins User: Nalin Makar Path: README src/main/java/hudson/plugins/testng/Publisher.java http://jenkins-ci.org/commit/testng-plugin-plugin/523dfea36f91a1425d1f377101e9207d02a48afc Log: Fixed: JENKINS-12648 - Results should be reported for failed/aborted builds as well (Reverted fix for JENKINS-12046 in v0.30) > TestNG shouldn't look for result files if build was aborted > --- > > Key: JENKINS-12046 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12046 > Project: Jenkins > Issue Type: Improvement > Components: testng >Reporter: kutzi >Assignee: nalin_makar >Priority: Minor > > When the build was aborted the plugin still seems to scan the workspace for > TestNG result files. > This is only a minor issue, but could save some time. See build log below > where we could have spared 50 seconds by this. > 17:48:11 Build was aborted > 17:48:11 [WARNINGS] Skipping publisher since build result is ABORTED > 17:48:11 Archiving artifacts > 17:48:11 ERROR: Ignore Problem expanding maven opts macros > org.jenkinsci.plugins.tokenmacro.TokenMacro > 17:48:11 Checking console output > 17:48:11 Looking for TestNG results report in workspace using pattern: > **/target/surefire-reports/**/testng-results.xml > 17:49:08 [ci-game] evaluating rule: Build result > 17:49:08 [ci-game] evaluating rule: Increased number of failed tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
[ https://issues.jenkins-ci.org/browse/JENKINS-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nalin_makar reopened JENKINS-12046: --- This seems like incorrect behavior. See JENKINS-12648. > TestNG shouldn't look for result files if build was aborted > --- > > Key: JENKINS-12046 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12046 > Project: Jenkins > Issue Type: Improvement > Components: testng >Reporter: kutzi >Assignee: nalin_makar >Priority: Minor > > When the build was aborted the plugin still seems to scan the workspace for > TestNG result files. > This is only a minor issue, but could save some time. See build log below > where we could have spared 50 seconds by this. > 17:48:11 Build was aborted > 17:48:11 [WARNINGS] Skipping publisher since build result is ABORTED > 17:48:11 Archiving artifacts > 17:48:11 ERROR: Ignore Problem expanding maven opts macros > org.jenkinsci.plugins.tokenmacro.TokenMacro > 17:48:11 Checking console output > 17:48:11 Looking for TestNG results report in workspace using pattern: > **/target/surefire-reports/**/testng-results.xml > 17:49:08 [ci-game] evaluating rule: Build result > 17:49:08 [ci-game] evaluating rule: Increased number of failed tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12046) TestNG shouldn't look for result files if build was aborted
[ https://issues.jenkins-ci.org/browse/JENKINS-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nalin_makar resolved JENKINS-12046. --- Resolution: Won't Fix Reverting change made for this fix. will be reverted in v0.32 > TestNG shouldn't look for result files if build was aborted > --- > > Key: JENKINS-12046 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12046 > Project: Jenkins > Issue Type: Improvement > Components: testng >Reporter: kutzi >Assignee: nalin_makar >Priority: Minor > > When the build was aborted the plugin still seems to scan the workspace for > TestNG result files. > This is only a minor issue, but could save some time. See build log below > where we could have spared 50 seconds by this. > 17:48:11 Build was aborted > 17:48:11 [WARNINGS] Skipping publisher since build result is ABORTED > 17:48:11 Archiving artifacts > 17:48:11 ERROR: Ignore Problem expanding maven opts macros > org.jenkinsci.plugins.tokenmacro.TokenMacro > 17:48:11 Checking console output > 17:48:11 Looking for TestNG results report in workspace using pattern: > **/target/surefire-reports/**/testng-results.xml > 17:49:08 [ci-game] evaluating rule: Build result > 17:49:08 [ci-game] evaluating rule: Increased number of failed tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
