[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/83ea9d9dca44939418c9f4a8c83598c6a88f1035 Log: FilePath.toComputer no worse than what we already are doing in onCheckout, though JENKINS-26096 suggests improvements. Originally-Committed-As: 5b778564c2f52397592e7c6ca5e5db2bf0452294 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: durable-task-step/pom.xml http://jenkins-ci.org/commit/pipeline-stage-step-plugin/f005fb1f24d43c698eecbbb8e2e1e9d848c9f561 Log: Also moved ComputerPickle and FilePathPickle to workflow-durable-task-step, introducing FilePathUtils pending JENKINS-26096. Originally-Committed-As: 712d524bf0942c0d7068c829a3a9ca45b7dae329 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: durable-task-step/pom.xml http://jenkins-ci.org/commit/pipeline-input-step-plugin/2ce10ceb18e1eb6365c4a364d44947feb43a34bd Log: Also moved ComputerPickle and FilePathPickle to workflow-durable-task-step, introducing FilePathUtils pending JENKINS-26096. Originally-Committed-As: 712d524bf0942c0d7068c829a3a9ca45b7dae329 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: durable-task-step/pom.xml http://jenkins-ci.org/commit/pipeline-build-step-plugin/a801b1b61a479b06b9ca9340489985e0970e2ce9 Log: Also moved ComputerPickle and FilePathPickle to workflow-durable-task-step, introducing FilePathUtils pending JENKINS-26096. Originally-Committed-As: 712d524bf0942c0d7068c829a3a9ca45b7dae329 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: support/pom.xml support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/WorkspaceActionImpl.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/ComputerPickle.java http://jenkins-ci.org/commit/workflow-support-plugin/deda00ac9134cc15736e549584eb6539b49d2d09 Log: Also moved ComputerPickle and FilePathPickle to workflow-durable-task-step, introducing FilePathUtils pending JENKINS-26096. Originally-Committed-As: 712d524bf0942c0d7068c829a3a9ca45b7dae329 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: api/src/main/java/org/jenkinsci/plugins/workflow/FilePathUtils.java api/src/main/java/org/jenkinsci/plugins/workflow/actions/WorkspaceAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/FilePathPickle.java http://jenkins-ci.org/commit/workflow-api-plugin/7ab85dedc993073147778cf7ab78a28b4c486784 Log: Also moved ComputerPickle and FilePathPickle to workflow-durable-task-step, introducing FilePathUtils pending JENKINS-26096. Originally-Committed-As: 712d524bf0942c0d7068c829a3a9ca45b7dae329 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/FilePathPickle.java http://jenkins-ci.org/commit/workflow-api-plugin/f738816f27ac5e2e6ebf425088eeb90f977ed78f Log: Noting JENKINS-26096. Originally-Committed-As: 775a42bb6c69501114ca38a744edad63a0ce9e06 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26096 Re: Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: api/src/main/java/org/jenkinsci/plugins/workflow/FilePathUtils.java api/src/main/java/org/jenkinsci/plugins/workflow/actions/WorkspaceAction.java durable-task-step/pom.xml durable-task-step/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/ComputerPickle.java durable-task-step/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/FilePathPickle.java durable-task-step/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/WorkspaceListLeasePickle.java support/pom.xml support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/WorkspaceActionImpl.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/ComputerPickle.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/FilePathPickle.java http://jenkins-ci.org/commit/workflow-plugin/712d524bf0942c0d7068c829a3a9ca45b7dae329 Log: Also moved ComputerPickle and FilePathPickle to workflow-durable-task-step, introducing FilePathUtils pending JENKINS-26096. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
SCM/JIRA link daemon commented on JENKINS-26096 Fixed FilePath.toComputer Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/5b778564c2f52397592e7c6ca5e5db2bf0452294 Log: FilePath.toComputer no worse than what we already are doing in onCheckout, though JENKINS-26096 suggests improvements. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Daniel Beck commented on JENKINS-26096 Fixed FilePath.toComputer The "fixed" version will be unable to handle admins disconnecting nodes and shuffling names around. This should then at least be documented somewhere. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Jesse Glick commented on JENKINS-26096 Fixed FilePath.toComputer Specifically: if a slave is connected and a FilePath is created on it, but then the slave is later disconnected and reconnected and someone calls toComputer on that cached path, you will get a null return value, because the old Channel is not the same as the new Channel (it is a live connection, like a java.net.Socket etc.). By comparison, FilePathPickle records the slave name permanently in channelNames even after a disconnection, so we can always figure out which slave a FilePath came from, no matter what happened to the connection subsequently. In the existing uses from Workflow, we actually do not care if the slave is disconnected now (we just want to know the node name), so FilePath.toComputer would not actually be useful at all: there is no Computer once a slave is disconnected and all its executors stop. Thus we would really want to have a more primitive method that returns a String for the node name (null if unknown for some reason, for example because the FilePath was created using some other exotic VirtualChannel); and toComputer would call that method and just look for a computer with that name. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-26096) Fixed FilePath.toComputer
Jesse Glick created JENKINS-26096 Fixed FilePath.toComputer Issue Type: Bug Assignee: Unassigned Components: core Created: 16/Dec/14 11:40 PM Description: As noted in FilePathPickle, the current version does not work if the slave has since been disconnected. It needs to be rewritten to use a listener. Project: Jenkins Labels: api workflow Priority: Major Reporter: Jesse Glick This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
