[JIRA] [extensible-choice-parameter] (JENKINS-22222) Extend name pattern to use dots too
ikedam
commented on JENKINS-2
Extend name pattern to use dots too
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/Util.java#L116
/**
* Pattern for capturing variables. Either $xyz, ${xyz} or ${a.b} but not $a.b, while ignoring "$$"
*/
private static final Pattern VARIABLE = Pattern.compile("\\$([A-Za-z0-9_]+|\\{[A-Za-z0-9_.]+\\}|\\$)");
This seems available from jenkins-1.526 (JENKINS-16660). Dots are not accepted before.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [extensible-choice-parameter] (JENKINS-22222) Extend name pattern to use dots too
ikedam commented on JENKINS-2 Extend name pattern to use dots too I'm not sure now. I know I can take one of follewing ways: Not check names at all. Check, but dispay only as a warning. (as your suggest) Check and display as a error. But never forbid it actually (as current implemantation). Let me have time to consider which is the best way. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [extensible-choice-parameter] (JENKINS-22222) Extend name pattern to use dots too
Sven Appenrodt commented on JENKINS-2 Extend name pattern to use dots too Thanks for asking. I assume there is no guideline but asking doesn't cost anything than a little time In that case - can we make a compromise that you continue checking the names but display the result (if any) as warning? Maybe many users will missinterpret your "error", but a warning like "use bash like names [a-zA-Z_-], there might be problems with using this parameter in actions" or something like this might be better. It's just to warn the user using that kind of name, not to forbid it. Thanks a lot This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [extensible-choice-parameter] (JENKINS-22222) Extend name pattern to use dots too
ikedam commented on JENKINS-2 Extend name pattern to use dots too It depends on how to use it. If used in shell or windows batch, it would does not work correct. Current parameter name check is performed under the rule of bash (alphabets, numbers, underscore). Though I haven't tested yet, it would work correct in almost other cases even the configuration page displays an error. Groovy scripts would also work well as they access build variables as a map object. I'll ask Jenkins developers whether there is a guideline about parameter names, and consider what's the best way. For now, I think followings are good for your case. Test parameters with dots work correct in your environments. Error messages in configuration pages are just informational, and Extensible Choice Parameter does not kick those values even in future releases. But I cannot ensure Jenkins itself accepts any values even in future reases... I still recommend you to use bash-like parameter names if you can easily adapt it. There may be a day you want to access those values from bash scripts or windows batches. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [extensible-choice-parameter] (JENKINS-22222) Extend name pattern to use dots too
Sven Appenrodt commented on JENKINS-2 Extend name pattern to use dots too Hint: getting triggerd by the parameterized trigger plugin whith having a choice "foo.bar" works, only the validation check for this field fails. Didn't tested accessing the choice via e.g. groovy... This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [extensible-choice-parameter] (JENKINS-22222) Extend name pattern to use dots too
Sven Appenrodt created JENKINS-2 Extend name pattern to use dots too Issue Type: Task Affects Versions: current Assignee: Unassigned Components: extensible-choice-parameter Created: 17/Mar/14 1:09 PM Description: After the parameterized trigger plugin wants to exchange all choices to extensible choices we have to change many properties in our jobs. But that's OK. Problem: Because of many of our properties containing dots we have to overwork half of our build process. Suggestion: Please check if the name of a property can contain . too. Environment: rely on https://wiki.jenkins-ci.org/display/JENKINS/Parameterized+Trigger+Plugin#ParameterizedTriggerPlugin-Backwardcompatibilitywithversion2.22 Project: Jenkins Priority: Minor Reporter: Sven Appenrodt This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
