[kwin] [Bug 488840] Glide effect is distorted

2024-06-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=488840

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||6.1.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-21 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=488840

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/-/commit/7eb9f75af2 |ma/kwin/-/commit/24c9ed3bde
   |2c4aeeb58e864772912ec060f79 |8a7830e43a2527d05e9099e5e13
   |826 |8bd

--- Comment #7 from Vlad Zahorodnii  ---
Git commit 24c9ed3bde8a7830e43a2527d05e9099e5e138bd by Vlad Zahorodnii.
Committed on 21/06/2024 at 13:05.
Pushed by vladz into branch 'Plasma/6.1'.

plugins/glide: Subdivide window quad grid

The way the glide effect works is that it takes 2D geometry and applies
the perspective projection to it on the CPU side. The reason we do it is
that the scene is 2D.

However, this leaves us with the well known problem where a texture
that's mapped to a trapezoid won't be correctly interpolated along the
diagonal.

It can addressed by performing a perspective division in the fragment
shader, but given the way the effect is structured, it's off the table. So
instead subdivide the window grid.


(cherry picked from commit 7eb9f75af22c4aeeb58e864772912ec060f79826)

Co-authored-by: Vlad Zahorodnii 

M  +1-0src/plugins/glide/glide.cpp

https://invent.kde.org/plasma/kwin/-/commit/24c9ed3bde8a7830e43a2527d05e9099e5e138bd

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-21 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=488840

Vlad Zahorodnii  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/-/commit/7eb9f75af2
   ||2c4aeeb58e864772912ec060f79
   ||826

--- Comment #6 from Vlad Zahorodnii  ---
Git commit 7eb9f75af22c4aeeb58e864772912ec060f79826 by Vlad Zahorodnii.
Committed on 21/06/2024 at 12:46.
Pushed by vladz into branch 'master'.

plugins/glide: Subdivide window quad grid

The way the glide effect works is that it takes 2D geometry and applies
the perspective projection to it on the CPU side. The reason we do it is
that the scene is 2D.

However, this leaves us with the well known problem where a texture
that's mapped to a trapezoid won't be correctly interpolated along the
diagonal.

It can addressed by performing a perspective division in the fragment
shader, but given the way the effect is structured, it's off the table. So
instead subdivide the window grid.

M  +1-0src/plugins/glide/glide.cpp

https://invent.kde.org/plasma/kwin/-/commit/7eb9f75af22c4aeeb58e864772912ec060f79826

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-20 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=488840

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|NEEDSINFO   |ASSIGNED
 Resolution|WAITINGFORINFO  |---

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/5956

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-20 Thread Hesam Gholami
https://bugs.kde.org/show_bug.cgi?id=488840

--- Comment #4 from Hesam Gholami  ---
I've added a new attachment in which you can see the same effect with the same
settings works correctly (without any distortion at bottom center) in KDE
Plasma 6.0.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-20 Thread Hesam Gholami
https://bugs.kde.org/show_bug.cgi?id=488840

--- Comment #3 from Hesam Gholami  ---
Created attachment 170717
  --> https://bugs.kde.org/attachment.cgi?id=170717&action=edit
Glide effect working correctly on Plasma 6.0.4

This preview is for KDE Plasma 6.0.4 where the Glide effect works correctly
without any distortion at bottom center section

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-20 Thread Hesam Gholami
https://bugs.kde.org/show_bug.cgi?id=488840

--- Comment #2 from Hesam Gholami  ---
(In reply to Nate Graham from comment #1)
> It looks like you've changed the settings of this effect. Does the issue go
> away if you restore them to their default values?

No. If I restore default settings, the issue will remain the same. But because
it happens fast, it's hard to see. So I've changed settings to demonstrate the
issue better.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=488840

Nate Graham  changed:

   What|Removed |Added

   Keywords||regression
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
It looks like you've changed the settings of this effect. Does the issue go
away if you restore them to their default values?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 488840] Glide effect is distorted

2024-06-20 Thread cwo
https://bugs.kde.org/show_bug.cgi?id=488840

cwo  changed:

   What|Removed |Added

   Assignee|plasma-b...@kde.org |kwin-bugs-n...@kde.org
  Component|general |effects-various
Product|plasmashell |kwin
   Target Milestone|1.0 |---
 CC||spikespie...@gmx.de

-- 
You are receiving this mail because:
You are watching all bug changes.