Using kqmlgraphplugin in Plasma Next
To people from kde-core-devel: please keep me and plasma-devel in CC, I am not subscribed to list Hello, Currently I am working on a QML Canvas based SignalPlotter, to replace the old Plasma1SignalPlotter which is KSignalPlotter and QGraphicWidget based. My SignalPlotter is in bshah/plotter-qml branch of plasma-framework (src/declarativeimports/plasmaextracomponents/SignalPlotter.qml) Meanwhile I was notified by apol that something like this already exist, which is QML, So basically my plan is to port kqmlgraphplugin to KDE Frameworks 5 and use it to plot data in Plasma Next. I am interested in porting it to KDE Frameworks 5. Is someone already working on that? If yes can I help with that? Otherwise I will start to port it. :) Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode
Re: Review Request 115408: Right align mime icon in kpropertiesdialog
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > position as the icon of the icon button. > I tried both, but I find right aligned prettier and more logical > considering the text under it. > > Thomas Lübking wrote: > Either. Reason is that due to the "arbitrary" shape (shadow, padding), > rightaligning the icon/button does not really line up with the text - thus > looks buggy (failed approach) > > Otoh, left alingning looks unbalanced mostly due to the vertical tab > border (ie. it's less an issue in eg. bespin, which has no vertical tabborder) > > kdeuser56 kdeuser56 wrote: > I am not sure I understand your point. Could explain me the "arbitrary" > shape problem? > I do not think the visual problem is caused by the vertical tab border. > Even if I remove that, it still looks bad and the bigger the font gets, the > uglier it looks. (Some words are longer in other languages, so this could > also be triggered by different language settings). > So in my opinion it looks bad, regardless of the theme. > Do you have another idea? > > > kdeuser56 kdeuser56 wrote: > I would be okay with centering the iconlabel. Centering the widget too > would be still better than left aligning, but I would prefer to keep it > right. > Should I change the diff to center the iconlabel, or should I provide > screenshots first? > > Thomas Lübking wrote: > > Could explain me the "arbitrary" shape problem? > The icons do not have a defined border as the text. They'll visually end > some pixels before the logical end (would even get worse for icons that do > not contain a sheet, but even that is visually 2px off) > > "Ugly" is subjective. > Fact is, that the vertical border creates a distinct border that the left > aligned version is closer to than to the implicit right border, thus it's > unbalanced (left overweight) > If you remove that border, the label visually moves more to the center > between window frame and implicit right border (the lineedit), what implies > local symmetry, thus stability. (Actually, you might even get a golden mean > positioning) > Granted: for long texts and huge fonts the part left of the tab certainly > becomes neglectable and that effect is lost. > -> I'd simply center align the icon. I'd suggest to have screenshots and wait for some more opinions then. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > --- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > --- > > Compiled and installed. Works as expected. > > > File Attachments > > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
Re: Review Request 115408: Right align mime icon in kpropertiesdialog
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > position as the icon of the icon button. > I tried both, but I find right aligned prettier and more logical > considering the text under it. > > Thomas Lübking wrote: > Either. Reason is that due to the "arbitrary" shape (shadow, padding), > rightaligning the icon/button does not really line up with the text - thus > looks buggy (failed approach) > > Otoh, left alingning looks unbalanced mostly due to the vertical tab > border (ie. it's less an issue in eg. bespin, which has no vertical tabborder) > > kdeuser56 kdeuser56 wrote: > I am not sure I understand your point. Could explain me the "arbitrary" > shape problem? > I do not think the visual problem is caused by the vertical tab border. > Even if I remove that, it still looks bad and the bigger the font gets, the > uglier it looks. (Some words are longer in other languages, so this could > also be triggered by different language settings). > So in my opinion it looks bad, regardless of the theme. > Do you have another idea? > > > kdeuser56 kdeuser56 wrote: > I would be okay with centering the iconlabel. Centering the widget too > would be still better than left aligning, but I would prefer to keep it > right. > Should I change the diff to center the iconlabel, or should I provide > screenshots first? > Could explain me the "arbitrary" shape problem? The icons do not have a defined border as the text. They'll visually end some pixels before the logical end (would even get worse for icons that do not contain a sheet, but even that is visually 2px off) "Ugly" is subjective. Fact is, that the vertical border creates a distinct border that the left aligned version is closer to than to the implicit right border, thus it's unbalanced (left overweight) If you remove that border, the label visually moves more to the center between window frame and implicit right border (the lineedit), what implies local symmetry, thus stability. (Actually, you might even get a golden mean positioning) Granted: for long texts and huge fonts the part left of the tab certainly becomes neglectable and that effect is lost. -> I'd simply center align the icon. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > --- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > --- > > Compiled and installed. Works as expected. > > > File Attachments > > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
Re: Review Request 115408: Right align mime icon in kpropertiesdialog
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > position as the icon of the icon button. > I tried both, but I find right aligned prettier and more logical > considering the text under it. > > Thomas Lübking wrote: > Either. Reason is that due to the "arbitrary" shape (shadow, padding), > rightaligning the icon/button does not really line up with the text - thus > looks buggy (failed approach) > > Otoh, left alingning looks unbalanced mostly due to the vertical tab > border (ie. it's less an issue in eg. bespin, which has no vertical tabborder) > > kdeuser56 kdeuser56 wrote: > I am not sure I understand your point. Could explain me the "arbitrary" > shape problem? > I do not think the visual problem is caused by the vertical tab border. > Even if I remove that, it still looks bad and the bigger the font gets, the > uglier it looks. (Some words are longer in other languages, so this could > also be triggered by different language settings). > So in my opinion it looks bad, regardless of the theme. > Do you have another idea? > I would be okay with centering the iconlabel. Centering the widget too would be still better than left aligning, but I would prefer to keep it right. Should I change the diff to center the iconlabel, or should I provide screenshots first? - kdeuser56 --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > --- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > --- > > Compiled and installed. Works as expected. > > > File Attachments > > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
Re: Review Request 115408: Right align mime icon in kpropertiesdialog
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > position as the icon of the icon button. > I tried both, but I find right aligned prettier and more logical > considering the text under it. > > Thomas Lübking wrote: > Either. Reason is that due to the "arbitrary" shape (shadow, padding), > rightaligning the icon/button does not really line up with the text - thus > looks buggy (failed approach) > > Otoh, left alingning looks unbalanced mostly due to the vertical tab > border (ie. it's less an issue in eg. bespin, which has no vertical tabborder) I am not sure I understand your point. Could explain me the "arbitrary" shape problem? I do not think the visual problem is caused by the vertical tab border. Even if I remove that, it still looks bad and the bigger the font gets, the uglier it looks. (Some words are longer in other languages, so this could also be triggered by different language settings). So in my opinion it looks bad, regardless of the theme. Do you have another idea? - kdeuser56 --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > --- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > --- > > Compiled and installed. Works as expected. > > > File Attachments > > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
Re: Review Request 115408: Right align mime icon in kpropertiesdialog
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > position as the icon of the icon button. > I tried both, but I find right aligned prettier and more logical > considering the text under it. Either. Reason is that due to the "arbitrary" shape (shadow, padding), rightaligning the icon/button does not really line up with the text - thus looks buggy (failed approach) Otoh, left alingning looks unbalanced mostly due to the vertical tab border (ie. it's less an issue in eg. bespin, which has no vertical tabborder) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > --- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > --- > > Compiled and installed. Works as expected. > > > File Attachments > > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
Re: Review Request 115408: Right align mime icon in kpropertiesdialog
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as the icon of the icon button. I tried both, but I find right aligned prettier and more logical considering the text under it. - kdeuser56 --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > --- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > --- > > Compiled and installed. Works as expected. > > > File Attachments > > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
Re: Review Request 115408: Right align mime icon in kpropertiesdialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- tried to center align it? - Thomas Lübking On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > --- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > --- > > Compiled and installed. Works as expected. > > > File Attachments > > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
Review Request 115408: Right align mime icon in kpropertiesdialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- Review request for kdelibs. Repository: kdelibs Description --- The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned. In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned. Especially with bigger font sizes, the visual issue becomes obvious. Idea: see kproperties-dolphin-1.png Before: see before-1.png and before-2.png After: see after-1.png and after-2.png Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w Diffs - kio/kfile/kpropertiesdialog.cpp 6611ee7 Diff: https://git.reviewboard.kde.org/r/115408/diff/ Testing --- Compiled and installed. Works as expected. File Attachments idea https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png before1 https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png before2 https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png after1 https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png after2 https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png Thanks, kdeuser56 kdeuser56
Re: kqmlgraphplugin -- a QML plugin to render beautiful and interactive graphs
Hi, > > So maybe "KDE QtQuick Charts" as the official name and "kdeqtquickcharts" > > for the repository? > > kqtquickcharts? That's better. More concise. So be it. Best regards, Sebastian
Re: kqmlgraphplugin -- a QML plugin to render beautiful and interactive graphs
Hi, > > Cool project, I really missed such a component a while back (I actually > wrote my own back then, which was less nice than yours). The code looks > sane too from a quick look, so I'm all for moving it to extragear (although > I'm not exactly an expert for sane code). Thanks! > > It doesn't seem to be designed for lots of data (since each point is an > object, etc.), which is understandable; but eventually it would be a nice > feature to add API designed towards such data in the future? The line chart isn't suited at all for big data sets right now. Not only it use multiple QML items per data point but the line connecting the data points is drawn into one huge buffer, even for the parts of the line clipped by the viewport. The bar chart behaves better. It is based on a ListView item, so only the items actually visible on screen (which is a fairly limited number) are created at a given time. I think API-wise both chart types are fine. There is no inherent problem with QTableModels for large data sets I know of. But the line chart definitely needs a more efficient implementation. This is one of the points I hope I can resolve when porting to Qt Quick 2. > > On Wednesday 29 January 2014 12:41:22 Inge Wallin wrote: > > Regarding 3D charts, I have no idea if this is even possible using QML > > alone or if you need to do something else for that. > > I assume you're talking about the "usual" 3D charts, such as 3D-looking pie > charts and bar graphs? For drawing those, I would not use any kind of 3D API > at all. Just drawing some rectangles and ellipses clipping each other will > be way easier for that purpose, which is very easy even with QtQuick 1. > (Apart from that, those 3D effects are bad for a chart's readability > anyways ;) This is no near-future stuff anyways. Best regards, Sebastian
Re: kqmlgraphplugin -- a QML plugin to render beautiful and interactive graphs
On Wednesday, January 29, 2014 22:53:59 Sven Brauch wrote: > Hi! > > Cool project, I really missed such a component a while back (I actually > wrote my own back then, which was less nice than yours). The code looks > sane too from a quick look, so I'm all for moving it to extragear (although > I'm not exactly an expert for sane code). > > It doesn't seem to be designed for lots of data (since each point is an > object, etc.), which is understandable; but eventually it would be a nice > feature to add API designed towards such data in the future? > > On Wednesday 29 January 2014 12:41:22 Inge Wallin wrote: > > Regarding 3D charts, I have no idea if this is even possible using QML > > alone or if you need to do something else for that. > > I assume you're talking about the "usual" 3D charts, such as 3D-looking pie > charts and bar graphs? For drawing those, I would not use any kind of 3D API > at all. Just drawing some rectangles and ellipses clipping each other will > be way easier for that purpose, which is very easy even with QtQuick 1. Those for sure, but not only. Also surface charts, which is more like what you would call a plot in some other programs. > (Apart from that, those 3D effects are bad for a chart's readability > anyways ;) I might even agree with you but we still need to support them. :) Except in some cases when you have a table of values that you need to visualize, then it's very difficult to do with 2D charts. -Inge > Greetings, > Sven
