Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Fantastic! Thanks very much Wayne

On 22 Nov 2017 01:17, "Wayne Stambaugh"  wrote:

> Yeah!!  I finally got this merged.  Thank you Oliver for your
> contribution to KiCad and for your patience.
>
> Cheers,
>
> Wayne
>
> On 11/21/2017 12:51 AM, Oliver Walters wrote:
> > Wayne,
> >
> > I have recreated the patch set once again, and there is no reference to
> > "printf" in any of these patch files.
> >
> > Please apply with the --ignore-whitepace flag, the file
> > /include/lib_table_grid.h is full of MS-DOS line endings and I believe
> > this is the cause.
> >
> > Patch set attached, hopefully works this time!
> >
> > Thanks,
> > Oliver
> >
> > On Tue, Nov 21, 2017 at 10:02 AM, Oliver Walters
> > mailto:oliver.henry.walt...@gmail.com>>
> > wrote:
> >
> > Wayne,
> >
> > Ok, apologies I thought I had addressed that (I haven't had a chance
> > to go back and look at these patches). I'll do so tonight.
> >
> > On Tue, Nov 21, 2017 at 10:00 AM, Wayne Stambaugh
> > mailto:stambau...@gmail.com>> wrote:
> >
> > I looked at patches 3-6 and I didn't see where the printf was
> > removed.
> >
> > On 11/20/2017 05:47 PM, Oliver Walters wrote:
> > > The printf() statement should be removed in one of the
> subsequent
> > > patches, as should the removal of that line. I'm unable to
> check this
> > > right now, are you able to confirm if one of the later patches
> fixes
> > > this problem?
> > >
> > > On Tue, Nov 21, 2017 at 9:44 AM, Wayne Stambaugh <
> stambau...@gmail.com 
> > > >>
> wrote:
> > >
> > > I made a change to fix a bug with the default plugin type
> when appending
> > > a new row to the table which caused the conflict.  This
> where I noticed
> > > the printf() debugging statement.  I also noticed that it
> appears that
> > > you removed a scroll to row call and I'm not sure how to
> reconcile the
> > > conflict.  Did you remove the scroll to row call on
> purpose or wasn't it
> > > necessary.  I don't want to break that behavior.
> > >
> > > On 11/20/2017 04:29 PM, Oliver Walters wrote:
> > > > Wayne,
> > > >
> > > > I think it is a whitespace issue, does it apply if you
> add
> > > > --ignore-whitespace to git-am ?
> > > >
> > > > On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh <
> stambau...@gmail.com 
> > >
> > > > 
> >  wrote:
> > > >
> > > > Oliver,
> > > >
> > > > No go yet again.  It looks like my commit 8b2b1381
> is causing a conflict
> > > > with patch 2 so please rebase your patches.  I also
> noticed a printf()
> > > > debugging statement in patch 2.  Please remove this
> and make sure there
> > > > are not any other printf() statements in your
> patches.  Sorry about
> > > > asking you to fix these issues but I really don't
> have the time to fix
> > > > patches right now.
> > > >
> > > > Cheers,
> > > >
> > > > Wayne
> > > >
> > > > On 11/20/2017 1:20 AM, Oliver Walters wrote:
> > > > > Wayne,
> > > > >
> > > > > I'm at a loss too. git am fails on 0002 but git
> apply works fine on each
> > > > > individual patch.
> > > > >
> > > > > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh <
> stambau...@gmail.com 
> > >
> > > 
> > >>
> > > > >  >   > >
> > > 
> > 
> > wrote:
> > > > >
> > > > > Oliver,
> > > > >
> > > > > Still no luck.  Did you possible do something
> > to mess up the
> > > > commit
> > > > > ordering?  I am applying these patches on top
> > a clean master
> > > > branch so
> > > > > I'm not sure what is going on here.  

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Yeah!!  I finally got this merged.  Thank you Oliver for your
contribution to KiCad and for your patience.

Cheers,

Wayne

On 11/21/2017 12:51 AM, Oliver Walters wrote:
> Wayne,
> 
> I have recreated the patch set once again, and there is no reference to
> "printf" in any of these patch files.
> 
> Please apply with the --ignore-whitepace flag, the file
> /include/lib_table_grid.h is full of MS-DOS line endings and I believe
> this is the cause.
> 
> Patch set attached, hopefully works this time!
> 
> Thanks,
> Oliver
> 
> On Tue, Nov 21, 2017 at 10:02 AM, Oliver Walters
> mailto:oliver.henry.walt...@gmail.com>>
> wrote:
> 
> Wayne,
> 
> Ok, apologies I thought I had addressed that (I haven't had a chance
> to go back and look at these patches). I'll do so tonight.
> 
> On Tue, Nov 21, 2017 at 10:00 AM, Wayne Stambaugh
> mailto:stambau...@gmail.com>> wrote:
> 
> I looked at patches 3-6 and I didn't see where the printf was
> removed.
> 
> On 11/20/2017 05:47 PM, Oliver Walters wrote:
> > The printf() statement should be removed in one of the subsequent
> > patches, as should the removal of that line. I'm unable to check 
> this
> > right now, are you able to confirm if one of the later patches fixes
> > this problem?
> >
> > On Tue, Nov 21, 2017 at 9:44 AM, Wayne Stambaugh 
> mailto:stambau...@gmail.com>
> > >> wrote:
> >
> >     I made a change to fix a bug with the default plugin type when 
> appending
> >     a new row to the table which caused the conflict.  This where I 
> noticed
> >     the printf() debugging statement.  I also noticed that it 
> appears that
> >     you removed a scroll to row call and I'm not sure how to 
> reconcile the
> >     conflict.  Did you remove the scroll to row call on purpose or 
> wasn't it
> >     necessary.  I don't want to break that behavior.
> >
> >     On 11/20/2017 04:29 PM, Oliver Walters wrote:
> >     > Wayne,
> >     >
> >     > I think it is a whitespace issue, does it apply if you add
> >     > --ignore-whitespace to git-am ?
> >     >
> >     > On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh 
> mailto:stambau...@gmail.com>
> >
> >     > 
>  >     >
> >     >     Oliver,
> >     >
> >     >     No go yet again.  It looks like my commit 8b2b1381 is 
> causing a conflict
> >     >     with patch 2 so please rebase your patches.  I also 
> noticed a printf()
> >     >     debugging statement in patch 2.  Please remove this and 
> make sure there
> >     >     are not any other printf() statements in your patches.  
> Sorry about
> >     >     asking you to fix these issues but I really don't have 
> the time to fix
> >     >     patches right now.
> >     >
> >     >     Cheers,
> >     >
> >     >     Wayne
> >     >
> >     >     On 11/20/2017 1:20 AM, Oliver Walters wrote:
> >     >     > Wayne,
> >     >     >
> >     >     > I'm at a loss too. git am fails on 0002 but git apply 
> works fine on each
> >     >     > individual patch.
> >     >     >
> >     >     > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh 
> mailto:stambau...@gmail.com>
> >
> >     
> >>
> >     >     >    >
> >     
> 
> wrote:
> >     >     >
> >     >     >     Oliver,
> >     >     >
> >     >     >     Still no luck.  Did you possible do something
> to mess up the
> >     >     commit
> >     >     >     ordering?  I am applying these patches on top
> a clean master
> >     >     branch so
> >     >     >     I'm not sure what is going on here.  I'm
> getting the
> >     following
> >     >     error
> >     >     >     from `git am` when I attempt to merge patch 2:
> >     >     >
> >     >     >     Applying: Toggle LIB_TABLE_ROW
> enabled/disabled in grid
> >     editor
> >     >     >     error: patch 

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Wayne,

I have recreated the patch set once again, and there is no reference to
"printf" in any of these patch files.

Please apply with the --ignore-whitepace flag, the file
/include/lib_table_grid.h is full of MS-DOS line endings and I believe this
is the cause.

Patch set attached, hopefully works this time!

Thanks,
Oliver

On Tue, Nov 21, 2017 at 10:02 AM, Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

> Wayne,
>
> Ok, apologies I thought I had addressed that (I haven't had a chance to go
> back and look at these patches). I'll do so tonight.
>
> On Tue, Nov 21, 2017 at 10:00 AM, Wayne Stambaugh 
> wrote:
>
>> I looked at patches 3-6 and I didn't see where the printf was removed.
>>
>> On 11/20/2017 05:47 PM, Oliver Walters wrote:
>> > The printf() statement should be removed in one of the subsequent
>> > patches, as should the removal of that line. I'm unable to check this
>> > right now, are you able to confirm if one of the later patches fixes
>> > this problem?
>> >
>> > On Tue, Nov 21, 2017 at 9:44 AM, Wayne Stambaugh > > > wrote:
>> >
>> > I made a change to fix a bug with the default plugin type when
>> appending
>> > a new row to the table which caused the conflict.  This where I
>> noticed
>> > the printf() debugging statement.  I also noticed that it appears
>> that
>> > you removed a scroll to row call and I'm not sure how to reconcile
>> the
>> > conflict.  Did you remove the scroll to row call on purpose or
>> wasn't it
>> > necessary.  I don't want to break that behavior.
>> >
>> > On 11/20/2017 04:29 PM, Oliver Walters wrote:
>> > > Wayne,
>> > >
>> > > I think it is a whitespace issue, does it apply if you add
>> > > --ignore-whitespace to git-am ?
>> > >
>> > > On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh <
>> stambau...@gmail.com 
>> > > >>
>> wrote:
>> > >
>> > > Oliver,
>> > >
>> > > No go yet again.  It looks like my commit 8b2b1381 is causing
>> a conflict
>> > > with patch 2 so please rebase your patches.  I also noticed a
>> printf()
>> > > debugging statement in patch 2.  Please remove this and make
>> sure there
>> > > are not any other printf() statements in your patches.  Sorry
>> about
>> > > asking you to fix these issues but I really don't have the
>> time to fix
>> > > patches right now.
>> > >
>> > > Cheers,
>> > >
>> > > Wayne
>> > >
>> > > On 11/20/2017 1:20 AM, Oliver Walters wrote:
>> > > > Wayne,
>> > > >
>> > > > I'm at a loss too. git am fails on 0002 but git apply works
>> fine on each
>> > > > individual patch.
>> > > >
>> > > > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh <
>> stambau...@gmail.com 
>> > >
>> > > > 
>> > > wrote:
>> > > >
>> > > > Oliver,
>> > > >
>> > > > Still no luck.  Did you possible do something to mess
>> up the
>> > > commit
>> > > > ordering?  I am applying these patches on top a clean
>> master
>> > > branch so
>> > > > I'm not sure what is going on here.  I'm getting the
>> > following
>> > > error
>> > > > from `git am` when I attempt to merge patch 2:
>> > > >
>> > > > Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid
>> > editor
>> > > > error: patch failed:
>> > eeschema/dialogs/dialog_sym_lib_table.cpp:350
>> > > > error: eeschema/dialogs/dialog_sym_lib_table.cpp:
>> patch does
>> > > not apply
>> > > > error: patch failed: include/lib_table_grid.h:32
>> > > > error: include/lib_table_grid.h: patch does not apply
>> > > > Patch failed at 0001 Toggle LIB_TABLE_ROW
>> > enabled/disabled in grid
>> > > > editor
>> > > > The copy of the patch that failed is found in:
>> > > .git/rebase-apply/patch
>> > > > When you have resolved this problem, run "git am
>> > --continue".
>> > > > If you prefer to skip this patch, run "git am --skip"
>> > instead.
>> > > > To restore the original branch and stop patching, run
>> > "git am
>> > > --abort".
>> > > >
>> > > > If any one has any ideas, I'm open to suggestion.  If
>> these
>> > > patches were
>> > > > generated properly, there should be no issues applying
>> them.
>> > > >
>> > > > Cheers,
>> > > >
>> > > > Wayne
>> > > >
>> > > > On 11/18/2017 

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Wayne,

Ok, apologies I thought I had addressed that (I haven't had a chance to go
back and look at these patches). I'll do so tonight.

On Tue, Nov 21, 2017 at 10:00 AM, Wayne Stambaugh 
wrote:

> I looked at patches 3-6 and I didn't see where the printf was removed.
>
> On 11/20/2017 05:47 PM, Oliver Walters wrote:
> > The printf() statement should be removed in one of the subsequent
> > patches, as should the removal of that line. I'm unable to check this
> > right now, are you able to confirm if one of the later patches fixes
> > this problem?
> >
> > On Tue, Nov 21, 2017 at 9:44 AM, Wayne Stambaugh  > > wrote:
> >
> > I made a change to fix a bug with the default plugin type when
> appending
> > a new row to the table which caused the conflict.  This where I
> noticed
> > the printf() debugging statement.  I also noticed that it appears
> that
> > you removed a scroll to row call and I'm not sure how to reconcile
> the
> > conflict.  Did you remove the scroll to row call on purpose or
> wasn't it
> > necessary.  I don't want to break that behavior.
> >
> > On 11/20/2017 04:29 PM, Oliver Walters wrote:
> > > Wayne,
> > >
> > > I think it is a whitespace issue, does it apply if you add
> > > --ignore-whitespace to git-am ?
> > >
> > > On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh <
> stambau...@gmail.com 
> > > >>
> wrote:
> > >
> > > Oliver,
> > >
> > > No go yet again.  It looks like my commit 8b2b1381 is causing
> a conflict
> > > with patch 2 so please rebase your patches.  I also noticed a
> printf()
> > > debugging statement in patch 2.  Please remove this and make
> sure there
> > > are not any other printf() statements in your patches.  Sorry
> about
> > > asking you to fix these issues but I really don't have the
> time to fix
> > > patches right now.
> > >
> > > Cheers,
> > >
> > > Wayne
> > >
> > > On 11/20/2017 1:20 AM, Oliver Walters wrote:
> > > > Wayne,
> > > >
> > > > I'm at a loss too. git am fails on 0002 but git apply works
> fine on each
> > > > individual patch.
> > > >
> > > > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh <
> stambau...@gmail.com 
> > >
> > > > 
> >  > > >
> > > > Oliver,
> > > >
> > > > Still no luck.  Did you possible do something to mess up
> the
> > > commit
> > > > ordering?  I am applying these patches on top a clean
> master
> > > branch so
> > > > I'm not sure what is going on here.  I'm getting the
> > following
> > > error
> > > > from `git am` when I attempt to merge patch 2:
> > > >
> > > > Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid
> > editor
> > > > error: patch failed:
> > eeschema/dialogs/dialog_sym_lib_table.cpp:350
> > > > error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch
> does
> > > not apply
> > > > error: patch failed: include/lib_table_grid.h:32
> > > > error: include/lib_table_grid.h: patch does not apply
> > > > Patch failed at 0001 Toggle LIB_TABLE_ROW
> > enabled/disabled in grid
> > > > editor
> > > > The copy of the patch that failed is found in:
> > > .git/rebase-apply/patch
> > > > When you have resolved this problem, run "git am
> > --continue".
> > > > If you prefer to skip this patch, run "git am --skip"
> > instead.
> > > > To restore the original branch and stop patching, run
> > "git am
> > > --abort".
> > > >
> > > > If any one has any ideas, I'm open to suggestion.  If
> these
> > > patches were
> > > > generated properly, there should be no issues applying
> them.
> > > >
> > > > Cheers,
> > > >
> > > > Wayne
> > > >
> > > > On 11/18/2017 07:11 PM, Oliver Walters wrote:
> > > > > Wayne
> > > > >
> > > > > Please find updated patch set attached. I have rebased
> and
> > > built from
> > > > > commit b6884d and it all works fine.
> > > > >
> > > > > Thanks
> > > > >
> > > > > On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh
> > > mailto:stambau...@gmail.com>
> > >
> > > 

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

I looked at patches 3-6 and I didn't see where the printf was removed.

On 11/20/2017 05:47 PM, Oliver Walters wrote:
> The printf() statement should be removed in one of the subsequent
> patches, as should the removal of that line. I'm unable to check this
> right now, are you able to confirm if one of the later patches fixes
> this problem?
> 
> On Tue, Nov 21, 2017 at 9:44 AM, Wayne Stambaugh  > wrote:
> 
> I made a change to fix a bug with the default plugin type when appending
> a new row to the table which caused the conflict.  This where I noticed
> the printf() debugging statement.  I also noticed that it appears that
> you removed a scroll to row call and I'm not sure how to reconcile the
> conflict.  Did you remove the scroll to row call on purpose or wasn't it
> necessary.  I don't want to break that behavior.
> 
> On 11/20/2017 04:29 PM, Oliver Walters wrote:
> > Wayne,
> >
> > I think it is a whitespace issue, does it apply if you add
> > --ignore-whitespace to git-am ?
> >
> > On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh  
> > >> wrote:
> >
> >     Oliver,
> >
> >     No go yet again.  It looks like my commit 8b2b1381 is causing a 
> conflict
> >     with patch 2 so please rebase your patches.  I also noticed a 
> printf()
> >     debugging statement in patch 2.  Please remove this and make sure 
> there
> >     are not any other printf() statements in your patches.  Sorry about
> >     asking you to fix these issues but I really don't have the time to 
> fix
> >     patches right now.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     On 11/20/2017 1:20 AM, Oliver Walters wrote:
> >     > Wayne,
> >     >
> >     > I'm at a loss too. git am fails on 0002 but git apply works fine 
> on each
> >     > individual patch.
> >     >
> >     > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh 
> mailto:stambau...@gmail.com>
> >
> >     > 
>  >     >
> >     >     Oliver,
> >     >
> >     >     Still no luck.  Did you possible do something to mess up the
> >     commit
> >     >     ordering?  I am applying these patches on top a clean master
> >     branch so
> >     >     I'm not sure what is going on here.  I'm getting the
> following
> >     error
> >     >     from `git am` when I attempt to merge patch 2:
> >     >
> >     >     Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid
> editor
> >     >     error: patch failed:
> eeschema/dialogs/dialog_sym_lib_table.cpp:350
> >     >     error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch does
> >     not apply
> >     >     error: patch failed: include/lib_table_grid.h:32
> >     >     error: include/lib_table_grid.h: patch does not apply
> >     >     Patch failed at 0001 Toggle LIB_TABLE_ROW
> enabled/disabled in grid
> >     >     editor
> >     >     The copy of the patch that failed is found in:
> >     .git/rebase-apply/patch
> >     >     When you have resolved this problem, run "git am
> --continue".
> >     >     If you prefer to skip this patch, run "git am --skip"
> instead.
> >     >     To restore the original branch and stop patching, run
> "git am
> >     --abort".
> >     >
> >     >     If any one has any ideas, I'm open to suggestion.  If these
> >     patches were
> >     >     generated properly, there should be no issues applying them.
> >     >
> >     >     Cheers,
> >     >
> >     >     Wayne
> >     >
> >     >     On 11/18/2017 07:11 PM, Oliver Walters wrote:
> >     >     > Wayne
> >     >     >
> >     >     > Please find updated patch set attached. I have rebased and
> >     built from
> >     >     > commit b6884d and it all works fine.
> >     >     >
> >     >     > Thanks
> >     >     >
> >     >     > On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh
> >     mailto:stambau...@gmail.com>
> >
> >     
> >>
> >     >     >    >
> >     
>  wrote:
> >     >     >
> >     >     >     Oliver,
> >     >     >
> 

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

The printf() statement should be removed in one of the subsequent patches,
as should the removal of that line. I'm unable to check this right now, are
you able to confirm if one of the later patches fixes this problem?

On Tue, Nov 21, 2017 at 9:44 AM, Wayne Stambaugh 
wrote:

> I made a change to fix a bug with the default plugin type when appending
> a new row to the table which caused the conflict.  This where I noticed
> the printf() debugging statement.  I also noticed that it appears that
> you removed a scroll to row call and I'm not sure how to reconcile the
> conflict.  Did you remove the scroll to row call on purpose or wasn't it
> necessary.  I don't want to break that behavior.
>
> On 11/20/2017 04:29 PM, Oliver Walters wrote:
> > Wayne,
> >
> > I think it is a whitespace issue, does it apply if you add
> > --ignore-whitespace to git-am ?
> >
> > On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh  > > wrote:
> >
> > Oliver,
> >
> > No go yet again.  It looks like my commit 8b2b1381 is causing a
> conflict
> > with patch 2 so please rebase your patches.  I also noticed a
> printf()
> > debugging statement in patch 2.  Please remove this and make sure
> there
> > are not any other printf() statements in your patches.  Sorry about
> > asking you to fix these issues but I really don't have the time to
> fix
> > patches right now.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 11/20/2017 1:20 AM, Oliver Walters wrote:
> > > Wayne,
> > >
> > > I'm at a loss too. git am fails on 0002 but git apply works fine
> on each
> > > individual patch.
> > >
> > > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh <
> stambau...@gmail.com 
> > > >>
> wrote:
> > >
> > > Oliver,
> > >
> > > Still no luck.  Did you possible do something to mess up the
> > commit
> > > ordering?  I am applying these patches on top a clean master
> > branch so
> > > I'm not sure what is going on here.  I'm getting the following
> > error
> > > from `git am` when I attempt to merge patch 2:
> > >
> > > Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid editor
> > > error: patch failed: eeschema/dialogs/dialog_sym_
> lib_table.cpp:350
> > > error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch does
> > not apply
> > > error: patch failed: include/lib_table_grid.h:32
> > > error: include/lib_table_grid.h: patch does not apply
> > > Patch failed at 0001 Toggle LIB_TABLE_ROW enabled/disabled in
> grid
> > > editor
> > > The copy of the patch that failed is found in:
> > .git/rebase-apply/patch
> > > When you have resolved this problem, run "git am --continue".
> > > If you prefer to skip this patch, run "git am --skip" instead.
> > > To restore the original branch and stop patching, run "git am
> > --abort".
> > >
> > > If any one has any ideas, I'm open to suggestion.  If these
> > patches were
> > > generated properly, there should be no issues applying them.
> > >
> > > Cheers,
> > >
> > > Wayne
> > >
> > > On 11/18/2017 07:11 PM, Oliver Walters wrote:
> > > > Wayne
> > > >
> > > > Please find updated patch set attached. I have rebased and
> > built from
> > > > commit b6884d and it all works fine.
> > > >
> > > > Thanks
> > > >
> > > > On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh
> > mailto:stambau...@gmail.com>
> > >
> > > > 
> >  > > >
> > > > Oliver,
> > > >
> > > > I just tried to apply your patches and ran into some
> > issues.
> > > Patch 1
> > > > applies but patch 2 fails.  Would you please rebase your
> > > patches so I
> > > > can get them merged as soon as possible.
> > > >
> > > > Thanks,
> > > >
> > > > Wayne
> > > >
> > > > On 11/15/2017 06:41 AM, Oliver Walters wrote:
> > > > > Wayne, et al,
> > > > >
> > > > > I am really liking the way that the new symbol table
> > works!
> > > Thanks for
> > > > > the huge effort that has gone into this.
> > > > >
> > > > > One thing that I have noticed is that when opening (for
> > > e.g.) the
> > > > > component chooser, the UI hangs while all the libraries
> > > load. Previously
> > > > > there was a progress dialog which at least informed
> > 

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

I made a change to fix a bug with the default plugin type when appending
a new row to the table which caused the conflict.  This where I noticed
the printf() debugging statement.  I also noticed that it appears that
you removed a scroll to row call and I'm not sure how to reconcile the
conflict.  Did you remove the scroll to row call on purpose or wasn't it
necessary.  I don't want to break that behavior.

On 11/20/2017 04:29 PM, Oliver Walters wrote:
> Wayne,
> 
> I think it is a whitespace issue, does it apply if you add
> --ignore-whitespace to git-am ?
> 
> On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh  > wrote:
> 
> Oliver,
> 
> No go yet again.  It looks like my commit 8b2b1381 is causing a conflict
> with patch 2 so please rebase your patches.  I also noticed a printf()
> debugging statement in patch 2.  Please remove this and make sure there
> are not any other printf() statements in your patches.  Sorry about
> asking you to fix these issues but I really don't have the time to fix
> patches right now.
> 
> Cheers,
> 
> Wayne
> 
> On 11/20/2017 1:20 AM, Oliver Walters wrote:
> > Wayne,
> >
> > I'm at a loss too. git am fails on 0002 but git apply works fine on each
> > individual patch.
> >
> > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh  
> > >> wrote:
> >
> >     Oliver,
> >
> >     Still no luck.  Did you possible do something to mess up the
> commit
> >     ordering?  I am applying these patches on top a clean master
> branch so
> >     I'm not sure what is going on here.  I'm getting the following
> error
> >     from `git am` when I attempt to merge patch 2:
> >
> >     Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid editor
> >     error: patch failed: eeschema/dialogs/dialog_sym_lib_table.cpp:350
> >     error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch does
> not apply
> >     error: patch failed: include/lib_table_grid.h:32
> >     error: include/lib_table_grid.h: patch does not apply
> >     Patch failed at 0001 Toggle LIB_TABLE_ROW enabled/disabled in grid
> >     editor
> >     The copy of the patch that failed is found in:
> .git/rebase-apply/patch
> >     When you have resolved this problem, run "git am --continue".
> >     If you prefer to skip this patch, run "git am --skip" instead.
> >     To restore the original branch and stop patching, run "git am
> --abort".
> >
> >     If any one has any ideas, I'm open to suggestion.  If these
> patches were
> >     generated properly, there should be no issues applying them.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     On 11/18/2017 07:11 PM, Oliver Walters wrote:
> >     > Wayne
> >     >
> >     > Please find updated patch set attached. I have rebased and
> built from
> >     > commit b6884d and it all works fine.
> >     >
> >     > Thanks
> >     >
> >     > On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh
> mailto:stambau...@gmail.com>
> >
> >     > 
>  >     >
> >     >     Oliver,
> >     >
> >     >     I just tried to apply your patches and ran into some
> issues. 
> >     Patch 1
> >     >     applies but patch 2 fails.  Would you please rebase your
> >     patches so I
> >     >     can get them merged as soon as possible.
> >     >
> >     >     Thanks,
> >     >
> >     >     Wayne
> >     >
> >     >     On 11/15/2017 06:41 AM, Oliver Walters wrote:
> >     >     > Wayne, et al,
> >     >     >
> >     >     > I am really liking the way that the new symbol table
> works!
> >     Thanks for
> >     >     > the huge effort that has gone into this.
> >     >     >
> >     >     > One thing that I have noticed is that when opening (for
> >     e.g.) the
> >     >     > component chooser, the UI hangs while all the libraries
> >     load. Previously
> >     >     > there was a progress dialog which at least informed
> the user
> >     what was
> >     >     > going on.
> >     >     >
> >     >     > I have re-implemented this dialog in the attached
> patch set.
> >     >     >
> >     >     > Further, I have also implemented a way to individually
> >     enable / disable
> >     >     > each row in the library tables (this works for SYMBOL_LIB
> >     and FP_LIB).
> >     >     >
> >     >     > This is based on the idea by Tomasz. Example
> screenshot below:
> >     >     >
> >     >

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Wayne,

I think it is a whitespace issue, does it apply if you add
--ignore-whitespace to git-am ?

On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh 
wrote:

> Oliver,
>
> No go yet again.  It looks like my commit 8b2b1381 is causing a conflict
> with patch 2 so please rebase your patches.  I also noticed a printf()
> debugging statement in patch 2.  Please remove this and make sure there
> are not any other printf() statements in your patches.  Sorry about
> asking you to fix these issues but I really don't have the time to fix
> patches right now.
>
> Cheers,
>
> Wayne
>
> On 11/20/2017 1:20 AM, Oliver Walters wrote:
> > Wayne,
> >
> > I'm at a loss too. git am fails on 0002 but git apply works fine on each
> > individual patch.
> >
> > On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh  > > wrote:
> >
> > Oliver,
> >
> > Still no luck.  Did you possible do something to mess up the commit
> > ordering?  I am applying these patches on top a clean master branch
> so
> > I'm not sure what is going on here.  I'm getting the following error
> > from `git am` when I attempt to merge patch 2:
> >
> > Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid editor
> > error: patch failed: eeschema/dialogs/dialog_sym_lib_table.cpp:350
> > error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch does not
> apply
> > error: patch failed: include/lib_table_grid.h:32
> > error: include/lib_table_grid.h: patch does not apply
> > Patch failed at 0001 Toggle LIB_TABLE_ROW enabled/disabled in grid
> > editor
> > The copy of the patch that failed is found in:
> .git/rebase-apply/patch
> > When you have resolved this problem, run "git am --continue".
> > If you prefer to skip this patch, run "git am --skip" instead.
> > To restore the original branch and stop patching, run "git am
> --abort".
> >
> > If any one has any ideas, I'm open to suggestion.  If these patches
> were
> > generated properly, there should be no issues applying them.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 11/18/2017 07:11 PM, Oliver Walters wrote:
> > > Wayne
> > >
> > > Please find updated patch set attached. I have rebased and built
> from
> > > commit b6884d and it all works fine.
> > >
> > > Thanks
> > >
> > > On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh <
> stambau...@gmail.com 
> > > >>
> wrote:
> > >
> > > Oliver,
> > >
> > > I just tried to apply your patches and ran into some issues.
> > Patch 1
> > > applies but patch 2 fails.  Would you please rebase your
> > patches so I
> > > can get them merged as soon as possible.
> > >
> > > Thanks,
> > >
> > > Wayne
> > >
> > > On 11/15/2017 06:41 AM, Oliver Walters wrote:
> > > > Wayne, et al,
> > > >
> > > > I am really liking the way that the new symbol table works!
> > Thanks for
> > > > the huge effort that has gone into this.
> > > >
> > > > One thing that I have noticed is that when opening (for
> > e.g.) the
> > > > component chooser, the UI hangs while all the libraries
> > load. Previously
> > > > there was a progress dialog which at least informed the user
> > what was
> > > > going on.
> > > >
> > > > I have re-implemented this dialog in the attached patch set.
> > > >
> > > > Further, I have also implemented a way to individually
> > enable / disable
> > > > each row in the library tables (this works for SYMBOL_LIB
> > and FP_LIB).
> > > >
> > > > This is based on the idea by Tomasz. Example screenshot
> below:
> > > >
> > > > Inline image 1
> > > >
> > > > I have tweaked the base LIB_TABLE_GRID code such that
> > disabled entries
> > > > are greyed out and made italic. The enabled / disabled
> status is
> > > > persistent in the sym/fp_lib_table files. Older version of
> > xxx_lib_table
> > > > files are read with all rows enabled by default.
> > > >
> > > > Please find patch set attached.
> > > >
> > > > Regards,
> > > > Oliver
> > > >
> > > >
> > > >
> > > > ___
> > > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > >  > >
> > > > Post to : kicad-developers@lists.launchpad.net
> > 
> > >  > >
> > > > Unsubscribe : h

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Oliver,

No go yet again.  It looks like my commit 8b2b1381 is causing a conflict
with patch 2 so please rebase your patches.  I also noticed a printf()
debugging statement in patch 2.  Please remove this and make sure there
are not any other printf() statements in your patches.  Sorry about
asking you to fix these issues but I really don't have the time to fix
patches right now.

Cheers,

Wayne

On 11/20/2017 1:20 AM, Oliver Walters wrote:
> Wayne,
> 
> I'm at a loss too. git am fails on 0002 but git apply works fine on each
> individual patch.
> 
> On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh  > wrote:
> 
> Oliver,
> 
> Still no luck.  Did you possible do something to mess up the commit
> ordering?  I am applying these patches on top a clean master branch so
> I'm not sure what is going on here.  I'm getting the following error
> from `git am` when I attempt to merge patch 2:
> 
> Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid editor
> error: patch failed: eeschema/dialogs/dialog_sym_lib_table.cpp:350
> error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch does not apply
> error: patch failed: include/lib_table_grid.h:32
> error: include/lib_table_grid.h: patch does not apply
> Patch failed at 0001 Toggle LIB_TABLE_ROW enabled/disabled in grid
> editor
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> 
> If any one has any ideas, I'm open to suggestion.  If these patches were
> generated properly, there should be no issues applying them.
> 
> Cheers,
> 
> Wayne
> 
> On 11/18/2017 07:11 PM, Oliver Walters wrote:
> > Wayne
> >
> > Please find updated patch set attached. I have rebased and built from
> > commit b6884d and it all works fine.
> >
> > Thanks
> >
> > On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh  
> > >> wrote:
> >
> >     Oliver,
> >
> >     I just tried to apply your patches and ran into some issues. 
> Patch 1
> >     applies but patch 2 fails.  Would you please rebase your
> patches so I
> >     can get them merged as soon as possible.
> >
> >     Thanks,
> >
> >     Wayne
> >
> >     On 11/15/2017 06:41 AM, Oliver Walters wrote:
> >     > Wayne, et al,
> >     >
> >     > I am really liking the way that the new symbol table works!
> Thanks for
> >     > the huge effort that has gone into this.
> >     >
> >     > One thing that I have noticed is that when opening (for
> e.g.) the
> >     > component chooser, the UI hangs while all the libraries
> load. Previously
> >     > there was a progress dialog which at least informed the user
> what was
> >     > going on.
> >     >
> >     > I have re-implemented this dialog in the attached patch set.
> >     >
> >     > Further, I have also implemented a way to individually
> enable / disable
> >     > each row in the library tables (this works for SYMBOL_LIB
> and FP_LIB).
> >     >
> >     > This is based on the idea by Tomasz. Example screenshot below:
> >     >
> >     > Inline image 1
> >     >
> >     > I have tweaked the base LIB_TABLE_GRID code such that
> disabled entries
> >     > are greyed out and made italic. The enabled / disabled status is
> >     > persistent in the sym/fp_lib_table files. Older version of
> xxx_lib_table
> >     > files are read with all rows enabled by default.
> >     >
> >     > Please find patch set attached.
> >     >
> >     > Regards,
> >     > Oliver
> >     >
> >     >
> >     >
> >     > ___
> >     > Mailing list: https://launchpad.net/~kicad-developers
> 
> >      >
> >     > Post to     : kicad-developers@lists.launchpad.net
> 
> >      >
> >     > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >      >
> >     > More help   : https://help.launchpad.net/ListHelp
> 
> >      >
> >     >
> >
> >     ___

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Wayne,

I'm at a loss too. git am fails on 0002 but git apply works fine on each
individual patch.

On Mon, Nov 20, 2017 at 3:29 AM, Wayne Stambaugh 
wrote:

> Oliver,
>
> Still no luck.  Did you possible do something to mess up the commit
> ordering?  I am applying these patches on top a clean master branch so
> I'm not sure what is going on here.  I'm getting the following error
> from `git am` when I attempt to merge patch 2:
>
> Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid editor
> error: patch failed: eeschema/dialogs/dialog_sym_lib_table.cpp:350
> error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch does not apply
> error: patch failed: include/lib_table_grid.h:32
> error: include/lib_table_grid.h: patch does not apply
> Patch failed at 0001 Toggle LIB_TABLE_ROW enabled/disabled in grid editor
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
> If any one has any ideas, I'm open to suggestion.  If these patches were
> generated properly, there should be no issues applying them.
>
> Cheers,
>
> Wayne
>
> On 11/18/2017 07:11 PM, Oliver Walters wrote:
> > Wayne
> >
> > Please find updated patch set attached. I have rebased and built from
> > commit b6884d and it all works fine.
> >
> > Thanks
> >
> > On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh  > > wrote:
> >
> > Oliver,
> >
> > I just tried to apply your patches and ran into some issues.  Patch 1
> > applies but patch 2 fails.  Would you please rebase your patches so I
> > can get them merged as soon as possible.
> >
> > Thanks,
> >
> > Wayne
> >
> > On 11/15/2017 06:41 AM, Oliver Walters wrote:
> > > Wayne, et al,
> > >
> > > I am really liking the way that the new symbol table works! Thanks
> for
> > > the huge effort that has gone into this.
> > >
> > > One thing that I have noticed is that when opening (for e.g.) the
> > > component chooser, the UI hangs while all the libraries load.
> Previously
> > > there was a progress dialog which at least informed the user what
> was
> > > going on.
> > >
> > > I have re-implemented this dialog in the attached patch set.
> > >
> > > Further, I have also implemented a way to individually enable /
> disable
> > > each row in the library tables (this works for SYMBOL_LIB and
> FP_LIB).
> > >
> > > This is based on the idea by Tomasz. Example screenshot below:
> > >
> > > Inline image 1
> > >
> > > I have tweaked the base LIB_TABLE_GRID code such that disabled
> entries
> > > are greyed out and made italic. The enabled / disabled status is
> > > persistent in the sym/fp_lib_table files. Older version of
> xxx_lib_table
> > > files are read with all rows enabled by default.
> > >
> > > Please find patch set attached.
> > >
> > > Regards,
> > > Oliver
> > >
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
> >
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Oliver,

Still no luck.  Did you possible do something to mess up the commit
ordering?  I am applying these patches on top a clean master branch so
I'm not sure what is going on here.  I'm getting the following error
from `git am` when I attempt to merge patch 2:

Applying: Toggle LIB_TABLE_ROW enabled/disabled in grid editor
error: patch failed: eeschema/dialogs/dialog_sym_lib_table.cpp:350
error: eeschema/dialogs/dialog_sym_lib_table.cpp: patch does not apply
error: patch failed: include/lib_table_grid.h:32
error: include/lib_table_grid.h: patch does not apply
Patch failed at 0001 Toggle LIB_TABLE_ROW enabled/disabled in grid editor
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

If any one has any ideas, I'm open to suggestion.  If these patches were
generated properly, there should be no issues applying them.

Cheers,

Wayne

On 11/18/2017 07:11 PM, Oliver Walters wrote:
> Wayne
> 
> Please find updated patch set attached. I have rebased and built from
> commit b6884d and it all works fine.
> 
> Thanks
> 
> On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh  > wrote:
> 
> Oliver,
> 
> I just tried to apply your patches and ran into some issues.  Patch 1
> applies but patch 2 fails.  Would you please rebase your patches so I
> can get them merged as soon as possible.
> 
> Thanks,
> 
> Wayne
> 
> On 11/15/2017 06:41 AM, Oliver Walters wrote:
> > Wayne, et al,
> >
> > I am really liking the way that the new symbol table works! Thanks for
> > the huge effort that has gone into this.
> >
> > One thing that I have noticed is that when opening (for e.g.) the
> > component chooser, the UI hangs while all the libraries load. Previously
> > there was a progress dialog which at least informed the user what was
> > going on.
> >
> > I have re-implemented this dialog in the attached patch set.
> >
> > Further, I have also implemented a way to individually enable / disable
> > each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
> >
> > This is based on the idea by Tomasz. Example screenshot below:
> >
> > Inline image 1
> >
> > I have tweaked the base LIB_TABLE_GRID code such that disabled entries
> > are greyed out and made italic. The enabled / disabled status is
> > persistent in the sym/fp_lib_table files. Older version of xxx_lib_table
> > files are read with all rows enabled by default.
> >
> > Please find patch set attached.
> >
> > Regards,
> > Oliver
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Wayne

Please find updated patch set attached. I have rebased and built from
commit b6884d and it all works fine.

Thanks

On Sun, Nov 19, 2017 at 4:42 AM, Wayne Stambaugh 
wrote:

> Oliver,
>
> I just tried to apply your patches and ran into some issues.  Patch 1
> applies but patch 2 fails.  Would you please rebase your patches so I
> can get them merged as soon as possible.
>
> Thanks,
>
> Wayne
>
> On 11/15/2017 06:41 AM, Oliver Walters wrote:
> > Wayne, et al,
> >
> > I am really liking the way that the new symbol table works! Thanks for
> > the huge effort that has gone into this.
> >
> > One thing that I have noticed is that when opening (for e.g.) the
> > component chooser, the UI hangs while all the libraries load. Previously
> > there was a progress dialog which at least informed the user what was
> > going on.
> >
> > I have re-implemented this dialog in the attached patch set.
> >
> > Further, I have also implemented a way to individually enable / disable
> > each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
> >
> > This is based on the idea by Tomasz. Example screenshot below:
> >
> > Inline image 1
> >
> > I have tweaked the base LIB_TABLE_GRID code such that disabled entries
> > are greyed out and made italic. The enabled / disabled status is
> > persistent in the sym/fp_lib_table files. Older version of xxx_lib_table
> > files are read with all rows enabled by default.
> >
> > Please find patch set attached.
> >
> > Regards,
> > Oliver
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
From 7031b7262c1afe7efa6dcd8c171a18ecbf5ca952 Mon Sep 17 00:00:00 2001
From: Oliver 
Date: Wed, 15 Nov 2017 22:32:23 +1100
Subject: [PATCH 6/6] Improved LIB_TABLE rendering

- Moved "Active" to first column
- Changed text attributes for disabled rows
---
 include/lib_table_grid.h | 48 ++--
 1 file changed, 46 insertions(+), 2 deletions(-)

diff --git a/include/lib_table_grid.h b/include/lib_table_grid.h
index c35c4f4..94726b5 100644
--- a/include/lib_table_grid.h
+++ b/include/lib_table_grid.h
@@ -24,15 +24,18 @@
 
 #include 
 
+const wxColour COLOUR_ROW_ENABLED( 0, 0, 0 );
+const wxColour COLOUR_ROW_DISABLED( 100, 100, 100 );
+
 /// The library table grid column order is established by this sequence.
 enum COL_ORDER
 {
+COL_ENABLED,
 COL_NICKNAME,
 COL_URI,
 COL_TYPE,
 COL_OPTIONS,
 COL_DESCR,
-COL_ENABLED,
 
 COL_COUNT   // keep as last
 };
@@ -180,12 +183,53 @@ public:
 case COL_TYPE:  return _( "Plugin Type" );
 case COL_OPTIONS:   return _( "Options" );
 case COL_DESCR: return _( "Description" );
-case COL_ENABLED:   return _( "Enabled" );
+case COL_ENABLED:   return _( "Active" );
 
 default:return wxEmptyString;
 }
 }
 
+/**
+ * Customize the appearance of LIB_TABLE_ROW entries
+ * - If not enabled, greyed out and italic
+ */
+virtual wxGridCellAttr* GetAttr( int aRow, int aCol, wxGridCellAttr::wxAttrKind aKind) override
+{
+auto* attr = wxGridTableBase::GetAttr( aRow, aCol, aKind );
+
+if( aRow < (int) size() )
+{
+if( !attr )
+{
+attr = new wxGridCellAttr();
+}
+
+wxFont font;
+
+if( attr->HasFont() )
+{
+font = attr->GetFont();
+}
+
+LIB_TABLE_ROW* r = at( (size_t) aRow );
+
+if( r && r->GetIsEnabled() )
+{
+font.SetStyle( wxFONTSTYLE_NORMAL );
+attr->SetTextColour( COLOUR_ROW_ENABLED );
+}
+else
+{
+font.SetStyle( wxFONTSTYLE_ITALIC );
+attr->SetTextColour( COLOUR_ROW_DISABLED );
+}
+
+attr->SetFont( font );
+}
+
+return attr;
+}
+
 protected:
 virtual LIB_TABLE_ROW* at( size_t aIndex ) = 0;
 
-- 
2.7.4

From 7694084a6d0930c8500d9215f824f957688e72d7 Mon Sep 17 00:00:00 2001
From: Oliver 
Date: Wed, 15 Nov 2017 21:48:38 +1100
Subject: [PATCH 5/6] Add progress dialog when loading symbol libraries

- Provides UX feedback for user
---
 eeschema/cmp_tree_model_adapter.cpp | 22 +-
 eeschema/cmp_tree_model_adapter.h   | 12 
 eeschema/getpart.cpp|  7 ++-
 eeschema/viewlibs.cpp   | 10 ++
 4 files changed, 37 insert

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Oliver,

I just tried to apply your patches and ran into some issues.  Patch 1
applies but patch 2 fails.  Would you please rebase your patches so I
can get them merged as soon as possible.

Thanks,

Wayne

On 11/15/2017 06:41 AM, Oliver Walters wrote:
> Wayne, et al,
> 
> I am really liking the way that the new symbol table works! Thanks for
> the huge effort that has gone into this.
> 
> One thing that I have noticed is that when opening (for e.g.) the
> component chooser, the UI hangs while all the libraries load. Previously
> there was a progress dialog which at least informed the user what was
> going on.
> 
> I have re-implemented this dialog in the attached patch set.
> 
> Further, I have also implemented a way to individually enable / disable
> each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
> 
> This is based on the idea by Tomasz. Example screenshot below:
> 
> Inline image 1
> 
> I have tweaked the base LIB_TABLE_GRID code such that disabled entries
> are greyed out and made italic. The enabled / disabled status is
> persistent in the sym/fp_lib_table files. Older version of xxx_lib_table
> files are read with all rows enabled by default.
> 
> Please find patch set attached.
> 
> Regards,
> Oliver
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Thank you!

On 18 Nov 2017 00:47, "Wayne Stambaugh"  wrote:

> Oliver,
>
> I took another look at your patch set and I see now that the library
> table files only change when there are disabled libraries.  This will
> ensure that the footprint library tables will be compatible with
> previous versions of KiCad as long as users don't disable any libraries.
>  I will merge your patch set over the weekend if there are no other
> major objections.  This change in behavior should be documented in the
> "Managing Footprint Libraries" section of the pcbnew docs.
>
> Folks, please do not hijack threads.  This thread should have only been
> a discussion about Oliver's proposed changes.
>
> Thanks,
>
> Wayne
>
> On 11/17/2017 07:06 AM, Oliver Walters wrote:
> > Wayne,
> >
> > Please confirm if you really do not want this feature now. This thread
> > is quickly turning into a how-to for the new symbol table :)
> >
> > Thanks
> >
> > On Thu, Nov 16, 2017 at 8:42 AM, Oliver Walters
> > mailto:oliver.henry.walt...@gmail.com>>
> > wrote:
> >
> >
> > On Thu, Nov 16, 2017 at 1:42 AM, Wayne Stambaugh
> > mailto:stambau...@gmail.com>> wrote:
> >
> > Gentlemen,
> >
> > I'm not sure about breaking the library table file format for the
> > version 5 release.  If we do, the footprint library table will
> > not be
> > compatible with older versions.  I would prefer that we push
> > this change
> > into version 6.
> >
> >
> > I'm not sure I understand why it would be ok to break it in v6 but
> > not v5? We are already introducing the sym-lib-table. If we waited
> > until v6 to make this change, then we would break *both* tables
> > (instead of just one).
> >
> >
> >
> > I'm OK with the progress dialog.  If you split that out as
> separate
> > patch, I will merge it.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> > > On 15/11/17 15:30, Maciej Suminski wrote:
> > >> Hi Oliver,
> > >>
> > >> Thank you for restoring the progress bar dialog. While the
> > library load
> > >> time has recently decreased a lot, the UI freeze still
> > happens with long
> > >> library lists.
> > >> Disclaimer: I have not looked at the code yet, I am just
> > praising the idea.
> > >>
> > >> As you are looking on the Symbol Library Table dialog, I
> > suppose you
> > >> might be also tempted to add a file browser to add new
> > libraries. If
> > >> that is the case, please refrain from doing so - it is done
> > in the
> > >> library editor refactor branch. If you had no such intention,
> > then
> > >> simply ignore this message.
> > >
> > > Hi Olivier & Orson,
> > >
> > > I partially implemented the simplified dialog I proposed on
> > the dev list
> > > a few days ago. Would anyone be interested in helping me
> > finish it?
> > >
> > > Tom
> > >
> > >>
> > >> Cheers,
> > >> Orson
> > >>
> > >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
> > >>> Wayne, et al,
> > >>>
> > >>> I am really liking the way that the new symbol table works!
> > Thanks for
> > >>> the huge effort that has gone into this.
> > >>>
> > >>> One thing that I have noticed is that when opening (for
> > e.g.) the
> > >>> component chooser, the UI hangs while all the libraries
> > load. Previously
> > >>> there was a progress dialog which at least informed the user
> > what was
> > >>> going on.
> > >>>
> > >>> I have re-implemented this dialog in the attached patch set.
> > >>>
> > >>> Further, I have also implemented a way to individually
> > enable / disable
> > >>> each row in the library tables (this works for SYMBOL_LIB
> > and FP_LIB).
> > >>>
> > >>> This is based on the idea by Tomasz. Example screenshot
> below:
> > >>>
> > >>> Inline image 1
> > >>>
> > >>> I have tweaked the base LIB_TABLE_GRID code such that
> > disabled entries
> > >>> are greyed out and made italic. The enabled / disabled
> status is
> > >>> persistent in the sym/fp_lib_table files. Older version of
> > xxx_lib_table
> > >>> files are read with all rows enabled by default.
> > >>>
> > >>> Please find patch set attached.
> > >>>
> > >>> Regards,
> > >>> Oliver
> > >>>
> > >>>
> > >>>
> > >>> ___
> > >>> Mailing list: https://launchpad.net/~kicad-developers
> > 
>

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Oliver,

I took another look at your patch set and I see now that the library
table files only change when there are disabled libraries.  This will
ensure that the footprint library tables will be compatible with
previous versions of KiCad as long as users don't disable any libraries.
 I will merge your patch set over the weekend if there are no other
major objections.  This change in behavior should be documented in the
"Managing Footprint Libraries" section of the pcbnew docs.

Folks, please do not hijack threads.  This thread should have only been
a discussion about Oliver's proposed changes.

Thanks,

Wayne

On 11/17/2017 07:06 AM, Oliver Walters wrote:
> Wayne,
> 
> Please confirm if you really do not want this feature now. This thread
> is quickly turning into a how-to for the new symbol table :)
> 
> Thanks
> 
> On Thu, Nov 16, 2017 at 8:42 AM, Oliver Walters
> mailto:oliver.henry.walt...@gmail.com>>
> wrote:
> 
> 
> On Thu, Nov 16, 2017 at 1:42 AM, Wayne Stambaugh
> mailto:stambau...@gmail.com>> wrote:
> 
> Gentlemen,
> 
> I'm not sure about breaking the library table file format for the
> version 5 release.  If we do, the footprint library table will
> not be
> compatible with older versions.  I would prefer that we push
> this change
> into version 6.
> 
> 
> I'm not sure I understand why it would be ok to break it in v6 but
> not v5? We are already introducing the sym-lib-table. If we waited
> until v6 to make this change, then we would break *both* tables
> (instead of just one).
>  
> 
> 
> I'm OK with the progress dialog.  If you split that out as separate
> patch, I will merge it.
> 
> Cheers,
> 
> Wayne
> 
> On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> > On 15/11/17 15:30, Maciej Suminski wrote:
> >> Hi Oliver,
> >>
> >> Thank you for restoring the progress bar dialog. While the
> library load
> >> time has recently decreased a lot, the UI freeze still
> happens with long
> >> library lists.
> >> Disclaimer: I have not looked at the code yet, I am just
> praising the idea.
> >>
> >> As you are looking on the Symbol Library Table dialog, I
> suppose you
> >> might be also tempted to add a file browser to add new
> libraries. If
> >> that is the case, please refrain from doing so - it is done
> in the
> >> library editor refactor branch. If you had no such intention,
> then
> >> simply ignore this message.
> >
> > Hi Olivier & Orson,
> >
> > I partially implemented the simplified dialog I proposed on
> the dev list
> > a few days ago. Would anyone be interested in helping me
> finish it?
> >
> > Tom
> >
> >>
> >> Cheers,
> >> Orson
> >>
> >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
> >>> Wayne, et al,
> >>>
> >>> I am really liking the way that the new symbol table works!
> Thanks for
> >>> the huge effort that has gone into this.
> >>>
> >>> One thing that I have noticed is that when opening (for
> e.g.) the
> >>> component chooser, the UI hangs while all the libraries
> load. Previously
> >>> there was a progress dialog which at least informed the user
> what was
> >>> going on.
> >>>
> >>> I have re-implemented this dialog in the attached patch set.
> >>>
> >>> Further, I have also implemented a way to individually
> enable / disable
> >>> each row in the library tables (this works for SYMBOL_LIB
> and FP_LIB).
> >>>
> >>> This is based on the idea by Tomasz. Example screenshot below:
> >>>
> >>> Inline image 1
> >>>
> >>> I have tweaked the base LIB_TABLE_GRID code such that
> disabled entries
> >>> are greyed out and made italic. The enabled / disabled status is
> >>> persistent in the sym/fp_lib_table files. Older version of
> xxx_lib_table
> >>> files are read with all rows enabled by default.
> >>>
> >>> Please find patch set attached.
> >>>
> >>> Regards,
> >>> Oliver
> >>>
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> 
> >>> Post to : kicad-developers@lists.launchpad.net
> 
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >>> More help   : https://help.launchpad.net/ListHelp
>   

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

Wayne,

Please confirm if you really do not want this feature now. This thread is
quickly turning into a how-to for the new symbol table :)

Thanks

On Thu, Nov 16, 2017 at 8:42 AM, Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

>
> On Thu, Nov 16, 2017 at 1:42 AM, Wayne Stambaugh 
> wrote:
>
>> Gentlemen,
>>
>> I'm not sure about breaking the library table file format for the
>> version 5 release.  If we do, the footprint library table will not be
>> compatible with older versions.  I would prefer that we push this change
>> into version 6.
>>
>
> I'm not sure I understand why it would be ok to break it in v6 but not v5?
> We are already introducing the sym-lib-table. If we waited until v6 to make
> this change, then we would break *both* tables (instead of just one).
>
>
>>
>> I'm OK with the progress dialog.  If you split that out as separate
>> patch, I will merge it.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
>> > On 15/11/17 15:30, Maciej Suminski wrote:
>> >> Hi Oliver,
>> >>
>> >> Thank you for restoring the progress bar dialog. While the library load
>> >> time has recently decreased a lot, the UI freeze still happens with
>> long
>> >> library lists.
>> >> Disclaimer: I have not looked at the code yet, I am just praising the
>> idea.
>> >>
>> >> As you are looking on the Symbol Library Table dialog, I suppose you
>> >> might be also tempted to add a file browser to add new libraries. If
>> >> that is the case, please refrain from doing so - it is done in the
>> >> library editor refactor branch. If you had no such intention, then
>> >> simply ignore this message.
>> >
>> > Hi Olivier & Orson,
>> >
>> > I partially implemented the simplified dialog I proposed on the dev list
>> > a few days ago. Would anyone be interested in helping me finish it?
>> >
>> > Tom
>> >
>> >>
>> >> Cheers,
>> >> Orson
>> >>
>> >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
>> >>> Wayne, et al,
>> >>>
>> >>> I am really liking the way that the new symbol table works! Thanks for
>> >>> the huge effort that has gone into this.
>> >>>
>> >>> One thing that I have noticed is that when opening (for e.g.) the
>> >>> component chooser, the UI hangs while all the libraries load.
>> Previously
>> >>> there was a progress dialog which at least informed the user what was
>> >>> going on.
>> >>>
>> >>> I have re-implemented this dialog in the attached patch set.
>> >>>
>> >>> Further, I have also implemented a way to individually enable /
>> disable
>> >>> each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
>> >>>
>> >>> This is based on the idea by Tomasz. Example screenshot below:
>> >>>
>> >>> Inline image 1
>> >>>
>> >>> I have tweaked the base LIB_TABLE_GRID code such that disabled entries
>> >>> are greyed out and made italic. The enabled / disabled status is
>> >>> persistent in the sym/fp_lib_table files. Older version of
>> xxx_lib_table
>> >>> files are read with all rows enabled by default.
>> >>>
>> >>> Please find patch set attached.
>> >>>
>> >>> Regards,
>> >>> Oliver
>> >>>
>> >>>
>> >>>
>> >>> ___
>> >>> Mailing list: https://launchpad.net/~kicad-developers
>> >>> Post to : kicad-developers@lists.launchpad.net
>> >>> Unsubscribe : https://launchpad.net/~kicad-developers
>> >>> More help   : https://help.launchpad.net/ListHelp
>> >>>
>> >>
>> >> ___
>> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> Post to : kicad-developers@lists.launchpad.net
>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> More help   : https://help.launchpad.net/ListHelp
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Rene Pöschl]

On 16/11/17 17:41, Kevin Cozens wrote:

On a side note, you might see a trailing / for the KISYS3DMOD environment
variable. That is there by default when you first run KiCad. I would remove
that extra character for consistency. So far I have not noticed any negative
effects when the path for KISYS3DMOD ends with a / character.


Did you use one of the newer footprints?
The new klc requires the 3dpath to include ${KISYS3DMOD}/ (Including the /)
So i guess this should be a problem if the / is included in KISYS3DMOD.



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Kevin Cozens]

On 2017-11-16 05:00 AM, Fabrizio Tappero wrote:
I have deleted the lib table and let kicad propose the new one so now all is 
fine.Â


The only problem I experienced is that the "RESCUE" rename action has 
screwed up all my schematics. Thank god git was made.


Make sure you do *not* have a / character at the end of the paths for the 
KICAD_PTEMPLATES and KICAD_SYMBOL_DIR environment variables. When you start 
KiCad you can find these variables and their paths under Prerences -> 
Configure Paths. If you see a trailing / in either, or both, of these 
environment variables remove that final /.


If you did have the trailing / in the paths of these variables you need to 
roll back the projects to a previously known good version. You can then open 
them with the latest version of KiCad and go through the remap process.


This is a known issue that needs to be fixed before 5.0 is released.

On a side note, you might see a trailing / for the KISYS3DMOD environment 
variable. That is there by default when you first run KiCad. I would remove 
that extra character for consistency. So far I have not noticed any negative 
effects when the path for KISYS3DMOD ends with a / character.


--
Cheers!

Kevin.

http://www.ve3syb.ca/   |"Nerds make the shiny things that distract
Owner of Elecraft K2 #2172  | the mouth-breathers, and that's why we're
| powerful!"
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Fabrizio Tappero]

Hey Wayne,
thanks for the link. I have read it and followed the steps. All is working
now.

Thanks a lot for the info.

cheers
Fabrizio


On Thu, Nov 16, 2017 at 1:38 PM, Wayne Stambaugh 
wrote:

> Did you follow the instructions I provided on the kicad website blog post?
>
> http://kicad-pcb.org/post/symbol-lib-table/
>
> On 11/16/2017 5:20 AM, Fabrizio Tappero wrote:
> > hi Guys,
> > I can confirm that the recent lib table commits have made my working
> > version of kicad totally unable to open recent schematics
> >
> >
> > Inline image 1
> > Inline image 3
> >
> >
> > all components seem visible and usable (if a new schematic is created)
> > but kicad is unable to load ALL symbols
> > from a schematic that was done one month ago.
> >
> > Inline image 2
> >
> > I do not know how to fix this any idea?
> >
> > cheers
> > Fabrizio
> >
> >
> >
> >
> > On Thu, Nov 16, 2017 at 11:00 AM, Fabrizio Tappero
> > mailto:fabrizio.tapp...@gmail.com>> wrote:
> >
> > Hi Guys,
> > hum... my version of kicad is a nightly buid that I heavily use at
> > work and that keep update every now and then. Probably all this
> > started a two years ago or so.
> >
> > I have deleted the lib table and let kicad propose the new one so
> > now all is fine.
> >
> > The only problem I experienced is that the "RESCUE" rename action
> > has screwed up all my schematics. Thank god git was made.
> >
> > I noticed some lib issues with the cache lib file that trigger a
> > rescue menu too. I am sorry I cant really ping point the problem. I
> > just wanted to get this email out there for future reference. I
> > realise however that I am not really providing good info
> >
> > cheers
> > Fabrizio
> >
> >
> >
> >
> > On Wed, Nov 15, 2017 at 10:42 PM, Oliver Walters
> >  > > wrote:
> >
> >
> > On Thu, Nov 16, 2017 at 1:42 AM, Wayne Stambaugh
> > mailto:stambau...@gmail.com>> wrote:
> >
> > Gentlemen,
> >
> > I'm not sure about breaking the library table file format
> > for the
> > version 5 release.  If we do, the footprint library table
> > will not be
> > compatible with older versions.  I would prefer that we push
> > this change
> > into version 6.
> >
> >
> > I'm not sure I understand why it would be ok to break it in v6
> > but not v5? We are already introducing the sym-lib-table. If we
> > waited until v6 to make this change, then we would break *both*
> > tables (instead of just one).
> >
> >
> >
> > I'm OK with the progress dialog.  If you split that out as
> > separate
> > patch, I will merge it.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> > > On 15/11/17 15:30, Maciej Suminski wrote:
> > >> Hi Oliver,
> > >>
> > >> Thank you for restoring the progress bar dialog. While
> > the library load
> > >> time has recently decreased a lot, the UI freeze still
> > happens with long
> > >> library lists.
> > >> Disclaimer: I have not looked at the code yet, I am just
> > praising the idea.
> > >>
> > >> As you are looking on the Symbol Library Table dialog, I
> > suppose you
> > >> might be also tempted to add a file browser to add new
> > libraries. If
> > >> that is the case, please refrain from doing so - it is
> > done in the
> > >> library editor refactor branch. If you had no such
> > intention, then
> > >> simply ignore this message.
> > >
> > > Hi Olivier & Orson,
> > >
> > > I partially implemented the simplified dialog I proposed
> > on the dev list
> > > a few days ago. Would anyone be interested in helping me
> > finish it?
> > >
> > > Tom
> > >
> > >>
> > >> Cheers,
> > >> Orson
> > >>
> > >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
> > >>> Wayne, et al,
> > >>>
> > >>> I am really liking the way that the new symbol table
> > works! Thanks for
> > >>> the huge effort that has gone into this.
> > >>>
> > >>> One thing that I have noticed is that when opening (for
> > e.g.) the
> > >>> component chooser, the UI hangs while all the libraries
> > load. Previously
> > >>> there was a progress dialog which at least informed the
> > user what was
> > >>> going on.
> > >>>
> > >>> I have

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Did you follow the instructions I provided on the kicad website blog post?

http://kicad-pcb.org/post/symbol-lib-table/

On 11/16/2017 5:20 AM, Fabrizio Tappero wrote:
> hi Guys,
> I can confirm that the recent lib table commits have made my working
> version of kicad totally unable to open recent schematics
> 
> 
> Inline image 1
> Inline image 3
> 
> 
> all components seem visible and usable (if a new schematic is created)
> but kicad is unable to load ALL symbols 
> from a schematic that was done one month ago.
> 
> Inline image 2
> 
> I do not know how to fix this any idea?
> 
> cheers
> Fabrizio
> 
> 
> 
> 
> On Thu, Nov 16, 2017 at 11:00 AM, Fabrizio Tappero
> mailto:fabrizio.tapp...@gmail.com>> wrote:
> 
> Hi Guys,
> hum... my version of kicad is a nightly buid that I heavily use at
> work and that keep update every now and then. Probably all this
> started a two years ago or so.
> 
> I have deleted the lib table and let kicad propose the new one so
> now all is fine. 
> 
> The only problem I experienced is that the "RESCUE" rename action
> has screwed up all my schematics. Thank god git was made.
> 
> I noticed some lib issues with the cache lib file that trigger a
> rescue menu too. I am sorry I cant really ping point the problem. I
> just wanted to get this email out there for future reference. I
> realise however that I am not really providing good info
> 
> cheers
> Fabrizio
> 
> 
> 
> 
> On Wed, Nov 15, 2017 at 10:42 PM, Oliver Walters
>  > wrote:
> 
> 
> On Thu, Nov 16, 2017 at 1:42 AM, Wayne Stambaugh
> mailto:stambau...@gmail.com>> wrote:
> 
> Gentlemen,
> 
> I'm not sure about breaking the library table file format
> for the
> version 5 release.  If we do, the footprint library table
> will not be
> compatible with older versions.  I would prefer that we push
> this change
> into version 6.
> 
> 
> I'm not sure I understand why it would be ok to break it in v6
> but not v5? We are already introducing the sym-lib-table. If we
> waited until v6 to make this change, then we would break *both*
> tables (instead of just one).
>  
> 
> 
> I'm OK with the progress dialog.  If you split that out as
> separate
> patch, I will merge it.
> 
> Cheers,
> 
> Wayne
> 
> On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> > On 15/11/17 15:30, Maciej Suminski wrote:
> >> Hi Oliver,
> >>
> >> Thank you for restoring the progress bar dialog. While
> the library load
> >> time has recently decreased a lot, the UI freeze still
> happens with long
> >> library lists.
> >> Disclaimer: I have not looked at the code yet, I am just
> praising the idea.
> >>
> >> As you are looking on the Symbol Library Table dialog, I
> suppose you
> >> might be also tempted to add a file browser to add new
> libraries. If
> >> that is the case, please refrain from doing so - it is
> done in the
> >> library editor refactor branch. If you had no such
> intention, then
> >> simply ignore this message.
> >
> > Hi Olivier & Orson,
> >
> > I partially implemented the simplified dialog I proposed
> on the dev list
> > a few days ago. Would anyone be interested in helping me
> finish it?
> >
> > Tom
> >
> >>
> >> Cheers,
> >> Orson
> >>
> >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
> >>> Wayne, et al,
> >>>
> >>> I am really liking the way that the new symbol table
> works! Thanks for
> >>> the huge effort that has gone into this.
> >>>
> >>> One thing that I have noticed is that when opening (for
> e.g.) the
> >>> component chooser, the UI hangs while all the libraries
> load. Previously
> >>> there was a progress dialog which at least informed the
> user what was
> >>> going on.
> >>>
> >>> I have re-implemented this dialog in the attached patch set.
> >>>
> >>> Further, I have also implemented a way to individually
> enable / disable
> >>> each row in the library tables (this works for
> SYMBOL_LIB and FP_LIB).
> >>>
> >>> This is based on the idea by Tomasz. Example screenshot
> below:
> >>>
> >>

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Fabrizio Tappero]

Hi Guys,
hum... my version of kicad is a nightly buid that I heavily use at work and
that keep update every now and then. Probably all this started a two years
ago or so.

I have deleted the lib table and let kicad propose the new one so now all
is fine.

The only problem I experienced is that the "RESCUE" rename action has
screwed up all my schematics. Thank god git was made.

I noticed some lib issues with the cache lib file that trigger a rescue
menu too. I am sorry I cant really ping point the problem. I just wanted to
get this email out there for future reference. I realise however that I am
not really providing good info

cheers
Fabrizio




On Wed, Nov 15, 2017 at 10:42 PM, Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

>
> On Thu, Nov 16, 2017 at 1:42 AM, Wayne Stambaugh 
> wrote:
>
>> Gentlemen,
>>
>> I'm not sure about breaking the library table file format for the
>> version 5 release.  If we do, the footprint library table will not be
>> compatible with older versions.  I would prefer that we push this change
>> into version 6.
>>
>
> I'm not sure I understand why it would be ok to break it in v6 but not v5?
> We are already introducing the sym-lib-table. If we waited until v6 to make
> this change, then we would break *both* tables (instead of just one).
>
>
>>
>> I'm OK with the progress dialog.  If you split that out as separate
>> patch, I will merge it.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
>> > On 15/11/17 15:30, Maciej Suminski wrote:
>> >> Hi Oliver,
>> >>
>> >> Thank you for restoring the progress bar dialog. While the library load
>> >> time has recently decreased a lot, the UI freeze still happens with
>> long
>> >> library lists.
>> >> Disclaimer: I have not looked at the code yet, I am just praising the
>> idea.
>> >>
>> >> As you are looking on the Symbol Library Table dialog, I suppose you
>> >> might be also tempted to add a file browser to add new libraries. If
>> >> that is the case, please refrain from doing so - it is done in the
>> >> library editor refactor branch. If you had no such intention, then
>> >> simply ignore this message.
>> >
>> > Hi Olivier & Orson,
>> >
>> > I partially implemented the simplified dialog I proposed on the dev list
>> > a few days ago. Would anyone be interested in helping me finish it?
>> >
>> > Tom
>> >
>> >>
>> >> Cheers,
>> >> Orson
>> >>
>> >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
>> >>> Wayne, et al,
>> >>>
>> >>> I am really liking the way that the new symbol table works! Thanks for
>> >>> the huge effort that has gone into this.
>> >>>
>> >>> One thing that I have noticed is that when opening (for e.g.) the
>> >>> component chooser, the UI hangs while all the libraries load.
>> Previously
>> >>> there was a progress dialog which at least informed the user what was
>> >>> going on.
>> >>>
>> >>> I have re-implemented this dialog in the attached patch set.
>> >>>
>> >>> Further, I have also implemented a way to individually enable /
>> disable
>> >>> each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
>> >>>
>> >>> This is based on the idea by Tomasz. Example screenshot below:
>> >>>
>> >>> Inline image 1
>> >>>
>> >>> I have tweaked the base LIB_TABLE_GRID code such that disabled entries
>> >>> are greyed out and made italic. The enabled / disabled status is
>> >>> persistent in the sym/fp_lib_table files. Older version of
>> xxx_lib_table
>> >>> files are read with all rows enabled by default.
>> >>>
>> >>> Please find patch set attached.
>> >>>
>> >>> Regards,
>> >>> Oliver
>> >>>
>> >>>
>> >>>
>> >>> ___
>> >>> Mailing list: https://launchpad.net/~kicad-developers
>> >>> Post to : kicad-developers@lists.launchpad.net
>> >>> Unsubscribe : https://launchpad.net/~kicad-developers
>> >>> More help   : https://help.launchpad.net/ListHelp
>> >>>
>> >>
>> >> ___
>> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> Post to : kicad-developers@lists.launchpad.net
>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> More help   : https://help.launchpad.net/ListHelp
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> Mo

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Oliver Walters]

On Thu, Nov 16, 2017 at 1:42 AM, Wayne Stambaugh 
wrote:

> Gentlemen,
>
> I'm not sure about breaking the library table file format for the
> version 5 release.  If we do, the footprint library table will not be
> compatible with older versions.  I would prefer that we push this change
> into version 6.
>

I'm not sure I understand why it would be ok to break it in v6 but not v5?
We are already introducing the sym-lib-table. If we waited until v6 to make
this change, then we would break *both* tables (instead of just one).


>
> I'm OK with the progress dialog.  If you split that out as separate
> patch, I will merge it.
>
> Cheers,
>
> Wayne
>
> On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> > On 15/11/17 15:30, Maciej Suminski wrote:
> >> Hi Oliver,
> >>
> >> Thank you for restoring the progress bar dialog. While the library load
> >> time has recently decreased a lot, the UI freeze still happens with long
> >> library lists.
> >> Disclaimer: I have not looked at the code yet, I am just praising the
> idea.
> >>
> >> As you are looking on the Symbol Library Table dialog, I suppose you
> >> might be also tempted to add a file browser to add new libraries. If
> >> that is the case, please refrain from doing so - it is done in the
> >> library editor refactor branch. If you had no such intention, then
> >> simply ignore this message.
> >
> > Hi Olivier & Orson,
> >
> > I partially implemented the simplified dialog I proposed on the dev list
> > a few days ago. Would anyone be interested in helping me finish it?
> >
> > Tom
> >
> >>
> >> Cheers,
> >> Orson
> >>
> >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
> >>> Wayne, et al,
> >>>
> >>> I am really liking the way that the new symbol table works! Thanks for
> >>> the huge effort that has gone into this.
> >>>
> >>> One thing that I have noticed is that when opening (for e.g.) the
> >>> component chooser, the UI hangs while all the libraries load.
> Previously
> >>> there was a progress dialog which at least informed the user what was
> >>> going on.
> >>>
> >>> I have re-implemented this dialog in the attached patch set.
> >>>
> >>> Further, I have also implemented a way to individually enable / disable
> >>> each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
> >>>
> >>> This is based on the idea by Tomasz. Example screenshot below:
> >>>
> >>> Inline image 1
> >>>
> >>> I have tweaked the base LIB_TABLE_GRID code such that disabled entries
> >>> are greyed out and made italic. The enabled / disabled status is
> >>> persistent in the sym/fp_lib_table files. Older version of
> xxx_lib_table
> >>> files are read with all rows enabled by default.
> >>>
> >>> Please find patch set attached.
> >>>
> >>> Regards,
> >>> Oliver
> >>>
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Where did you get your symbol library table file from?
${KICAD_SYS_SYMBOL_DIR} is not correct.  It should be
${KICAD_SYMBOL_DIR}.  This is the environment variable used in the
default library table at
https://github.com/KiCad/kicad-library/blob/master/template/sym-lib-table


On 11/15/2017 12:05 PM, Fabrizio Tappero wrote:
> Hi,
> I am not sure what the problem is but after a recent nightly build
> update I have lost all my schematic libs. This is the lib table config
> 
> ​Inline image 1​
> 
> all lib files are in /usr/share/kicad/library but when I add components
> to a new schematic no libraries gets loaded.
> 
> Can anybody help?
> 
> cheers
> Fabrizio
> 
> 
> 
> On Wed, Nov 15, 2017 at 3:42 PM, Wayne Stambaugh  > wrote:
> 
> Gentlemen,
> 
> I'm not sure about breaking the library table file format for the
> version 5 release.  If we do, the footprint library table will not be
> compatible with older versions.  I would prefer that we push this change
> into version 6.
> 
> I'm OK with the progress dialog.  If you split that out as separate
> patch, I will merge it.
> 
> Cheers,
> 
> Wayne
> 
> On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> > On 15/11/17 15:30, Maciej Suminski wrote:
> >> Hi Oliver,
> >>
> >> Thank you for restoring the progress bar dialog. While the
> library load
> >> time has recently decreased a lot, the UI freeze still happens
> with long
> >> library lists.
> >> Disclaimer: I have not looked at the code yet, I am just praising
> the idea.
> >>
> >> As you are looking on the Symbol Library Table dialog, I suppose you
> >> might be also tempted to add a file browser to add new libraries. If
> >> that is the case, please refrain from doing so - it is done in the
> >> library editor refactor branch. If you had no such intention, then
> >> simply ignore this message.
> >
> > Hi Olivier & Orson,
> >
> > I partially implemented the simplified dialog I proposed on the
> dev list
> > a few days ago. Would anyone be interested in helping me finish it?
> >
> > Tom
> >
> >>
> >> Cheers,
> >> Orson
> >>
> >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
> >>> Wayne, et al,
> >>>
> >>> I am really liking the way that the new symbol table works!
> Thanks for
> >>> the huge effort that has gone into this.
> >>>
> >>> One thing that I have noticed is that when opening (for e.g.) the
> >>> component chooser, the UI hangs while all the libraries load.
> Previously
> >>> there was a progress dialog which at least informed the user
> what was
> >>> going on.
> >>>
> >>> I have re-implemented this dialog in the attached patch set.
> >>>
> >>> Further, I have also implemented a way to individually enable /
> disable
> >>> each row in the library tables (this works for SYMBOL_LIB and
> FP_LIB).
> >>>
> >>> This is based on the idea by Tomasz. Example screenshot below:
> >>>
> >>> Inline image 1
> >>>
> >>> I have tweaked the base LIB_TABLE_GRID code such that disabled
> entries
> >>> are greyed out and made italic. The enabled / disabled status is
> >>> persistent in the sym/fp_lib_table files. Older version of
> xxx_lib_table
> >>> files are read with all rows enabled by default.
> >>>
> >>> Please find patch set attached.
> >>>
> >>> Regards,
> >>> Oliver
> >>>
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> 
> >>> Post to : kicad-developers@lists.launchpad.net
> 
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >>> More help   : https://help.launchpad.net/ListHelp
> 
> >>>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> 
> >> Post to : kicad-developers@lists.launchpad.net
> 
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >> More help   : https://help.launchpad.net/ListHelp
> 
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
>   

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Simon Wells]

please see KICAD_SYS_SYMBOL_DIR != KICAD_SYMBOL_DIR


> On 16/11/2017, at 06:05, Fabrizio Tappero  wrote:
> 
> Hi,
> I am not sure what the problem is but after a recent nightly build update I 
> have lost all my schematic libs. This is the lib table config
> 
> ​​
> 
> all lib files are in /usr/share/kicad/library but when I add components to a 
> new schematic no libraries gets loaded.
> 
> Can anybody help?
> 
> cheers
> Fabrizio
> 
> 
> 
> On Wed, Nov 15, 2017 at 3:42 PM, Wayne Stambaugh  > wrote:
> Gentlemen,
> 
> I'm not sure about breaking the library table file format for the
> version 5 release.  If we do, the footprint library table will not be
> compatible with older versions.  I would prefer that we push this change
> into version 6.
> 
> I'm OK with the progress dialog.  If you split that out as separate
> patch, I will merge it.
> 
> Cheers,
> 
> Wayne
> 
> On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> > On 15/11/17 15:30, Maciej Suminski wrote:
> >> Hi Oliver,
> >>
> >> Thank you for restoring the progress bar dialog. While the library load
> >> time has recently decreased a lot, the UI freeze still happens with long
> >> library lists.
> >> Disclaimer: I have not looked at the code yet, I am just praising the idea.
> >>
> >> As you are looking on the Symbol Library Table dialog, I suppose you
> >> might be also tempted to add a file browser to add new libraries. If
> >> that is the case, please refrain from doing so - it is done in the
> >> library editor refactor branch. If you had no such intention, then
> >> simply ignore this message.
> >
> > Hi Olivier & Orson,
> >
> > I partially implemented the simplified dialog I proposed on the dev list
> > a few days ago. Would anyone be interested in helping me finish it?
> >
> > Tom
> >
> >>
> >> Cheers,
> >> Orson
> >>
> >> On 15/11/2017 12:41 PM, Oliver Walters wrote:
> >>> Wayne, et al,
> >>>
> >>> I am really liking the way that the new symbol table works! Thanks for
> >>> the huge effort that has gone into this.
> >>>
> >>> One thing that I have noticed is that when opening (for e.g.) the
> >>> component chooser, the UI hangs while all the libraries load. Previously
> >>> there was a progress dialog which at least informed the user what was
> >>> going on.
> >>>
> >>> I have re-implemented this dialog in the attached patch set.
> >>>
> >>> Further, I have also implemented a way to individually enable / disable
> >>> each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
> >>>
> >>> This is based on the idea by Tomasz. Example screenshot below:
> >>>
> >>> Inline image 1
> >>>
> >>> I have tweaked the base LIB_TABLE_GRID code such that disabled entries
> >>> are greyed out and made italic. The enabled / disabled status is
> >>> persistent in the sym/fp_lib_table files. Older version of xxx_lib_table
> >>> files are read with all rows enabled by default.
> >>>
> >>> Please find patch set attached.
> >>>
> >>> Regards,
> >>> Oliver
> >>>
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers 
> >>> 
> >>> Post to : kicad-developers@lists.launchpad.net 
> >>> 
> >>> Unsubscribe : https://launchpad.net/~kicad-developers 
> >>> 
> >>> More help   : https://help.launchpad.net/ListHelp 
> >>> 
> >>>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers 
> >> 
> >> Post to : kicad-developers@lists.launchpad.net 
> >> 
> >> Unsubscribe : https://launchpad.net/~kicad-developers 
> >> 
> >> More help   : https://help.launchpad.net/ListHelp 
> >> 
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers 
> > 
> > Post to : kicad-developers@lists.launchpad.net 
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers 
> > 
> > More help   : https://help.launchpad.net/ListHelp 
> > 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> 
> ___
> Mailing list: https://launchpad.ne

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Wayne Stambaugh]

Gentlemen,

I'm not sure about breaking the library table file format for the
version 5 release.  If we do, the footprint library table will not be
compatible with older versions.  I would prefer that we push this change
into version 6.

I'm OK with the progress dialog.  If you split that out as separate
patch, I will merge it.

Cheers,

Wayne

On 11/15/2017 9:38 AM, Tomasz Wlostowski wrote:
> On 15/11/17 15:30, Maciej Suminski wrote:
>> Hi Oliver,
>>
>> Thank you for restoring the progress bar dialog. While the library load
>> time has recently decreased a lot, the UI freeze still happens with long
>> library lists.
>> Disclaimer: I have not looked at the code yet, I am just praising the idea.
>>
>> As you are looking on the Symbol Library Table dialog, I suppose you
>> might be also tempted to add a file browser to add new libraries. If
>> that is the case, please refrain from doing so - it is done in the
>> library editor refactor branch. If you had no such intention, then
>> simply ignore this message.
> 
> Hi Olivier & Orson,
> 
> I partially implemented the simplified dialog I proposed on the dev list
> a few days ago. Would anyone be interested in helping me finish it?
> 
> Tom
> 
>>
>> Cheers,
>> Orson
>>
>> On 15/11/2017 12:41 PM, Oliver Walters wrote:
>>> Wayne, et al,
>>>
>>> I am really liking the way that the new symbol table works! Thanks for
>>> the huge effort that has gone into this.
>>>
>>> One thing that I have noticed is that when opening (for e.g.) the
>>> component chooser, the UI hangs while all the libraries load. Previously
>>> there was a progress dialog which at least informed the user what was
>>> going on.
>>>
>>> I have re-implemented this dialog in the attached patch set.
>>>
>>> Further, I have also implemented a way to individually enable / disable
>>> each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
>>>
>>> This is based on the idea by Tomasz. Example screenshot below:
>>>
>>> Inline image 1
>>>
>>> I have tweaked the base LIB_TABLE_GRID code such that disabled entries
>>> are greyed out and made italic. The enabled / disabled status is
>>> persistent in the sym/fp_lib_table files. Older version of xxx_lib_table
>>> files are read with all rows enabled by default.
>>>
>>> Please find patch set attached.
>>>
>>> Regards,
>>> Oliver
>>>
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Tomasz Wlostowski]

On 15/11/17 15:30, Maciej Suminski wrote:
> Hi Oliver,
> 
> Thank you for restoring the progress bar dialog. While the library load
> time has recently decreased a lot, the UI freeze still happens with long
> library lists.
> Disclaimer: I have not looked at the code yet, I am just praising the idea.
> 
> As you are looking on the Symbol Library Table dialog, I suppose you
> might be also tempted to add a file browser to add new libraries. If
> that is the case, please refrain from doing so - it is done in the
> library editor refactor branch. If you had no such intention, then
> simply ignore this message.

Hi Olivier & Orson,

I partially implemented the simplified dialog I proposed on the dev list
a few days ago. Would anyone be interested in helping me finish it?

Tom

> 
> Cheers,
> Orson
> 
> On 15/11/2017 12:41 PM, Oliver Walters wrote:
>> Wayne, et al,
>>
>> I am really liking the way that the new symbol table works! Thanks for
>> the huge effort that has gone into this.
>>
>> One thing that I have noticed is that when opening (for e.g.) the
>> component chooser, the UI hangs while all the libraries load. Previously
>> there was a progress dialog which at least informed the user what was
>> going on.
>>
>> I have re-implemented this dialog in the attached patch set.
>>
>> Further, I have also implemented a way to individually enable / disable
>> each row in the library tables (this works for SYMBOL_LIB and FP_LIB).
>>
>> This is based on the idea by Tomasz. Example screenshot below:
>>
>> Inline image 1
>>
>> I have tweaked the base LIB_TABLE_GRID code such that disabled entries
>> are greyed out and made italic. The enabled / disabled status is
>> persistent in the sym/fp_lib_table files. Older version of xxx_lib_table
>> files are read with all rows enabled by default.
>>
>> Please find patch set attached.
>>
>> Regards,
>> Oliver
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

[Maciej Suminski]

Hi Oliver,

Thank you for restoring the progress bar dialog. While the library load 
time has recently decreased a lot, the UI freeze still happens with long 
library lists.

Disclaimer: I have not looked at the code yet, I am just praising the idea.

As you are looking on the Symbol Library Table dialog, I suppose you 
might be also tempted to add a file browser to add new libraries. If 
that is the case, please refrain from doing so - it is done in the 
library editor refactor branch. If you had no such intention, then 
simply ignore this message.


Cheers,
Orson

On 15/11/2017 12:41 PM, Oliver Walters wrote:

Wayne, et al,

I am really liking the way that the new symbol table works! Thanks for
the huge effort that has gone into this.

One thing that I have noticed is that when opening (for e.g.) the
component chooser, the UI hangs while all the libraries load. Previously
there was a progress dialog which at least informed the user what was
going on.

I have re-implemented this dialog in the attached patch set.

Further, I have also implemented a way to individually enable / disable
each row in the library tables (this works for SYMBOL_LIB and FP_LIB).

This is based on the idea by Tomasz. Example screenshot below:

Inline image 1

I have tweaked the base LIB_TABLE_GRID code such that disabled entries
are greyed out and made italic. The enabled / disabled status is
persistent in the sym/fp_lib_table files. Older version of xxx_lib_table
files are read with all rows enabled by default.

Please find patch set attached.

Regards,
Oliver



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp