[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Srdjan Jankovic changed: What|Removed |Added Attachment #22667|0 |1 is obsolete|| --- Comment #17 from Srdjan Jankovic --- Created attachment 22806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22806&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Srdjan Jankovic changed: What|Removed |Added Attachment #22665|0 |1 is obsolete|| --- Comment #16 from Srdjan Jankovic --- Created attachment 22805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22805&action=edit bug_11077: get rid of some warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #8 from Katrin Fischer --- Created attachment 22804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22804&action=edit Bug 11218: QA follow-up - Fixing some whitespace and a variable declaration Fixing some things the QA script pointed out this morning: - whitespace - variable declaration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What|Removed |Added Attachment #22796|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #7 from Liz Rea --- Created attachment 22803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22803&action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea Passes functional tests and automated tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7567] News by Library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #2 from M. Tompsett --- Refactored, Enhanced, and Fixed. I'm tempted to rename this to "Overhaul of News". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What|Removed |Added Attachment #22795|0 |1 is obsolete|| --- Comment #6 from Liz Rea --- Created attachment 22802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22802&action=edit y# Attachment to Bug 11218 - Due notices broken / not generated Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What|Removed |Added Attachment #22795|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What|Removed |Added Attachment #22796|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What|Removed |Added Attachment #22799|0 |1 is obsolete|| CC||l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7567] News by Library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What|Removed |Added CC|mtomp...@hotmail.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8396] back to results in catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8396 Bob Birchall changed: What|Removed |Added CC||b...@calyx.net.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What|Removed |Added Attachment #22794|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #3 from M. Tompsett --- Created attachment 22801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22801&action=edit [SIGNED OFF] bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What|Removed |Added Priority|P5 - low|P3 --- Comment #2 from Srdjan Jankovic --- This may yield significant improvements in performance. Hairy spots: * I have removed GetItemsLocationInfo() in favour of GetItemsInfo(). In case of people not using XSLT, it may incur small penalty in virtual shelves because GetItemsInfo() is a tad heavier. However, it should be insignificant compared to the benefit when XSLT is used. * I wish I knew more about Koha internals. Because then I could have more confidence in saying that items info gathered in searchResults() is sufficient for building the display. It looked fine to me, but still I need someone more knowledgeable to confirm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #1 from Srdjan Jankovic --- Created attachment 22800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22800&action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - removed GetItemsLocationInfo() - added sort_by input param to GetItemsInfo() - VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call with GetItemsInfo() call, passing order_by "cn_sort" * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What|Removed |Added Attachment #22795|0 |1 is obsolete|| Attachment #22796|0 |1 is obsolete|| --- Comment #5 from Liz Rea --- Created attachment 22799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22799&action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea Passes functional and automated testing. Due notice functionality restored. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 --- Comment #2 from Peggy Thrasher --- Created attachment 22798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22798&action=edit Bug 11040 Add option to print regular slip to CircAutoPrintQuickSlip -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Peggy Thrasher changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |p.thras...@dover.nh.gov |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 --- Comment #1 from Peggy Thrasher --- Created attachment 22797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22797&action=edit Test Plan for 11040 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | --- Comment #4 from Katrin Fischer --- In my tests this seems to work now with the patches applied, please test thorougly and feedback welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #3 from Katrin Fischer --- Created attachment 22796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22796&action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #2 from Katrin Fischer --- Created attachment 22795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22795&action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What|Removed |Added Attachment #22663|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic --- Created attachment 22794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22794&action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #16 from Katrin Fischer --- As the advance_notice.pl script also procudes the DUE notices, the assumption that issues due today should not be selected is not correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11218 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9362 --- Comment #1 from Katrin Fischer --- As it worked before I tried tracking the problem down with git bisect - it came up with the changes from bug 9362 which looks plausible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] New: Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Bug ID: 11218 Summary: Due notices broken / not generated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org After updating a library we found due notices (send on the date a book is due) are no longer being generated. This bug is in 3.12.5 and I confirmed it's also a valid bug in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Attachment #22782|0 |1 is obsolete|| --- Comment #16 from mathieu saby --- Created attachment 22793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22793&action=edit [PATCH 2] Bug 9807 : Followup fixing variable name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Attachment #22781|0 |1 is obsolete|| --- Comment #15 from mathieu saby --- Created attachment 22792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22792&action=edit [PATCH ] Bug 9807 : Make possible to view a basketgroup without reopening it Patch rewritten to eliminate reindenting Should be more easy to understand. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #14 from mathieu saby --- Jonathan, I will rewrite the patch without any reindenting. I think it will be more easy to understand for QA team. As reindenting is needed for code readabiliy, it will add a followup for it. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #16 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #12 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #15 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > Kyle, why do you add the new field issue_id? You don't use it in your code. > I mark this patch as failed QA. I did't test it but you modify the structure > of the issues table without modifying the old_issues table. The issue's table needs a primary key in order to fetch related rows via DBIx::Class. I'm not sure where you say I'm not modifying the old_issues table. I see my changes in both updastedatabase.pl and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Attachment #21145|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 22791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22791&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11217] New: The # in accountlines descriptions makes them un-writeoffable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Bug ID: 11217 Summary: The # in accountlines descriptions makes them un-writeoffable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The # symbol in a description for a fine/charge makes it so that clicking write off doesn't work. It will put a write off line in the table, but it won't clear the amount owed on the find line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
Olli-Antti Kivilahti changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||olli-antti.kivila...@jns.fi
--- Comment #19 from Olli-Antti Kivilahti ---
-
-- Letters.t --
-
All test complete! Awsum!
--
-- Overdues.t --
--
"my" variable $mtts masks earlier declaration in same scope
+
line 50: my $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);
Should be
line 50: $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);
DBD::mysql::db do failed: Cannot add or update a child row: a foreign key
constraint fails (`kohadata`.`overduerules_transport_types`, CONSTRAINT
`overduerules_fk` FOREIGN KEY (`branchcode`, `categorycode`) REFERENCES
`overduerules` (`branchcode`, `categorycode`) ON DELETE CASCADE ON) at
/home/kivilahtio/koha/kohaclone/t/db_dependent/Overdues.t line 23.
+
koha.overduerules-table is missing the branchcode and patron.categorycode
definitions you are trying to link to with
line 24: INSERT INTO overduerules_transport_types( branchcode, categorycode,
letternumber, message_transport_type ) VALUES
('CPL', 'PT', 1, 'email'),
After adding a definition via tools/overduerules.pl for branch CPL for patron
PT, the given SQL element works (not the whole clause).
Should be included in the test case.
---
-- Overdues.pm --
---
at GetOverdueMessageTransportTypes()
"return a arrayref with message_transport_type for given branchcode,
categorycode and letternumber(1,2 or 3)"
Should be
"return a arrayref with all message_transport_types for given branchcode,
categorycode and letternumber(1,2 or 3)"
Should GetOverdueMessageTransportTypes() also take into account the default
values? When library branch specific rules are not set then the function could
return the default values instead?
-
-- tools/overduerules.pl --
-
Adding definitions seems to work pretty well. Will test more tomorrow. Good
work with this one!
Failed QA because Overdues.t needs improvement.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart --- Kyle, why do you add the new field issue_id? You don't use it in your code. I mark this patch as failed QA. I did't test it but you modify the structure of the issues table without modifying the old_issues table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What|Removed |Added Attachment #22789|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 22790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22790&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #26 from Jonathan Druart --- Tomás, you will win a bonus point if you provide a patch for the bootstrap theme :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #6 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #7 from sandbo...@biblibre.com --- Created attachment 22789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22789&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 sandbo...@biblibre.com changed: What|Removed |Added Attachment #22783|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What|Removed |Added Attachment #21897|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 22788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22788&action=edit Bug 10987: Too many 'see also' and 'see from' labels occurences If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as decribed. No koha-qa errors Nice view on staff and both opac Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- Tested with bug 10691. Works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What|Removed |Added Attachment #22213|0 |1 is obsolete|| Attachment #22214|0 |1 is obsolete|| Attachment #22215|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 22785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22785&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list [Staff] This patch changes the URL and data used to show the 'see also' links on the Staff's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a entries with plain text (i.e. no linking) - Make sure zebra is running and changes got indexed. - In the staff interface search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id for linked authorities, and to an authority search result in the case of plain text entries. - Check that the authority search from the cataloguing interface still works as usual. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #25 from Jonathan Druart --- Created attachment 22787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22787&action=edit Bug 10691: Small glitch fixed A small glitch prevented 'see from' headings to show. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #24 from Jonathan Druart --- Created attachment 22786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22786&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list This patch changes the URL and data used to show the 'see also' links on the OPAC's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a without linking (i.e. plain text) - Make sure zebra is running and changes got indexed. - In the OPAC search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id in the case of linked authorities, and to an authority search in the case of plain text names. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #22 from Jonathan Druart --- QA comment: I tested on a sandbox and did not find the link issue. Links for "see also" have the expected behavior. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #6 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 sandbo...@biblibre.com changed: What|Removed |Added Attachment #22778|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #7 from sandbo...@biblibre.com --- Created attachment 22784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22784&action=edit Bug 11126 - Make the holds system optionally give precedence to local holds This feature will allow libraries to specify that, when an item is returned, a local hold may be given priority for fulfillment even though it is of lower priority in the list of unfilled holds. This feature has three settings: * LocalHoldsPriority, which enables the feature * LocalHoldsPriorityPatronControl, which selects for either tha patron's home library, or the patron's pickup library for the hold * LocalHoldsPriorityItemControl, which selects for either the item's holding library, or home library. So, this feature can "give priority for filling holds to patrons whose (home library|pickup library) matches the item's (home library|holding library)" Test Plan: 1) Apply this patch 2) Run t/db_dependent/Holds/LocalHoldsPriority.t Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 marjorie barry-vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Paola Rossi changed: What|Removed |Added CC||paola.ro...@cineca.it --- Comment #16 from Paola Rossi --- Kind Mathieu Saby, I install master 3.13.00.042 choosing ICU, DOM, unimarc, as required, and the Italian version of koha. A problem appears at 5-th step of the test plan, with this warning messagge: ./rebuild_zebra.pl -r -b -x -v Zebra configuration information Zebra biblio directory = /home/koha/bug-11202/var/lib/zebradb/biblios Zebra authorities directory = /home/koha/bug-11202/var/lib/zebradb/authorities Koha directory = /var/root-koha/bug-11202 BIBLIONUMBER in : 001$@ BIBLIOITEMNUMBER in : 090$a skipping authorities exporting biblio 1 Records exported: 1 REINDEXING zebra 16:35:52-07/11 zebraidx(9494) [warn] /home/koha/bug-11202/etc/zebradb/biblios/etc/dom-config.xml: could not parse xslt stylesheet /home/koha/bug-11202/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl 16:35:52-07/11 zebraidx(9494) [warn] /home/koha/bug-11202/etc/zebradb/biblios/etc/dom-config.xml: could not parse xslt stylesheet /home/koha/bug-11202/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl CLEANING Then the search answers erroneously zero findings. Can you help me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What|Removed |Added Attachment #22772|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 22783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22783&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Dobrica Pavlinusic changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dpav...@rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11216] New: Patron modification creates indefinite manual restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Bug ID: 11216 Summary: Patron modification creates indefinite manual restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dpav...@rot13.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #11 from mathieu saby --- The closedbg variable passed to template is used to decide if the bg must be only displayed, or make editable. By the way, I've remarked a typo : "closedgb" for "closedbg". I'm writing a followup. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #13 from mathieu saby --- Created attachment 22782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22782&action=edit [PATCH 2] Bug 9807 : Followup fixing variable name Fixing closedbg name in template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Attachment #22023|0 |1 is obsolete|| --- Comment #12 from mathieu saby --- Created attachment 22781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22781&action=edit [PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it Main patch rebased (little conflict) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2693] Tagging: Add filter by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #7 from Jonathan Druart --- QA comment: I reproduced the error described by David, but just one time. I don't think it is critical. However, the autocomplete is often dependent on the CircAutocompl pref (request.tt, patron search header), but not always (patron list, course reserve). Since we are not in the circulation module, maybe this pref should not be check. But I suppose this pref exists in order to avoid performance issue. I am leaning towards to mark as passed QA this patch but I let the last word to the RM (as always, of course ;)) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2693] Tagging: Add filter by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Jonathan Druart changed: What|Removed |Added Attachment #22289|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 22780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22780&action=edit Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. Signed-off-by: David Cook Patch works as described. I'm not sure whether or not it would be better to be able to search by name, as that would involve either choosing between names after applying the filter or showing any possible matches, so this seems fine. -- Owen and I did observe that we were able to cause AJAX errors while using this autocomplete, but we are not 100% sure how we caused the error. In my case, I was able to occasionally cause it by typing in a name then backspacing rapidly. The ajaxError method is attached to every element in the DOM (yikes) so it's tough to say what exactly is the source of the error (which is signalled by a pop-up window that can be cancelled). The error is quite rare so I don't think it's necessarily a problem for us. One idea that Owen had was to remove the current error message, which is very unhelpful and replace it with an error like "Something went wrong. Try again." Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #10 from mathieu saby --- > 2/ The view "show" is not clear in the code. Personally, I don't understand > anything. Could you specify what you call the view "show" ? I don't find the "show" word in my patch. > 3/ There is some useless loop: > [% FOREACH billingplaceloo IN billingplaceloop %] > [% IF ( billingplaceloo.selected ) %] > [% billingplaceloo.branchname %] > [% END %] > [% END %] > It is not a logic way to display an input. This unless loop was here before my patch. So I kept it here. It was not my goal to remove it. But it can be fixed later. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #9 from mathieu saby --- (In reply to Jonathan Druart from comment #8) > I am a little bit disconcerted. > The aqbasketgroup.tt is really dirty and it is not easy to do something in > it. => so true. it's horrible. And very hard to understand without reindenting... > But this patch is not really clear: > 1/ I don't know if to add a lot of simple comment is useful (in the pl file). It was usefull for me, to understand how the file was structured. But I can suppress comments if they are unneeded. > 4/ There is a mix between new code and indentation fixes (use the -w option > for git show). For me reindentation were logical, because I add a new condition in the template (l. 147:[% IF (closedbg) %] ), so I felt free to reindent For the other points, I cannot answer quickly, and must watch it closely. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #12 from Matthias Meusburger ---
Hello,
Thanks Matin, for rebasing my patch, and providing a test plan :)
One thing though, using $ENV{'SERVER_NAME'} is not such a good idea imho,
because it won't work if koha is behind a reverse proxy.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11107] Label in staff client - authors on facets not easily accessible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107 Jonathan Druart changed: What|Removed |Added CC||maddogwils...@gmail.com --- Comment #5 from Jonathan Druart --- *** Bug 11103 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11103] label authors in facets not easy selectable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11103 Jonathan Druart changed: What|Removed |Added Status|Signed Off |RESOLVED CC||jonathan.dru...@biblibre.co ||m Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- Same patch already pushed to master. *** This bug has been marked as a duplicate of bug 11107 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10809] use template branches plugin in serials search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10809] use template branches plugin in serials search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart --- Simple patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10809] use template branches plugin in serials search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Jonathan Druart changed: What|Removed |Added Attachment #22024|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 22779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22779&action=edit Bug 10809 - use template branches plugin in serials search In serials-search.pl, branch name is computed using branch code and then passed to template. This patch uses the new template plugin now for this : Koha::Template::Plugin::Branches. Test plan : - Go to serials search - Perform a search that returns at least an open an a closed subscription having a branch defined => The branch name is displayed in "Library" column Signed-off-by: Pierre Angot Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart --- I am a little bit disconcerted. The aqbasketgroup.tt is really dirty and it is not easy to do something in it. But this patch is not really clear: 1/ I don't know if to add a lot of simple comment is useful (in the pl file). 2/ The view "show" is not clear in the code. Personally, I don't understand anything. 3/ There is some useless loop: [% FOREACH billingplaceloo IN billingplaceloop %] [% IF ( billingplaceloo.selected ) %] [% billingplaceloo.branchname %] [% END %] [% END %] It is not a logic way to display an input. 4/ There is a mix between new code and indentation fixes (use the -w option for git show). 5/ There is no "show" view for the opened bg. And for the closed bd, the "show" view is accessible on click on a button. Why there is no a simple "show" op and a link on the bg name? I let someone else from the QA team to give his/her opinion on this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Kyle M Hall changed: What|Removed |Added Attachment #22543|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 22778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22778&action=edit Bug 11126 - Make the holds system optionally give precedence to local holds This feature will allow libraries to specify that, when an item is returned, a local hold may be given priority for fulfillment even though it is of lower priority in the list of unfilled holds. This feature has three settings: * LocalHoldsPriority, which enables the feature * LocalHoldsPriorityPatronControl, which selects for either tha patron's home library, or the patron's pickup library for the hold * LocalHoldsPriorityItemControl, which selects for either the item's holding library, or home library. So, this feature can "give priority for filling holds to patrons whose (home library|pickup library) matches the item's (home library|holding library)" Test Plan: 1) Apply this patch 2) Run t/db_dependent/Holds/LocalHoldsPriority.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #5 from Jonathan Druart --- I forgot the dependency! Sorry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- Tomás, the patch does not apply anymore, could you rebase it please? fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 --- Comment #29 from Jonathan Druart --- (forgot to remove the coma at the end of the syspref.sql file) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What|Removed |Added Attachment #22776|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 22777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22777&action=edit Bug 10986: QA followup This patch fixes some qa issues: FAIL C4/Languages.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: merge marker (<<<) (line 7157) FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs AdvancedSearchLanguages is bad placed (see bug 10610) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What|Removed |Added Attachment #22775|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 22776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22776&action=edit Bug 10986: QA followup This patch fixes some qa issues: FAIL C4/Languages.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: merge marker (<<<) (line 7157) FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs AdvancedSearchLanguages is bad placed (see bug 10610) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 --- Comment #26 from Jonathan Druart --- Created attachment 22775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22775&action=edit Bug 10986: QA followup This patch fixes some qa issues: FAIL C4/Languages.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: merge marker (<<<) (line 7157) FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs AdvancedSearchLanguages is bad placed (see bug 10610) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What|Removed |Added Attachment #21856|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 22774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22774&action=edit Bugs 10986 - Limit the list of languages in advanced search In Advanced Search, the list of available language is long and will only get longer. For a library offering books in 2-3 languages, that is offering too much info to the user (most of the small libraries we deal with only offer documents in two languages). Code changes: Languages.pm: Extract getAllLanguages to make a more customizable getLanguages (have getAllLanguage call it, so rest of codebase is oblivious to the change). Build array returned based on system pref if corresponding argument is set. search.pl and opac-search.pl: call getLanguages instead of getAllLanguages. TESTING 0) All language codes are iso 639-2 (three characters) 1) in OPAC, Advanced search, open Language box, acknowledge 30+ items. 2) in Intranet, go to system preferences AdvancedSearchLanguages, enter "ita|eng" 3) back in OPAC, refresh screen, acknowledge only Italian and English are listed. 4) in Intranet, click Search then click "More options" to make the Language box appear. Acknowledge limited options. 5) Regression Test: Back to the preference, empty the field then save. Go back to the OPAC and Intranet search, refresh the page, then the Language drop-box will now contain 30+ items. Signed-off-by: Mathieu Saby Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #24 from Jonathan Druart --- QA comment: The patch works as expected. The syspref makes sense for me. Some QA issues, I will provide a QA followup. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch complexity|--- |String patch Assignee|paul.poul...@biblibre.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491 M. de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491 --- Comment #2 from M. de Rooy --- Created attachment 22773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22773&action=edit Bug 7491: Description for item-level_itypes is misleading Adding some text to the pref description referring to opac display. Test plan: Look at the new description in Cataloging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What|Removed |Added Attachment #22771|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 22772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22772&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What|Removed |Added Attachment #22770|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 22771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22771&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What|Removed |Added Attachment #22757|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 22770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22770&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 --- Comment #39 from mathieu saby --- (In reply to M. de Rooy from comment #38) > QA Comment: > Works as advertised. Nice to have. > No complaints from qa tools. Code looks good to me. > Includes string changes, so candidate for 3.16. > I am passing QA on these patches, but have some hesitations as to design and > navigation, as described in the following points: > > 1) The design of the page showing that the basket has been deleted, but also > listing a warning c/should look better (layman's perspective :) > 2) This same error page gives me the link Go back to booksellers page (note > the problems reported earlier about its performance). Since I came from a > basket of a specific bookseller, I would rather go back to the basket list > of THAT bookseller. You opened up a new report for that, I understand. I > think that this set of patches would be even more attractive with such a > link. > 3) A successful deletion actually does the same and sends me back to all > booksellers. Please give me my particular bookseller instead :) > > Thanks. > > PS I downgraded the bug severity. I can understand that you feel this is an > important issue, but critical is really another category. Thank you For the points 1-3 it could be improved by other patches ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
