[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 --- Comment #25 from Joonas Kylmälä --- (In reply to Marcel de Rooy from comment #24) > Cant block this one for the stuff mentioned in comment19. Refactor_holds++ Regarding the refactoring, I have already opened some bug reports, e.g. bug 27032. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Owen, Martin, could you help this one (and bug 27610) to avoid unnecessary rebases? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- With but also without this patch I have a test failure on Koha/Biblio.t: # Subtest: AddBiblio 1..4 not ok 1 - expected warnings when adding too long LCCN # Failed test 'expected warnings when adding too long LCCN' # at t/db_dependent/Biblio.t line 61. # didn't find a warning # expected to find warning: (?^u:Data too long for column 'lccn') # expected to find warning: (?^u:Data too long for column 'lccn') not ok 2 - AddBiblio returns undef for biblionumber if something went wrong # Failed test 'AddBiblio returns undef for biblionumber if something went wrong' # at t/db_dependent/Biblio.t line 63. # got: '1529' # expected: undef not ok 3 - AddBiblio returns undef for biblioitemnumber if something went wrong # Failed test 'AddBiblio returns undef for biblioitemnumber if something went wrong' # at t/db_dependent/Biblio.t line 65. # got: '1472' # expected: undef not ok 4 - No biblio should have been added if something went wrong # Failed test 'No biblio should have been added if something went wrong' # at t/db_dependent/Biblio.t line 68. # got: '1016' # expected: '1015' # Looks like you failed 4 tests of 4. not ok 2 - AddBiblio # Failed test 'AddBiblio' # at t/db_dependent/Biblio.t line 70. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27874] OPAC is broken "Can't locate C4/Boolean.pm"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27874 Jonathan Druart changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- reset_all will fix it. You need to update plack.psgi. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27796] SIP payment types should not be available as refund types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27796 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Martin Renvoize --- (In reply to Sally from comment #7) > After applying the patch, I get the following error when trying to load > pos/pay.pl or boraccount.pl: > > Template process failed: file error - transaction_types.inc: not found at > /kohadevbox/koha/C4/Templates.pm line 122 Ooops, seems I missed the file when constructing the patch.. I've uploaded a fresh one with the missing file included now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27796] SIP payment types should not be available as refund types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27796 Martin Renvoize changed: What|Removed |Added Attachment #117370|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 117784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117784&action=edit Bug 27796: Centralise payment/transaction type handling This patch centralises the payment/transaction type select options handling so the SIP types are properly in all cases. Test plan 1) Check that SIP payment types are properly hidden on the following modals. 1a) Refund modal on the borrower account page (The 'Account credit' option should appear here) 1b) Payout modal on borrower account page 1c) Payment via paycollect 1d) Payment via point of sale 1e) Refund vis point of sale, register details page (The 'Account credit' option should only appear for debts associated to a patron and not for payments accepted via point of sale) 2) Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27745] Use of uninitialized value in hash element error at C4/Search.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27745 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27745] Use of uninitialized value in hash element error at C4/Search.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27745
Marcel de Rooy changed:
What|Removed |Added
Attachment #117614|0 |1
is obsolete||
--- Comment #6 from Marcel de Rooy ---
Created attachment 117783
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117783&action=edit
Bug 27745: prevent warning for uninitialized value as a hash key
When you edit and save items with an empty "c - Shelving location"
field, it gets stored into the database as "NULL",
which is allowed in the database, and the field is not "required",
so this seems expected.
But when the search page is rendered, it gets value by location key
($shelflocations->{ $item->{location} }) which gives undef warning.
Solved by checking if $item->{location} is perl true.
To reproduce:
1) Edit the book or create new one with an empty shelving location.
2) Use the search feature to have that book in the searched list.
3) Check plack-intranet-error.log to find "Use of uninitialized
value in hash element" error.
4) Apply the patch.
5) Repeat the search and check the logs again to ensure that error
didn't appear again.
Signed-off-by: Didier Gautheron
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27745] Use of uninitialized value in hash element error at C4/Search.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27745 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #51 from Marcel de Rooy --- Processing additional checks * Commit title does not start with 'Bug X: ' - 28c2325c47 * Commit title does not start with 'Bug X: ' - 787cf5cda9 * Commit title does not start with 'Bug X: ' - 01aa2c4bb8 * Commit title does not start with 'Bug X: ' - ce321c3ad3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 --- Comment #24 from Marcel de Rooy --- Cant block this one for the stuff mentioned in comment19. Refactor_holds++ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Marcel de Rooy changed: What|Removed |Added Attachment #117021|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 117782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117782&action=edit Bug 27058: Remove confusing and unnecessary $biblionumber1 variable The code is much more understandable now because with $biblio2 and $biblionumber1 variables use to point to the same biblio one might have thought $biblionumber1 points to $biblio1 which in this case is not true. Let's just drop the extra variable because the object notation of accessing is just as simple. To test: 1) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t => passes Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Marcel de Rooy changed: What|Removed |Added Attachment #114211|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 117781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117781&action=edit Bug 27058: Make checkout availability use all notforloan reasons The ItemsAnyAvailableAndNotRestricted function is checking whether an item can be checked out and it incorrectly only checks the positive notforloan values when there can be also negative notforloan values. If notforloan value is not 0 then it means the item cannot be checked out. In the case of ordered items the value is negative (-1) and thus before this change the checkout availability was reported incorrectly. To test: 1) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Notice it fails 2) Apply this patch 3) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Notice it passes now. To test via Koha sandbox (Alternatively): 1) Create circ rule with If all unavailable 2) Create new biblio 3) Order a new item to the biblio via acquisitions and set the not for loan value to Ordered / -1 4) Notice you cannot place a hold to the biblio 5) Apply patch 6) Notice you can now place a hold to the biblio Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Marcel de Rooy changed: What|Removed |Added Attachment #114210|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 117780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117780&action=edit Bug 27058: Add test to show ordered items cannot be checked out Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Christian Stelzenmüller changed: What|Removed |Added CC||christian.stelzenmueller@bs ||z-bw.de --- Comment #228 from Christian Stelzenmüller --- I got an error at testing on step 4: Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. Error trace: Could not compile /kohadevbox/koha/admin/marc-merge-rules.pl: Global symbol "$bib_items_added" requires explicit package name (did you forget to declare "my $bib_items_added"?) at /kohadevbox/koha/C4/ImportBatch.pm line 676. Global symbol "$bib_items_replaced" requires explicit package name (did you forget to declare "my $bib_items_replaced"?) at /kohadevbox/koha/C4/ImportBatch.pm line 676. Global symbol "$bib_items_errored" requires explicit package name (did you forget to declare "my $bib_items_errored"?) at /kohadevbox/koha/C4/ImportBatch.pm line 676. Global symbol "$bib_items_added" requires explicit package name (did you forget to declare "my $bib_items_added"?) at /kohadevbox/koha/C4/ImportBatch.pm line 677. Global symbol "$bib_items_replaced" requires explicit package name (did you forget to declare "my $bib_items_replaced"?) at /kohadevbox/koha/C4/ImportBatch.pm line 678. Global symbol "$bib_items_errored" requires explicit package name (did you forget to declare "my $bib_items_errored"?) at /kohadevbox/koha/C4/ImportBatch.pm line 679. syntax error at /kohadevbox/koha/C4/ImportBatch.pm line 684, near "HEAD ModAuthority" Compilation failed in require at /kohadevbox/koha/admin/marc-merge-rules.pl line 33. BEGIN failed--compilation aborted at /kohadevbox/koha/admin/marc-merge-rules.pl line 33. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #34 from Martin Renvoize --- Thanks David :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #33 from David Cook --- (In reply to Martin Renvoize from comment #27) > Any chance you could progress this bug with a QA stamp David... My inbox is swamped but I couldn't say no ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook changed: What|Removed |Added Attachment #117532|0 |1 is obsolete|| --- Comment #32 from David Cook --- Created attachment 117779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117779&action=edit Bug 25674: Remove default vhost Signed-off-by: Martin Renvoize Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook changed: What|Removed |Added Attachment #117531|0 |1 is obsolete|| --- Comment #31 from David Cook --- Created attachment 117778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117778&action=edit Bug 25674: Add documentation Signed-off-by: Martin Renvoize Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook changed: What|Removed |Added Attachment #117530|0 |1 is obsolete|| --- Comment #30 from David Cook --- Created attachment 11 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11&action=edit Bug 25674: Adapt koha-create This patch adds the following option switches to koha-create: --mb-host --mb-port --mb-user --mb-pass --mb-vhost They are used to override the default values on instance creation. To test: 1. Play with the several option switches and verify that the resulting koha-conf.xml contains the expected data. => SUCCESS: It works as expected 2. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook changed: What|Removed |Added Attachment #117529|0 |1 is obsolete|| --- Comment #29 from David Cook --- Created attachment 117776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117776&action=edit Bug 25674: Add placeholders for RabbitMQ configuration Signed-off-by: Martin Renvoize Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #28 from David Cook --- My test plan: 1. cp debian/templates/koha-conf-site.xml.in /etc/koha/koha-conf-site.xml.in 2. cp debian/scripts/koha-create /usr/sbin/koha-create 3. koha-create --create-db --mb-host test1 --mb-port 8000 --mb-user test2 --mb-pass test3 --mb-vhost test4 test5 4. vi /etc/koha/sites/test5/koha-conf.xml 5. Note the following block near the bottom of the file: test1 8000 test2 test3 test4 6. koha-create --create-db test6 7. vi /etc/koha/sites/test6/koha-conf.xml 8. Note the following block near the bottom of the file: localhost 61613 guest guest testing 4 commit(s) (applied to 5038a57 '39 Bug 26742: Remove die from connect') Processing files before patches |>| 1 / 1 (100.00%) Processing files after patches |>| 1 / 1 (100.00%) OK debian/docs/koha-create.xml Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #34 from David Cook --- (In reply to Tomás Cohen Arazi from comment #32) > (In reply to Martin Renvoize from comment #26) > > Or, dare I say it.. shipping a local clone of the Mojo stack inside Koha. > > We should do that. And jump to current versions of the OpenAPI plugin and > Mojolicious 8.x. if not possible to package them, of course. I think there > was a Perl version issue with stretch? I don't know about stretch, but yeah I suppose the downside of picking and choosing some libraries to be via DEB packages and some to be embedded is that our support for multiple different OSes could be problematic (based on Mojo dependencie). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #33 from David Cook --- (In reply to Mason James from comment #31) > no, it's impossible for us to do this because the version we want (3.25) is > *lower* than the version available (4.13) in the debian.net/bullseye repo > > see... https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893#c16 > > ps: i would love to be proven incorrect on this info Except that we already do it with libhttp-oai-perl. At https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893#c18 you mention the issue becomes libmojolicious-plugin-openapi-perl has dependency issues, but then we can just control that one too and provide our own package, which makes sense since we're already mucking with Mojolicious versions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #15 from wainuiwitikap...@catalyst.net.nz --- (In reply to Lucas Gass from comment #6) > Looking good! > > One area that is a bit odd looking now is OPAC purchase suggestions. Now > there is an h1 and and h2 with very similar text. Can this be fixed? > > https://snipboard.io/SCFALO.jpg Hi Lucas, I have now made Bug 27876 and Bug 27877 to deal with redundancies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Blocks||27877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy and correct error/alert headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Blocks||27877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy and correct error/alert headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Depends on||27631, 27741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27877] New: Accessibility: Staff Client - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 Bug ID: 27877 Summary: Accessibility: Staff Client - Reduce heading redundancy and correct error/alert headings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Bug 27631 created headings on each page of the Staff Client, then Bug 27741 fixed the hierarchy of the other headings in each page to ensure there was no skipping of heading levels, and that items that appeared as headings of some sort, had an tag. There are now a few headings that are redundant so this bug will deal with issues like this. Many of the alerts and errors are also tagged as headings, which for many cases is not correct. Therefore, this bug will also deal with these issues -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 --- Comment #4 from Hayley Pelham --- > As the goal for this bug is to correct the existing hierarchy of headings, > we can deal with any redundancy (or locations where headings are used they > perhaps shouldn't be) on a separate bug report. Bug 27876 has been created for this purpose. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 Hayley Pelham changed: What|Removed |Added CC||hayleypel...@catalyst.net.n ||z --- Comment #14 from Hayley Pelham --- Hello everyone, I've signed off this patch set also to indicate that I've tested it and semantically everything is looking good. As the goal for this bug is to correct the existing hierarchy of headings, we can deal with any redundancy (or locations where headings are used they perhaps shouldn't be) on Bug 27876. As Wainui and I are both with Catalyst IT it'd be great if someone could take a look at this and sign it and its block Bug 27740 off or provide some feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #13 from Hayley Pelham --- Created attachment 117775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117775&action=edit Bug 27610: (follow-up) Hide on opac-main.tt This patch visually hides the on opac-main.tt so that libraries' customisations of their home pages are not disturbed by the introduction of a descriptive , but the heading is still available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Apply dependencies and all patches on this bug report 2) Observe a new heading level 1 'Home' on the OPAC main page 2) Apply this patch 3) Observe the heading is hidden visually, but in the source code you can see it is in the correct hierarchy and it is more descriptive 'Koha home' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #12 from Hayley Pelham --- Created attachment 117774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117774&action=edit Bug 27610: Changed pages of OPAC to have a Changed each of the pages in the OPAC to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in a follow up patch or bug. To test: 1) Go to the OPAC 2) Apply patch 3) Go to each of the pages and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored by: Catalyst IT Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 Hayley Pelham changed: What|Removed |Added Attachment #117017|0 |1 is obsolete|| Attachment #117769|0 |1 is obsolete|| Attachment #117772|0 |1 is obsolete|| --- Comment #11 from Hayley Pelham --- Created attachment 117773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117773&action=edit Bug 27610: Changed around logo to To test: 1) Look at OPAC and the logo 2) Apply patch 3) Check Koha logo looks the same as before applying the patch 4) Ensure page source shows logo inside and not Sponsored-by: Catalyst IT Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 Hayley Pelham changed: What|Removed |Added Attachment #116296|0 |1 is obsolete|| --- Comment #10 from Hayley Pelham --- Created attachment 117772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117772&action=edit Bug 27610: Changed around logo to To test: 1) Look at OPAC and the logo 2) Apply patch 3) Check Koha logo looks the same as before applying the patch 4) Ensure page source shows logo inside and not Sponsored-by: Catalyst IT Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Blocks||27876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 [Bug 27876] Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Depends on||27740 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Blocks||27876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 [Bug 27876] Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Depends on||27610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |wainuiwitikapark@catalyst.n ||et.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] New: Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Bug ID: 27876 Summary: Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Bug 27610 created headings on each page of the OPAC, then Bug 27740 fixed the hierarchy of the other headings in each page to ensure there was no skipping of heading levels, and that items that appeared as headings of some sort, had an tag. There are now a few headings that are redundant (e.g. Purchase suggestions https://snipboard.io/SCFALO.jpg) so this bug will deal with issues like this. Many of the alerts and errors are also tagged as headings, which for many cases is not correct. Therefore, this bug will also deal with these issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Hayley Pelham changed: What|Removed |Added CC||hayleypel...@catalyst.net.n ||z --- Comment #3 from Hayley Pelham --- Hello everyone, I've signed off this patch to indicate that it's been checked through and tested and everything's looking good semantically. As the goal for this bug is to correct the existing hierarchy of headings, we can deal with any redundancy (or locations where headings are used they perhaps shouldn't be) on a separate bug report. As Wainui and I are both with Catalyst IT it'd be great if someone could take a look at this and sign it and its dependency Bug 27610 off or provide some feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Hayley Pelham changed: What|Removed |Added Attachment #117629|0 |1 is obsolete|| --- Comment #2 from Hayley Pelham --- Created attachment 117771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117771&action=edit Bug 27740: Corrected tags & hierarchy of headings Bug 27610 corrected the tags in each of the OPAC files. This patch corrects the hierarchy of the rest of the headings on each of the pages. To test: 1) Go to the OPAC 2) Apply Bug 27610 patch 3) Apply patch (Bug 27740) 4) Go to each of the pages and check that the headings under are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27742] Accessibility: OPAC - Page titles should have unique information first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 Hayley Pelham changed: What|Removed |Added Attachment #117193|0 |1 is obsolete|| --- Comment #4 from Hayley Pelham --- Created attachment 117770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117770&action=edit Bug 27742: (follow-up) Add title for record blocked page This modifies the title for the template used when a bibliographic record is blocked. Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27742] Accessibility: OPAC - Page titles should have unique information first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 Hayley Pelham changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #9 from Hayley Pelham --- Created attachment 117769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117769&action=edit Bug 27610: (follow-up) Hide on opac-main.tt This patch visually hides the on opac-main.tt so that libraries' customisations of their home pages are not disturbed by the introduction of a descriptive , but the heading is still available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Apply dependencies and all patches on this bug report 2) Observe a new heading level 1 'Home' on the OPAC main page 2) Apply this patch 3) Observe the heading is hidden visually, but in the source code you can see it is in the correct hierarchy and it is more descriptive 'Koha home' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #98 from Hayley Pelham --- (In reply to Tomás Cohen Arazi from comment #97) > (In reply to Hayley Pelham from comment #96) > > Hi all, > > > > When I went to master in my devbox, I got this error when restarting > > services and my sites wouldn't load: > > > > BEGIN failed--compilation aborted at /etc/koha/sites/kohadev/plack.psgi line > > 29. > > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate > > C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC > > contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer > > /home/vagrant/kohaclone/lib/installer /etc/perl > > /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 > > /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 > > /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 > > /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at > > /etc/koha/sites/kohadev/plack.psgi line 29. > > > > I removed the use line in /etc/koha/sites/kohadev/plack.psgi, but is there > > something else I should have done? And will this happen for other Kohas? > > > > Cheers, > > Hayley > > reset_all should do the job of replacing the old plack.psgi. Ah, of course! Gracias :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #97 from Tomás Cohen Arazi --- (In reply to Hayley Pelham from comment #96) > Hi all, > > When I went to master in my devbox, I got this error when restarting > services and my sites wouldn't load: > > BEGIN failed--compilation aborted at /etc/koha/sites/kohadev/plack.psgi line > 29. > Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate > C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC > contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer > /home/vagrant/kohaclone/lib/installer /etc/perl > /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 > /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 > /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 > /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at > /etc/koha/sites/kohadev/plack.psgi line 29. > > I removed the use line in /etc/koha/sites/kohadev/plack.psgi, but is there > something else I should have done? And will this happen for other Kohas? > > Cheers, > Hayley reset_all should do the job of replacing the old plack.psgi. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Hayley Pelham changed: What|Removed |Added CC||hayleypel...@catalyst.net.n ||z --- Comment #96 from Hayley Pelham --- Hi all, When I went to master in my devbox, I got this error when restarting services and my sites wouldn't load: BEGIN failed--compilation aborted at /etc/koha/sites/kohadev/plack.psgi line 29. Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /etc/koha/sites/kohadev/plack.psgi line 29. I removed the use line in /etc/koha/sites/kohadev/plack.psgi, but is there something else I should have done? And will this happen for other Kohas? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #8 from wainuiwitikap...@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #7) > (In reply to Lucas Gass from comment #6) > > Looking good! > > > > One area that is a bit odd looking now is OPAC purchase suggestions. Now > > there is an h1 and and h2 with very similar text. Can this be fixed? > > > > https://snipboard.io/SCFALO.jpg > > Hi Lucas! Thanks for your comment! Yes that is definitely very redundant. > However, the aim of this bug was to just ensure that there is one > heading on each page of the OPAC. Then the Bug 27740 ensures the structure > and hierarchy of the headings under are correct. Neither of those are > specifically dealing with redundancy of headings and/or whether or not > headings under are actually headings (i.e. there are currently some > errors and alerts that are tags that shouldn't actually be headings). > Therefore, I think if you want to make a follow up patch about this > particular issue, that depends on this Bug 27610 and Bug 27740, that would > probably be the best way to go. Great spotting though and appreciate the > feedback! Hey again, on second thought, I'll just make a new bug myself that deals with things like redundancy of page titles and then I will also make another bug about things that shouldn't be headings. Watch this space for the new bugs :) I'll make them soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #3 from wainuiwitikap...@catalyst.net.nz --- (In reply to Martin Renvoize from comment #2) > Awesome So great to see this starting to move forward. > > Is this ready for testing? If it is, then updating the status for 'Needs > signoff' will trigger us eager beavers to take a look :) > > Welcome aboard. Hey Martin! I'm still working on the second patch of this bug regarding adding s on each page. Hopefully will be done soon! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Katrin Fischer changed: What|Removed |Added Blocks||27874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27874 [Bug 27874] OPAC is broken "Can't locate C4/Boolean.pm" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27874] OPAC is broken "Can't locate C4/Boolean.pm"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27874 Katrin Fischer changed: What|Removed |Added Depends on||22824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 [Bug 22824] Replace YAML::Syck with YAML::XS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27875] New: CollapseFieldsPatronAddForm reveals guarantor_template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27875 Bug ID: 27875 Summary: CollapseFieldsPatronAddForm reveals guarantor_template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If you use CollapseFieldsPatronAddForm to hide the guarantor section of the member entry form, toggling that section reveals the guarantor_template. I have yet to find a way to work around this problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27874] New: OPAC is broken "Can't locate C4/Boolean.pm"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27874 Bug ID: 27874 Summary: OPAC is broken "Can't locate C4/Boolean.pm" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org I think is probably a side effect of a recent change: Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /etc/koha/sites/kohadev/plack.psgi line 29. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #18 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05, please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842 --- Comment #13 from Katrin Fischer --- I wonder if we are on the right track here by changing the information in past serials or if this doesn't destroy useful information. Serials are known to be odd. When you look at the national serials database they have a graph view on their record detail pages where you can see how often they change their names, merge with others... divide etc. It's pretty, but also scary! And for our catalogers every change like this means a new record. So it makes sense that we can change which record a subscription is attached to. The name change would not necessarily affect the subscription itself. So could it be by design that the original biblionumber was stored? As you said, we don't actually need it, as we have the current biblionumber in the subscription. If it was thought to be for keeping some history, it could make sense and the fix would maybe to stop it from deleting the issues when the record is deleted. We could also think about updating the biblionumber of the next expected issue when the biblionumber is changed. Not sure about this - just something I was wondering about when I noticed the biblionumber in serials in the past. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Jeff Gaines changed: What|Removed |Added CC||jga...@arlingtonva.us --- Comment #3 from Jeff Gaines --- I would very much like more control over this setting. At the very least it should be a year's worth of data, but some smaller libraries might be able to hold multi-year logs. I support this request. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in|| CC||and...@bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27841] Add unique action types to action logs for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27841 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #1 from Rebecca Coert --- This would be extremely useful in tracking the detailed activity of our Hold Shelves. We're very interested in tracking all parts of the "hold cycle" from placing to checkout/expiration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27814] Improve responsive behavior of the user page in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27814 --- Comment #6 from Katrin Fischer --- Also looking at it I wonder if we don't give up too much space left and right with the current layout on smaller screens... should we kill/minimize that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #2 from Rebecca Coert --- 100% agree! It's possible that management is going to request a report that requires us to look back at important data that it more than 180 days old. It's impossible to predict what information you'll need to access & when. Recently ran into this issue looking at holds placed/filled/etc. in July 2020. The report is empty because the data's been scrubbed by the cron. I second Andrew's request for granularity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27814] Improve responsive behavior of the user page in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27814 --- Comment #5 from Katrin Fischer --- I've tried several times with yarn build --view opac and restart_all... but I fail to see a big difference. Also the table options (Print etc.) fail to wrap at some point for me. Could I ask you to try this out with German? The English link descriptions are all super short in this case... and I just now the situation will be very different with German. (Renew = Verlängern, Print = Drucken etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 --- Comment #2 from Barbara Johnson --- Created attachment 117768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117768&action=edit Patron details screen display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 --- Comment #1 from Barbara Johnson --- Created attachment 117767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117767&action=edit Check out screen display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27873] New: Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Bug ID: 27873 Summary: Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com On the check out screen (circulation.pl) info about the patron’s account displays in the following order: expiration, restrictions, charges, notes, messages. But on the patron details screen (moremember.pl) the info displays in a different order: charges, messages, notes, restrictions, expiration. For consistency it seems like the info should display in the same order on both screens. Additionally it would help when training new staff members and when working a busy information desk to be able to rely on finding the information in the same place on both screens. Our Library prefers the sort order that displays on the check out screen because it puts the expiration date, restrictions and then charges at the top of the screen so that staff can quickly see the status of the account and handle them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27534] koha upgrade throws SQL error while applying Bug 25333 - Change message transport type for Talking Tech from "phone" to "itiva"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27534 --- Comment #19 from Andrew Fuerste-Henry --- (or, rather, missing dependencies) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27534] koha upgrade throws SQL error while applying Bug 25333 - Change message transport type for Talking Tech from "phone" to "itiva"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27534 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #18 from Andrew Fuerste-Henry --- enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #19 from Katrin Fischer --- Please remember to add text for the release notes! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #18 from Katrin Fischer --- Thx for the follow-up - love this even more now! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Katrin Fischer changed: What|Removed |Added Attachment #117755|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 117766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117766&action=edit Bug 5697: (follow-up) Save the user's choice to show or hide auto-links This patch adds local storage of the user's selection when they click the "Show/hide data menus" control. The selection persists until the user logs out. To test, apply the patch and run an SQL report which will return borrowernumber, cardnumber, itemnumber, or biblionumber. - When the results display, confirm that these numbers are shown with the auto-link menu. - Click the "Hide data menus" link. The text should change to "Show data menus" and the menus should disappear. - Navigate away from the page and re-run the report. - The menus should be automatically hidden in the results. - Log out of the staff client, return to saved reports, and run the report again. - The auto-link menus should appear. Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Katrin Fischer changed: What|Removed |Added Attachment #117096|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 117765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117765&action=edit Bug 5697: Automatic linking in guided reports This patch modifies the output of reports so that if certain columns are returned the data in the colums automatically offer menus of actions: - borrowernumber: View, edit, check out - cardnumber: Check out - itemnumber: View, edit - biblionumber: View, edit Like the menu of batch operations, this functionality is available only if the column is returned with its original name (e.g. biblionumber, not "biblionumber AS `Biblio number`). To test, apply the patch and run a report which will return examples of each kind of data. I used: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() LIMIT 50 When the report runs you should see that the data in each affected column is displayed as a link, each of which should trigger the correct menu. Test each case to confirm that the correct page is opened. Test the "toggle data menus" control. Clicking it should hide and show the menus in the report results. Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12358] Split hold notes into public and internal hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12358 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27871 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27871] Make hold notes optionally visible in OPAC patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27871 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12358 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27871] Make hold notes optionally visible in OPAC patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27871 --- Comment #5 from Katrin Fischer --- Just thinking loud - also happy to explore different ideas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27871] Make hold notes optionally visible in OPAC patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27871 --- Comment #4 from Andrew Fuerste-Henry --- Fair enough! I have no quarrel with the suggestion in bug 12358. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 --- Comment #7 from Martin Renvoize --- Sounds great, I'm sure it'll be a great patch, thanks for working on it. I'm sure we'll all agree to set a guideline by it at the Dev meeting which should mean we keep up the good work going forward :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27871] Make hold notes optionally visible in OPAC patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27871 --- Comment #3 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #2) > Existing bug 12358 suggests splitting hold notes into public and non-public. > I suggested this as a less complex alternative. While some libraries may > want these notes visible while others do not, it's a whole other level of > complexity to allow both options at once. > > Turning on OpacHoldNotes allows patrons to enter notes when placing holds, > but doesn't allow patrons to ever see those notes. Hm not sure I agree about complexity. It's anothre database field and visiblity would be much more straightforward than it's now - less likely to accidentally leak information or get in a state where you can't switch the pref because you have sensitive data in the notes or might have. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27871] Make hold notes optionally visible in OPAC patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27871 --- Comment #2 from Andrew Fuerste-Henry --- Existing bug 12358 suggests splitting hold notes into public and non-public. I suggested this as a less complex alternative. While some libraries may want these notes visible while others do not, it's a whole other level of complexity to allow both options at once. Turning on OpacHoldNotes allows patrons to enter notes when placing holds, but doesn't allow patrons to ever see those notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Katrin Fischer changed: What|Removed |Added Attachment #116606|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 117764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117764&action=edit Bug 26272: Add ajax driven cashup modal to library page This patch adds an ajax driven cashup summary modal to the library registers summary page. Test plan 1/ Enable UseCashRegisters in the system preferences 2/ Add at least one cash register to your library 3/ Make some payments of various types (Cash, Card) against the cash register 4/ View the register transactions details page 5/ Make a refund against a payment 6/ Cashup 7/ View the cashup summary by clicking on the 'Summary' link on the register page. 8/ Navigate to the 'libraries' summary page 9/ View the cashup summary by clicking on the 'Summary' link in the registers table. 10/ Signoff Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27871] Make hold notes optionally visible in OPAC patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27871 --- Comment #1 from Katrin Fischer --- Hi Andrew, can you describe how this would be different to the current behaviour of the OpacHoldNotes system preference? I think there is another bug around that I liked the idea of: split the hold notes into an internal and a public note. Would this be a viable alternative solution? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #24 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #7 from wainuiwitikap...@catalyst.net.nz --- (In reply to Lucas Gass from comment #6) > Looking good! > > One area that is a bit odd looking now is OPAC purchase suggestions. Now > there is an h1 and and h2 with very similar text. Can this be fixed? > > https://snipboard.io/SCFALO.jpg Hi Lucas! Thanks for your comment! Yes that is definitely very redundant. However, the aim of this bug was to just ensure that there is one heading on each page of the OPAC. Then the Bug 27740 ensures the structure and hierarchy of the headings under are correct. Neither of those are specifically dealing with redundancy of headings and/or whether or not headings under are actually headings (i.e. there are currently some errors and alerts that are tags that shouldn't actually be headings). Therefore, I think if you want to make a follow up patch about this particular issue, that depends on this Bug 27610 and Bug 27740, that would probably be the best way to go. Great spotting though and appreciate the feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27872] New: Expand {QUERY_KW} function from OPACNoResultsFound to not-empty search results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27872
Bug ID: 27872
Summary: Expand {QUERY_KW} function from OPACNoResultsFound to
not-empty search results page
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
If a patron finds a record but it is unavailable, they can use
OPACSearchForTitleIn to look for that same record elsewhere.
If a patron finds nothing at all, they can use OPACNoResultsFound to repeat
their search in another catalog.
But if a patron performs a search that returns *something* but not the thing
they want, then they don't have a path to another catalog. We should allow
that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 --- Comment #6 from wainuiwitikap...@catalyst.net.nz --- Hi everyone! Thanks for that Martin! As I've already been working on reversing the contents of the page title, I will just finish up the patch and attach it. Then it should hopefully be a lot easier when reconstructing it to have less information in it, which could be a follow up patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #10 from Nick Clemens --- Created attachment 117763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117763&action=edit Bug 27797: (QA follow-up) Additional tests and operator change I added a few tests to cover additional cases and found the operator precedence was failing, switched 'and' to '&&' Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797
Nick Clemens changed:
What|Removed |Added
Attachment #117541|0 |1
is obsolete||
--- Comment #9 from Nick Clemens ---
Created attachment 117762
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117762&action=edit
Bug 27797: Make POST /holds use the stashed koha.overrides
Bug 26181 introduced a way to override behavior through a new header,
x-koha-override. And bug 27760 introduced a generic approach to handle
x-koha-override.
This patchset makes the POST /api/v1/holds route rely on this new way of
handling x-koha-override instead of doing it manually.
The header is added to the spec as a parameter.
Note: the header should be defined as:
"type": "array",
"collectionFormat": "csv",
"items": {
"type": "string",
"enum": [
"any"
]
}
but the versions of JSON::Validator we use have lots of bugs related to
header type coercion, so it just doesn't work. The changelog for
JSON::Validator is fairly elocuent about it.
The override now takes a list of valid keywords (right now only 'any'
but it would be fairly straight-forward to add a fairly granular set of
options based on each possible AddReserve failure.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
4. Sign off!
Signed-off-by: Martin Renvoize
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Nick Clemens changed: What|Removed |Added Attachment #117540|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 117761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117761&action=edit Bug 27797: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27514] Input boxes change size when selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27514 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- I can only recreate this in Firefox 84 if I use Ubuntu. On MacOS I do not recreate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 --- Comment #1 from Lucas Gass --- Created attachment 117760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117760&action=edit Bug 27869: let user know something went wrong with csv upload To test: -attempt to upload a malformed CSV file -nothing happens, check the console and see the error: Uncaught TypeError: arrData[(arrData.length - 1)] is undefined -apply patch -try again -now you should at least see a warning that something went wrong -attempt to upload a good CSV file, it should work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27870] Add holds table at /opac-user.pl#opac-user-holds to Table Settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27870 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||27871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27871 [Bug 27871] Make hold notes optionally visible in OPAC patron record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
