Re: [libvirt] [PATCH 2/4] python: add python binding for virDomainSetBlkioParameters

2011-07-28 Thread Michal Privoznik

On 27.07.2011 04:13, Hu Tao wrote:

---
  python/libvirt-override-api.xml |1 +
  python/libvirt-override.c   |   94 +-
  2 files changed, 92 insertions(+), 3 deletions(-)


ACK, but again, we need update of virDomainSetBlkioParameters description.
I'll collect all of these and push it then as one patch.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH 2/4] python: add python binding for virDomainSetBlkioParameters

2011-07-28 Thread Hu Tao
On Thu, Jul 28, 2011 at 10:15:21AM +0200, Michal Privoznik wrote:
> On 27.07.2011 04:13, Hu Tao wrote:
> >---
> >  python/libvirt-override-api.xml |1 +
> >  python/libvirt-override.c   |   94 
> > +-
> >  2 files changed, 92 insertions(+), 3 deletions(-)
> >
> ACK, but again, we need update of virDomainSetBlkioParameters description.
> I'll collect all of these and push it then as one patch.

Thanks.

-- 
Thanks,
Hu Tao

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 2/4] python: add python binding for virDomainSetBlkioParameters

2011-07-26 Thread Hu Tao
---
 python/libvirt-override-api.xml |1 +
 python/libvirt-override.c   |   94 +-
 2 files changed, 92 insertions(+), 3 deletions(-)

diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml
index 00f8e6a..928bfb7 100644
--- a/python/libvirt-override-api.xml
+++ b/python/libvirt-override-api.xml
@@ -206,6 +206,7 @@
   
   
   
+  
 
 
   Get the blkio parameters
diff --git a/python/libvirt-override.c b/python/libvirt-override.c
index beb0969..e53451f 100644
--- a/python/libvirt-override.c
+++ b/python/libvirt-override.c
@@ -565,11 +565,99 @@ libvirt_virDomainSetSchedulerParametersFlags(PyObject 
*self ATTRIBUTE_UNUSED,
 }
 
 
-/* FIXME: This is a place holder for the implementation. */
 static PyObject *
 libvirt_virDomainSetBlkioParameters(PyObject *self ATTRIBUTE_UNUSED,
- PyObject *args ATTRIBUTE_UNUSED) {
-return VIR_PY_INT_FAIL;
+ PyObject *args) {
+virDomainPtr domain;
+PyObject *pyobj_domain, *info;
+int i_retval;
+int nparams = 0, i;
+unsigned int flags;
+virTypedParameterPtr params;
+
+if (!PyArg_ParseTuple(args,
+  (char *)"OOi:virDomainSetBlkioParameters",
+  &pyobj_domain, &info, &flags))
+return(NULL);
+domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain);
+
+LIBVIRT_BEGIN_ALLOW_THREADS;
+i_retval = virDomainGetBlkioParameters(domain, NULL, &nparams, flags);
+LIBVIRT_END_ALLOW_THREADS;
+
+if (i_retval < 0)
+return VIR_PY_INT_FAIL;
+
+if ((params = malloc(sizeof(*params)*nparams)) == NULL)
+return VIR_PY_INT_FAIL;
+
+LIBVIRT_BEGIN_ALLOW_THREADS;
+i_retval = virDomainGetBlkioParameters(domain, params, &nparams, flags);
+LIBVIRT_END_ALLOW_THREADS;
+
+if (i_retval < 0) {
+free(params);
+return VIR_PY_INT_FAIL;
+}
+
+/* convert to a Python tuple of long objects */
+for (i = 0; i < nparams; i++) {
+PyObject *key, *val;
+key = libvirt_constcharPtrWrap(params[i].field);
+val = PyDict_GetItem(info, key);
+Py_DECREF(key);
+
+if (val == NULL)
+continue;
+
+switch (params[i].type) {
+case VIR_TYPED_PARAM_INT:
+params[i].value.i = (int)PyInt_AS_LONG(val);
+break;
+
+case VIR_TYPED_PARAM_UINT:
+params[i].value.ui = (unsigned int)PyInt_AS_LONG(val);
+break;
+
+case VIR_TYPED_PARAM_LLONG:
+params[i].value.l = (long long)PyLong_AsLongLong(val);
+break;
+
+case VIR_TYPED_PARAM_ULLONG:
+params[i].value.ul = (unsigned long long)PyLong_AsLongLong(val);
+break;
+
+case VIR_TYPED_PARAM_DOUBLE:
+params[i].value.d = (double)PyFloat_AsDouble(val);
+break;
+
+case VIR_TYPED_PARAM_BOOLEAN:
+{
+/* Hack - Python's definition of Py_True breaks strict
+ * aliasing rules, so can't directly compare :-(
+ */
+PyObject *hacktrue = PyBool_FromLong(1);
+params[i].value.b = hacktrue == val ? 1: 0;
+Py_DECREF(hacktrue);
+}
+break;
+
+default:
+free(params);
+return VIR_PY_INT_FAIL;
+}
+}
+
+LIBVIRT_BEGIN_ALLOW_THREADS;
+i_retval = virDomainSetBlkioParameters(domain, params, nparams, flags);
+LIBVIRT_END_ALLOW_THREADS;
+if (i_retval < 0) {
+free(params);
+return VIR_PY_INT_FAIL;
+}
+
+free(params);
+return VIR_PY_INT_SUCCESS;
 }
 
 static PyObject *
-- 
1.7.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list