Re: [libvirt] [PATCH 2/4] qemu: refactor qemuCompressProgramAvailable()

2013-10-10 Thread Peter Krempa
On 10/09/13 22:37, Eric Blake wrote:
> On 10/09/2013 10:31 AM, Peter Krempa wrote:
>> ---
>>  src/qemu/qemu_driver.c | 14 +++---
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
> 
> ACK.
> 

Pushed; Thanks.

Peter



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/4] qemu: refactor qemuCompressProgramAvailable()

2013-10-09 Thread Eric Blake
On 10/09/2013 10:31 AM, Peter Krempa wrote:
> ---
>  src/qemu/qemu_driver.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/4] qemu: refactor qemuCompressProgramAvailable()

2013-10-09 Thread Peter Krempa
---
 src/qemu/qemu_driver.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index b9f340c..cfdbb9a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3138,18 +3138,18 @@ cleanup:
 }

 /* Returns true if a compression program is available in PATH */
-static bool qemuCompressProgramAvailable(virQEMUSaveFormat compress)
+static bool
+qemuCompressProgramAvailable(virQEMUSaveFormat compress)
 {
-const char *prog;
-char *c;
+char *path;

 if (compress == QEMU_SAVE_FORMAT_RAW)
 return true;
-prog = qemuSaveCompressionTypeToString(compress);
-c = virFindFileInPath(prog);
-if (!c)
+
+if (!(path = virFindFileInPath(qemuSaveCompressionTypeToString(compress
 return false;
-VIR_FREE(c);
+
+VIR_FREE(path);
 return true;
 }

-- 
1.8.3.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list