Re: [libvirt] [PATCH 3/4] python: add python binding for virDomainGetMemoryParameters

2011-07-28 Thread Michal Privoznik

On 27.07.2011 04:13, Hu Tao wrote:

---
  python/libvirt-override-api.xml |6 +-
  python/libvirt-override.c   |   79 +-
  2 files changed, 79 insertions(+), 6 deletions(-)


ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 3/4] python: add python binding for virDomainGetMemoryParameters

2011-07-26 Thread Hu Tao
---
 python/libvirt-override-api.xml |6 +-
 python/libvirt-override.c   |   79 +-
 2 files changed, 79 insertions(+), 6 deletions(-)

diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml
index 928bfb7..0a67f9d 100644
--- a/python/libvirt-override-api.xml
+++ b/python/libvirt-override-api.xml
@@ -221,10 +221,10 @@
   
 
 
-  Get the memory parameters, the @params array will be filled with 
the values.
-  
+  Get the memory parameters
+  
   
-  
+  
 
 
   list the storage pools, stores the pointers to the names in 
@names
diff --git a/python/libvirt-override.c b/python/libvirt-override.c
index e53451f..7ab67e9 100644
--- a/python/libvirt-override.c
+++ b/python/libvirt-override.c
@@ -747,11 +747,84 @@ libvirt_virDomainSetMemoryParameters(PyObject *self 
ATTRIBUTE_UNUSED,
 return VIR_PY_INT_FAIL;
 }
 
-/* FIXME: This is a place holder for the implementation. */
 static PyObject *
 libvirt_virDomainGetMemoryParameters(PyObject *self ATTRIBUTE_UNUSED,
- PyObject *args ATTRIBUTE_UNUSED) {
-return VIR_PY_INT_FAIL;
+ PyObject *args) {
+virDomainPtr domain;
+PyObject *pyobj_domain, *info;
+int i_retval;
+int nparams = 0, i;
+unsigned int flags;
+virTypedParameterPtr params;
+
+if (!PyArg_ParseTuple(args, (char *)"Oi:virDomainGetMemoryParameters",
+  &pyobj_domain, &flags))
+return(NULL);
+domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain);
+
+LIBVIRT_BEGIN_ALLOW_THREADS;
+i_retval = virDomainGetMemoryParameters(domain, NULL, &nparams, flags);
+LIBVIRT_END_ALLOW_THREADS;
+
+if (i_retval < 0)
+return VIR_PY_NONE;
+
+if ((params = malloc(sizeof(*params)*nparams)) == NULL)
+return VIR_PY_NONE;
+
+LIBVIRT_BEGIN_ALLOW_THREADS;
+i_retval = virDomainGetMemoryParameters(domain, params, &nparams, flags);
+LIBVIRT_END_ALLOW_THREADS;
+
+if (i_retval < 0) {
+free(params);
+return VIR_PY_NONE;
+}
+
+/* convert to a Python tuple of long objects */
+if ((info = PyDict_New()) == NULL) {
+free(params);
+return VIR_PY_NONE;
+}
+for (i = 0 ; i < nparams ; i++) {
+PyObject *key, *val;
+
+switch (params[i].type) {
+case VIR_TYPED_PARAM_INT:
+val = PyInt_FromLong((long)params[i].value.i);
+break;
+
+case VIR_TYPED_PARAM_UINT:
+val = PyInt_FromLong((long)params[i].value.ui);
+break;
+
+case VIR_TYPED_PARAM_LLONG:
+val = PyLong_FromLongLong((long long)params[i].value.l);
+break;
+
+case VIR_TYPED_PARAM_ULLONG:
+val = PyLong_FromLongLong((long long)params[i].value.ul);
+break;
+
+case VIR_TYPED_PARAM_DOUBLE:
+val = PyFloat_FromDouble((double)params[i].value.d);
+break;
+
+case VIR_TYPED_PARAM_BOOLEAN:
+val = PyBool_FromLong((long)params[i].value.b);
+break;
+
+default:
+free(params);
+Py_DECREF(info);
+return VIR_PY_NONE;
+}
+
+key = libvirt_constcharPtrWrap(params[i].field);
+PyDict_SetItem(info, key, val);
+}
+free(params);
+return(info);
 }
 
 static PyObject *
-- 
1.7.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list