Re: [libvirt] [PATCH 4/4] examples: Fix event detail printing in python test
On Fri, Sep 7, 2012 at 3:26 AM, Jiri Denemark wrote: > On Thu, Sep 06, 2012 at 17:50:25 -0600, Eric Blake wrote: >> On 09/06/2012 05:31 PM, Doug Goldstein wrote: >> > On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark wrote: >> >> If there is only one detail string for a particular event, we need to pu >> >> s/pu/put a/ > > Oh my and I just pushed the series without fixing this typo :-/ At least it's > not the first one and certainly not the last one either. > > Thanks for the reviews. > > Jirka Ugh, sorry. I guess my brain has auto-correct built in because I didn't see that. Eric has spotted numerous typos that others have missed which is a good thing. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/4] examples: Fix event detail printing in python test
On Thu, Sep 06, 2012 at 17:50:25 -0600, Eric Blake wrote: > On 09/06/2012 05:31 PM, Doug Goldstein wrote: > > On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark wrote: > >> If there is only one detail string for a particular event, we need to pu > > s/pu/put a/ Oh my and I just pushed the series without fixing this typo :-/ At least it's not the first one and certainly not the last one either. Thanks for the reviews. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/4] examples: Fix event detail printing in python test
On 09/06/2012 05:31 PM, Doug Goldstein wrote: > On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark wrote: >> If there is only one detail string for a particular event, we need to pu s/pu/put a/ >> comma after the string otherwise the string itself will be taken as a >> list and only its first character will be printed out. For example, >> -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/4] examples: Fix event detail printing in python test
On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark wrote: > If there is only one detail string for a particular event, we need to pu > comma after the string otherwise the string itself will be taken as a > list and only its first character will be printed out. For example, > > myDomainEventCallback1 EVENT: Domain fedora17(12) Shutdown F > > instead of the desired > > myDomainEventCallback1 EVENT: Domain fedora17(12) Shutdown Finished > --- > examples/domain-events/events-python/event-test.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/domain-events/events-python/event-test.py > b/examples/domain-events/events-python/event-test.py > index fd71acd..3e314bf 100644 > --- a/examples/domain-events/events-python/event-test.py > +++ b/examples/domain-events/events-python/event-test.py > @@ -443,12 +443,12 @@ def eventToString(event): > def detailToString(event, detail): > eventStrings = ( > ( "Added", "Updated" ), > -( "Removed" ), > +( "Removed", ), > ( "Booted", "Migrated", "Restored", "Snapshot", "Wakeup" ), > ( "Paused", "Migrated", "IOError", "Watchdog", "Restored", > "Snapshot" ), > ( "Unpaused", "Migrated", "Snapshot" ), > ( "Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", "Failed", > "Snapshot"), > -( "Finished" ) > +( "Finished", ), > ( "Memory", ) > ) > return eventStrings[event][detail] > -- > 1.7.12 ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 4/4] examples: Fix event detail printing in python test
If there is only one detail string for a particular event, we need to pu comma after the string otherwise the string itself will be taken as a list and only its first character will be printed out. For example, myDomainEventCallback1 EVENT: Domain fedora17(12) Shutdown F instead of the desired myDomainEventCallback1 EVENT: Domain fedora17(12) Shutdown Finished --- examples/domain-events/events-python/event-test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/domain-events/events-python/event-test.py b/examples/domain-events/events-python/event-test.py index fd71acd..3e314bf 100644 --- a/examples/domain-events/events-python/event-test.py +++ b/examples/domain-events/events-python/event-test.py @@ -443,12 +443,12 @@ def eventToString(event): def detailToString(event, detail): eventStrings = ( ( "Added", "Updated" ), -( "Removed" ), +( "Removed", ), ( "Booted", "Migrated", "Restored", "Snapshot", "Wakeup" ), ( "Paused", "Migrated", "IOError", "Watchdog", "Restored", "Snapshot" ), ( "Unpaused", "Migrated", "Snapshot" ), ( "Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", "Failed", "Snapshot"), -( "Finished" ) +( "Finished", ), ( "Memory", ) ) return eventStrings[event][detail] -- 1.7.12 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
