Re: [libvirt] [PATCH 6/6] virsh: Remove unused vshNameSorter

[Peter Krempa]

On 09/05/12 08:28, Osier Yang wrote:

vshNameSorter now is not used anymore. Remove it.
---
  tools/virsh.c |9 -
  tools/virsh.h |1 -
  2 files changed, 0 insertions(+), 10 deletions(-)



Yep, this function isn't used after all the changes.

ACK.

Peter

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 6/6] virsh: Remove unused vshNameSorter

[Osier Yang]

vshNameSorter now is not used anymore. Remove it.
---
 tools/virsh.c |9 -
 tools/virsh.h |1 -
 2 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 684f7ca..8e794ea 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -136,15 +136,6 @@ _vshStrdup(vshControl *ctl, const char *s, const char 
*filename, int line)
 /* Poison the raw allocating identifiers in favor of our vsh variants.  */
 #define strdup use_vshStrdup_instead_of_strdup
 
-int
-vshNameSorter(const void *a, const void *b)
-{
-const char **sa = (const char**)a;
-const char **sb = (const char**)b;
-
-return vshStrcasecmp(*sa, *sb);
-}
-
 double
 vshPrettyCapacity(unsigned long long val, const char **unit)
 {
diff --git a/tools/virsh.h b/tools/virsh.h
index 2758d37..ac12b8b 100644
--- a/tools/virsh.h
+++ b/tools/virsh.h
@@ -314,7 +314,6 @@ void vshDebug(vshControl *ctl, int level, const char 
*format, ...)
 
 /* User visible sort, so we want locale-specific case comparison.  */
 # define vshStrcasecmp(S1, S2) strcasecmp(S1, S2)
-int vshNameSorter(const void *a, const void *b);
 
 int vshDomainState(vshControl *ctl, virDomainPtr dom, int *reason);
 virTypedParameterPtr vshFindTypedParamByName(const char *name,
-- 
1.7.7.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list