Re: [libvirt] [PATCH v2 1/3] Public API for parallel migration

2019-03-27 Thread Jiri Denemark
On Wed, Feb 13, 2019 at 15:03:44 -0500, John Ferlan wrote:
> 
> 
> On 2/8/19 10:08 AM, Jiri Denemark wrote:
> > This patch adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which
> > will ask the hypervisor to use multiple parallel connections for
> > migrating a domain. The number of parallel connections can be set using
> > VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS typed parameter.
> > 
> > Signed-off-by: Jiri Denemark 
> > ---
> >  include/libvirt/libvirt-domain.h | 14 ++
> >  1 file changed, 14 insertions(+)
> > 
> 
> Shall I assume the multifd-page-count is not going to be implemented?

Right, this parameter was dropped in QEMU.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH v2 1/3] Public API for parallel migration

2019-02-13 Thread John Ferlan



On 2/8/19 10:08 AM, Jiri Denemark wrote:
> This patch adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which
> will ask the hypervisor to use multiple parallel connections for
> migrating a domain. The number of parallel connections can be set using
> VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS typed parameter.
> 
> Signed-off-by: Jiri Denemark 
> ---
>  include/libvirt/libvirt-domain.h | 14 ++
>  1 file changed, 14 insertions(+)
> 

Shall I assume the multifd-page-count is not going to be implemented? or
something for the future?

Reviewed-by: John Ferlan 

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH v2 1/3] Public API for parallel migration

2019-02-08 Thread Jiri Denemark
This patch adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which
will ask the hypervisor to use multiple parallel connections for
migrating a domain. The number of parallel connections can be set using
VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS typed parameter.

Signed-off-by: Jiri Denemark 
---
 include/libvirt/libvirt-domain.h | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index d82c75a9d9..b2d82d8152 100644
--- a/include/libvirt/libvirt-domain.h
+++ b/include/libvirt/libvirt-domain.h
@@ -831,6 +831,12 @@ typedef enum {
  */
 VIR_MIGRATE_TLS   = (1 << 16),
 
+/* Send memory pages to the destination host through several network
+ * connections. See VIR_MIGRATE_PARAM_PARALLEL_* parameters for
+ * configuring the parallel migration.
+ */
+VIR_MIGRATE_PARALLEL  = (1 << 17),
+
 } virDomainMigrateFlags;
 
 
@@ -1025,6 +1031,14 @@ typedef enum {
  */
 # define VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT  "auto_converge.increment"
 
+/**
+ * VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS:
+ *
+ * virDomainMigrate* params field: number of connections used during parallel
+ * migration. As VIR_TYPED_PARAM_INT.
+ */
+# define VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS "parallel.connections"
+
 /* Domain migration. */
 virDomainPtr virDomainMigrate (virDomainPtr domain, virConnectPtr dconn,
unsigned long flags, const char *dname,
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list